[INFO] crate libsocket 0.1.1 is already in cache [INFO] extracting crate libsocket 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/libsocket/0.1.1 [INFO] extracting crate libsocket 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libsocket/0.1.1 [INFO] validating manifest of libsocket-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libsocket-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libsocket-0.1.1 [INFO] finished frobbing libsocket-0.1.1 [INFO] frobbed toml for libsocket-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/libsocket/0.1.1/Cargo.toml [INFO] started frobbing libsocket-0.1.1 [INFO] finished frobbing libsocket-0.1.1 [INFO] frobbed toml for libsocket-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libsocket/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libsocket-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libsocket/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7ac8de26e0ee3399b9ac4d5bd607ec6dbb1dd6f6447897e8cb8160b6e157cda0 [INFO] running `"docker" "start" "-a" "7ac8de26e0ee3399b9ac4d5bd607ec6dbb1dd6f6447897e8cb8160b6e157cda0"` [INFO] [stderr] Checking libsocket v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | fd: fd [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | fd: fd [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / return Ok(Socket { [INFO] [stderr] 106 | | fd: result [INFO] [stderr] 107 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 105 | Ok(Socket { [INFO] [stderr] 106 | fd: result [INFO] [stderr] 107 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / return Socket { [INFO] [stderr] 113 | | fd: fd [INFO] [stderr] 114 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 112 | Socket { [INFO] [stderr] 113 | fd: fd [INFO] [stderr] 114 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | / return Ok(Socket{ [INFO] [stderr] 180 | | fd: result [INFO] [stderr] 181 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 179 | Ok(Socket{ [INFO] [stderr] 180 | fd: result [INFO] [stderr] 181 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | return Ok(num_read); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(num_read)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | return Ok(num_sent); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(num_sent)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:805:9 [INFO] [stderr] | [INFO] [stderr] 805 | return self.recv(buf, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.recv(buf, 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:811:9 [INFO] [stderr] | [INFO] [stderr] 811 | return self.send(buf, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.send(buf, 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:814:9 [INFO] [stderr] | [INFO] [stderr] 814 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / return Ok(Socket { [INFO] [stderr] 106 | | fd: result [INFO] [stderr] 107 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 105 | Ok(Socket { [INFO] [stderr] 106 | fd: result [INFO] [stderr] 107 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / return Socket { [INFO] [stderr] 113 | | fd: fd [INFO] [stderr] 114 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 112 | Socket { [INFO] [stderr] 113 | fd: fd [INFO] [stderr] 114 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | / return Ok(Socket{ [INFO] [stderr] 180 | | fd: result [INFO] [stderr] 181 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 179 | Ok(Socket{ [INFO] [stderr] 180 | fd: result [INFO] [stderr] 181 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | return Ok(num_read); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(num_read)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | return Ok(num_sent); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(num_sent)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:805:9 [INFO] [stderr] | [INFO] [stderr] 805 | return self.recv(buf, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.recv(buf, 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:811:9 [INFO] [stderr] | [INFO] [stderr] 811 | return self.send(buf, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.send(buf, 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:814:9 [INFO] [stderr] | [INFO] [stderr] 814 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:124:33 [INFO] [stderr] | [INFO] [stderr] 124 | libc::bind(self.fd, address, address_len) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:141:36 [INFO] [stderr] | [INFO] [stderr] 141 | libc::connect(self.fd, address, address_len) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:172:35 [INFO] [stderr] | [INFO] [stderr] 172 | libc::accept(self.fd, address, address_len) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:172:44 [INFO] [stderr] | [INFO] [stderr] 172 | libc::accept(self.fd, address, address_len) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:268:29 [INFO] [stderr] | [INFO] [stderr] 268 | let optval: c_int = match nodelay { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 269 | | true => 1, [INFO] [stderr] 270 | | false => 0 [INFO] [stderr] 271 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if nodelay { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:349:29 [INFO] [stderr] | [INFO] [stderr] 349 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 350 | | true => 1, [INFO] [stderr] 351 | | false => 0 [INFO] [stderr] 352 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:376:29 [INFO] [stderr] | [INFO] [stderr] 376 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 377 | | true => 1, [INFO] [stderr] 378 | | false => 0 [INFO] [stderr] 379 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:397:29 [INFO] [stderr] | [INFO] [stderr] 397 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 398 | | true => 1, [INFO] [stderr] 399 | | false => 0 [INFO] [stderr] 400 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:419:29 [INFO] [stderr] | [INFO] [stderr] 419 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 420 | | true => 1, [INFO] [stderr] 421 | | false => 0 [INFO] [stderr] 422 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:440:29 [INFO] [stderr] | [INFO] [stderr] 440 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 441 | | true => 1, [INFO] [stderr] 442 | | false => 0 [INFO] [stderr] 443 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:470:29 [INFO] [stderr] | [INFO] [stderr] 470 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 471 | | true => 1, [INFO] [stderr] 472 | | false => 0 [INFO] [stderr] 473 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:499:29 [INFO] [stderr] | [INFO] [stderr] 499 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 500 | | true => 1, [INFO] [stderr] 501 | | false => 0 [INFO] [stderr] 502 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:521:29 [INFO] [stderr] | [INFO] [stderr] 521 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 522 | | true => 1, [INFO] [stderr] 523 | | false => 0 [INFO] [stderr] 524 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:543:29 [INFO] [stderr] | [INFO] [stderr] 543 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 544 | | true => 1, [INFO] [stderr] 545 | | false => 0 [INFO] [stderr] 546 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:734:29 [INFO] [stderr] | [INFO] [stderr] 734 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 735 | | true => 1, [INFO] [stderr] 736 | | false => 0 [INFO] [stderr] 737 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:784:29 [INFO] [stderr] | [INFO] [stderr] 784 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 785 | | true => 1, [INFO] [stderr] 786 | | false => 0 [INFO] [stderr] 787 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `libsocket`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:124:33 [INFO] [stderr] | [INFO] [stderr] 124 | libc::bind(self.fd, address, address_len) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:141:36 [INFO] [stderr] | [INFO] [stderr] 141 | libc::connect(self.fd, address, address_len) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:172:35 [INFO] [stderr] | [INFO] [stderr] 172 | libc::accept(self.fd, address, address_len) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:172:44 [INFO] [stderr] | [INFO] [stderr] 172 | libc::accept(self.fd, address, address_len) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:268:29 [INFO] [stderr] | [INFO] [stderr] 268 | let optval: c_int = match nodelay { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 269 | | true => 1, [INFO] [stderr] 270 | | false => 0 [INFO] [stderr] 271 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if nodelay { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:349:29 [INFO] [stderr] | [INFO] [stderr] 349 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 350 | | true => 1, [INFO] [stderr] 351 | | false => 0 [INFO] [stderr] 352 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:376:29 [INFO] [stderr] | [INFO] [stderr] 376 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 377 | | true => 1, [INFO] [stderr] 378 | | false => 0 [INFO] [stderr] 379 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:397:29 [INFO] [stderr] | [INFO] [stderr] 397 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 398 | | true => 1, [INFO] [stderr] 399 | | false => 0 [INFO] [stderr] 400 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:419:29 [INFO] [stderr] | [INFO] [stderr] 419 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 420 | | true => 1, [INFO] [stderr] 421 | | false => 0 [INFO] [stderr] 422 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:440:29 [INFO] [stderr] | [INFO] [stderr] 440 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 441 | | true => 1, [INFO] [stderr] 442 | | false => 0 [INFO] [stderr] 443 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:470:29 [INFO] [stderr] | [INFO] [stderr] 470 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 471 | | true => 1, [INFO] [stderr] 472 | | false => 0 [INFO] [stderr] 473 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:499:29 [INFO] [stderr] | [INFO] [stderr] 499 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 500 | | true => 1, [INFO] [stderr] 501 | | false => 0 [INFO] [stderr] 502 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:521:29 [INFO] [stderr] | [INFO] [stderr] 521 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 522 | | true => 1, [INFO] [stderr] 523 | | false => 0 [INFO] [stderr] 524 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:543:29 [INFO] [stderr] | [INFO] [stderr] 543 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 544 | | true => 1, [INFO] [stderr] 545 | | false => 0 [INFO] [stderr] 546 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:734:29 [INFO] [stderr] | [INFO] [stderr] 734 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 735 | | true => 1, [INFO] [stderr] 736 | | false => 0 [INFO] [stderr] 737 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:784:29 [INFO] [stderr] | [INFO] [stderr] 784 | let optval: c_int = match option { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 785 | | true => 1, [INFO] [stderr] 786 | | false => 0 [INFO] [stderr] 787 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if option { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `libsocket`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7ac8de26e0ee3399b9ac4d5bd607ec6dbb1dd6f6447897e8cb8160b6e157cda0"` [INFO] running `"docker" "rm" "-f" "7ac8de26e0ee3399b9ac4d5bd607ec6dbb1dd6f6447897e8cb8160b6e157cda0"` [INFO] [stdout] 7ac8de26e0ee3399b9ac4d5bd607ec6dbb1dd6f6447897e8cb8160b6e157cda0