[INFO] crate libsm 0.3.0 is already in cache [INFO] extracting crate libsm 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/libsm/0.3.0 [INFO] extracting crate libsm 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libsm/0.3.0 [INFO] validating manifest of libsm-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libsm-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libsm-0.3.0 [INFO] finished frobbing libsm-0.3.0 [INFO] frobbed toml for libsm-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/libsm/0.3.0/Cargo.toml [INFO] started frobbing libsm-0.3.0 [INFO] finished frobbing libsm-0.3.0 [INFO] frobbed toml for libsm-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libsm/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libsm-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libsm/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f61d745e9b4dd0405aed78571938c3e905ea33411d282a19f7fac4b5c9fb6288 [INFO] running `"docker" "start" "-a" "f61d745e9b4dd0405aed78571938c3e905ea33411d282a19f7fac4b5c9fb6288"` [INFO] [stderr] Checking yasna v0.1.3 [INFO] [stderr] Checking libsm v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sm2/field.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | let (t, c) = raw_add(&sum, &s[1]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sm2/field.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | let (s, b) = raw_sub(&sum, &self.modulus); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sm2/field.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | let (t, c) = raw_add(&sum, &s[1]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sm2/field.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | let (s, b) = raw_sub(&sum, &self.modulus); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sm2/field.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | let mut c = FieldElem::zero(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sm2/field.rs:339:17 [INFO] [stderr] | [INFO] [stderr] 339 | let j = k - i; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sm2/field.rs:341:22 [INFO] [stderr] | [INFO] [stderr] 341 | let (u, v) = u32_mul(a.value[7 - i], b.value[7 - j]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/sm2/field.rs:341:25 [INFO] [stderr] | [INFO] [stderr] 341 | let (u, v) = u32_mul(a.value[7 - i], b.value[7 - j]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sm2/ecc.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | let mut c = BigUint::zero(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sm2/ecc.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | let n = self.n.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sm3/hash.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | let mut c = self.digest[2] as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sm3/hash.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | let mut d = self.digest[3] as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/sm3/hash.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | let mut e = self.digest[4] as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/sm3/hash.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | let mut f = self.digest[5] as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/sm3/hash.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | let mut g = self.digest[6] as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/sm3/hash.rs:169:17 [INFO] [stderr] | [INFO] [stderr] 169 | let mut h = self.digest[7] as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sm2/field.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | let mut c = FieldElem::zero(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sm2/field.rs:339:17 [INFO] [stderr] | [INFO] [stderr] 339 | let j = k - i; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sm2/field.rs:341:22 [INFO] [stderr] | [INFO] [stderr] 341 | let (u, v) = u32_mul(a.value[7 - i], b.value[7 - j]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/sm2/field.rs:341:25 [INFO] [stderr] | [INFO] [stderr] 341 | let (u, v) = u32_mul(a.value[7 - i], b.value[7 - j]); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sm2/ecc.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | let mut c = BigUint::zero(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sm2/ecc.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | let n = self.n.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/sm3/hash.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | let mut c = self.digest[2] as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/sm3/hash.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | let mut d = self.digest[3] as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/sm3/hash.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | let mut e = self.digest[4] as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/sm3/hash.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | let mut f = self.digest[5] as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/sm3/hash.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | let mut g = self.digest[6] as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/sm3/hash.rs:169:17 [INFO] [stderr] | [INFO] [stderr] 169 | let mut h = self.digest[7] as u32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffe` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:35:25 [INFO] [stderr] | [INFO] [stderr] 35 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:35:37 [INFO] [stderr] | [INFO] [stderr] 35 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:35:49 [INFO] [stderr] | [INFO] [stderr] 35 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:35:61 [INFO] [stderr] | [INFO] [stderr] 35 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:35:73 [INFO] [stderr] | [INFO] [stderr] 35 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:35:85 [INFO] [stderr] | [INFO] [stderr] 35 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | return sum; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | return raw_sum; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `raw_sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | return diff; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `diff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | return raw_diff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `raw_diff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:130:31 [INFO] [stderr] | [INFO] [stderr] 130 | part3.value[5] = (t & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | return c; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:251:9 [INFO] [stderr] | [INFO] [stderr] 251 | return Err(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:265:29 [INFO] [stderr] | [INFO] [stderr] 265 | sum.value[7] = (t_sum & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:269:29 [INFO] [stderr] | [INFO] [stderr] 269 | sum.value[6] = (t_sum & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:273:29 [INFO] [stderr] | [INFO] [stderr] 273 | sum.value[5] = (t_sum & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:277:29 [INFO] [stderr] | [INFO] [stderr] 277 | sum.value[4] = (t_sum & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:281:29 [INFO] [stderr] | [INFO] [stderr] 281 | sum.value[3] = (t_sum & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:285:29 [INFO] [stderr] | [INFO] [stderr] 285 | sum.value[2] = (t_sum & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:289:29 [INFO] [stderr] | [INFO] [stderr] 289 | sum.value[1] = (t_sum & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:293:29 [INFO] [stderr] | [INFO] [stderr] 293 | sum.value[0] = (t_sum & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:322:18 [INFO] [stderr] | [INFO] [stderr] 322 | let v = uv & 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:349:25 [INFO] [stderr] | [INFO] [stderr] 349 | local = local & 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:394:9 [INFO] [stderr] | [INFO] [stderr] 394 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:406:9 [INFO] [stderr] | [INFO] [stderr] 406 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:426:13 [INFO] [stderr] | [INFO] [stderr] 426 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:428:13 [INFO] [stderr] | [INFO] [stderr] 428 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:473:23 [INFO] [stderr] | [INFO] [stderr] 473 | arr[7] = (x & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:87:41 [INFO] [stderr] | [INFO] [stderr] 87 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:87:53 [INFO] [stderr] | [INFO] [stderr] 87 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:87:65 [INFO] [stderr] | [INFO] [stderr] 87 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:87:77 [INFO] [stderr] | [INFO] [stderr] 87 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:87:89 [INFO] [stderr] | [INFO] [stderr] 87 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | 0xfffffffc, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | 0x28E9FA9E, 0x9D9F5E34, 0x4D5A9E4B, 0xCF6509A7, 0xF39789F5, 0x15AB8F92, 0xDDBCBD41, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x28E9_FA9E` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:91:29 [INFO] [stderr] | [INFO] [stderr] 91 | 0x28E9FA9E, 0x9D9F5E34, 0x4D5A9E4B, 0xCF6509A7, 0xF39789F5, 0x15AB8F92, 0xDDBCBD41, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x9D9F_5E34` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:91:41 [INFO] [stderr] | [INFO] [stderr] 91 | 0x28E9FA9E, 0x9D9F5E34, 0x4D5A9E4B, 0xCF6509A7, 0xF39789F5, 0x15AB8F92, 0xDDBCBD41, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4D5A_9E4B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:91:53 [INFO] [stderr] | [INFO] [stderr] 91 | 0x28E9FA9E, 0x9D9F5E34, 0x4D5A9E4B, 0xCF6509A7, 0xF39789F5, 0x15AB8F92, 0xDDBCBD41, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xCF65_09A7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:91:65 [INFO] [stderr] | [INFO] [stderr] 91 | 0x28E9FA9E, 0x9D9F5E34, 0x4D5A9E4B, 0xCF6509A7, 0xF39789F5, 0x15AB8F92, 0xDDBCBD41, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xF397_89F5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:91:77 [INFO] [stderr] | [INFO] [stderr] 91 | 0x28E9FA9E, 0x9D9F5E34, 0x4D5A9E4B, 0xCF6509A7, 0xF39789F5, 0x15AB8F92, 0xDDBCBD41, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x15AB_8F92` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:91:89 [INFO] [stderr] | [INFO] [stderr] 91 | 0x28E9FA9E, 0x9D9F5E34, 0x4D5A9E4B, 0xCF6509A7, 0xF39789F5, 0x15AB8F92, 0xDDBCBD41, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xDDBC_BD41` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | 0x4D940E93, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4D94_0E93` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | return c; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | return Ok(p); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | return Ok(p); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | 0x32C4AE2C, 0x1F198119, 0x5F990446, 0x6A39C994, 0x8FE30BBF, 0xF2660BE1, 0x715A4589, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x32C4_AE2C` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 229 | 0x32C4AE2C, 0x1F198119, 0x5F990446, 0x6A39C994, 0x8FE30BBF, 0xF2660BE1, 0x715A4589, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1F19_8119` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:229:37 [INFO] [stderr] | [INFO] [stderr] 229 | 0x32C4AE2C, 0x1F198119, 0x5F990446, 0x6A39C994, 0x8FE30BBF, 0xF2660BE1, 0x715A4589, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5F99_0446` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:229:49 [INFO] [stderr] | [INFO] [stderr] 229 | 0x32C4AE2C, 0x1F198119, 0x5F990446, 0x6A39C994, 0x8FE30BBF, 0xF2660BE1, 0x715A4589, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6A39_C994` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:229:61 [INFO] [stderr] | [INFO] [stderr] 229 | 0x32C4AE2C, 0x1F198119, 0x5F990446, 0x6A39C994, 0x8FE30BBF, 0xF2660BE1, 0x715A4589, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8FE3_0BBF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:229:73 [INFO] [stderr] | [INFO] [stderr] 229 | 0x32C4AE2C, 0x1F198119, 0x5F990446, 0x6A39C994, 0x8FE30BBF, 0xF2660BE1, 0x715A4589, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xF266_0BE1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:229:85 [INFO] [stderr] | [INFO] [stderr] 229 | 0x32C4AE2C, 0x1F198119, 0x5F990446, 0x6A39C994, 0x8FE30BBF, 0xF2660BE1, 0x715A4589, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x715A_4589` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | 0x334C74C7, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x334C_74C7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | 0xBC3736A2, 0xF4F6779C, 0x59BDCEE3, 0x6B692153, 0xD0A9877C, 0xC62A4740, 0x02DF32E5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBC37_36A2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:233:25 [INFO] [stderr] | [INFO] [stderr] 233 | 0xBC3736A2, 0xF4F6779C, 0x59BDCEE3, 0x6B692153, 0xD0A9877C, 0xC62A4740, 0x02DF32E5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xF4F6_779C` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:233:37 [INFO] [stderr] | [INFO] [stderr] 233 | 0xBC3736A2, 0xF4F6779C, 0x59BDCEE3, 0x6B692153, 0xD0A9877C, 0xC62A4740, 0x02DF32E5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x59BD_CEE3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:233:49 [INFO] [stderr] | [INFO] [stderr] 233 | 0xBC3736A2, 0xF4F6779C, 0x59BDCEE3, 0x6B692153, 0xD0A9877C, 0xC62A4740, 0x02DF32E5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6B69_2153` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:233:61 [INFO] [stderr] | [INFO] [stderr] 233 | 0xBC3736A2, 0xF4F6779C, 0x59BDCEE3, 0x6B692153, 0xD0A9877C, 0xC62A4740, 0x02DF32E5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xD0A9_877C` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:233:73 [INFO] [stderr] | [INFO] [stderr] 233 | 0xBC3736A2, 0xF4F6779C, 0x59BDCEE3, 0x6B692153, 0xD0A9877C, 0xC62A4740, 0x02DF32E5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xC62A_4740` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:233:85 [INFO] [stderr] | [INFO] [stderr] 233 | 0xBC3736A2, 0xF4F6779C, 0x59BDCEE3, 0x6B692153, 0xD0A9877C, 0xC62A4740, 0x02DF32E5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x02DF_32E5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | 0x2139F0A0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2139_F0A0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:425:13 [INFO] [stderr] | [INFO] [stderr] 425 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:427:13 [INFO] [stderr] | [INFO] [stderr] 427 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:495:21 [INFO] [stderr] | [INFO] [stderr] 495 | return Ok(p); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:498:21 [INFO] [stderr] | [INFO] [stderr] 498 | return Err(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:509:21 [INFO] [stderr] | [INFO] [stderr] 509 | return Ok(p); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:512:21 [INFO] [stderr] | [INFO] [stderr] 512 | return Err(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:516:13 [INFO] [stderr] | [INFO] [stderr] 516 | return Err(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:524:13 [INFO] [stderr] | [INFO] [stderr] 524 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:526:13 [INFO] [stderr] | [INFO] [stderr] 526 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/signature.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | return Ok((r, s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((r, s))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/signature.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | return Ok(Signature { r, s }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Signature { r, s })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/signature.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return der; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `der` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/signature.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/signature.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | return (pk, sk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(pk, sk)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/signature.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | return pk; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `pk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/signature.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | return Ok(sk); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(sk)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | 0x7380166f, 0x4914b2b9, 0x172442d7, 0xda8a0600, 0xa96f30bc, 0x163138aa, 0xe38dee4d, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7380_166f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:75:29 [INFO] [stderr] | [INFO] [stderr] 75 | 0x7380166f, 0x4914b2b9, 0x172442d7, 0xda8a0600, 0xa96f30bc, 0x163138aa, 0xe38dee4d, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4914_b2b9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:75:41 [INFO] [stderr] | [INFO] [stderr] 75 | 0x7380166f, 0x4914b2b9, 0x172442d7, 0xda8a0600, 0xa96f30bc, 0x163138aa, 0xe38dee4d, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1724_42d7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:75:53 [INFO] [stderr] | [INFO] [stderr] 75 | 0x7380166f, 0x4914b2b9, 0x172442d7, 0xda8a0600, 0xa96f30bc, 0x163138aa, 0xe38dee4d, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xda8a_0600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:75:65 [INFO] [stderr] | [INFO] [stderr] 75 | 0x7380166f, 0x4914b2b9, 0x172442d7, 0xda8a0600, 0xa96f30bc, 0x163138aa, 0xe38dee4d, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa96f_30bc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:75:77 [INFO] [stderr] | [INFO] [stderr] 75 | 0x7380166f, 0x4914b2b9, 0x172442d7, 0xda8a0600, 0xa96f30bc, 0x163138aa, 0xe38dee4d, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1631_38aa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:75:89 [INFO] [stderr] | [INFO] [stderr] 75 | 0x7380166f, 0x4914b2b9, 0x172442d7, 0xda8a0600, 0xa96f30bc, 0x163138aa, 0xe38dee4d, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xe38d_ee4d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | 0xb0fb0e4e, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xb0fb_0e4e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:180:31 [INFO] [stderr] | [INFO] [stderr] 180 | .wrapping_add(0x79cc4519u32.rotate_left(i as u32)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x79cc_4519u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:210:31 [INFO] [stderr] | [INFO] [stderr] 210 | .wrapping_add(0x7a879d8au32.rotate_left(i as u32)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x7a87_9d8au32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | 0xa3b1bac6, 0x56aa3350, 0x677d9197, 0xb27022dc [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa3b1_bac6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | 0xa3b1bac6, 0x56aa3350, 0x677d9197, 0xb27022dc [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x56aa_3350` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:130:29 [INFO] [stderr] | [INFO] [stderr] 130 | 0xa3b1bac6, 0x56aa3350, 0x677d9197, 0xb27022dc [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x677d_9197` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:130:41 [INFO] [stderr] | [INFO] [stderr] 130 | 0xa3b1bac6, 0x56aa3350, 0x677d9197, 0xb27022dc [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xb270_22dc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | 0x00070e15, 0x1c232a31, 0x383f464d, 0x545b6269, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0007_0e15` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | 0x00070e15, 0x1c232a31, 0x383f464d, 0x545b6269, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1c23_2a31` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:134:29 [INFO] [stderr] | [INFO] [stderr] 134 | 0x00070e15, 0x1c232a31, 0x383f464d, 0x545b6269, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x383f_464d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:134:41 [INFO] [stderr] | [INFO] [stderr] 134 | 0x00070e15, 0x1c232a31, 0x383f464d, 0x545b6269, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x545b_6269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | 0x70777e85, 0x8c939aa1, 0xa8afb6bd, 0xc4cbd2d9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7077_7e85` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | 0x70777e85, 0x8c939aa1, 0xa8afb6bd, 0xc4cbd2d9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8c93_9aa1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:135:29 [INFO] [stderr] | [INFO] [stderr] 135 | 0x70777e85, 0x8c939aa1, 0xa8afb6bd, 0xc4cbd2d9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa8af_b6bd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:135:41 [INFO] [stderr] | [INFO] [stderr] 135 | 0x70777e85, 0x8c939aa1, 0xa8afb6bd, 0xc4cbd2d9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xc4cb_d2d9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | 0xe0e7eef5, 0xfc030a11, 0x181f262d, 0x343b4249, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xe0e7_eef5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | 0xe0e7eef5, 0xfc030a11, 0x181f262d, 0x343b4249, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfc03_0a11` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:136:29 [INFO] [stderr] | [INFO] [stderr] 136 | 0xe0e7eef5, 0xfc030a11, 0x181f262d, 0x343b4249, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x181f_262d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:136:41 [INFO] [stderr] | [INFO] [stderr] 136 | 0xe0e7eef5, 0xfc030a11, 0x181f262d, 0x343b4249, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x343b_4249` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | 0x50575e65, 0x6c737a81, 0x888f969d, 0xa4abb2b9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5057_5e65` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | 0x50575e65, 0x6c737a81, 0x888f969d, 0xa4abb2b9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6c73_7a81` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:137:29 [INFO] [stderr] | [INFO] [stderr] 137 | 0x50575e65, 0x6c737a81, 0x888f969d, 0xa4abb2b9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x888f_969d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:137:41 [INFO] [stderr] | [INFO] [stderr] 137 | 0x50575e65, 0x6c737a81, 0x888f969d, 0xa4abb2b9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa4ab_b2b9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | 0xc0c7ced5, 0xdce3eaf1, 0xf8ff060d, 0x141b2229, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xc0c7_ced5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | 0xc0c7ced5, 0xdce3eaf1, 0xf8ff060d, 0x141b2229, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdce3_eaf1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:138:29 [INFO] [stderr] | [INFO] [stderr] 138 | 0xc0c7ced5, 0xdce3eaf1, 0xf8ff060d, 0x141b2229, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf8ff_060d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:138:41 [INFO] [stderr] | [INFO] [stderr] 138 | 0xc0c7ced5, 0xdce3eaf1, 0xf8ff060d, 0x141b2229, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x141b_2229` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | 0x30373e45, 0x4c535a61, 0x686f767d, 0x848b9299, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3037_3e45` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | 0x30373e45, 0x4c535a61, 0x686f767d, 0x848b9299, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4c53_5a61` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:139:29 [INFO] [stderr] | [INFO] [stderr] 139 | 0x30373e45, 0x4c535a61, 0x686f767d, 0x848b9299, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x686f_767d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:139:41 [INFO] [stderr] | [INFO] [stderr] 139 | 0x30373e45, 0x4c535a61, 0x686f767d, 0x848b9299, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x848b_9299` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | 0xa0a7aeb5, 0xbcc3cad1, 0xd8dfe6ed, 0xf4fb0209, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa0a7_aeb5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | 0xa0a7aeb5, 0xbcc3cad1, 0xd8dfe6ed, 0xf4fb0209, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xbcc3_cad1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:140:29 [INFO] [stderr] | [INFO] [stderr] 140 | 0xa0a7aeb5, 0xbcc3cad1, 0xd8dfe6ed, 0xf4fb0209, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xd8df_e6ed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:140:41 [INFO] [stderr] | [INFO] [stderr] 140 | 0xa0a7aeb5, 0xbcc3cad1, 0xd8dfe6ed, 0xf4fb0209, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf4fb_0209` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | 0x10171e25, 0x2c333a41, 0x484f565d, 0x646b7279 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1017_1e25` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | 0x10171e25, 0x2c333a41, 0x484f565d, 0x646b7279 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2c33_3a41` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:141:29 [INFO] [stderr] | [INFO] [stderr] 141 | 0x10171e25, 0x2c333a41, 0x484f565d, 0x646b7279 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x484f_565d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:141:41 [INFO] [stderr] | [INFO] [stderr] 141 | 0x10171e25, 0x2c333a41, 0x484f565d, 0x646b7279 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x646b_7279` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffe` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:35:25 [INFO] [stderr] | [INFO] [stderr] 35 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:35:37 [INFO] [stderr] | [INFO] [stderr] 35 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:35:49 [INFO] [stderr] | [INFO] [stderr] 35 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:35:61 [INFO] [stderr] | [INFO] [stderr] 35 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:35:73 [INFO] [stderr] | [INFO] [stderr] 35 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:35:85 [INFO] [stderr] | [INFO] [stderr] 35 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | return sum; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | return raw_sum; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `raw_sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | return diff; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `diff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | return raw_diff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `raw_diff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:130:31 [INFO] [stderr] | [INFO] [stderr] 130 | part3.value[5] = (t & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | return c; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:251:9 [INFO] [stderr] | [INFO] [stderr] 251 | return Err(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:265:29 [INFO] [stderr] | [INFO] [stderr] 265 | sum.value[7] = (t_sum & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:269:29 [INFO] [stderr] | [INFO] [stderr] 269 | sum.value[6] = (t_sum & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:273:29 [INFO] [stderr] | [INFO] [stderr] 273 | sum.value[5] = (t_sum & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:277:29 [INFO] [stderr] | [INFO] [stderr] 277 | sum.value[4] = (t_sum & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:281:29 [INFO] [stderr] | [INFO] [stderr] 281 | sum.value[3] = (t_sum & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:285:29 [INFO] [stderr] | [INFO] [stderr] 285 | sum.value[2] = (t_sum & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:289:29 [INFO] [stderr] | [INFO] [stderr] 289 | sum.value[1] = (t_sum & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:293:29 [INFO] [stderr] | [INFO] [stderr] 293 | sum.value[0] = (t_sum & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:322:18 [INFO] [stderr] | [INFO] [stderr] 322 | let v = uv & 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:349:25 [INFO] [stderr] | [INFO] [stderr] 349 | local = local & 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:394:9 [INFO] [stderr] | [INFO] [stderr] 394 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:406:9 [INFO] [stderr] | [INFO] [stderr] 406 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:426:13 [INFO] [stderr] | [INFO] [stderr] 426 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/field.rs:428:13 [INFO] [stderr] | [INFO] [stderr] 428 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:473:23 [INFO] [stderr] | [INFO] [stderr] 473 | arr[7] = (x & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:501:37 [INFO] [stderr] | [INFO] [stderr] 501 | let b = FieldElem::from_num(0xffffffff); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:503:38 [INFO] [stderr] | [INFO] [stderr] 503 | let c1 = FieldElem::from_num(0x100000000); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:514:37 [INFO] [stderr] | [INFO] [stderr] 514 | let a = FieldElem::from_num(0xffffffff); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:560:13 [INFO] [stderr] | [INFO] [stderr] 560 | 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:560:25 [INFO] [stderr] | [INFO] [stderr] 560 | 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:560:37 [INFO] [stderr] | [INFO] [stderr] 560 | 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:560:49 [INFO] [stderr] | [INFO] [stderr] 560 | 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:560:61 [INFO] [stderr] | [INFO] [stderr] 560 | 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:560:73 [INFO] [stderr] | [INFO] [stderr] 560 | 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:560:85 [INFO] [stderr] | [INFO] [stderr] 560 | 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:561:13 [INFO] [stderr] | [INFO] [stderr] 561 | 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:564:13 [INFO] [stderr] | [INFO] [stderr] 564 | 0x7fffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:564:25 [INFO] [stderr] | [INFO] [stderr] 564 | 0x7fffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:564:37 [INFO] [stderr] | [INFO] [stderr] 564 | 0x7fffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:564:49 [INFO] [stderr] | [INFO] [stderr] 564 | 0x7fffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:564:61 [INFO] [stderr] | [INFO] [stderr] 564 | 0x7fffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:564:73 [INFO] [stderr] | [INFO] [stderr] 564 | 0x7fffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:564:85 [INFO] [stderr] | [INFO] [stderr] 564 | 0x7fffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/field.rs:565:13 [INFO] [stderr] | [INFO] [stderr] 565 | 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:87:41 [INFO] [stderr] | [INFO] [stderr] 87 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:87:53 [INFO] [stderr] | [INFO] [stderr] 87 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:87:65 [INFO] [stderr] | [INFO] [stderr] 87 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:87:77 [INFO] [stderr] | [INFO] [stderr] 87 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:87:89 [INFO] [stderr] | [INFO] [stderr] 87 | 0xfffffffe, 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff, 0x00000000, 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | 0xfffffffc, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | 0x28E9FA9E, 0x9D9F5E34, 0x4D5A9E4B, 0xCF6509A7, 0xF39789F5, 0x15AB8F92, 0xDDBCBD41, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x28E9_FA9E` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:91:29 [INFO] [stderr] | [INFO] [stderr] 91 | 0x28E9FA9E, 0x9D9F5E34, 0x4D5A9E4B, 0xCF6509A7, 0xF39789F5, 0x15AB8F92, 0xDDBCBD41, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x9D9F_5E34` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:91:41 [INFO] [stderr] | [INFO] [stderr] 91 | 0x28E9FA9E, 0x9D9F5E34, 0x4D5A9E4B, 0xCF6509A7, 0xF39789F5, 0x15AB8F92, 0xDDBCBD41, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4D5A_9E4B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:91:53 [INFO] [stderr] | [INFO] [stderr] 91 | 0x28E9FA9E, 0x9D9F5E34, 0x4D5A9E4B, 0xCF6509A7, 0xF39789F5, 0x15AB8F92, 0xDDBCBD41, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xCF65_09A7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:91:65 [INFO] [stderr] | [INFO] [stderr] 91 | 0x28E9FA9E, 0x9D9F5E34, 0x4D5A9E4B, 0xCF6509A7, 0xF39789F5, 0x15AB8F92, 0xDDBCBD41, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xF397_89F5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:91:77 [INFO] [stderr] | [INFO] [stderr] 91 | 0x28E9FA9E, 0x9D9F5E34, 0x4D5A9E4B, 0xCF6509A7, 0xF39789F5, 0x15AB8F92, 0xDDBCBD41, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x15AB_8F92` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:91:89 [INFO] [stderr] | [INFO] [stderr] 91 | 0x28E9FA9E, 0x9D9F5E34, 0x4D5A9E4B, 0xCF6509A7, 0xF39789F5, 0x15AB8F92, 0xDDBCBD41, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xDDBC_BD41` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | 0x4D940E93, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4D94_0E93` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | return c; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | return Ok(p); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | return Ok(p); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | 0x32C4AE2C, 0x1F198119, 0x5F990446, 0x6A39C994, 0x8FE30BBF, 0xF2660BE1, 0x715A4589, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x32C4_AE2C` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 229 | 0x32C4AE2C, 0x1F198119, 0x5F990446, 0x6A39C994, 0x8FE30BBF, 0xF2660BE1, 0x715A4589, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1F19_8119` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:229:37 [INFO] [stderr] | [INFO] [stderr] 229 | 0x32C4AE2C, 0x1F198119, 0x5F990446, 0x6A39C994, 0x8FE30BBF, 0xF2660BE1, 0x715A4589, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5F99_0446` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:229:49 [INFO] [stderr] | [INFO] [stderr] 229 | 0x32C4AE2C, 0x1F198119, 0x5F990446, 0x6A39C994, 0x8FE30BBF, 0xF2660BE1, 0x715A4589, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6A39_C994` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:229:61 [INFO] [stderr] | [INFO] [stderr] 229 | 0x32C4AE2C, 0x1F198119, 0x5F990446, 0x6A39C994, 0x8FE30BBF, 0xF2660BE1, 0x715A4589, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8FE3_0BBF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:229:73 [INFO] [stderr] | [INFO] [stderr] 229 | 0x32C4AE2C, 0x1F198119, 0x5F990446, 0x6A39C994, 0x8FE30BBF, 0xF2660BE1, 0x715A4589, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xF266_0BE1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:229:85 [INFO] [stderr] | [INFO] [stderr] 229 | 0x32C4AE2C, 0x1F198119, 0x5F990446, 0x6A39C994, 0x8FE30BBF, 0xF2660BE1, 0x715A4589, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x715A_4589` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | 0x334C74C7, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x334C_74C7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | 0xBC3736A2, 0xF4F6779C, 0x59BDCEE3, 0x6B692153, 0xD0A9877C, 0xC62A4740, 0x02DF32E5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xBC37_36A2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:233:25 [INFO] [stderr] | [INFO] [stderr] 233 | 0xBC3736A2, 0xF4F6779C, 0x59BDCEE3, 0x6B692153, 0xD0A9877C, 0xC62A4740, 0x02DF32E5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xF4F6_779C` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:233:37 [INFO] [stderr] | [INFO] [stderr] 233 | 0xBC3736A2, 0xF4F6779C, 0x59BDCEE3, 0x6B692153, 0xD0A9877C, 0xC62A4740, 0x02DF32E5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x59BD_CEE3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:233:49 [INFO] [stderr] | [INFO] [stderr] 233 | 0xBC3736A2, 0xF4F6779C, 0x59BDCEE3, 0x6B692153, 0xD0A9877C, 0xC62A4740, 0x02DF32E5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6B69_2153` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:233:61 [INFO] [stderr] | [INFO] [stderr] 233 | 0xBC3736A2, 0xF4F6779C, 0x59BDCEE3, 0x6B692153, 0xD0A9877C, 0xC62A4740, 0x02DF32E5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xD0A9_877C` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:233:73 [INFO] [stderr] | [INFO] [stderr] 233 | 0xBC3736A2, 0xF4F6779C, 0x59BDCEE3, 0x6B692153, 0xD0A9877C, 0xC62A4740, 0x02DF32E5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xC62A_4740` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:233:85 [INFO] [stderr] | [INFO] [stderr] 233 | 0xBC3736A2, 0xF4F6779C, 0x59BDCEE3, 0x6B692153, 0xD0A9877C, 0xC62A4740, 0x02DF32E5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x02DF_32E5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:234:13 [INFO] [stderr] | [INFO] [stderr] 234 | 0x2139F0A0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2139_F0A0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:425:13 [INFO] [stderr] | [INFO] [stderr] 425 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:427:13 [INFO] [stderr] | [INFO] [stderr] 427 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:495:21 [INFO] [stderr] | [INFO] [stderr] 495 | return Ok(p); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:498:21 [INFO] [stderr] | [INFO] [stderr] 498 | return Err(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:509:21 [INFO] [stderr] | [INFO] [stderr] 509 | return Ok(p); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:512:21 [INFO] [stderr] | [INFO] [stderr] 512 | return Err(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:516:13 [INFO] [stderr] | [INFO] [stderr] 516 | return Err(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:524:13 [INFO] [stderr] | [INFO] [stderr] 524 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/ecc.rs:526:13 [INFO] [stderr] | [INFO] [stderr] 526 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:584:54 [INFO] [stderr] | [INFO] [stderr] 584 | let twice_g = curve.g_mul(&BigUint::from_u64(4294967296).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_296` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm2/ecc.rs:585:53 [INFO] [stderr] | [INFO] [stderr] 585 | let double_g = curve.mul(&BigUint::from_u64(4294967296).unwrap(), &g); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_296` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/signature.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | return Ok((r, s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((r, s))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/signature.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | return Ok(Signature { r, s }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Signature { r, s })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/signature.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | return der; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `der` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/signature.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/signature.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | return (pk, sk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(pk, sk)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/signature.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | return pk; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `pk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sm2/signature.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | return Ok(sk); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(sk)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | 0x7380166f, 0x4914b2b9, 0x172442d7, 0xda8a0600, 0xa96f30bc, 0x163138aa, 0xe38dee4d, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7380_166f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:75:29 [INFO] [stderr] | [INFO] [stderr] 75 | 0x7380166f, 0x4914b2b9, 0x172442d7, 0xda8a0600, 0xa96f30bc, 0x163138aa, 0xe38dee4d, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4914_b2b9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:75:41 [INFO] [stderr] | [INFO] [stderr] 75 | 0x7380166f, 0x4914b2b9, 0x172442d7, 0xda8a0600, 0xa96f30bc, 0x163138aa, 0xe38dee4d, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1724_42d7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:75:53 [INFO] [stderr] | [INFO] [stderr] 75 | 0x7380166f, 0x4914b2b9, 0x172442d7, 0xda8a0600, 0xa96f30bc, 0x163138aa, 0xe38dee4d, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xda8a_0600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:75:65 [INFO] [stderr] | [INFO] [stderr] 75 | 0x7380166f, 0x4914b2b9, 0x172442d7, 0xda8a0600, 0xa96f30bc, 0x163138aa, 0xe38dee4d, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa96f_30bc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:75:77 [INFO] [stderr] | [INFO] [stderr] 75 | 0x7380166f, 0x4914b2b9, 0x172442d7, 0xda8a0600, 0xa96f30bc, 0x163138aa, 0xe38dee4d, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1631_38aa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:75:89 [INFO] [stderr] | [INFO] [stderr] 75 | 0x7380166f, 0x4914b2b9, 0x172442d7, 0xda8a0600, 0xa96f30bc, 0x163138aa, 0xe38dee4d, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xe38d_ee4d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | 0xb0fb0e4e, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xb0fb_0e4e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:180:31 [INFO] [stderr] | [INFO] [stderr] 180 | .wrapping_add(0x79cc4519u32.rotate_left(i as u32)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x79cc_4519u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm3/hash.rs:210:31 [INFO] [stderr] | [INFO] [stderr] 210 | .wrapping_add(0x7a879d8au32.rotate_left(i as u32)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x7a87_9d8au32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | 0xa3b1bac6, 0x56aa3350, 0x677d9197, 0xb27022dc [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa3b1_bac6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | 0xa3b1bac6, 0x56aa3350, 0x677d9197, 0xb27022dc [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x56aa_3350` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:130:29 [INFO] [stderr] | [INFO] [stderr] 130 | 0xa3b1bac6, 0x56aa3350, 0x677d9197, 0xb27022dc [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x677d_9197` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:130:41 [INFO] [stderr] | [INFO] [stderr] 130 | 0xa3b1bac6, 0x56aa3350, 0x677d9197, 0xb27022dc [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xb270_22dc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | 0x00070e15, 0x1c232a31, 0x383f464d, 0x545b6269, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0007_0e15` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | 0x00070e15, 0x1c232a31, 0x383f464d, 0x545b6269, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1c23_2a31` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:134:29 [INFO] [stderr] | [INFO] [stderr] 134 | 0x00070e15, 0x1c232a31, 0x383f464d, 0x545b6269, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x383f_464d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:134:41 [INFO] [stderr] | [INFO] [stderr] 134 | 0x00070e15, 0x1c232a31, 0x383f464d, 0x545b6269, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x545b_6269` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | 0x70777e85, 0x8c939aa1, 0xa8afb6bd, 0xc4cbd2d9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7077_7e85` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | 0x70777e85, 0x8c939aa1, 0xa8afb6bd, 0xc4cbd2d9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8c93_9aa1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:135:29 [INFO] [stderr] | [INFO] [stderr] 135 | 0x70777e85, 0x8c939aa1, 0xa8afb6bd, 0xc4cbd2d9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa8af_b6bd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:135:41 [INFO] [stderr] | [INFO] [stderr] 135 | 0x70777e85, 0x8c939aa1, 0xa8afb6bd, 0xc4cbd2d9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xc4cb_d2d9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | 0xe0e7eef5, 0xfc030a11, 0x181f262d, 0x343b4249, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xe0e7_eef5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | 0xe0e7eef5, 0xfc030a11, 0x181f262d, 0x343b4249, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfc03_0a11` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:136:29 [INFO] [stderr] | [INFO] [stderr] 136 | 0xe0e7eef5, 0xfc030a11, 0x181f262d, 0x343b4249, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x181f_262d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:136:41 [INFO] [stderr] | [INFO] [stderr] 136 | 0xe0e7eef5, 0xfc030a11, 0x181f262d, 0x343b4249, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x343b_4249` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | 0x50575e65, 0x6c737a81, 0x888f969d, 0xa4abb2b9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5057_5e65` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | 0x50575e65, 0x6c737a81, 0x888f969d, 0xa4abb2b9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6c73_7a81` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:137:29 [INFO] [stderr] | [INFO] [stderr] 137 | 0x50575e65, 0x6c737a81, 0x888f969d, 0xa4abb2b9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x888f_969d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:137:41 [INFO] [stderr] | [INFO] [stderr] 137 | 0x50575e65, 0x6c737a81, 0x888f969d, 0xa4abb2b9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa4ab_b2b9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | 0xc0c7ced5, 0xdce3eaf1, 0xf8ff060d, 0x141b2229, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xc0c7_ced5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | 0xc0c7ced5, 0xdce3eaf1, 0xf8ff060d, 0x141b2229, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdce3_eaf1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:138:29 [INFO] [stderr] | [INFO] [stderr] 138 | 0xc0c7ced5, 0xdce3eaf1, 0xf8ff060d, 0x141b2229, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf8ff_060d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:138:41 [INFO] [stderr] | [INFO] [stderr] 138 | 0xc0c7ced5, 0xdce3eaf1, 0xf8ff060d, 0x141b2229, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x141b_2229` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | 0x30373e45, 0x4c535a61, 0x686f767d, 0x848b9299, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3037_3e45` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | 0x30373e45, 0x4c535a61, 0x686f767d, 0x848b9299, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4c53_5a61` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:139:29 [INFO] [stderr] | [INFO] [stderr] 139 | 0x30373e45, 0x4c535a61, 0x686f767d, 0x848b9299, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x686f_767d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:139:41 [INFO] [stderr] | [INFO] [stderr] 139 | 0x30373e45, 0x4c535a61, 0x686f767d, 0x848b9299, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x848b_9299` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:140:5 [INFO] [stderr] | [INFO] [stderr] 140 | 0xa0a7aeb5, 0xbcc3cad1, 0xd8dfe6ed, 0xf4fb0209, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa0a7_aeb5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | 0xa0a7aeb5, 0xbcc3cad1, 0xd8dfe6ed, 0xf4fb0209, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xbcc3_cad1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:140:29 [INFO] [stderr] | [INFO] [stderr] 140 | 0xa0a7aeb5, 0xbcc3cad1, 0xd8dfe6ed, 0xf4fb0209, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xd8df_e6ed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:140:41 [INFO] [stderr] | [INFO] [stderr] 140 | 0xa0a7aeb5, 0xbcc3cad1, 0xd8dfe6ed, 0xf4fb0209, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf4fb_0209` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | 0x10171e25, 0x2c333a41, 0x484f565d, 0x646b7279 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1017_1e25` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | 0x10171e25, 0x2c333a41, 0x484f565d, 0x646b7279 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2c33_3a41` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:141:29 [INFO] [stderr] | [INFO] [stderr] 141 | 0x10171e25, 0x2c333a41, 0x484f565d, 0x646b7279 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x484f_565d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:141:41 [INFO] [stderr] | [INFO] [stderr] 141 | 0x10171e25, 0x2c333a41, 0x484f565d, 0x646b7279 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x646b_7279` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:208:27 [INFO] [stderr] | [INFO] [stderr] 208 | assert_eq!(rk[0], 0xf12186f9); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf121_86f9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/sm4/cipher.rs:209:28 [INFO] [stderr] | [INFO] [stderr] 209 | assert_eq!(rk[31], 0x9124a012); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x9124_a012` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sm2::field::FieldCtx` [INFO] [stderr] --> src/sm2/field.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> FieldCtx { [INFO] [stderr] 32 | | // p = FFFFFFFE FFFFFFFF FFFFFFFF FFFFFFFF FFFFFFFF 00000000 FFFFFFFF FFFFFFFF [INFO] [stderr] 33 | | // = 2^256 - 2^224 - 2^96 + 2^64 -1 [INFO] [stderr] 34 | | let modulus = FieldElem::new([ [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | impl Default for sm2::field::FieldCtx { [INFO] [stderr] 31 | fn default() -> Self { [INFO] [stderr] 32 | Self::new() [INFO] [stderr] 33 | } [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:129:22 [INFO] [stderr] | [INFO] [stderr] 129 | let t: u64 = x[8] as u64 + x[9] as u64 + x[13] as u64 + x[14] as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(x[8])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:129:36 [INFO] [stderr] | [INFO] [stderr] 129 | let t: u64 = x[8] as u64 + x[9] as u64 + x[13] as u64 + x[14] as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(x[9])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:129:50 [INFO] [stderr] | [INFO] [stderr] 129 | let t: u64 = x[8] as u64 + x[9] as u64 + x[13] as u64 + x[14] as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(x[13])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:129:65 [INFO] [stderr] | [INFO] [stderr] 129 | let t: u64 = x[8] as u64 + x[9] as u64 + x[13] as u64 + x[14] as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(x[14])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | carry = carry - c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry -= c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sm2/field.rs:217:22 [INFO] [stderr] | [INFO] [stderr] 217 | let mut q1 = x.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:264:22 [INFO] [stderr] | [INFO] [stderr] 264 | let t_sum: u64 = a.value[7] as u64 + b.value[7] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(a.value[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:264:42 [INFO] [stderr] | [INFO] [stderr] 264 | let t_sum: u64 = a.value[7] as u64 + b.value[7] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(b.value[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:264:62 [INFO] [stderr] | [INFO] [stderr] 264 | let t_sum: u64 = a.value[7] as u64 + b.value[7] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(carry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:268:22 [INFO] [stderr] | [INFO] [stderr] 268 | let t_sum: u64 = a.value[6] as u64 + b.value[6] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(a.value[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:268:42 [INFO] [stderr] | [INFO] [stderr] 268 | let t_sum: u64 = a.value[6] as u64 + b.value[6] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(b.value[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:268:62 [INFO] [stderr] | [INFO] [stderr] 268 | let t_sum: u64 = a.value[6] as u64 + b.value[6] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(carry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:272:22 [INFO] [stderr] | [INFO] [stderr] 272 | let t_sum: u64 = a.value[5] as u64 + b.value[5] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(a.value[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:272:42 [INFO] [stderr] | [INFO] [stderr] 272 | let t_sum: u64 = a.value[5] as u64 + b.value[5] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(b.value[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:272:62 [INFO] [stderr] | [INFO] [stderr] 272 | let t_sum: u64 = a.value[5] as u64 + b.value[5] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(carry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:276:22 [INFO] [stderr] | [INFO] [stderr] 276 | let t_sum: u64 = a.value[4] as u64 + b.value[4] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(a.value[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:276:42 [INFO] [stderr] | [INFO] [stderr] 276 | let t_sum: u64 = a.value[4] as u64 + b.value[4] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(b.value[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:276:62 [INFO] [stderr] | [INFO] [stderr] 276 | let t_sum: u64 = a.value[4] as u64 + b.value[4] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(carry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:280:22 [INFO] [stderr] | [INFO] [stderr] 280 | let t_sum: u64 = a.value[3] as u64 + b.value[3] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(a.value[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:280:42 [INFO] [stderr] | [INFO] [stderr] 280 | let t_sum: u64 = a.value[3] as u64 + b.value[3] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(b.value[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:280:62 [INFO] [stderr] | [INFO] [stderr] 280 | let t_sum: u64 = a.value[3] as u64 + b.value[3] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(carry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:284:22 [INFO] [stderr] | [INFO] [stderr] 284 | let t_sum: u64 = a.value[2] as u64 + b.value[2] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(a.value[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:284:42 [INFO] [stderr] | [INFO] [stderr] 284 | let t_sum: u64 = a.value[2] as u64 + b.value[2] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(b.value[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:284:62 [INFO] [stderr] | [INFO] [stderr] 284 | let t_sum: u64 = a.value[2] as u64 + b.value[2] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(carry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:288:22 [INFO] [stderr] | [INFO] [stderr] 288 | let t_sum: u64 = a.value[1] as u64 + b.value[1] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(a.value[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:288:42 [INFO] [stderr] | [INFO] [stderr] 288 | let t_sum: u64 = a.value[1] as u64 + b.value[1] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(b.value[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:288:62 [INFO] [stderr] | [INFO] [stderr] 288 | let t_sum: u64 = a.value[1] as u64 + b.value[1] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(carry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:292:22 [INFO] [stderr] | [INFO] [stderr] 292 | let t_sum: u64 = a.value[0] as u64 + b.value[0] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(a.value[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:292:42 [INFO] [stderr] | [INFO] [stderr] 292 | let t_sum: u64 = a.value[0] as u64 + b.value[0] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(b.value[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:292:62 [INFO] [stderr] | [INFO] [stderr] 292 | let t_sum: u64 = a.value[0] as u64 + b.value[0] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(carry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:305:26 [INFO] [stderr] | [INFO] [stderr] 305 | let t_sum: i64 = a.value[i] as i64 - b.value[i] as i64 - borrow as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(a.value[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:305:46 [INFO] [stderr] | [INFO] [stderr] 305 | let t_sum: i64 = a.value[i] as i64 - b.value[i] as i64 - borrow as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(b.value[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:305:66 [INFO] [stderr] | [INFO] [stderr] 305 | let t_sum: i64 = a.value[i] as i64 - b.value[i] as i64 - borrow as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(borrow)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | j = j + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `j += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:320:14 [INFO] [stderr] | [INFO] [stderr] 320 | let uv = a as u64 * b as u64; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:320:25 [INFO] [stderr] | [INFO] [stderr] 320 | let uv = a as u64 * b as u64; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:346:13 [INFO] [stderr] | [INFO] [stderr] 346 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:349:9 [INFO] [stderr] | [INFO] [stderr] 349 | local = local & 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local &= 0xffffffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:354:9 [INFO] [stderr] | [INFO] [stderr] 354 | k = k + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `k += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:392:13 [INFO] [stderr] | [INFO] [stderr] 392 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: defining a method called `eq` on this type; consider implementing the `std::cmp::PartialEq` trait or choosing a less ambiguous name [INFO] [stderr] --> src/sm2/field.rs:397:5 [INFO] [stderr] | [INFO] [stderr] 397 | / pub fn eq(&self, x: &FieldElem) -> bool { [INFO] [stderr] 398 | | let mut i = 0; [INFO] [stderr] 399 | | while i < 8 { [INFO] [stderr] 400 | | if self.value[i] != x.value[i] { [INFO] [stderr] ... | [INFO] [stderr] 406 | | return true; [INFO] [stderr] 407 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:404:13 [INFO] [stderr] | [INFO] [stderr] 404 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:418:13 [INFO] [stderr] | [INFO] [stderr] 418 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/sm2/field.rs:425:9 [INFO] [stderr] | [INFO] [stderr] 425 | / if x == 0 { [INFO] [stderr] 426 | | return true; [INFO] [stderr] 427 | | } else { [INFO] [stderr] 428 | | return false; [INFO] [stderr] 429 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `return x == 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sm2::ecc::EccCtx` [INFO] [stderr] --> src/sm2/ecc.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / pub fn new() -> EccCtx { [INFO] [stderr] 83 | | let fctx = FieldCtx::new(); [INFO] [stderr] 84 | | EccCtx { [INFO] [stderr] 85 | | fctx: FieldCtx::new(), [INFO] [stderr] ... | [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 81 | impl Default for sm2::ecc::EccCtx { [INFO] [stderr] 82 | fn default() -> Self { [INFO] [stderr] 83 | Self::new() [INFO] [stderr] 84 | } [INFO] [stderr] 85 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | u = u / two.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `u /= two.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:130:21 [INFO] [stderr] | [INFO] [stderr] 130 | a = a / two.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `a /= two.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | v = v / two.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `v /= two.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:139:21 [INFO] [stderr] | [INFO] [stderr] 139 | c = c / two.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `c /= two.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | u = u - v.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `u -= v.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | a = a - c.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `a -= c.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | v = v - u.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `v -= u.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:155:21 [INFO] [stderr] | [INFO] [stderr] 155 | c = c - a.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `c -= a.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:367:13 [INFO] [stderr] | [INFO] [stderr] 367 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:402:13 [INFO] [stderr] | [INFO] [stderr] 402 | i = i - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/sm2/ecc.rs:412:13 [INFO] [stderr] | [INFO] [stderr] 412 | / if z2.eq(&FieldElem::zero()) { [INFO] [stderr] 413 | | return true; [INFO] [stderr] 414 | | } else { [INFO] [stderr] 415 | | return false; [INFO] [stderr] 416 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `return z2.eq(&FieldElem::zero())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/sm2/ecc.rs:424:9 [INFO] [stderr] | [INFO] [stderr] 424 | / if p1x.eq(&p2x) && p1y.eq(&p2y) { [INFO] [stderr] 425 | | return true; [INFO] [stderr] 426 | | } else { [INFO] [stderr] 427 | | return false; [INFO] [stderr] 428 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `return p1x.eq(&p2x) && p1y.eq(&p2y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/sm2/ecc.rs:523:9 [INFO] [stderr] | [INFO] [stderr] 523 | / if self.z.eq(&FieldElem::zero()) { [INFO] [stderr] 524 | | return true; [INFO] [stderr] 525 | | } else { [INFO] [stderr] 526 | | return false; [INFO] [stderr] 527 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `return self.z.eq(&FieldElem::zero())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sm2::signature::SigCtx` [INFO] [stderr] --> src/sm2/signature.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | / pub fn new() -> SigCtx { [INFO] [stderr] 89 | | SigCtx { [INFO] [stderr] 90 | | curve: EccCtx::new(), [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | impl Default for sm2::signature::SigCtx { [INFO] [stderr] 88 | fn default() -> Self { [INFO] [stderr] 89 | Self::new() [INFO] [stderr] 90 | } [INFO] [stderr] 91 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/signature.rs:172:17 [INFO] [stderr] | [INFO] [stderr] 172 | s2_1 = s2_1 + curve.get_n(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `s2_1 += curve.get_n()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/signature.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | s2 = s2 % curve.get_n(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `s2 %= curve.get_n()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/sm2/signature.rs:248:12 [INFO] [stderr] | [INFO] [stderr] 248 | if sk >= &curve.n || sk == &BigUint::zero() { [INFO] [stderr] | ^^^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `curve.n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sm3/hash.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | let n: u32 = (b[i] as u32) << 24 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(b[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sm3/hash.rs:59:11 [INFO] [stderr] | [INFO] [stderr] 59 | | (b[i + 1] as u32) << 16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(b[i + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sm3/hash.rs:60:11 [INFO] [stderr] | [INFO] [stderr] 60 | | (b[i + 2] as u32) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(b[i + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(b[i + 3] as u32)` [INFO] [stderr] --> src/sm3/hash.rs:61:11 [INFO] [stderr] | [INFO] [stderr] 61 | | (b[i + 3] as u32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sm3/hash.rs:61:11 [INFO] [stderr] | [INFO] [stderr] 61 | | (b[i + 3] as u32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(b[i + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.digest[i]` [INFO] [stderr] --> src/sm3/hash.rs:106:33 [INFO] [stderr] | [INFO] [stderr] 106 | output[i * 4 + 3] = (self.digest[i] >> 0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.length` [INFO] [stderr] --> src/sm3/hash.rs:127:33 [INFO] [stderr] | [INFO] [stderr] 127 | self.unhandle_msg.push((self.length >> 0 & 0xff) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | self.digest[0] = a ^ self.digest[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.digest[0] ^= a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | self.digest[1] = b ^ self.digest[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.digest[1] ^= b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | self.digest[2] = c ^ self.digest[2]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.digest[2] ^= c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | self.digest[3] = d ^ self.digest[3]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.digest[3] ^= d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | self.digest[4] = e ^ self.digest[4]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.digest[4] ^= e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | self.digest[5] = f ^ self.digest[5]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.digest[5] ^= f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:239:9 [INFO] [stderr] | [INFO] [stderr] 239 | self.digest[6] = g ^ self.digest[6]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.digest[6] ^= g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:240:9 [INFO] [stderr] | [INFO] [stderr] 240 | self.digest[7] = h ^ self.digest[7]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.digest[7] ^= h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sm4/cipher.rs:63:20 [INFO] [stderr] | [INFO] [stderr] 63 | let out: u32 = input[3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(input[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sm4/cipher.rs:64:22 [INFO] [stderr] | [INFO] [stderr] 64 | let out = out + ((input[2] as u32) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(input[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sm4/cipher.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | let out = out + ((input[1] as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(input[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sm4/cipher.rs:66:12 [INFO] [stderr] | [INFO] [stderr] 66 | out + ((input[0] as u32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(input[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `out` [INFO] [stderr] --> src/sm4/cipher.rs:74:14 [INFO] [stderr] | [INFO] [stderr] 74 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 74 | for (i, ) in out.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | k[i] = k[i] ^ FK[i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `k[i] ^= FK[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | k[0] = k[0] ^ t_prime_trans(k[1] ^ k[2] ^ k[3] ^ CK[i * 4]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `k[0] ^= t_prime_trans(k[1] ^ k[2] ^ k[3] ^ CK[i * 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | k[1] = k[1] ^ t_prime_trans(k[2] ^ k[3] ^ k[0] ^ CK[i * 4 + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `k[1] ^= t_prime_trans(k[2] ^ k[3] ^ k[0] ^ CK[i * 4 + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | k[2] = k[2] ^ t_prime_trans(k[3] ^ k[0] ^ k[1] ^ CK[i * 4 + 2]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `k[2] ^= t_prime_trans(k[3] ^ k[0] ^ k[1] ^ CK[i * 4 + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | k[3] = k[3] ^ t_prime_trans(k[0] ^ k[1] ^ k[2] ^ CK[i * 4 + 3]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `k[3] ^= t_prime_trans(k[0] ^ k[1] ^ k[2] ^ CK[i * 4 + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | x[0] = x[0] ^ t_trans(x[1] ^ x[2] ^ x[3] ^ rk[i * 4]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[0] ^= t_trans(x[1] ^ x[2] ^ x[3] ^ rk[i * 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | x[1] = x[1] ^ t_trans(x[2] ^ x[3] ^ x[0] ^ rk[i * 4 + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[1] ^= t_trans(x[2] ^ x[3] ^ x[0] ^ rk[i * 4 + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:173:13 [INFO] [stderr] | [INFO] [stderr] 173 | x[2] = x[2] ^ t_trans(x[3] ^ x[0] ^ x[1] ^ rk[i * 4 + 2]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[2] ^= t_trans(x[3] ^ x[0] ^ x[1] ^ rk[i * 4 + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | x[3] = x[3] ^ t_trans(x[0] ^ x[1] ^ x[2] ^ rk[i * 4 + 3]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[3] ^= t_trans(x[0] ^ x[1] ^ x[2] ^ rk[i * 4 + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | x[0] = x[0] ^ t_trans(x[1] ^ x[2] ^ x[3] ^ rk[31 - i * 4]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[0] ^= t_trans(x[1] ^ x[2] ^ x[3] ^ rk[31 - i * 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | x[1] = x[1] ^ t_trans(x[2] ^ x[3] ^ x[0] ^ rk[31 - (i * 4 + 1)]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[1] ^= t_trans(x[2] ^ x[3] ^ x[0] ^ rk[31 - (i * 4 + 1)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | x[2] = x[2] ^ t_trans(x[3] ^ x[0] ^ x[1] ^ rk[31 - (i * 4 + 2)]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[2] ^= t_trans(x[3] ^ x[0] ^ x[1] ^ rk[31 - (i * 4 + 2)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | x[3] = x[3] ^ t_trans(x[0] ^ x[1] ^ x[2] ^ rk[31 - (i * 4 + 3)]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[3] ^= t_trans(x[0] ^ x[1] ^ x[2] ^ rk[31 - (i * 4 + 3)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/sm4/cipher_mode.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | t = a[15 - i] as i32 + carry; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(a[15 - i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sm2::field::FieldCtx` [INFO] [stderr] --> src/sm2/field.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> FieldCtx { [INFO] [stderr] 32 | | // p = FFFFFFFE FFFFFFFF FFFFFFFF FFFFFFFF FFFFFFFF 00000000 FFFFFFFF FFFFFFFF [INFO] [stderr] 33 | | // = 2^256 - 2^224 - 2^96 + 2^64 -1 [INFO] [stderr] 34 | | let modulus = FieldElem::new([ [INFO] [stderr] ... | [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | impl Default for sm2::field::FieldCtx { [INFO] [stderr] 31 | fn default() -> Self { [INFO] [stderr] 32 | Self::new() [INFO] [stderr] 33 | } [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:129:22 [INFO] [stderr] | [INFO] [stderr] 129 | let t: u64 = x[8] as u64 + x[9] as u64 + x[13] as u64 + x[14] as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(x[8])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:129:36 [INFO] [stderr] | [INFO] [stderr] 129 | let t: u64 = x[8] as u64 + x[9] as u64 + x[13] as u64 + x[14] as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(x[9])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:129:50 [INFO] [stderr] | [INFO] [stderr] 129 | let t: u64 = x[8] as u64 + x[9] as u64 + x[13] as u64 + x[14] as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(x[13])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:129:65 [INFO] [stderr] | [INFO] [stderr] 129 | let t: u64 = x[8] as u64 + x[9] as u64 + x[13] as u64 + x[14] as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(x[14])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | carry = carry + c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry += c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | carry = carry - c as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `carry -= c as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sm2/field.rs:217:22 [INFO] [stderr] | [INFO] [stderr] 217 | let mut q1 = x.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:264:22 [INFO] [stderr] | [INFO] [stderr] 264 | let t_sum: u64 = a.value[7] as u64 + b.value[7] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(a.value[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:264:42 [INFO] [stderr] | [INFO] [stderr] 264 | let t_sum: u64 = a.value[7] as u64 + b.value[7] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(b.value[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:264:62 [INFO] [stderr] | [INFO] [stderr] 264 | let t_sum: u64 = a.value[7] as u64 + b.value[7] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(carry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:268:22 [INFO] [stderr] | [INFO] [stderr] 268 | let t_sum: u64 = a.value[6] as u64 + b.value[6] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(a.value[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:268:42 [INFO] [stderr] | [INFO] [stderr] 268 | let t_sum: u64 = a.value[6] as u64 + b.value[6] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(b.value[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:268:62 [INFO] [stderr] | [INFO] [stderr] 268 | let t_sum: u64 = a.value[6] as u64 + b.value[6] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(carry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:272:22 [INFO] [stderr] | [INFO] [stderr] 272 | let t_sum: u64 = a.value[5] as u64 + b.value[5] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(a.value[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:272:42 [INFO] [stderr] | [INFO] [stderr] 272 | let t_sum: u64 = a.value[5] as u64 + b.value[5] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(b.value[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:272:62 [INFO] [stderr] | [INFO] [stderr] 272 | let t_sum: u64 = a.value[5] as u64 + b.value[5] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(carry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:276:22 [INFO] [stderr] | [INFO] [stderr] 276 | let t_sum: u64 = a.value[4] as u64 + b.value[4] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(a.value[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:276:42 [INFO] [stderr] | [INFO] [stderr] 276 | let t_sum: u64 = a.value[4] as u64 + b.value[4] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(b.value[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:276:62 [INFO] [stderr] | [INFO] [stderr] 276 | let t_sum: u64 = a.value[4] as u64 + b.value[4] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(carry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:280:22 [INFO] [stderr] | [INFO] [stderr] 280 | let t_sum: u64 = a.value[3] as u64 + b.value[3] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(a.value[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:280:42 [INFO] [stderr] | [INFO] [stderr] 280 | let t_sum: u64 = a.value[3] as u64 + b.value[3] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(b.value[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:280:62 [INFO] [stderr] | [INFO] [stderr] 280 | let t_sum: u64 = a.value[3] as u64 + b.value[3] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(carry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:284:22 [INFO] [stderr] | [INFO] [stderr] 284 | let t_sum: u64 = a.value[2] as u64 + b.value[2] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(a.value[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:284:42 [INFO] [stderr] | [INFO] [stderr] 284 | let t_sum: u64 = a.value[2] as u64 + b.value[2] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(b.value[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:284:62 [INFO] [stderr] | [INFO] [stderr] 284 | let t_sum: u64 = a.value[2] as u64 + b.value[2] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(carry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:288:22 [INFO] [stderr] | [INFO] [stderr] 288 | let t_sum: u64 = a.value[1] as u64 + b.value[1] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(a.value[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:288:42 [INFO] [stderr] | [INFO] [stderr] 288 | let t_sum: u64 = a.value[1] as u64 + b.value[1] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(b.value[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:288:62 [INFO] [stderr] | [INFO] [stderr] 288 | let t_sum: u64 = a.value[1] as u64 + b.value[1] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(carry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:292:22 [INFO] [stderr] | [INFO] [stderr] 292 | let t_sum: u64 = a.value[0] as u64 + b.value[0] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(a.value[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:292:42 [INFO] [stderr] | [INFO] [stderr] 292 | let t_sum: u64 = a.value[0] as u64 + b.value[0] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(b.value[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:292:62 [INFO] [stderr] | [INFO] [stderr] 292 | let t_sum: u64 = a.value[0] as u64 + b.value[0] as u64 + carry as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(carry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:305:26 [INFO] [stderr] | [INFO] [stderr] 305 | let t_sum: i64 = a.value[i] as i64 - b.value[i] as i64 - borrow as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(a.value[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:305:46 [INFO] [stderr] | [INFO] [stderr] 305 | let t_sum: i64 = a.value[i] as i64 - b.value[i] as i64 - borrow as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(b.value[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:305:66 [INFO] [stderr] | [INFO] [stderr] 305 | let t_sum: i64 = a.value[i] as i64 - b.value[i] as i64 - borrow as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(borrow)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | j = j + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `j += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:320:14 [INFO] [stderr] | [INFO] [stderr] 320 | let uv = a as u64 * b as u64; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/sm2/field.rs:320:25 [INFO] [stderr] | [INFO] [stderr] 320 | let uv = a as u64 * b as u64; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:346:13 [INFO] [stderr] | [INFO] [stderr] 346 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:349:9 [INFO] [stderr] | [INFO] [stderr] 349 | local = local & 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local &= 0xffffffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:354:9 [INFO] [stderr] | [INFO] [stderr] 354 | k = k + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `k += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:392:13 [INFO] [stderr] | [INFO] [stderr] 392 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: defining a method called `eq` on this type; consider implementing the `std::cmp::PartialEq` trait or choosing a less ambiguous name [INFO] [stderr] --> src/sm2/field.rs:397:5 [INFO] [stderr] | [INFO] [stderr] 397 | / pub fn eq(&self, x: &FieldElem) -> bool { [INFO] [stderr] 398 | | let mut i = 0; [INFO] [stderr] 399 | | while i < 8 { [INFO] [stderr] 400 | | if self.value[i] != x.value[i] { [INFO] [stderr] ... | [INFO] [stderr] 406 | | return true; [INFO] [stderr] 407 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:404:13 [INFO] [stderr] | [INFO] [stderr] 404 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/field.rs:418:13 [INFO] [stderr] | [INFO] [stderr] 418 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/sm2/field.rs:425:9 [INFO] [stderr] | [INFO] [stderr] 425 | / if x == 0 { [INFO] [stderr] 426 | | return true; [INFO] [stderr] 427 | | } else { [INFO] [stderr] 428 | | return false; [INFO] [stderr] 429 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `return x == 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/sm2/field.rs:522:18 [INFO] [stderr] | [INFO] [stderr] 522 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 522 | for in &mut buf { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sm2::ecc::EccCtx` [INFO] [stderr] --> src/sm2/ecc.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / pub fn new() -> EccCtx { [INFO] [stderr] 83 | | let fctx = FieldCtx::new(); [INFO] [stderr] 84 | | EccCtx { [INFO] [stderr] 85 | | fctx: FieldCtx::new(), [INFO] [stderr] ... | [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 81 | impl Default for sm2::ecc::EccCtx { [INFO] [stderr] 82 | fn default() -> Self { [INFO] [stderr] 83 | Self::new() [INFO] [stderr] 84 | } [INFO] [stderr] 85 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | u = u / two.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `u /= two.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:130:21 [INFO] [stderr] | [INFO] [stderr] 130 | a = a / two.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `a /= two.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | v = v / two.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `v /= two.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:139:21 [INFO] [stderr] | [INFO] [stderr] 139 | c = c / two.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `c /= two.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | u = u - v.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `u -= v.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | a = a - c.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `a -= c.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | v = v - u.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `v -= u.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:155:21 [INFO] [stderr] | [INFO] [stderr] 155 | c = c - a.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `c -= a.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:367:13 [INFO] [stderr] | [INFO] [stderr] 367 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/ecc.rs:402:13 [INFO] [stderr] | [INFO] [stderr] 402 | i = i - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/sm2/ecc.rs:412:13 [INFO] [stderr] | [INFO] [stderr] 412 | / if z2.eq(&FieldElem::zero()) { [INFO] [stderr] 413 | | return true; [INFO] [stderr] 414 | | } else { [INFO] [stderr] 415 | | return false; [INFO] [stderr] 416 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `return z2.eq(&FieldElem::zero())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/sm2/ecc.rs:424:9 [INFO] [stderr] | [INFO] [stderr] 424 | / if p1x.eq(&p2x) && p1y.eq(&p2y) { [INFO] [stderr] 425 | | return true; [INFO] [stderr] 426 | | } else { [INFO] [stderr] 427 | | return false; [INFO] [stderr] 428 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `return p1x.eq(&p2x) && p1y.eq(&p2y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/sm2/ecc.rs:523:9 [INFO] [stderr] | [INFO] [stderr] 523 | / if self.z.eq(&FieldElem::zero()) { [INFO] [stderr] 524 | | return true; [INFO] [stderr] 525 | | } else { [INFO] [stderr] 526 | | return false; [INFO] [stderr] 527 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `return self.z.eq(&FieldElem::zero())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sm2::signature::SigCtx` [INFO] [stderr] --> src/sm2/signature.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | / pub fn new() -> SigCtx { [INFO] [stderr] 89 | | SigCtx { [INFO] [stderr] 90 | | curve: EccCtx::new(), [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 87 | impl Default for sm2::signature::SigCtx { [INFO] [stderr] 88 | fn default() -> Self { [INFO] [stderr] 89 | Self::new() [INFO] [stderr] 90 | } [INFO] [stderr] 91 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/signature.rs:172:17 [INFO] [stderr] | [INFO] [stderr] 172 | s2_1 = s2_1 + curve.get_n(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `s2_1 += curve.get_n()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm2/signature.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | s2 = s2 % curve.get_n(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `s2 %= curve.get_n()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/sm2/signature.rs:248:12 [INFO] [stderr] | [INFO] [stderr] 248 | if sk >= &curve.n || sk == &BigUint::zero() { [INFO] [stderr] | ^^^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `curve.n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sm3/hash.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | let n: u32 = (b[i] as u32) << 24 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(b[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sm3/hash.rs:59:11 [INFO] [stderr] | [INFO] [stderr] 59 | | (b[i + 1] as u32) << 16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(b[i + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sm3/hash.rs:60:11 [INFO] [stderr] | [INFO] [stderr] 60 | | (b[i + 2] as u32) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(b[i + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(b[i + 3] as u32)` [INFO] [stderr] --> src/sm3/hash.rs:61:11 [INFO] [stderr] | [INFO] [stderr] 61 | | (b[i + 3] as u32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sm3/hash.rs:61:11 [INFO] [stderr] | [INFO] [stderr] 61 | | (b[i + 3] as u32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(b[i + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.digest[i]` [INFO] [stderr] --> src/sm3/hash.rs:106:33 [INFO] [stderr] | [INFO] [stderr] 106 | output[i * 4 + 3] = (self.digest[i] >> 0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.length` [INFO] [stderr] --> src/sm3/hash.rs:127:33 [INFO] [stderr] | [INFO] [stderr] 127 | self.unhandle_msg.push((self.length >> 0 & 0xff) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | self.digest[0] = a ^ self.digest[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.digest[0] ^= a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | self.digest[1] = b ^ self.digest[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.digest[1] ^= b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | self.digest[2] = c ^ self.digest[2]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.digest[2] ^= c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | self.digest[3] = d ^ self.digest[3]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.digest[3] ^= d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | self.digest[4] = e ^ self.digest[4]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.digest[4] ^= e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | self.digest[5] = f ^ self.digest[5]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.digest[5] ^= f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:239:9 [INFO] [stderr] | [INFO] [stderr] 239 | self.digest[6] = g ^ self.digest[6]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.digest[6] ^= g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm3/hash.rs:240:9 [INFO] [stderr] | [INFO] [stderr] 240 | self.digest[7] = h ^ self.digest[7]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.digest[7] ^= h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sm4/cipher.rs:63:20 [INFO] [stderr] | [INFO] [stderr] 63 | let out: u32 = input[3] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(input[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sm4/cipher.rs:64:22 [INFO] [stderr] | [INFO] [stderr] 64 | let out = out + ((input[2] as u32) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(input[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sm4/cipher.rs:65:22 [INFO] [stderr] | [INFO] [stderr] 65 | let out = out + ((input[1] as u32) << 16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(input[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/sm4/cipher.rs:66:12 [INFO] [stderr] | [INFO] [stderr] 66 | out + ((input[0] as u32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(input[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `out` [INFO] [stderr] --> src/sm4/cipher.rs:74:14 [INFO] [stderr] | [INFO] [stderr] 74 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 74 | for (i, ) in out.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | k[i] = k[i] ^ FK[i]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `k[i] ^= FK[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | k[0] = k[0] ^ t_prime_trans(k[1] ^ k[2] ^ k[3] ^ CK[i * 4]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `k[0] ^= t_prime_trans(k[1] ^ k[2] ^ k[3] ^ CK[i * 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | k[1] = k[1] ^ t_prime_trans(k[2] ^ k[3] ^ k[0] ^ CK[i * 4 + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `k[1] ^= t_prime_trans(k[2] ^ k[3] ^ k[0] ^ CK[i * 4 + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | k[2] = k[2] ^ t_prime_trans(k[3] ^ k[0] ^ k[1] ^ CK[i * 4 + 2]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `k[2] ^= t_prime_trans(k[3] ^ k[0] ^ k[1] ^ CK[i * 4 + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | k[3] = k[3] ^ t_prime_trans(k[0] ^ k[1] ^ k[2] ^ CK[i * 4 + 3]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `k[3] ^= t_prime_trans(k[0] ^ k[1] ^ k[2] ^ CK[i * 4 + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | x[0] = x[0] ^ t_trans(x[1] ^ x[2] ^ x[3] ^ rk[i * 4]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[0] ^= t_trans(x[1] ^ x[2] ^ x[3] ^ rk[i * 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | x[1] = x[1] ^ t_trans(x[2] ^ x[3] ^ x[0] ^ rk[i * 4 + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[1] ^= t_trans(x[2] ^ x[3] ^ x[0] ^ rk[i * 4 + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:173:13 [INFO] [stderr] | [INFO] [stderr] 173 | x[2] = x[2] ^ t_trans(x[3] ^ x[0] ^ x[1] ^ rk[i * 4 + 2]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[2] ^= t_trans(x[3] ^ x[0] ^ x[1] ^ rk[i * 4 + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | x[3] = x[3] ^ t_trans(x[0] ^ x[1] ^ x[2] ^ rk[i * 4 + 3]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[3] ^= t_trans(x[0] ^ x[1] ^ x[2] ^ rk[i * 4 + 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | x[0] = x[0] ^ t_trans(x[1] ^ x[2] ^ x[3] ^ rk[31 - i * 4]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[0] ^= t_trans(x[1] ^ x[2] ^ x[3] ^ rk[31 - i * 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | x[1] = x[1] ^ t_trans(x[2] ^ x[3] ^ x[0] ^ rk[31 - (i * 4 + 1)]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[1] ^= t_trans(x[2] ^ x[3] ^ x[0] ^ rk[31 - (i * 4 + 1)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | x[2] = x[2] ^ t_trans(x[3] ^ x[0] ^ x[1] ^ rk[31 - (i * 4 + 2)]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[2] ^= t_trans(x[3] ^ x[0] ^ x[1] ^ rk[31 - (i * 4 + 2)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/sm4/cipher.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | x[3] = x[3] ^ t_trans(x[0] ^ x[1] ^ x[2] ^ rk[31 - (i * 4 + 3)]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `x[3] ^= t_trans(x[0] ^ x[1] ^ x[2] ^ rk[31 - (i * 4 + 3)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/sm4/cipher_mode.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | t = a[15 - i] as i32 + carry; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(a[15 - i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.19s [INFO] running `"docker" "inspect" "f61d745e9b4dd0405aed78571938c3e905ea33411d282a19f7fac4b5c9fb6288"` [INFO] running `"docker" "rm" "-f" "f61d745e9b4dd0405aed78571938c3e905ea33411d282a19f7fac4b5c9fb6288"` [INFO] [stdout] f61d745e9b4dd0405aed78571938c3e905ea33411d282a19f7fac4b5c9fb6288