[INFO] crate librsync-sys 0.1.1 is already in cache [INFO] extracting crate librsync-sys 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/librsync-sys/0.1.1 [INFO] extracting crate librsync-sys 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/librsync-sys/0.1.1 [INFO] validating manifest of librsync-sys-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of librsync-sys-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing librsync-sys-0.1.1 [INFO] finished frobbing librsync-sys-0.1.1 [INFO] frobbed toml for librsync-sys-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/librsync-sys/0.1.1/Cargo.toml [INFO] started frobbing librsync-sys-0.1.1 [INFO] finished frobbing librsync-sys-0.1.1 [INFO] frobbed toml for librsync-sys-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/librsync-sys/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting librsync-sys-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/librsync-sys/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 49dc2f100cb3084898790a3798627a7ce956e51a7bc9c28e09a687c5004b1380 [INFO] running `"docker" "start" "-a" "49dc2f100cb3084898790a3798627a7ce956e51a7bc9c28e09a687c5004b1380"` [INFO] [stderr] Compiling librsync-sys v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'gcc::Config': gcc::Config has been renamed to gcc::Build [INFO] [stderr] --> build.rs:10:19 [INFO] [stderr] | [INFO] [stderr] 10 | let mut cfg = gcc::Config::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'gcc::Build::new': crate has been renamed to `cc`, the `gcc` name is not maintained [INFO] [stderr] --> build.rs:10:19 [INFO] [stderr] | [INFO] [stderr] 10 | let mut cfg = gcc::Config::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: librsync/src/delta.c: In function 'rs_findmatch': [INFO] [stderr] warning: librsync/src/delta.c:263:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] [INFO] [stderr] warning: if (*match_len > job->block_len) { [INFO] [stderr] warning: ^ [INFO] [stderr] warning: librsync/src/delta.c: In function 'rs_appendmiss': [INFO] [stderr] warning: librsync/src/delta.c:321:43: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] [INFO] [stderr] warning: if (job->basis_len || (job->scoop_pos >= rs_outbuflen)) { [INFO] [stderr] warning: ^~ [INFO] [stderr] warning: librsync/src/job.c: In function 'rs_job_s_complete': [INFO] [stderr] warning: librsync/src/job.c:103:46: warning: unused parameter 'job' [-Wunused-parameter] [INFO] [stderr] warning: static rs_result rs_job_s_complete(rs_job_t *job) [INFO] [stderr] warning: ^~~ [INFO] [stderr] warning: librsync/src/job.c: In function 'rs_job_iter': [INFO] [stderr] warning: librsync/src/job.c:144:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] [INFO] [stderr] warning: if ((orig_in == buffers->avail_in) && (orig_out == buffers->avail_out) [INFO] [stderr] warning: ^~ [INFO] [stderr] warning: librsync/src/job.c:144:59: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] [INFO] [stderr] warning: if ((orig_in == buffers->avail_in) && (orig_out == buffers->avail_out) [INFO] [stderr] warning: ^~ [INFO] [stderr] warning: In file included from librsync/src/mksum.c:44:0: [INFO] [stderr] warning: librsync/src/mksum.c: In function 'rs_sig_begin': [INFO] [stderr] warning: librsync/src/mksum.c:179:31: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] [INFO] [stderr] warning: assert(strong_sum_len <= native_length); [INFO] [stderr] warning: ^ [INFO] [stderr] warning: librsync/src/patch.c: In function 'rs_patch_s_copying': [INFO] [stderr] warning: librsync/src/patch.c:217:43: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] [INFO] [stderr] warning: desired_len = len = (buffs->avail_out < job->basis_len) ? buffs->avail_out : job->basis_len; [INFO] [stderr] warning: ^ [INFO] [stderr] warning: librsync/src/patch.c:217:80: warning: signed and unsigned type in conditional expression [-Wsign-compare] [INFO] [stderr] warning: desired_len = len = (buffs->avail_out < job->basis_len) ? buffs->avail_out : job->basis_len; [INFO] [stderr] warning: ^ [INFO] [stderr] warning: librsync/src/patch.c:231:67: warning: suggest braces around empty body in an 'else' statement [-Wempty-body] [INFO] [stderr] warning: rs_trace("copy callback returned %s", rs_strerror(result)); [INFO] [stderr] warning: ^ [INFO] [stderr] warning: librsync/src/patch.c: In function 'rs_patch_s_header': [INFO] [stderr] warning: librsync/src/patch.c:277:43: warning: suggest braces around empty body in an 'else' statement [-Wempty-body] [INFO] [stderr] warning: rs_trace("got patch magic %#x", v); [INFO] [stderr] warning: ^ [INFO] [stderr] warning: librsync/src/search.c: In function 'heap_sort': [INFO] [stderr] warning: librsync/src/search.c:83:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] [INFO] [stderr] warning: for (i = 1; i < sums->count; ++i) { [INFO] [stderr] warning: ^ [INFO] [stderr] warning: librsync/src/search.c: In function 'rs_search_for_block': [INFO] [stderr] warning: librsync/src/search.c:167:61: warning: unused parameter 'stats' [-Wunused-parameter] [INFO] [stderr] warning: rs_signature_t const *sig, rs_stats_t * stats, [INFO] [stderr] warning: ^~~~~ [INFO] [stderr] warning: librsync/src/trace.c: In function 'rs_trace0': [INFO] [stderr] warning: librsync/src/trace.c:201:23: warning: unused parameter 's' [-Wunused-parameter] [INFO] [stderr] warning: rs_trace0(char const *s, ...) [INFO] [stderr] warning: ^ [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> lib.rs:7:35 [INFO] [stderr] | [INFO] [stderr] 7 | pub const RS_DELTA_MAGIC: c_int = 0x72730236; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7273_0236` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> lib.rs:8:37 [INFO] [stderr] | [INFO] [stderr] 8 | pub const RS_MD4_SIG_MAGIC: c_int = 0x72730136; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7273_0136` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> lib.rs:9:40 [INFO] [stderr] | [INFO] [stderr] 9 | pub const RS_BLAKE2_SIG_MAGIC: c_int = 0x72730137; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7273_0137` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> lib.rs:7:35 [INFO] [stderr] | [INFO] [stderr] 7 | pub const RS_DELTA_MAGIC: c_int = 0x72730236; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7273_0236` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> lib.rs:8:37 [INFO] [stderr] | [INFO] [stderr] 8 | pub const RS_MD4_SIG_MAGIC: c_int = 0x72730136; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7273_0136` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> lib.rs:9:40 [INFO] [stderr] | [INFO] [stderr] 9 | pub const RS_BLAKE2_SIG_MAGIC: c_int = 0x72730137; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7273_0137` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.99s [INFO] running `"docker" "inspect" "49dc2f100cb3084898790a3798627a7ce956e51a7bc9c28e09a687c5004b1380"` [INFO] running `"docker" "rm" "-f" "49dc2f100cb3084898790a3798627a7ce956e51a7bc9c28e09a687c5004b1380"` [INFO] [stdout] 49dc2f100cb3084898790a3798627a7ce956e51a7bc9c28e09a687c5004b1380