[INFO] crate librsync 0.2.0 is already in cache [INFO] extracting crate librsync 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/librsync/0.2.0 [INFO] extracting crate librsync 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/librsync/0.2.0 [INFO] validating manifest of librsync-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of librsync-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing librsync-0.2.0 [INFO] removed path dependency librsync-sys from librsync-0.2.0 [INFO] finished frobbing librsync-0.2.0 [INFO] frobbed toml for librsync-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/librsync/0.2.0/Cargo.toml [INFO] started frobbing librsync-0.2.0 [INFO] removed path dependency librsync-sys from librsync-0.2.0 [INFO] finished frobbing librsync-0.2.0 [INFO] frobbed toml for librsync-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/librsync/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting librsync-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/librsync/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 20eaace2cd5f489929253f607f4dcf4406ccd670859aed5d9b44d11f62c46cca [INFO] running `"docker" "start" "-a" "20eaace2cd5f489929253f607f4dcf4406ccd670859aed5d9b44d11f62c46cca"` [INFO] [stderr] Compiling librsync-sys v0.1.1 [INFO] [stderr] Checking librsync v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | job: job, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `job` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/job.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:339:13 [INFO] [stderr] | [INFO] [stderr] 339 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] --> src/job.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | job: job, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `job` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:339:13 [INFO] [stderr] | [INFO] [stderr] 339 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/whole.rs:108:18 [INFO] [stderr] | [INFO] [stderr] 108 | const DATA: &'static str = "this is a string to be tested"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/whole.rs:109:19 [INFO] [stderr] | [INFO] [stderr] 109 | const DATA2: &'static str = "this is another string to be tested"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:482:18 [INFO] [stderr] | [INFO] [stderr] 482 | const DATA: &'static str = "this is a string to be tested"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:483:19 [INFO] [stderr] | [INFO] [stderr] 483 | const DATA2: &'static str = "this is another string to be tested"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:335:63 [INFO] [stderr] | [INFO] [stderr] 335 | let job = unsafe { raw::rs_patch_begin(patch_copy_cb, mem::transmute(&*cb_data)) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*cb_data as *const std::rc::Rc> as *mut libc::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:421:15 [INFO] [stderr] | [INFO] [stderr] 421 | fn as_raw(&self) -> raw::rs_magic_number { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/lib.rs:456:48 [INFO] [stderr] | [INFO] [stderr] 456 | let h: *mut Rc> = mem::transmute(opaque); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `opaque as *mut std::rc::Rc>` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/lib.rs:460:28 [INFO] [stderr] | [INFO] [stderr] 460 | let buf: *mut u8 = mem::transmute(*buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `*buf as *mut u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:335:63 [INFO] [stderr] | [INFO] [stderr] 335 | let job = unsafe { raw::rs_patch_begin(patch_copy_cb, mem::transmute(&*cb_data)) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*cb_data as *const std::rc::Rc> as *mut libc::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:421:15 [INFO] [stderr] | [INFO] [stderr] 421 | fn as_raw(&self) -> raw::rs_magic_number { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/lib.rs:456:48 [INFO] [stderr] | [INFO] [stderr] 456 | let h: *mut Rc> = mem::transmute(opaque); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `opaque as *mut std::rc::Rc>` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/lib.rs:460:28 [INFO] [stderr] | [INFO] [stderr] 460 | let buf: *mut u8 = mem::transmute(*buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `*buf as *mut u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.16s [INFO] running `"docker" "inspect" "20eaace2cd5f489929253f607f4dcf4406ccd670859aed5d9b44d11f62c46cca"` [INFO] running `"docker" "rm" "-f" "20eaace2cd5f489929253f607f4dcf4406ccd670859aed5d9b44d11f62c46cca"` [INFO] [stdout] 20eaace2cd5f489929253f607f4dcf4406ccd670859aed5d9b44d11f62c46cca