[INFO] crate libreauth 0.11.0 is already in cache [INFO] extracting crate libreauth 0.11.0 into work/ex/clippy-test-run/sources/stable/reg/libreauth/0.11.0 [INFO] extracting crate libreauth 0.11.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libreauth/0.11.0 [INFO] validating manifest of libreauth-0.11.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libreauth-0.11.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libreauth-0.11.0 [INFO] finished frobbing libreauth-0.11.0 [INFO] frobbed toml for libreauth-0.11.0 written to work/ex/clippy-test-run/sources/stable/reg/libreauth/0.11.0/Cargo.toml [INFO] started frobbing libreauth-0.11.0 [INFO] finished frobbing libreauth-0.11.0 [INFO] frobbed toml for libreauth-0.11.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libreauth/0.11.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libreauth-0.11.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libreauth/0.11.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 63362a88a538d35172b3696a31e30a1abefdb1c29efa9b67a989fab94b2378f4 [INFO] running `"docker" "start" "-a" "63362a88a538d35172b3696a31e30a1abefdb1c29efa9b67a989fab94b2378f4"` [INFO] [stderr] Checking blake2-rfc v0.2.18 [INFO] [stderr] Checking sha3 v0.7.3 [INFO] [stderr] Checking pbkdf2 v0.2.3 [INFO] [stderr] Checking rust-argon2 v0.3.0 [INFO] [stderr] Checking libreauth v0.11.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pass/mod.rs:703:13 [INFO] [stderr] | [INFO] [stderr] 703 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pass/mod.rs:703:13 [INFO] [stderr] | [INFO] [stderr] 703 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/hotp.rs:779:42 [INFO] [stderr] | [INFO] [stderr] 779 | for nb in vec![10, 42, 69, 1024, 0xffffff] { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/oath/totp.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | (base_counter - self.negative_tolerance)..(base_counter + self.positive_tolerance + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((base_counter - self.negative_tolerance)..=base_counter + self.positive_tolerance)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:448:24 [INFO] [stderr] | [INFO] [stderr] 448 | .timestamp(1111111109) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_111_111_109` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:493:24 [INFO] [stderr] | [INFO] [stderr] 493 | .timestamp(1111111109) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_111_111_109` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:538:24 [INFO] [stderr] | [INFO] [stderr] 538 | .timestamp(1111111109) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_111_111_109` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:586:24 [INFO] [stderr] | [INFO] [stderr] 586 | .timestamp(1111111109) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_111_111_109` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:634:24 [INFO] [stderr] | [INFO] [stderr] 634 | .timestamp(1111111109) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_111_111_109` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:692:42 [INFO] [stderr] | [INFO] [stderr] 692 | for nb in vec![10, 42, 69, 1024, 0xffffff] { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:790:14 [INFO] [stderr] | [INFO] [stderr] 790 | (1111111109, HashFunction::Sha1, "07081804"), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_111_111_109` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:791:14 [INFO] [stderr] | [INFO] [stderr] 791 | (1111111111, HashFunction::Sha1, "14050471"), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_111_111_111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:792:14 [INFO] [stderr] | [INFO] [stderr] 792 | (1234567890, HashFunction::Sha1, "89005924"), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:793:14 [INFO] [stderr] | [INFO] [stderr] 793 | (2000000000, HashFunction::Sha1, "69279037"), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:794:14 [INFO] [stderr] | [INFO] [stderr] 794 | (20000000000, HashFunction::Sha1, "65353130"), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `20_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:815:14 [INFO] [stderr] | [INFO] [stderr] 815 | (1111111109, HashFunction::Sha256, "68084774"), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_111_111_109` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:816:14 [INFO] [stderr] | [INFO] [stderr] 816 | (1111111111, HashFunction::Sha256, "67062674"), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_111_111_111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:817:14 [INFO] [stderr] | [INFO] [stderr] 817 | (1234567890, HashFunction::Sha256, "91819424"), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:818:14 [INFO] [stderr] | [INFO] [stderr] 818 | (2000000000, HashFunction::Sha256, "90698825"), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:819:14 [INFO] [stderr] | [INFO] [stderr] 819 | (20000000000, HashFunction::Sha256, "77737706"), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `20_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:840:14 [INFO] [stderr] | [INFO] [stderr] 840 | (1111111109, HashFunction::Sha512, "25091201"), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_111_111_109` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:841:14 [INFO] [stderr] | [INFO] [stderr] 841 | (1111111111, HashFunction::Sha512, "99943326"), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_111_111_111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:842:14 [INFO] [stderr] | [INFO] [stderr] 842 | (1234567890, HashFunction::Sha512, "93441116"), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:843:14 [INFO] [stderr] | [INFO] [stderr] 843 | (2000000000, HashFunction::Sha512, "38618901"), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:844:14 [INFO] [stderr] | [INFO] [stderr] 844 | (20000000000, HashFunction::Sha512, "47863826"), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `20_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:878:14 [INFO] [stderr] | [INFO] [stderr] 878 | (1234567890, 0, "590587", false), // +1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:879:14 [INFO] [stderr] | [INFO] [stderr] 879 | (1234567890, 1, "590587", true), // +1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:880:14 [INFO] [stderr] | [INFO] [stderr] 880 | (1234567890, 1, "240500", false), // +2 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:881:14 [INFO] [stderr] | [INFO] [stderr] 881 | (1234567890, 2, "240500", true), // +2 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:882:14 [INFO] [stderr] | [INFO] [stderr] 882 | (1234567890, 0, "980357", false), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:883:14 [INFO] [stderr] | [INFO] [stderr] 883 | (1234567890, 1, "980357", true), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:884:14 [INFO] [stderr] | [INFO] [stderr] 884 | (1234567890, 1, "186057", false), // -2 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:885:14 [INFO] [stderr] | [INFO] [stderr] 885 | (1234567890, 2, "186057", true), // -2 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:903:14 [INFO] [stderr] | [INFO] [stderr] 903 | (1234567890, 0, "590587", false), // +1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:904:14 [INFO] [stderr] | [INFO] [stderr] 904 | (1234567890, 1, "590587", true), // +1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:905:14 [INFO] [stderr] | [INFO] [stderr] 905 | (1234567890, 1, "240500", false), // +2 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:906:14 [INFO] [stderr] | [INFO] [stderr] 906 | (1234567890, 2, "240500", true), // +2 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:907:14 [INFO] [stderr] | [INFO] [stderr] 907 | (1234567890, 0, "980357", false), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:908:14 [INFO] [stderr] | [INFO] [stderr] 908 | (1234567890, 1, "980357", false), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:909:14 [INFO] [stderr] | [INFO] [stderr] 909 | (1234567890, 1, "186057", false), // -2 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:910:14 [INFO] [stderr] | [INFO] [stderr] 910 | (1234567890, 2, "186057", false), // -2 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:928:14 [INFO] [stderr] | [INFO] [stderr] 928 | (1234567890, 0, "590587", false), // +1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:929:14 [INFO] [stderr] | [INFO] [stderr] 929 | (1234567890, 1, "590587", false), // +1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:930:14 [INFO] [stderr] | [INFO] [stderr] 930 | (1234567890, 1, "240500", false), // +2 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:931:14 [INFO] [stderr] | [INFO] [stderr] 931 | (1234567890, 2, "240500", false), // +2 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:932:14 [INFO] [stderr] | [INFO] [stderr] 932 | (1234567890, 0, "980357", false), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:933:14 [INFO] [stderr] | [INFO] [stderr] 933 | (1234567890, 1, "980357", true), // -1 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:934:14 [INFO] [stderr] | [INFO] [stderr] 934 | (1234567890, 1, "186057", false), // -2 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/oath/totp.rs:935:14 [INFO] [stderr] | [INFO] [stderr] 935 | (1234567890, 2, "186057", true), // -2 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_234_567_890` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/oath/hotp.rs:779:19 [INFO] [stderr] | [INFO] [stderr] 779 | for nb in vec![10, 42, 69, 1024, 0xffffff] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[10, 42, 69, 1024, 0xffffff]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: the loop variable `count` is used to index `examples` [INFO] [stderr] --> src/oath/hotp.rs:904:22 [INFO] [stderr] | [INFO] [stderr] 904 | for count in 0..examples.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 904 | for (count, ) in examples.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/oath/totp.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | (base_counter - self.negative_tolerance)..(base_counter + self.positive_tolerance + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((base_counter - self.negative_tolerance)..=base_counter + self.positive_tolerance)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/oath/totp.rs:692:19 [INFO] [stderr] | [INFO] [stderr] 692 | for nb in vec![10, 42, 69, 1024, 0xffffff] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[10, 42, 69, 1024, 0xffffff]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/pass/mod.rs:1038:5 [INFO] [stderr] | [INFO] [stderr] 1038 | / fn test_params() { [INFO] [stderr] 1039 | | let mut b = HashBuilder::new_std(PasswordStorageStandard::Nist80063b); [INFO] [stderr] 1040 | | let hb = b [INFO] [stderr] 1041 | | .min_len(42) [INFO] [stderr] ... | [INFO] [stderr] 1083 | | } [INFO] [stderr] 1084 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.06s [INFO] running `"docker" "inspect" "63362a88a538d35172b3696a31e30a1abefdb1c29efa9b67a989fab94b2378f4"` [INFO] running `"docker" "rm" "-f" "63362a88a538d35172b3696a31e30a1abefdb1c29efa9b67a989fab94b2378f4"` [INFO] [stdout] 63362a88a538d35172b3696a31e30a1abefdb1c29efa9b67a989fab94b2378f4