[INFO] crate libpulse-simple-binding 2.4.0 is already in cache [INFO] extracting crate libpulse-simple-binding 2.4.0 into work/ex/clippy-test-run/sources/stable/reg/libpulse-simple-binding/2.4.0 [INFO] extracting crate libpulse-simple-binding 2.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libpulse-simple-binding/2.4.0 [INFO] validating manifest of libpulse-simple-binding-2.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libpulse-simple-binding-2.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libpulse-simple-binding-2.4.0 [INFO] finished frobbing libpulse-simple-binding-2.4.0 [INFO] frobbed toml for libpulse-simple-binding-2.4.0 written to work/ex/clippy-test-run/sources/stable/reg/libpulse-simple-binding/2.4.0/Cargo.toml [INFO] started frobbing libpulse-simple-binding-2.4.0 [INFO] finished frobbing libpulse-simple-binding-2.4.0 [INFO] frobbed toml for libpulse-simple-binding-2.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libpulse-simple-binding/2.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libpulse-simple-binding-2.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libpulse-simple-binding/2.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5e2c5fe32279df2fe615b97953c09a3de779264aec01e60ba83d1f5a16d92bf1 [INFO] running `"docker" "start" "-a" "5e2c5fe32279df2fe615b97953c09a3de779264aec01e60ba83d1f5a16d92bf1"` [INFO] [stderr] Compiling libpulse-sys v1.5.0 [INFO] [stderr] Compiling libpulse-simple-sys v1.5.0 [INFO] [stderr] Checking libpulse-binding v2.5.0 [INFO] [stderr] warning: redundant linker flag specified for library `pulse-simple` [INFO] [stderr] [INFO] [stderr] Checking libpulse-simple-binding v2.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / pub fn new(server: Option<&str>, name: &str, dir: pulse::stream::Direction, [INFO] [stderr] 144 | | dev: Option<&str>, stream_name: &str, ss: &pulse::sample::Spec, [INFO] [stderr] 145 | | map: Option<&pulse::channelmap::Map>, attr: Option<&pulse::def::BufferAttr> [INFO] [stderr] 146 | | ) -> Result [INFO] [stderr] ... | [INFO] [stderr] 195 | | Ok(Self::from_raw(ptr)) [INFO] [stderr] 196 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:151:42 [INFO] [stderr] | [INFO] [stderr] 151 | Some(server) => CString::new(server.clone()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 151 | Some(server) => CString::new(&(*server).clone()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 151 | Some(server) => CString::new(&str::clone(server)).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:155:39 [INFO] [stderr] | [INFO] [stderr] 155 | Some(dev) => CString::new(dev.clone()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 155 | Some(dev) => CString::new(&(*dev).clone()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 155 | Some(dev) => CString::new(&str::clone(dev)).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:160:35 [INFO] [stderr] | [INFO] [stderr] 160 | Some(map) => unsafe { std::mem::transmute(map) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `map as *const pulse::channelmap::Map as *const pcapi::pa_channel_map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:164:36 [INFO] [stderr] | [INFO] [stderr] 164 | Some(attr) => unsafe { std::mem::transmute(attr) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `attr as *const pulse::def::BufferAttr as *const pcapi::pa_buffer_attr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:175:35 [INFO] [stderr] | [INFO] [stderr] 175 | let c_name = CString::new(name.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 175 | let c_name = CString::new(&(*name).clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 175 | let c_name = CString::new(&str::clone(name)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:176:42 [INFO] [stderr] | [INFO] [stderr] 176 | let c_stream_name = CString::new(stream_name.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 176 | let c_stream_name = CString::new(&(*stream_name).clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 176 | let c_stream_name = CString::new(&str::clone(stream_name)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | std::mem::transmute(ss), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ss as *const pulse::sample::Spec as *const pcapi::pa_sample_spec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `libpulse-simple-binding`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / pub fn new(server: Option<&str>, name: &str, dir: pulse::stream::Direction, [INFO] [stderr] 144 | | dev: Option<&str>, stream_name: &str, ss: &pulse::sample::Spec, [INFO] [stderr] 145 | | map: Option<&pulse::channelmap::Map>, attr: Option<&pulse::def::BufferAttr> [INFO] [stderr] 146 | | ) -> Result [INFO] [stderr] ... | [INFO] [stderr] 195 | | Ok(Self::from_raw(ptr)) [INFO] [stderr] 196 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:151:42 [INFO] [stderr] | [INFO] [stderr] 151 | Some(server) => CString::new(server.clone()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 151 | Some(server) => CString::new(&(*server).clone()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 151 | Some(server) => CString::new(&str::clone(server)).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:155:39 [INFO] [stderr] | [INFO] [stderr] 155 | Some(dev) => CString::new(dev.clone()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 155 | Some(dev) => CString::new(&(*dev).clone()).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 155 | Some(dev) => CString::new(&str::clone(dev)).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:160:35 [INFO] [stderr] | [INFO] [stderr] 160 | Some(map) => unsafe { std::mem::transmute(map) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `map as *const pulse::channelmap::Map as *const pcapi::pa_channel_map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:164:36 [INFO] [stderr] | [INFO] [stderr] 164 | Some(attr) => unsafe { std::mem::transmute(attr) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `attr as *const pulse::def::BufferAttr as *const pcapi::pa_buffer_attr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:175:35 [INFO] [stderr] | [INFO] [stderr] 175 | let c_name = CString::new(name.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 175 | let c_name = CString::new(&(*name).clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 175 | let c_name = CString::new(&str::clone(name)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:176:42 [INFO] [stderr] | [INFO] [stderr] 176 | let c_stream_name = CString::new(stream_name.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 176 | let c_stream_name = CString::new(&(*stream_name).clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 176 | let c_stream_name = CString::new(&str::clone(stream_name)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | std::mem::transmute(ss), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ss as *const pulse::sample::Spec as *const pcapi::pa_sample_spec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `libpulse-simple-binding`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5e2c5fe32279df2fe615b97953c09a3de779264aec01e60ba83d1f5a16d92bf1"` [INFO] running `"docker" "rm" "-f" "5e2c5fe32279df2fe615b97953c09a3de779264aec01e60ba83d1f5a16d92bf1"` [INFO] [stdout] 5e2c5fe32279df2fe615b97953c09a3de779264aec01e60ba83d1f5a16d92bf1