[INFO] crate libpart 0.1.4 is already in cache [INFO] extracting crate libpart 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/libpart/0.1.4 [INFO] extracting crate libpart 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libpart/0.1.4 [INFO] validating manifest of libpart-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libpart-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libpart-0.1.4 [INFO] finished frobbing libpart-0.1.4 [INFO] frobbed toml for libpart-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/libpart/0.1.4/Cargo.toml [INFO] started frobbing libpart-0.1.4 [INFO] finished frobbing libpart-0.1.4 [INFO] frobbed toml for libpart-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libpart/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libpart-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libpart/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5a4edd7c9779ea241981652ab5241d1c336d8d69219e43b47e3ebb4765fb0407 [INFO] running `"docker" "start" "-a" "5a4edd7c9779ea241981652ab5241d1c336d8d69219e43b47e3ebb4765fb0407"` [INFO] [stderr] Checking checksum v0.2.1 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking libpart v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gpt.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | desc: desc [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `desc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gpt.rs:277:21 [INFO] [stderr] | [INFO] [stderr] 277 | part_type: part_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `part_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gpt.rs:278:21 [INFO] [stderr] | [INFO] [stderr] 278 | part_id: part_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `part_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gpt.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | first_usable: first_usable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_usable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gpt.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | last_usable: last_usable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_usable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gpt.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | partitions: partitions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `partitions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mbr.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | system_id: system_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `system_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mbr.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | start_lba: start_lba, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_lba` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mbr.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | sector_count: sector_count [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sector_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gpt.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | desc: desc [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `desc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gpt.rs:277:21 [INFO] [stderr] | [INFO] [stderr] 277 | part_type: part_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `part_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gpt.rs:278:21 [INFO] [stderr] | [INFO] [stderr] 278 | part_id: part_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `part_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gpt.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | first_usable: first_usable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_usable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gpt.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | last_usable: last_usable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_usable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gpt.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | partitions: partitions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `partitions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mbr.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | system_id: system_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `system_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mbr.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | start_lba: start_lba, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_lba` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mbr.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | sector_count: sector_count [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sector_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn to_bytes(&self, sector_size: u16) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:9:27 [INFO] [stderr] | [INFO] [stderr] 9 | let sector_size = sector_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sector_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | let sector_size = sector_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sector_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:26:27 [INFO] [stderr] | [INFO] [stderr] 26 | let sector_size = sector_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sector_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/gpt.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | let desc = String::from(match &t { [INFO] [stderr] | ____________________^ [INFO] [stderr] 105 | | &ErrorType::NoTable => String::from("No GPT found"), [INFO] [stderr] 106 | | &ErrorType::ChecksumError => String::from("GPT corrupt"), [INFO] [stderr] 107 | | &ErrorType::InvalidVersion => String::from("Invalid GPT Version"), [INFO] [stderr] ... | [INFO] [stderr] 112 | | &ErrorType::UUIDError(ref e) => format!("Invalid UUID: {}", e.description()) [INFO] [stderr] 113 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `String::from()` [INFO] [stderr] | [INFO] [stderr] 104 | let desc = match &t { [INFO] [stderr] 105 | &ErrorType::NoTable => String::from("No GPT found"), [INFO] [stderr] 106 | &ErrorType::ChecksumError => String::from("GPT corrupt"), [INFO] [stderr] 107 | &ErrorType::InvalidVersion => String::from("Invalid GPT Version"), [INFO] [stderr] 108 | &ErrorType::InvalidHeader => String::from("Invalid GPT Header"), [INFO] [stderr] 109 | &ErrorType::UTF16Error => String::from("Encoding Error in GPT: Invalid UTF-16"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/gpt.rs:104:33 [INFO] [stderr] | [INFO] [stderr] 104 | let desc = String::from(match &t { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 105 | | &ErrorType::NoTable => String::from("No GPT found"), [INFO] [stderr] 106 | | &ErrorType::ChecksumError => String::from("GPT corrupt"), [INFO] [stderr] 107 | | &ErrorType::InvalidVersion => String::from("Invalid GPT Version"), [INFO] [stderr] ... | [INFO] [stderr] 112 | | &ErrorType::UUIDError(ref e) => format!("Invalid UUID: {}", e.description()) [INFO] [stderr] 113 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 104 | let desc = String::from(match t { [INFO] [stderr] 105 | ErrorType::NoTable => String::from("No GPT found"), [INFO] [stderr] 106 | ErrorType::ChecksumError => String::from("GPT corrupt"), [INFO] [stderr] 107 | ErrorType::InvalidVersion => String::from("Invalid GPT Version"), [INFO] [stderr] 108 | ErrorType::InvalidHeader => String::from("Invalid GPT Header"), [INFO] [stderr] 109 | ErrorType::UTF16Error => String::from("Encoding Error in GPT: Invalid UTF-16"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/gpt.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | / match &self.error_type { [INFO] [stderr] 140 | | &ErrorType::IOError(ref e) => Some(e), [INFO] [stderr] 141 | | &ErrorType::UUIDError(ref e) => Some(e), [INFO] [stderr] 142 | | _ => None [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 139 | match self.error_type { [INFO] [stderr] 140 | ErrorType::IOError(ref e) => Some(e), [INFO] [stderr] 141 | ErrorType::UUIDError(ref e) => Some(e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/gpt.rs:159:35 [INFO] [stderr] | [INFO] [stderr] 159 | read.seek(SeekFrom::Start(block_size as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(block_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/gpt.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | try!(read.read(&mut buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/gpt.rs:173:40 [INFO] [stderr] | [INFO] [stderr] 173 | try!(read.seek(SeekFrom::Start(block_size as u64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(block_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/gpt.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | try!(read.read(&mut buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/gpt.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | try!(read.read(&mut buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/gpt.rs:230:44 [INFO] [stderr] | [INFO] [stderr] 230 | try!(read.seek(SeekFrom::Start(block_size as u64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(block_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/gpt.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | try!(read.read(&mut buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/gpt.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | try!(read.read(&mut buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/gpt.rs:314:9 [INFO] [stderr] | [INFO] [stderr] 314 | try!(cur.write(&GPT_MAGIC)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/gpt.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | try!(cur.write(&[0x00, 0x00, 0x01, 0x00])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/gpt.rs:361:21 [INFO] [stderr] | [INFO] [stderr] 361 | let p = match p { [INFO] [stderr] | _____________________^ [INFO] [stderr] 362 | | &Some(ref p) => p, [INFO] [stderr] 363 | | &None => &empty [INFO] [stderr] 364 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 361 | let p = match *p { [INFO] [stderr] 362 | Some(ref p) => p, [INFO] [stderr] 363 | None => &empty [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/gpt.rs:381:9 [INFO] [stderr] | [INFO] [stderr] 381 | try!(write.write(pcur.get_ref())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/gpt.rs:395:9 [INFO] [stderr] | [INFO] [stderr] 395 | try!(write.write(&buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/gpt.rs:399:9 [INFO] [stderr] | [INFO] [stderr] 399 | try!(write.write(cur.get_ref())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/gpt.rs:463:14 [INFO] [stderr] | [INFO] [stderr] 463 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 463 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/gpt.rs:488:14 [INFO] [stderr] | [INFO] [stderr] 488 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 488 | for in &mut buf { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/gpt.rs:497:5 [INFO] [stderr] | [INFO] [stderr] 497 | try!(read.read(&mut buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/gpt.rs:515:5 [INFO] [stderr] | [INFO] [stderr] 515 | try!(write.write(&buf_out)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/gpt.rs:528:14 [INFO] [stderr] | [INFO] [stderr] 528 | for i in 0..len { [INFO] [stderr] | ^^^^^^ help: try replacing the loop by: `output[..len].clone_from_slice(&input[..len])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/mbr.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | try!(read.read(&mut stage0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `parts`. [INFO] [stderr] --> src/mbr.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 26 | for in &mut parts { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/mbr.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | try!(write.write(&self.bootloader)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mbr.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | / match p { [INFO] [stderr] 44 | | &Some(ref part) => try!(part.write(write)), [INFO] [stderr] 45 | | &None => try!(PartitionEntry::default().write(write)) [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | match *p { [INFO] [stderr] 44 | Some(ref part) => try!(part.write(write)), [INFO] [stderr] 45 | None => try!(PartitionEntry::default().write(write)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/mbr.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | try!(write.write(&chs)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/mbr.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | try!(write.write(&chs)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 16 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `libpart`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn to_bytes(&self, sector_size: u16) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:9:27 [INFO] [stderr] | [INFO] [stderr] 9 | let sector_size = sector_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sector_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | let sector_size = sector_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sector_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:26:27 [INFO] [stderr] | [INFO] [stderr] 26 | let sector_size = sector_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(sector_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/gpt.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | let desc = String::from(match &t { [INFO] [stderr] | ____________________^ [INFO] [stderr] 105 | | &ErrorType::NoTable => String::from("No GPT found"), [INFO] [stderr] 106 | | &ErrorType::ChecksumError => String::from("GPT corrupt"), [INFO] [stderr] 107 | | &ErrorType::InvalidVersion => String::from("Invalid GPT Version"), [INFO] [stderr] ... | [INFO] [stderr] 112 | | &ErrorType::UUIDError(ref e) => format!("Invalid UUID: {}", e.description()) [INFO] [stderr] 113 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `String::from()` [INFO] [stderr] | [INFO] [stderr] 104 | let desc = match &t { [INFO] [stderr] 105 | &ErrorType::NoTable => String::from("No GPT found"), [INFO] [stderr] 106 | &ErrorType::ChecksumError => String::from("GPT corrupt"), [INFO] [stderr] 107 | &ErrorType::InvalidVersion => String::from("Invalid GPT Version"), [INFO] [stderr] 108 | &ErrorType::InvalidHeader => String::from("Invalid GPT Header"), [INFO] [stderr] 109 | &ErrorType::UTF16Error => String::from("Encoding Error in GPT: Invalid UTF-16"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/gpt.rs:104:33 [INFO] [stderr] | [INFO] [stderr] 104 | let desc = String::from(match &t { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 105 | | &ErrorType::NoTable => String::from("No GPT found"), [INFO] [stderr] 106 | | &ErrorType::ChecksumError => String::from("GPT corrupt"), [INFO] [stderr] 107 | | &ErrorType::InvalidVersion => String::from("Invalid GPT Version"), [INFO] [stderr] ... | [INFO] [stderr] 112 | | &ErrorType::UUIDError(ref e) => format!("Invalid UUID: {}", e.description()) [INFO] [stderr] 113 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 104 | let desc = String::from(match t { [INFO] [stderr] 105 | ErrorType::NoTable => String::from("No GPT found"), [INFO] [stderr] 106 | ErrorType::ChecksumError => String::from("GPT corrupt"), [INFO] [stderr] 107 | ErrorType::InvalidVersion => String::from("Invalid GPT Version"), [INFO] [stderr] 108 | ErrorType::InvalidHeader => String::from("Invalid GPT Header"), [INFO] [stderr] 109 | ErrorType::UTF16Error => String::from("Encoding Error in GPT: Invalid UTF-16"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/gpt.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | / match &self.error_type { [INFO] [stderr] 140 | | &ErrorType::IOError(ref e) => Some(e), [INFO] [stderr] 141 | | &ErrorType::UUIDError(ref e) => Some(e), [INFO] [stderr] 142 | | _ => None [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 139 | match self.error_type { [INFO] [stderr] 140 | ErrorType::IOError(ref e) => Some(e), [INFO] [stderr] 141 | ErrorType::UUIDError(ref e) => Some(e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/gpt.rs:159:35 [INFO] [stderr] | [INFO] [stderr] 159 | read.seek(SeekFrom::Start(block_size as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(block_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/gpt.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | try!(read.read(&mut buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/gpt.rs:173:40 [INFO] [stderr] | [INFO] [stderr] 173 | try!(read.seek(SeekFrom::Start(block_size as u64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(block_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/gpt.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | try!(read.read(&mut buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/gpt.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | try!(read.read(&mut buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/gpt.rs:230:44 [INFO] [stderr] | [INFO] [stderr] 230 | try!(read.seek(SeekFrom::Start(block_size as u64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(block_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/gpt.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | try!(read.read(&mut buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/gpt.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | try!(read.read(&mut buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/gpt.rs:314:9 [INFO] [stderr] | [INFO] [stderr] 314 | try!(cur.write(&GPT_MAGIC)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/gpt.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | try!(cur.write(&[0x00, 0x00, 0x01, 0x00])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/gpt.rs:361:21 [INFO] [stderr] | [INFO] [stderr] 361 | let p = match p { [INFO] [stderr] | _____________________^ [INFO] [stderr] 362 | | &Some(ref p) => p, [INFO] [stderr] 363 | | &None => &empty [INFO] [stderr] 364 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 361 | let p = match *p { [INFO] [stderr] 362 | Some(ref p) => p, [INFO] [stderr] 363 | None => &empty [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/gpt.rs:381:9 [INFO] [stderr] | [INFO] [stderr] 381 | try!(write.write(pcur.get_ref())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/gpt.rs:395:9 [INFO] [stderr] | [INFO] [stderr] 395 | try!(write.write(&buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/gpt.rs:399:9 [INFO] [stderr] | [INFO] [stderr] 399 | try!(write.write(cur.get_ref())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/gpt.rs:463:14 [INFO] [stderr] | [INFO] [stderr] 463 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 463 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/gpt.rs:488:14 [INFO] [stderr] | [INFO] [stderr] 488 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 488 | for in &mut buf { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/gpt.rs:497:5 [INFO] [stderr] | [INFO] [stderr] 497 | try!(read.read(&mut buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/gpt.rs:515:5 [INFO] [stderr] | [INFO] [stderr] 515 | try!(write.write(&buf_out)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/gpt.rs:528:14 [INFO] [stderr] | [INFO] [stderr] 528 | for i in 0..len { [INFO] [stderr] | ^^^^^^ help: try replacing the loop by: `output[..len].clone_from_slice(&input[..len])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/mbr.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | try!(read.read(&mut stage0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `parts`. [INFO] [stderr] --> src/mbr.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 26 | for in &mut parts { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/mbr.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | try!(write.write(&self.bootloader)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/mbr.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | / match p { [INFO] [stderr] 44 | | &Some(ref part) => try!(part.write(write)), [INFO] [stderr] 45 | | &None => try!(PartitionEntry::default().write(write)) [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | match *p { [INFO] [stderr] 44 | Some(ref part) => try!(part.write(write)), [INFO] [stderr] 45 | None => try!(PartitionEntry::default().write(write)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/mbr.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | try!(write.write(&chs)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/mbr.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | try!(write.write(&chs)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 16 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `libpart`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5a4edd7c9779ea241981652ab5241d1c336d8d69219e43b47e3ebb4765fb0407"` [INFO] running `"docker" "rm" "-f" "5a4edd7c9779ea241981652ab5241d1c336d8d69219e43b47e3ebb4765fb0407"` [INFO] [stdout] 5a4edd7c9779ea241981652ab5241d1c336d8d69219e43b47e3ebb4765fb0407