[INFO] crate libosu 0.0.7 is already in cache
[INFO] extracting crate libosu 0.0.7 into work/ex/clippy-test-run/sources/stable/reg/libosu/0.0.7
[INFO] extracting crate libosu 0.0.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libosu/0.0.7
[INFO] validating manifest of libosu-0.0.7 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of libosu-0.0.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing libosu-0.0.7
[INFO] finished frobbing libosu-0.0.7
[INFO] frobbed toml for libosu-0.0.7 written to work/ex/clippy-test-run/sources/stable/reg/libosu/0.0.7/Cargo.toml
[INFO] started frobbing libosu-0.0.7
[INFO] finished frobbing libosu-0.0.7
[INFO] frobbed toml for libosu-0.0.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libosu/0.0.7/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting libosu-0.0.7 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libosu/0.0.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7c0b43f6a438c62be2ecd8946d51e40c0c7fefe9a185e0eddcd477e4f43bb253
[INFO] running `"docker" "start" "-a" "7c0b43f6a438c62be2ecd8946d51e40c0c7fefe9a185e0eddcd477e4f43bb253"`
[INFO] [stderr]    Compiling num-rational v0.2.1
[INFO] [stderr]     Checking libosu v0.0.7 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/osz/hitobject.rs:110:13
[INFO] [stderr]     |
[INFO] [stderr] 110 |             kind: kind,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/osz/hitobject.rs:110:13
[INFO] [stderr]     |
[INFO] [stderr] 110 |             kind: kind,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:36:12
[INFO] [stderr]    |
[INFO] [stderr] 36 |     Key6 = 131072,
[INFO] [stderr]    |            ^^^^^^ help: consider: `131_072`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:37:12
[INFO] [stderr]    |
[INFO] [stderr] 37 |     Key7 = 262144,
[INFO] [stderr]    |            ^^^^^^ help: consider: `262_144`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:38:12
[INFO] [stderr]    |
[INFO] [stderr] 38 |     Key8 = 524288,
[INFO] [stderr]    |            ^^^^^^ help: consider: `524_288`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:39:14
[INFO] [stderr]    |
[INFO] [stderr] 39 |     KeyMod = 1015808,
[INFO] [stderr]    |              ^^^^^^^ help: consider: `1_015_808`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:40:14
[INFO] [stderr]    |
[INFO] [stderr] 40 |     FadeIn = 1048576,
[INFO] [stderr]    |              ^^^^^^^ help: consider: `1_048_576`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:41:14
[INFO] [stderr]    |
[INFO] [stderr] 41 |     Random = 2097152,
[INFO] [stderr]    |              ^^^^^^^ help: consider: `2_097_152`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:42:15
[INFO] [stderr]    |
[INFO] [stderr] 42 |     LastMod = 4194304,
[INFO] [stderr]    |               ^^^^^^^ help: consider: `4_194_304`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:43:22
[INFO] [stderr]    |
[INFO] [stderr] 43 |     FreeModAllowed = 2077883,
[INFO] [stderr]    |                      ^^^^^^^ help: consider: `2_077_883`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:44:12
[INFO] [stderr]    |
[INFO] [stderr] 44 |     Key9 = 16777216,
[INFO] [stderr]    |            ^^^^^^^^ help: consider: `16_777_216`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:45:13
[INFO] [stderr]    |
[INFO] [stderr] 45 |     Key10 = 33554432,
[INFO] [stderr]    |             ^^^^^^^^ help: consider: `33_554_432`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:46:12
[INFO] [stderr]    |
[INFO] [stderr] 46 |     Key1 = 67108864,
[INFO] [stderr]    |            ^^^^^^^^ help: consider: `67_108_864`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:47:12
[INFO] [stderr]    |
[INFO] [stderr] 47 |     Key3 = 134217728,
[INFO] [stderr]    |            ^^^^^^^^^ help: consider: `134_217_728`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:48:12
[INFO] [stderr]    |
[INFO] [stderr] 48 |     Key2 = 268435456,
[INFO] [stderr]    |            ^^^^^^^^^ help: consider: `268_435_456`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/enums.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |         return self as u32 | other as u32;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self as u32 | other as u32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hitsounds.rs:51:9
[INFO] [stderr]    |
[INFO] [stderr] 51 |         return self.0 | other.0;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.0 | other.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/timing.rs:298:9
[INFO] [stderr]     |
[INFO] [stderr] 298 |         return 60_000.0 / self.get_bpm();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `60_000.0 / self.get_bpm()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:36:12
[INFO] [stderr]    |
[INFO] [stderr] 36 |     Key6 = 131072,
[INFO] [stderr]    |            ^^^^^^ help: consider: `131_072`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:37:12
[INFO] [stderr]    |
[INFO] [stderr] 37 |     Key7 = 262144,
[INFO] [stderr]    |            ^^^^^^ help: consider: `262_144`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:38:12
[INFO] [stderr]    |
[INFO] [stderr] 38 |     Key8 = 524288,
[INFO] [stderr]    |            ^^^^^^ help: consider: `524_288`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:39:14
[INFO] [stderr]    |
[INFO] [stderr] 39 |     KeyMod = 1015808,
[INFO] [stderr]    |              ^^^^^^^ help: consider: `1_015_808`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:40:14
[INFO] [stderr]    |
[INFO] [stderr] 40 |     FadeIn = 1048576,
[INFO] [stderr]    |              ^^^^^^^ help: consider: `1_048_576`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:41:14
[INFO] [stderr]    |
[INFO] [stderr] 41 |     Random = 2097152,
[INFO] [stderr]    |              ^^^^^^^ help: consider: `2_097_152`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:42:15
[INFO] [stderr]    |
[INFO] [stderr] 42 |     LastMod = 4194304,
[INFO] [stderr]    |               ^^^^^^^ help: consider: `4_194_304`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:43:22
[INFO] [stderr]    |
[INFO] [stderr] 43 |     FreeModAllowed = 2077883,
[INFO] [stderr]    |                      ^^^^^^^ help: consider: `2_077_883`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:44:12
[INFO] [stderr]    |
[INFO] [stderr] 44 |     Key9 = 16777216,
[INFO] [stderr]    |            ^^^^^^^^ help: consider: `16_777_216`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:45:13
[INFO] [stderr]    |
[INFO] [stderr] 45 |     Key10 = 33554432,
[INFO] [stderr]    |             ^^^^^^^^ help: consider: `33_554_432`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:46:12
[INFO] [stderr]    |
[INFO] [stderr] 46 |     Key1 = 67108864,
[INFO] [stderr]    |            ^^^^^^^^ help: consider: `67_108_864`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:47:12
[INFO] [stderr]    |
[INFO] [stderr] 47 |     Key3 = 134217728,
[INFO] [stderr]    |            ^^^^^^^^^ help: consider: `134_217_728`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/enums.rs:48:12
[INFO] [stderr]    |
[INFO] [stderr] 48 |     Key2 = 268435456,
[INFO] [stderr]    |            ^^^^^^^^^ help: consider: `268_435_456`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/enums.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |         return self as u32 | other as u32;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self as u32 | other as u32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/hitsounds.rs:51:9
[INFO] [stderr]    |
[INFO] [stderr] 51 |         return self.0 | other.0;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.0 | other.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/timing.rs:298:9
[INFO] [stderr]     |
[INFO] [stderr] 298 |         return 60_000.0 / self.get_bpm();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `60_000.0 / self.get_bpm()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/beatmap.rs:185:16
[INFO] [stderr]     |
[INFO] [stderr] 185 |             if &timing_point.time < &time {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 185 |             if timing_point.time < time {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/beatmap.rs:196:16
[INFO] [stderr]     |
[INFO] [stderr] 196 |             if &hit_object.start_time == &time {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 196 |             if hit_object.start_time == time {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/beatmap.rs:236:30
[INFO] [stderr]     |
[INFO] [stderr] 236 |                     for i in 0..(repeats + 1) {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^ help: use: `0..=repeats`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/beatmap.rs:185:16
[INFO] [stderr]     |
[INFO] [stderr] 185 |             if &timing_point.time < &time {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 185 |             if timing_point.time < time {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/beatmap.rs:196:16
[INFO] [stderr]     |
[INFO] [stderr] 196 |             if &hit_object.start_time == &time {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 196 |             if hit_object.start_time == time {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/beatmap.rs:236:30
[INFO] [stderr]     |
[INFO] [stderr] 236 |                     for i in 0..(repeats + 1) {
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^ help: use: `0..=repeats`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/osz/beatmap.rs:57:13
[INFO] [stderr]    |
[INFO] [stderr] 57 | /             match SECTION_HEADER_RGX.captures(line) {
[INFO] [stderr] 58 | |                 Some(captures) => {
[INFO] [stderr] 59 | |                     section = String::from(&captures["name"]);
[INFO] [stderr] 60 | |                     continue;
[INFO] [stderr] 61 | |                 }
[INFO] [stderr] 62 | |                 None => (),
[INFO] [stderr] 63 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 57 |             if let Some(captures) = SECTION_HEADER_RGX.captures(line) {
[INFO] [stderr] 58 |     section = String::from(&captures["name"]);
[INFO] [stderr] 59 |     continue;
[INFO] [stderr] 60 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/osz/beatmap.rs:66:16
[INFO] [stderr]    |
[INFO] [stderr] 66 |             if line.trim().len() == 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.trim().is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/osz/beatmap.rs:57:13
[INFO] [stderr]    |
[INFO] [stderr] 57 | /             match SECTION_HEADER_RGX.captures(line) {
[INFO] [stderr] 58 | |                 Some(captures) => {
[INFO] [stderr] 59 | |                     section = String::from(&captures["name"]);
[INFO] [stderr] 60 | |                     continue;
[INFO] [stderr] 61 | |                 }
[INFO] [stderr] 62 | |                 None => (),
[INFO] [stderr] 63 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 57 |             if let Some(captures) = SECTION_HEADER_RGX.captures(line) {
[INFO] [stderr] 58 |     section = String::from(&captures["name"]);
[INFO] [stderr] 59 |     continue;
[INFO] [stderr] 60 | }
[INFO] [stderr]    |
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/osz/beatmap.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 | /             if val == 0 {
[INFO] [stderr] 31 | |                 false
[INFO] [stderr] 32 | |             } else {
[INFO] [stderr] 33 | |                 true
[INFO] [stderr] 34 | |             }
[INFO] [stderr]    | |_____________^ help: you can reduce it to: `!(val == 0)`
[INFO] [stderr] ...
[INFO] [stderr] 87 |                           "Countdown" => kvalue!(captures[beatmap.countdown]: parse(bool)),
[INFO] [stderr]    |                                          ------------------------------------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/osz/beatmap.rs:66:16
[INFO] [stderr]    |
[INFO] [stderr] 66 |             if line.trim().len() == 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.trim().is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/osz/beatmap.rs:30:13
[INFO] [stderr]     |
[INFO] [stderr] 30  | /             if val == 0 {
[INFO] [stderr] 31  | |                 false
[INFO] [stderr] 32  | |             } else {
[INFO] [stderr] 33  | |                 true
[INFO] [stderr] 34  | |             }
[INFO] [stderr]     | |_____________^ help: you can reduce it to: `!(val == 0)`
[INFO] [stderr] ...
[INFO] [stderr] 114 |                               kvalue!(captures[beatmap.letterbox_in_breaks]: parse(bool))
[INFO] [stderr]     |                               ----------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/osz/beatmap.rs:30:13
[INFO] [stderr]     |
[INFO] [stderr] 30  | /             if val == 0 {
[INFO] [stderr] 31  | |                 false
[INFO] [stderr] 32  | |             } else {
[INFO] [stderr] 33  | |                 true
[INFO] [stderr] 34  | |             }
[INFO] [stderr]     | |_____________^ help: you can reduce it to: `!(val == 0)`
[INFO] [stderr] ...
[INFO] [stderr] 117 |                               kvalue!(captures[beatmap.widescreen_storyboard]: parse(bool))
[INFO] [stderr]     |                               ------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/osz/beatmap.rs:122:40
[INFO] [stderr]     |
[INFO] [stderr] 122 |                                 .split(",")
[INFO] [stderr]     |                                        ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/osz/beatmap.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 | /             if val == 0 {
[INFO] [stderr] 31 | |                 false
[INFO] [stderr] 32 | |             } else {
[INFO] [stderr] 33 | |                 true
[INFO] [stderr] 34 | |             }
[INFO] [stderr]    | |_____________^ help: you can reduce it to: `!(val == 0)`
[INFO] [stderr] ...
[INFO] [stderr] 87 |                           "Countdown" => kvalue!(captures[beatmap.countdown]: parse(bool)),
[INFO] [stderr]    |                                          ------------------------------------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/osz/beatmap.rs:142:57
[INFO] [stderr]     |
[INFO] [stderr] 142 |                                 captures["value"].split(" ").map(|s| s.to_owned()).collect()
[INFO] [stderr]     |                                                         ^^^ help: try using a char instead: `' '`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/osz/beatmap.rs:30:13
[INFO] [stderr]     |
[INFO] [stderr] 30  | /             if val == 0 {
[INFO] [stderr] 31  | |                 false
[INFO] [stderr] 32  | |             } else {
[INFO] [stderr] 33  | |                 true
[INFO] [stderr] 34  | |             }
[INFO] [stderr]     | |_____________^ help: you can reduce it to: `!(val == 0)`
[INFO] [stderr] ...
[INFO] [stderr] 114 |                               kvalue!(captures[beatmap.letterbox_in_breaks]: parse(bool))
[INFO] [stderr]     |                               ----------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/osz/beatmap.rs:179:13
[INFO] [stderr]     |
[INFO] [stderr] 179 | /             match tp.kind {
[INFO] [stderr] 180 | |                 TimingPointKind::Uninherited { .. } => prev = Some(tp.clone()),
[INFO] [stderr] 181 | |                 _ => (),
[INFO] [stderr] 182 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let TimingPointKind::Uninherited { .. } = tp.kind { prev = Some(tp.clone()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/osz/beatmap.rs:30:13
[INFO] [stderr]     |
[INFO] [stderr] 30  | /             if val == 0 {
[INFO] [stderr] 31  | |                 false
[INFO] [stderr] 32  | |             } else {
[INFO] [stderr] 33  | |                 true
[INFO] [stderr] 34  | |             }
[INFO] [stderr]     | |_____________^ help: you can reduce it to: `!(val == 0)`
[INFO] [stderr] ...
[INFO] [stderr] 117 |                               kvalue!(captures[beatmap.widescreen_storyboard]: parse(bool))
[INFO] [stderr]     |                               ------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/osz/beatmap.rs:122:40
[INFO] [stderr]     |
[INFO] [stderr] 122 |                                 .split(",")
[INFO] [stderr]     |                                        ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/osz/beatmap.rs:142:57
[INFO] [stderr]     |
[INFO] [stderr] 142 |                                 captures["value"].split(" ").map(|s| s.to_owned()).collect()
[INFO] [stderr]     |                                                         ^^^ help: try using a char instead: `' '`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/osz/beatmap.rs:179:13
[INFO] [stderr]     |
[INFO] [stderr] 179 | /             match tp.kind {
[INFO] [stderr] 180 | |                 TimingPointKind::Uninherited { .. } => prev = Some(tp.clone()),
[INFO] [stderr] 181 | |                 _ => (),
[INFO] [stderr] 182 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let TimingPointKind::Uninherited { .. } = tp.kind { prev = Some(tp.clone()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/osz/beatmap.rs:225:13
[INFO] [stderr]     |
[INFO] [stderr] 225 | /             match &self.sample_set {
[INFO] [stderr] 226 | |                 &SampleSet::None => "None",
[INFO] [stderr] 227 | |                 &SampleSet::Normal => "Normal",
[INFO] [stderr] 228 | |                 &SampleSet::Soft => "Soft",
[INFO] [stderr] 229 | |                 &SampleSet::Drum => "Drum",
[INFO] [stderr] 230 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 225 |             match self.sample_set {
[INFO] [stderr] 226 |                 SampleSet::None => "None",
[INFO] [stderr] 227 |                 SampleSet::Normal => "Normal",
[INFO] [stderr] 228 |                 SampleSet::Soft => "Soft",
[INFO] [stderr] 229 |                 SampleSet::Drum => "Drum",
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/osz/beatmap.rs:225:13
[INFO] [stderr]     |
[INFO] [stderr] 225 | /             match &self.sample_set {
[INFO] [stderr] 226 | |                 &SampleSet::None => "None",
[INFO] [stderr] 227 | |                 &SampleSet::Normal => "Normal",
[INFO] [stderr] 228 | |                 &SampleSet::Soft => "Soft",
[INFO] [stderr] 229 | |                 &SampleSet::Drum => "Drum",
[INFO] [stderr] 230 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 225 |             match self.sample_set {
[INFO] [stderr] 226 |                 SampleSet::None => "None",
[INFO] [stderr] 227 |                 SampleSet::Normal => "Normal",
[INFO] [stderr] 228 |                 SampleSet::Soft => "Soft",
[INFO] [stderr] 229 |                 SampleSet::Drum => "Drum",
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/osz/hitobject.rs:17:42
[INFO] [stderr]    |
[INFO] [stderr] 17 |         let parts = input.as_ref().split(",").collect::<Vec<_>>();
[INFO] [stderr]    |                                          ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/osz/hitobject.rs:37:48
[INFO] [stderr]    |
[INFO] [stderr] 37 |             let mut ctl_parts = parts[5].split("|").collect::<Vec<_>>();
[INFO] [stderr]    |                                                ^^^ help: try using a char instead: `'|'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/osz/hitobject.rs:55:28
[INFO] [stderr]    |
[INFO] [stderr] 55 |                 / (100.0 * parent.difficulty.slider_multiplier as f64))
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(parent.difficulty.slider_multiplier)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/osz/hitobject.rs:69:41
[INFO] [stderr]    |
[INFO] [stderr] 69 |                         let p = s.split(":").collect::<Vec<_>>();
[INFO] [stderr]    |                                         ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/osz/hitobject.rs:86:40
[INFO] [stderr]    |
[INFO] [stderr] 86 |         let extra_parts = extras.split(":").collect::<Vec<_>>();
[INFO] [stderr]    |                                        ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/osz/hitobject.rs:97:19
[INFO] [stderr]     |
[INFO] [stderr] 97  |               time: match &kind {
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 98  | |                 &HitObjectKind::Spinner { ref end_time } => end_time.clone(),
[INFO] [stderr] 99  | |                 _ => start_time.clone(),
[INFO] [stderr] 100 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 97  |             time: match kind {
[INFO] [stderr] 98  |                 HitObjectKind::Spinner { ref end_time } => end_time.clone(),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/osz/hitobject.rs:124:24
[INFO] [stderr]     |
[INFO] [stderr] 124 |           let obj_type = match &self.kind {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 125 | |             &HitObjectKind::Circle => 1,
[INFO] [stderr] 126 | |             &HitObjectKind::Slider { .. } => 2,
[INFO] [stderr] 127 | |             &HitObjectKind::Spinner { .. } => 8,
[INFO] [stderr] 128 | |         } | if self.new_combo { 4 } else { 0 }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 124 |         let obj_type = match self.kind {
[INFO] [stderr] 125 |             HitObjectKind::Circle => 1,
[INFO] [stderr] 126 |             HitObjectKind::Slider { .. } => 2,
[INFO] [stderr] 127 |             HitObjectKind::Spinner { .. } => 8,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/osz/hitobject.rs:141:29
[INFO] [stderr]     |
[INFO] [stderr] 141 |           let type_specific = match &self.kind {
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 142 | |             &HitObjectKind::Slider {
[INFO] [stderr] 143 | |                 ref kind,
[INFO] [stderr] 144 | |                 ref repeats,
[INFO] [stderr] ...   |
[INFO] [stderr] 171 | |             _ => String::new(),
[INFO] [stderr] 172 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 141 |         let type_specific = match self.kind {
[INFO] [stderr] 142 |             HitObjectKind::Slider {
[INFO] [stderr] 143 |                 ref kind,
[INFO] [stderr] 144 |                 ref repeats,
[INFO] [stderr] 145 |                 ref control,
[INFO] [stderr] 146 |                 ref pixel_length,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/osz/hitobject.rs:153:21
[INFO] [stderr]     |
[INFO] [stderr] 153 | /                     match kind {
[INFO] [stderr] 154 | |                         &SliderSplineKind::Linear => "L",
[INFO] [stderr] 155 | |                         &SliderSplineKind::Bezier => "B",
[INFO] [stderr] 156 | |                         &SliderSplineKind::Catmull => "C",
[INFO] [stderr] 157 | |                         &SliderSplineKind::Perfect => "P",
[INFO] [stderr] 158 | |                     },
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 153 |                     match *kind {
[INFO] [stderr] 154 |                         SliderSplineKind::Linear => "L",
[INFO] [stderr] 155 |                         SliderSplineKind::Bezier => "B",
[INFO] [stderr] 156 |                         SliderSplineKind::Catmull => "C",
[INFO] [stderr] 157 |                         SliderSplineKind::Perfect => "P",
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/osz/timing.rs:17:42
[INFO] [stderr]    |
[INFO] [stderr] 17 |         let parts = input.as_ref().split(",").collect::<Vec<_>>();
[INFO] [stderr]    |                                          ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/osz/timing.rs:36:48
[INFO] [stderr]    |
[INFO] [stderr] 36 |                     parent: parent.clone().map(|tp| Box::new(tp)),
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Box::new`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/osz/hitobject.rs:17:42
[INFO] [stderr]    |
[INFO] [stderr] 17 |         let parts = input.as_ref().split(",").collect::<Vec<_>>();
[INFO] [stderr]    |                                          ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/osz/timing.rs:68:25
[INFO] [stderr]    |
[INFO] [stderr] 68 |           let inherited = match &self.kind {
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 69 | |             &TimingPointKind::Inherited { .. } => 0,
[INFO] [stderr] 70 | |             &TimingPointKind::Uninherited { .. } => 1,
[INFO] [stderr] 71 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 68 |         let inherited = match self.kind {
[INFO] [stderr] 69 |             TimingPointKind::Inherited { .. } => 0,
[INFO] [stderr] 70 |             TimingPointKind::Uninherited { .. } => 1,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/osz/hitobject.rs:37:48
[INFO] [stderr]    |
[INFO] [stderr] 37 |             let mut ctl_parts = parts[5].split("|").collect::<Vec<_>>();
[INFO] [stderr]    |                                                ^^^ help: try using a char instead: `'|'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/osz/hitobject.rs:55:28
[INFO] [stderr]    |
[INFO] [stderr] 55 |                 / (100.0 * parent.difficulty.slider_multiplier as f64))
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(parent.difficulty.slider_multiplier)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/osz/hitobject.rs:69:41
[INFO] [stderr]    |
[INFO] [stderr] 69 |                         let p = s.split(":").collect::<Vec<_>>();
[INFO] [stderr]    |                                         ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/osz/hitobject.rs:86:40
[INFO] [stderr]    |
[INFO] [stderr] 86 |         let extra_parts = extras.split(":").collect::<Vec<_>>();
[INFO] [stderr]    |                                        ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/osz/hitobject.rs:97:19
[INFO] [stderr]     |
[INFO] [stderr] 97  |               time: match &kind {
[INFO] [stderr]     |  ___________________^
[INFO] [stderr] 98  | |                 &HitObjectKind::Spinner { ref end_time } => end_time.clone(),
[INFO] [stderr] 99  | |                 _ => start_time.clone(),
[INFO] [stderr] 100 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 97  |             time: match kind {
[INFO] [stderr] 98  |                 HitObjectKind::Spinner { ref end_time } => end_time.clone(),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:122:33
[INFO] [stderr]     |
[INFO] [stderr] 122 |                 let mpm = mpb * (*meter as f64);
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^ help: try: `f64::from(*meter)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:126:44
[INFO] [stderr]     |
[INFO] [stderr] 126 |                 let measure_offset = mpm * (*m as f64);
[INFO] [stderr]     |                                            ^^^^^^^^^^^ help: try: `f64::from(*m)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:129:40
[INFO] [stderr]     |
[INFO] [stderr] 129 |                 let remaining_offset = (*f.numer() as f64) * mpm / (*f.denom() as f64);
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*f.numer())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:129:68
[INFO] [stderr]     |
[INFO] [stderr] 129 |                 let remaining_offset = (*f.numer() as f64) * mpm / (*f.denom() as f64);
[INFO] [stderr]     |                                                                    ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*f.denom())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:168:33
[INFO] [stderr]     |
[INFO] [stderr] 168 |                 let mpm = mpb * (meter as f64);
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^ help: try: `f64::from(meter)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:171:33
[INFO] [stderr]     |
[INFO] [stderr] 171 |                 let measures = ((cur - base) as f64 / mpm) as i32;
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cur - base)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:174:37
[INFO] [stderr]     |
[INFO] [stderr] 174 |                 let measure_start = base as f64 + (measures as f64 * mpm);
[INFO] [stderr]     |                                     ^^^^^^^^^^^ help: try: `f64::from(base)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:174:52
[INFO] [stderr]     |
[INFO] [stderr] 174 |                 let measure_start = base as f64 + (measures as f64 * mpm);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^ help: try: `f64::from(measures)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:175:30
[INFO] [stderr]     |
[INFO] [stderr] 175 |                 let offset = cur as f64 - measure_start;
[INFO] [stderr]     |                              ^^^^^^^^^^ help: try: `f64::from(cur)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/osz/hitobject.rs:124:24
[INFO] [stderr]     |
[INFO] [stderr] 124 |           let obj_type = match &self.kind {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 125 | |             &HitObjectKind::Circle => 1,
[INFO] [stderr] 126 | |             &HitObjectKind::Slider { .. } => 2,
[INFO] [stderr] 127 | |             &HitObjectKind::Spinner { .. } => 8,
[INFO] [stderr] 128 | |         } | if self.new_combo { 4 } else { 0 }
[INFO] [stderr]     | |_________^
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/timing.rs:179:26
[INFO] [stderr]     |
[INFO] [stderr] 179 |                 for d in vec![1, 2, 3, 4, 6, 8, 12, 16] {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3, 4, 6, 8, 12, 16]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 124 |         let obj_type = match self.kind {
[INFO] [stderr] 125 |             HitObjectKind::Circle => 1,
[INFO] [stderr] 126 |             HitObjectKind::Slider { .. } => 2,
[INFO] [stderr] 127 |             HitObjectKind::Spinner { .. } => 8,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:181:42
[INFO] [stderr]     |
[INFO] [stderr] 181 |                         let snap = mpm * i as f64 / d as f64;
[INFO] [stderr]     |                                          ^^^^^^^^ help: try: `f64::from(i)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:181:53
[INFO] [stderr]     |
[INFO] [stderr] 181 |                         let snap = mpm * i as f64 / d as f64;
[INFO] [stderr]     |                                                     ^^^^^^^^ help: try: `f64::from(d)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:185:42
[INFO] [stderr]     |
[INFO] [stderr] 185 |                         let snap = mpm * (i + d) as f64 / d as f64;
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^ help: try: `f64::from(i + d)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:185:59
[INFO] [stderr]     |
[INFO] [stderr] 185 |                         let snap = mpm * (i + d) as f64 / d as f64;
[INFO] [stderr]     |                                                           ^^^^^^^^ help: try: `f64::from(d)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/osz/hitobject.rs:141:29
[INFO] [stderr]     |
[INFO] [stderr] 141 |           let type_specific = match &self.kind {
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 142 | |             &HitObjectKind::Slider {
[INFO] [stderr] 143 | |                 ref kind,
[INFO] [stderr] 144 | |                 ref repeats,
[INFO] [stderr] ...   |
[INFO] [stderr] 171 | |             _ => String::new(),
[INFO] [stderr] 172 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 141 |         let type_specific = match self.kind {
[INFO] [stderr] 142 |             HitObjectKind::Slider {
[INFO] [stderr] 143 |                 ref kind,
[INFO] [stderr] 144 |                 ref repeats,
[INFO] [stderr] 145 |                 ref control,
[INFO] [stderr] 146 |                 ref pixel_length,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/osz/hitobject.rs:153:21
[INFO] [stderr]     |
[INFO] [stderr] 153 | /                     match kind {
[INFO] [stderr] 154 | |                         &SliderSplineKind::Linear => "L",
[INFO] [stderr] 155 | |                         &SliderSplineKind::Bezier => "B",
[INFO] [stderr] 156 | |                         &SliderSplineKind::Catmull => "C",
[INFO] [stderr] 157 | |                         &SliderSplineKind::Perfect => "P",
[INFO] [stderr] 158 | |                     },
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 153 |                     match *kind {
[INFO] [stderr] 154 |                         SliderSplineKind::Linear => "L",
[INFO] [stderr] 155 |                         SliderSplineKind::Bezier => "B",
[INFO] [stderr] 156 |                         SliderSplineKind::Catmull => "C",
[INFO] [stderr] 157 |                         SliderSplineKind::Perfect => "P",
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/timing.rs:270:9
[INFO] [stderr]     |
[INFO] [stderr] 270 | /         match &self.kind {
[INFO] [stderr] 271 | |             &TimingPointKind::Uninherited { .. } => self,
[INFO] [stderr] 272 | |             &TimingPointKind::Inherited { ref parent, .. } => match parent {
[INFO] [stderr] 273 | |                 Some(_parent) => _parent.get_uninherited_ancestor(),
[INFO] [stderr] 274 | |                 None => panic!("Inherited timing point does not have a parent."),
[INFO] [stderr] 275 | |             },
[INFO] [stderr] 276 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 270 |         match self.kind {
[INFO] [stderr] 271 |             TimingPointKind::Uninherited { .. } => self,
[INFO] [stderr] 272 |             TimingPointKind::Inherited { ref parent, .. } => match parent {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/timing.rs:281:9
[INFO] [stderr]     |
[INFO] [stderr] 281 | /         match &ancestor.kind {
[INFO] [stderr] 282 | |             &TimingPointKind::Uninherited { ref bpm, .. } => *bpm,
[INFO] [stderr] 283 | |             _ => panic!("The ancestor should always be an Uninherited timing point."),
[INFO] [stderr] 284 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 281 |         match ancestor.kind {
[INFO] [stderr] 282 |             TimingPointKind::Uninherited { ref bpm, .. } => *bpm,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/timing.rs:290:9
[INFO] [stderr]     |
[INFO] [stderr] 290 | /         match &ancestor.kind {
[INFO] [stderr] 291 | |             &TimingPointKind::Uninherited { ref meter, .. } => *meter,
[INFO] [stderr] 292 | |             _ => panic!("The ancestor should always be an Uninherited timing point."),
[INFO] [stderr] 293 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 290 |         match ancestor.kind {
[INFO] [stderr] 291 |             TimingPointKind::Uninherited { ref meter, .. } => *meter,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/osz/timing.rs:17:42
[INFO] [stderr]    |
[INFO] [stderr] 17 |         let parts = input.as_ref().split(",").collect::<Vec<_>>();
[INFO] [stderr]    |                                          ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/osz/timing.rs:36:48
[INFO] [stderr]    |
[INFO] [stderr] 36 |                     parent: parent.clone().map(|tp| Box::new(tp)),
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Box::new`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/osz/timing.rs:68:25
[INFO] [stderr]    |
[INFO] [stderr] 68 |           let inherited = match &self.kind {
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 69 | |             &TimingPointKind::Inherited { .. } => 0,
[INFO] [stderr] 70 | |             &TimingPointKind::Uninherited { .. } => 1,
[INFO] [stderr] 71 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 68 |         let inherited = match self.kind {
[INFO] [stderr] 69 |             TimingPointKind::Inherited { .. } => 0,
[INFO] [stderr] 70 |             TimingPointKind::Uninherited { .. } => 1,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:122:33
[INFO] [stderr]     |
[INFO] [stderr] 122 |                 let mpm = mpb * (*meter as f64);
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^ help: try: `f64::from(*meter)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:126:44
[INFO] [stderr]     |
[INFO] [stderr] 126 |                 let measure_offset = mpm * (*m as f64);
[INFO] [stderr]     |                                            ^^^^^^^^^^^ help: try: `f64::from(*m)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:129:40
[INFO] [stderr]     |
[INFO] [stderr] 129 |                 let remaining_offset = (*f.numer() as f64) * mpm / (*f.denom() as f64);
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*f.numer())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:129:68
[INFO] [stderr]     |
[INFO] [stderr] 129 |                 let remaining_offset = (*f.numer() as f64) * mpm / (*f.denom() as f64);
[INFO] [stderr]     |                                                                    ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*f.denom())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:168:33
[INFO] [stderr]     |
[INFO] [stderr] 168 |                 let mpm = mpb * (meter as f64);
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^ help: try: `f64::from(meter)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:171:33
[INFO] [stderr]     |
[INFO] [stderr] 171 |                 let measures = ((cur - base) as f64 / mpm) as i32;
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cur - base)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:174:37
[INFO] [stderr]     |
[INFO] [stderr] 174 |                 let measure_start = base as f64 + (measures as f64 * mpm);
[INFO] [stderr]     |                                     ^^^^^^^^^^^ help: try: `f64::from(base)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:174:52
[INFO] [stderr]     |
[INFO] [stderr] 174 |                 let measure_start = base as f64 + (measures as f64 * mpm);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^ help: try: `f64::from(measures)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:175:30
[INFO] [stderr]     |
[INFO] [stderr] 175 |                 let offset = cur as f64 - measure_start;
[INFO] [stderr]     |                              ^^^^^^^^^^ help: try: `f64::from(cur)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/timing.rs:179:26
[INFO] [stderr]     |
[INFO] [stderr] 179 |                 for d in vec![1, 2, 3, 4, 6, 8, 12, 16] {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3, 4, 6, 8, 12, 16]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:181:42
[INFO] [stderr]     |
[INFO] [stderr] 181 |                         let snap = mpm * i as f64 / d as f64;
[INFO] [stderr]     |                                          ^^^^^^^^ help: try: `f64::from(i)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:181:53
[INFO] [stderr]     |
[INFO] [stderr] 181 |                         let snap = mpm * i as f64 / d as f64;
[INFO] [stderr]     |                                                     ^^^^^^^^ help: try: `f64::from(d)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:185:42
[INFO] [stderr]     |
[INFO] [stderr] 185 |                         let snap = mpm * (i + d) as f64 / d as f64;
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^ help: try: `f64::from(i + d)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/timing.rs:185:59
[INFO] [stderr]     |
[INFO] [stderr] 185 |                         let snap = mpm * (i + d) as f64 / d as f64;
[INFO] [stderr]     |                                                           ^^^^^^^^ help: try: `f64::from(d)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/timing.rs:270:9
[INFO] [stderr]     |
[INFO] [stderr] 270 | /         match &self.kind {
[INFO] [stderr] 271 | |             &TimingPointKind::Uninherited { .. } => self,
[INFO] [stderr] 272 | |             &TimingPointKind::Inherited { ref parent, .. } => match parent {
[INFO] [stderr] 273 | |                 Some(_parent) => _parent.get_uninherited_ancestor(),
[INFO] [stderr] 274 | |                 None => panic!("Inherited timing point does not have a parent."),
[INFO] [stderr] 275 | |             },
[INFO] [stderr] 276 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 270 |         match self.kind {
[INFO] [stderr] 271 |             TimingPointKind::Uninherited { .. } => self,
[INFO] [stderr] 272 |             TimingPointKind::Inherited { ref parent, .. } => match parent {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/timing.rs:281:9
[INFO] [stderr]     |
[INFO] [stderr] 281 | /         match &ancestor.kind {
[INFO] [stderr] 282 | |             &TimingPointKind::Uninherited { ref bpm, .. } => *bpm,
[INFO] [stderr] 283 | |             _ => panic!("The ancestor should always be an Uninherited timing point."),
[INFO] [stderr] 284 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 281 |         match ancestor.kind {
[INFO] [stderr] 282 |             TimingPointKind::Uninherited { ref bpm, .. } => *bpm,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/timing.rs:290:9
[INFO] [stderr]     |
[INFO] [stderr] 290 | /         match &ancestor.kind {
[INFO] [stderr] 291 | |             &TimingPointKind::Uninherited { ref meter, .. } => *meter,
[INFO] [stderr] 292 | |             _ => panic!("The ancestor should always be an Uninherited timing point."),
[INFO] [stderr] 293 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 290 |         match ancestor.kind {
[INFO] [stderr] 291 |             TimingPointKind::Uninherited { ref meter, .. } => *meter,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Write`
[INFO] [stderr]  --> tests/test_serde.rs:7:21
[INFO] [stderr]   |
[INFO] [stderr] 7 | use std::io::{Read, Write};
[INFO] [stderr]   |                     ^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/test_serde.rs:47:25
[INFO] [stderr]    |
[INFO] [stderr] 47 |     test_parser_774965: 774965,
[INFO] [stderr]    |                         ^^^^^^ help: consider: `774_965`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/test_serde.rs:48:25
[INFO] [stderr]    |
[INFO] [stderr] 48 |     test_parser_804683: 804683,
[INFO] [stderr]    |                         ^^^^^^ help: consider: `804_683`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.03s
[INFO] running `"docker" "inspect" "7c0b43f6a438c62be2ecd8946d51e40c0c7fefe9a185e0eddcd477e4f43bb253"`
[INFO] running `"docker" "rm" "-f" "7c0b43f6a438c62be2ecd8946d51e40c0c7fefe9a185e0eddcd477e4f43bb253"`
[INFO] [stdout] 7c0b43f6a438c62be2ecd8946d51e40c0c7fefe9a185e0eddcd477e4f43bb253