[INFO] crate libnetkeeper 0.1.0 is already in cache [INFO] extracting crate libnetkeeper 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/libnetkeeper/0.1.0 [INFO] extracting crate libnetkeeper 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libnetkeeper/0.1.0 [INFO] validating manifest of libnetkeeper-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libnetkeeper-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libnetkeeper-0.1.0 [INFO] finished frobbing libnetkeeper-0.1.0 [INFO] frobbed toml for libnetkeeper-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/libnetkeeper/0.1.0/Cargo.toml [INFO] started frobbing libnetkeeper-0.1.0 [INFO] finished frobbing libnetkeeper-0.1.0 [INFO] frobbed toml for libnetkeeper-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libnetkeeper/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libnetkeeper-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libnetkeeper/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0fa9543237261da9ba93c13f2d17ce5413e63d4f5a422309fa419b7fc1970c97 [INFO] running `"docker" "start" "-a" "0fa9543237261da9ba93c13f2d17ce5413e63d4f5a422309fa419b7fc1970c97"` [INFO] [stderr] Checking md4 v0.4.1 [INFO] [stderr] Checking libnetkeeper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netkeeper/heartbeater.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netkeeper/heartbeater.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | type_name: type_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netkeeper/heartbeater.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netkeeper/heartbeater.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netkeeper/heartbeater.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | frame: frame, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/singlenet/attributes.rs:1:10 [INFO] [stderr] | [INFO] [stderr] 1 | #![allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netkeeper/heartbeater.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netkeeper/heartbeater.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | type_name: type_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netkeeper/heartbeater.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netkeeper/heartbeater.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netkeeper/heartbeater.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | frame: frame, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/singlenet/attributes.rs:1:10 [INFO] [stderr] | [INFO] [stderr] 1 | #![allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/singlenet/attributes.rs:1:10 [INFO] [stderr] | [INFO] [stderr] 1 | #![allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/drcom/pppoe/heartbeater.rs:499:23 [INFO] [stderr] | [INFO] [stderr] 499 | assert_eq!(crc32, 201589764); [INFO] [stderr] | ^^^^^^^^^ help: consider: `201_589_764` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/drcom/wired/dialer.rs:851:16 [INFO] [stderr] | [INFO] [stderr] 851 | 3581815520); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_581_815_520` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/drcom/tests.rs:20:39 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(cr.challenge_seed, 185207048); [INFO] [stderr] | ^^^^^^^^^ help: consider: `185_207_048` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/drcom/tests.rs:32:41 [INFO] [stderr] | [INFO] [stderr] 32 | 0x04030201u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0403_0201u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/drcom/tests.rs:39:41 [INFO] [stderr] | [INFO] [stderr] 39 | 0x04030201u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0403_0201u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/drcom/tests.rs:46:41 [INFO] [stderr] | [INFO] [stderr] 46 | 0x04030200u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0403_0200u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/drcom/tests.rs:83:46 [INFO] [stderr] | [INFO] [stderr] 83 | Some(0x22221111u32)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x2222_1111u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/drcom/tests.rs:279:88 [INFO] [stderr] | [INFO] [stderr] 279 | let phase1 = PhaseOneRequest::new([1, 2, 3, 4], "password", [5, 6, 7, 8], Some(123456789)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `123_456_789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/netkeeper/heartbeater.rs:250:47 [INFO] [stderr] | [INFO] [stderr] 250 | let pin = PacketUtils::claculate_pin(Some(1472483020)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_472_483_020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/netkeeper/tests.rs:10:72 [INFO] [stderr] | [INFO] [stderr] 10 | let encrypted = dialer.encrypt_account("05802278989@HYXY.XY", Some(1472483020)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_472_483_020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ghca/tests.rs:9:49 [INFO] [stderr] | [INFO] [stderr] 9 | Some(0x57F486F7), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x57F4_86F7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ghca/tests.rs:10:49 [INFO] [stderr] | [INFO] [stderr] 10 | Some(0x57F48719)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x57F4_8719` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ghca/tests.rs:14:50 [INFO] [stderr] | [INFO] [stderr] 14 | Some(0x57F4B79E), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x57F4_B79E` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ghca/tests.rs:15:50 [INFO] [stderr] | [INFO] [stderr] 15 | Some(0x57F4B7B0)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x57F4_B7B0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ghca/tests.rs:19:50 [INFO] [stderr] | [INFO] [stderr] 19 | Some(0x57F4B79E), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x57F4_B79E` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ghca/tests.rs:20:50 [INFO] [stderr] | [INFO] [stderr] 20 | Some(0x57F4B7B0)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x57F4_B7B0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `match_same_arms` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/singlenet/attributes.rs:1:10 [INFO] [stderr] | [INFO] [stderr] 1 | #![allow(match_same_arms)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::match_same_arms` [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/singlenet/attributes.rs:400:60 [INFO] [stderr] | [INFO] [stderr] 400 | let kp_data1 = KeepaliveDataCalculator::calculate(Some(1472483020), None); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_472_483_020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/singlenet/attributes.rs:401:60 [INFO] [stderr] | [INFO] [stderr] 401 | let kp_data2 = KeepaliveDataCalculator::calculate(Some(1472483020), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_472_483_020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/singlenet/heartbeater.rs:329:47 [INFO] [stderr] | [INFO] [stderr] 329 | let seq = PacketFactoryWin::calc_seq(Some(1472483020)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_472_483_020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/singlenet/tests.rs:11:72 [INFO] [stderr] | [INFO] [stderr] 11 | let encrypted = dialer.encrypt_account("05802278989@HYXY.XY", Some(1472483020)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_472_483_020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/singlenet/tests.rs:20:56 [INFO] [stderr] | [INFO] [stderr] 20 | Some(1472483020), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_472_483_020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/singlenet/tests.rs:25:56 [INFO] [stderr] | [INFO] [stderr] 25 | Some(1472483020), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_472_483_020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/drcom/wired/dialer.rs:380:43 [INFO] [stderr] | [INFO] [stderr] 380 | for (i, c) in password.as_bytes().into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/drcom/wired/dialer.rs:486:30 [INFO] [stderr] | [INFO] [stderr] 486 | for (i, ip) in value.into_iter().take(4).enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/drcom/wired/dialer.rs:549:38 [INFO] [stderr] | [INFO] [stderr] 549 | fn hash_mac_address(mac_address: &[u8; 6], password_md5_hash: &[u8; 16]) -> [u8; 6] { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 6]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: casting from `*const [u8]` to a more-strictly-aligned pointer (`*const u16`) [INFO] [stderr] --> src/singlenet/dialer.rs:105:56 [INFO] [stderr] | [INFO] [stderr] 105 | data_shorts = slice::from_raw_parts::((data as *const [u8]) as *const u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/singlenet/attributes.rs:171:17 [INFO] [stderr] | [INFO] [stderr] 171 | pub fn name(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/singlenet/attributes.rs:224:15 [INFO] [stderr] | [INFO] [stderr] 224 | pub fn id(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/singlenet/attributes.rs:276:19 [INFO] [stderr] | [INFO] [stderr] 276 | pub fn parent(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/singlenet/attributes.rs:301:23 [INFO] [stderr] | [INFO] [stderr] 301 | pub fn value_type(&self) -> AttributeValueType { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `libnetkeeper`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/drcom/wired/dialer.rs:380:43 [INFO] [stderr] | [INFO] [stderr] 380 | for (i, c) in password.as_bytes().into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/drcom/wired/dialer.rs:486:30 [INFO] [stderr] | [INFO] [stderr] 486 | for (i, ip) in value.into_iter().take(4).enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/drcom/wired/dialer.rs:549:38 [INFO] [stderr] | [INFO] [stderr] 549 | fn hash_mac_address(mac_address: &[u8; 6], password_md5_hash: &[u8; 16]) -> [u8; 6] { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 6]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: casting from `*const [u8]` to a more-strictly-aligned pointer (`*const u16`) [INFO] [stderr] --> src/singlenet/dialer.rs:105:56 [INFO] [stderr] | [INFO] [stderr] 105 | data_shorts = slice::from_raw_parts::((data as *const [u8]) as *const u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/singlenet/attributes.rs:171:17 [INFO] [stderr] | [INFO] [stderr] 171 | pub fn name(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/singlenet/attributes.rs:224:15 [INFO] [stderr] | [INFO] [stderr] 224 | pub fn id(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/singlenet/attributes.rs:276:19 [INFO] [stderr] | [INFO] [stderr] 276 | pub fn parent(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/singlenet/attributes.rs:301:23 [INFO] [stderr] | [INFO] [stderr] 301 | pub fn value_type(&self) -> AttributeValueType { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `libnetkeeper`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0fa9543237261da9ba93c13f2d17ce5413e63d4f5a422309fa419b7fc1970c97"` [INFO] running `"docker" "rm" "-f" "0fa9543237261da9ba93c13f2d17ce5413e63d4f5a422309fa419b7fc1970c97"` [INFO] [stdout] 0fa9543237261da9ba93c13f2d17ce5413e63d4f5a422309fa419b7fc1970c97