[INFO] crate libmultilog 0.1.0 is already in cache [INFO] extracting crate libmultilog 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/libmultilog/0.1.0 [INFO] extracting crate libmultilog 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libmultilog/0.1.0 [INFO] validating manifest of libmultilog-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libmultilog-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libmultilog-0.1.0 [INFO] finished frobbing libmultilog-0.1.0 [INFO] frobbed toml for libmultilog-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/libmultilog/0.1.0/Cargo.toml [INFO] started frobbing libmultilog-0.1.0 [INFO] finished frobbing libmultilog-0.1.0 [INFO] frobbed toml for libmultilog-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libmultilog/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libmultilog-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libmultilog/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 620d322048f56310577dd01fcdd40571bef5a128c7eb620aa88c1d58668a6673 [INFO] running `"docker" "start" "-a" "620d322048f56310577dd01fcdd40571bef5a128c7eb620aa88c1d58668a6673"` [INFO] [stderr] Checking blastfig v0.3.3 [INFO] [stderr] Compiling vergen v0.1.1 [INFO] [stderr] Compiling libmultilog v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/multi.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | const STDOUT = 0b00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/multi.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | const FILE = 0b00000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/multi.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | const STDOUT = 0b00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/multi.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | const FILE = 0b00000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `Log` [INFO] [stderr] --> src/multi.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | use log::{self, Log, LogLevel, LogLevelFilter, LogMetadata, LogRecord, SetLoggerError}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude` [INFO] [stderr] --> src/file.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/multi.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | / match self.file { [INFO] [stderr] 71 | | Some(ref mut f) => { [INFO] [stderr] 72 | | f.add_filter(lvl, r); [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | None => {} [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 70 | if let Some(ref mut f) = self.file { [INFO] [stderr] 71 | f.add_filter(lvl, r); [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/multi.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | / match self.file { [INFO] [stderr] 176 | | Some(ref f) => { [INFO] [stderr] 177 | | f.log(record); [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | None => {} [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 175 | if let Some(ref f) = self.file { [INFO] [stderr] 176 | f.log(record); [INFO] [stderr] 177 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/multi.rs:188:17 [INFO] [stderr] | [INFO] [stderr] 188 | / match self.stdout { [INFO] [stderr] 189 | | Some(ref s) => { [INFO] [stderr] 190 | | s.log(record); [INFO] [stderr] 191 | | } [INFO] [stderr] 192 | | None => {} [INFO] [stderr] 193 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 188 | if let Some(ref s) = self.stdout { [INFO] [stderr] 189 | s.log(record); [INFO] [stderr] 190 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/stdout.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | / match self.outputfn.lock() { [INFO] [stderr] 25 | | Ok(ref mut f) => f(record), [INFO] [stderr] 26 | | Err(_) => {} [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(ref mut f) = self.outputfn.lock() { f(record) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused import: `Log` [INFO] [stderr] --> src/multi.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | use log::{self, Log, LogLevel, LogLevelFilter, LogMetadata, LogRecord, SetLoggerError}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude` [INFO] [stderr] --> src/file.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/multi.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | / match self.file { [INFO] [stderr] 71 | | Some(ref mut f) => { [INFO] [stderr] 72 | | f.add_filter(lvl, r); [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | None => {} [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 70 | if let Some(ref mut f) = self.file { [INFO] [stderr] 71 | f.add_filter(lvl, r); [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/multi.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | / match self.file { [INFO] [stderr] 176 | | Some(ref f) => { [INFO] [stderr] 177 | | f.log(record); [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | None => {} [INFO] [stderr] 180 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 175 | if let Some(ref f) = self.file { [INFO] [stderr] 176 | f.log(record); [INFO] [stderr] 177 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/multi.rs:188:17 [INFO] [stderr] | [INFO] [stderr] 188 | / match self.stdout { [INFO] [stderr] 189 | | Some(ref s) => { [INFO] [stderr] 190 | | s.log(record); [INFO] [stderr] 191 | | } [INFO] [stderr] 192 | | None => {} [INFO] [stderr] 193 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 188 | if let Some(ref s) = self.stdout { [INFO] [stderr] 189 | s.log(record); [INFO] [stderr] 190 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/stdout.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | / match self.outputfn.lock() { [INFO] [stderr] 25 | | Ok(ref mut f) => f(record), [INFO] [stderr] 26 | | Err(_) => {} [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(ref mut f) = self.outputfn.lock() { f(record) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> tests/lib.rs:221:5 [INFO] [stderr] | [INFO] [stderr] 221 | let _ = fs::remove_file(tmp.join("log.log")).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.56s [INFO] running `"docker" "inspect" "620d322048f56310577dd01fcdd40571bef5a128c7eb620aa88c1d58668a6673"` [INFO] running `"docker" "rm" "-f" "620d322048f56310577dd01fcdd40571bef5a128c7eb620aa88c1d58668a6673"` [INFO] [stdout] 620d322048f56310577dd01fcdd40571bef5a128c7eb620aa88c1d58668a6673