[INFO] crate libmount 0.1.11 is already in cache [INFO] extracting crate libmount 0.1.11 into work/ex/clippy-test-run/sources/stable/reg/libmount/0.1.11 [INFO] extracting crate libmount 0.1.11 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libmount/0.1.11 [INFO] validating manifest of libmount-0.1.11 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libmount-0.1.11 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libmount-0.1.11 [INFO] finished frobbing libmount-0.1.11 [INFO] frobbed toml for libmount-0.1.11 written to work/ex/clippy-test-run/sources/stable/reg/libmount/0.1.11/Cargo.toml [INFO] started frobbing libmount-0.1.11 [INFO] finished frobbing libmount-0.1.11 [INFO] frobbed toml for libmount-0.1.11 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libmount/0.1.11/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libmount-0.1.11 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libmount/0.1.11:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ffa5b05062c6b0dfc2af8d29b06cafdf814cffd8ca4fb81a4485f6c1c434b8bd [INFO] running `"docker" "start" "-a" "ffa5b05062c6b0dfc2af8d29b06cafdf814cffd8ca4fb81a4485f6c1c434b8bd"` [INFO] [stderr] Checking libmount v0.1.11 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | msg: msg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `msg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | row_num: row_num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `row_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | row: row, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | mount_id: mount_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mount_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:185:9 [INFO] [stderr] | [INFO] [stderr] 185 | parent_id: parent_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parent_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | mount_point: mount_point, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mount_point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | mount_options: mount_options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mount_options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | optional_fields: optional_fields, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `optional_fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | fstype: fstype, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fstype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | mount_source: mount_source, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mount_source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | super_options: super_options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `super_options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | msg: msg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `msg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | row_num: row_num, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `row_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | row: row, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | mount_id: mount_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mount_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:185:9 [INFO] [stderr] | [INFO] [stderr] 185 | parent_id: parent_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parent_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | mount_point: mount_point, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mount_point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | mount_options: mount_options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mount_options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | optional_fields: optional_fields, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `optional_fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | fstype: fstype, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fstype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | mount_source: mount_source, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mount_source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mountinfo.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | super_options: super_options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `super_options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | return CString::new(path.as_os_str().as_bytes()).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CString::new(path.as_os_str().as_bytes()).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tmpfs.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return cur.into_inner(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cur.into_inner()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mountinfo.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return &self.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mountinfo.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return &self.msg; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.msg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mountinfo.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mountinfo.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | return &v[0..0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&v[0..0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mountinfo.rs:286:5 [INFO] [stderr] | [INFO] [stderr] 286 | return &v[0..0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&v[0..0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mountinfo.rs:301:5 [INFO] [stderr] | [INFO] [stderr] 301 | return (&v[0..], &v[0..0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(&v[0..], &v[0..0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | return CString::new(path.as_os_str().as_bytes()).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CString::new(path.as_os_str().as_bytes()).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tmpfs.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return cur.into_inner(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cur.into_inner()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mountinfo.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return &self.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mountinfo.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return &self.msg; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.msg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mountinfo.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mountinfo.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | return &v[0..0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&v[0..0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mountinfo.rs:286:5 [INFO] [stderr] | [INFO] [stderr] 286 | return &v[0..0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&v[0..0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mountinfo.rs:301:5 [INFO] [stderr] | [INFO] [stderr] 301 | return (&v[0..], &v[0..0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(&v[0..], &v[0..0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bind.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | flags = flags | MsFlags::MS_REC; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= MsFlags::MS_REC` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bind.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | format!("{}", user()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `user().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/overlay.rs:156:27 [INFO] [stderr] | [INFO] [stderr] 156 | info.push(format!("{}", if u.dev() == w.dev() [INFO] [stderr] | ___________________________^ [INFO] [stderr] 157 | | { "same-fs" } else { "different-fs" })); [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( if u.dev() == w.dev() [INFO] [stderr] 3 | { "same-fs" } else { "different-fs" }.to_string() ) ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/overlay.rs:166:12 [INFO] [stderr] | [INFO] [stderr] 166 | if self.lowerdirs.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.lowerdirs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/tmpfs.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | cur.write(b",").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/tmpfs.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | cur.write(b",").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/tmpfs.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | cur.write(b",").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/tmpfs.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | cur.write(b",").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tmpfs.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | format!("{}", user()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `user().to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/remount.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | format!("{}", user()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `user().to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mountinfo.rs:164:1 [INFO] [stderr] | [INFO] [stderr] 164 | / pub(crate) fn parse_mount_point<'a>(row: &'a [u8]) [INFO] [stderr] 165 | | -> Result>, ParseRowError> [INFO] [stderr] 166 | | { [INFO] [stderr] 167 | | let row = rstrip_cr(&row); [INFO] [stderr] ... | [INFO] [stderr] 195 | | })) [INFO] [stderr] 196 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/mountinfo.rs:226:34 [INFO] [stderr] | [INFO] [stderr] 226 | return Err(ParseRowError(format!("Expected more fields"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Expected more fields".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mountinfo.rs:232:1 [INFO] [stderr] | [INFO] [stderr] 232 | / fn parse_os_str<'a>(data: &'a [u8]) [INFO] [stderr] 233 | | -> Result<(Cow<'a, OsStr>, &'a [u8]), ParseRowError> [INFO] [stderr] 234 | | { [INFO] [stderr] 235 | | let (field, tail) = try!(parse_field(data, b" ")); [INFO] [stderr] 236 | | Ok((unescape_octals(OsStr::from_bytes(field)), tail)) [INFO] [stderr] 237 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mountinfo.rs:263:1 [INFO] [stderr] | [INFO] [stderr] 263 | / fn parse_optional<'a>(data: &'a [u8]) [INFO] [stderr] 264 | | -> Result<(Cow<'a, OsStr>, &'a [u8]), ParseRowError> [INFO] [stderr] 265 | | { [INFO] [stderr] 266 | | let (field, tail) = try!(parse_field(data, b"- ")); [INFO] [stderr] 267 | | let field = rstrip_whitespaces(field); [INFO] [stderr] 268 | | Ok((unescape_octals(OsStr::from_bytes(field)), tail)) [INFO] [stderr] 269 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/mountinfo.rs:283:23 [INFO] [stderr] | [INFO] [stderr] 283 | return &v[..i + 1]; [INFO] [stderr] | ^^^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `libmount`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bind.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | flags = flags | MsFlags::MS_REC; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags |= MsFlags::MS_REC` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bind.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | format!("{}", user()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `user().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/overlay.rs:156:27 [INFO] [stderr] | [INFO] [stderr] 156 | info.push(format!("{}", if u.dev() == w.dev() [INFO] [stderr] | ___________________________^ [INFO] [stderr] 157 | | { "same-fs" } else { "different-fs" })); [INFO] [stderr] | |__________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( if u.dev() == w.dev() [INFO] [stderr] 3 | { "same-fs" } else { "different-fs" }.to_string() ) ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/overlay.rs:166:12 [INFO] [stderr] | [INFO] [stderr] 166 | if self.lowerdirs.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.lowerdirs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/tmpfs.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | cur.write(b",").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/tmpfs.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | cur.write(b",").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/tmpfs.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | cur.write(b",").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/tmpfs.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | cur.write(b",").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tmpfs.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | format!("{}", user()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `user().to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/tmpfs.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | "size=1048576,nr_inodes=1024,mode=01777,uid=1000,gid=1000".as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"size=1048576,nr_inodes=1024,mode=01777,uid=1000,gid=1000"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/remount.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | format!("{}", user()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `user().to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mountinfo.rs:164:1 [INFO] [stderr] | [INFO] [stderr] 164 | / pub(crate) fn parse_mount_point<'a>(row: &'a [u8]) [INFO] [stderr] 165 | | -> Result>, ParseRowError> [INFO] [stderr] 166 | | { [INFO] [stderr] 167 | | let row = rstrip_cr(&row); [INFO] [stderr] ... | [INFO] [stderr] 195 | | })) [INFO] [stderr] 196 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/mountinfo.rs:226:34 [INFO] [stderr] | [INFO] [stderr] 226 | return Err(ParseRowError(format!("Expected more fields"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Expected more fields".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mountinfo.rs:232:1 [INFO] [stderr] | [INFO] [stderr] 232 | / fn parse_os_str<'a>(data: &'a [u8]) [INFO] [stderr] 233 | | -> Result<(Cow<'a, OsStr>, &'a [u8]), ParseRowError> [INFO] [stderr] 234 | | { [INFO] [stderr] 235 | | let (field, tail) = try!(parse_field(data, b" ")); [INFO] [stderr] 236 | | Ok((unescape_octals(OsStr::from_bytes(field)), tail)) [INFO] [stderr] 237 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/mountinfo.rs:263:1 [INFO] [stderr] | [INFO] [stderr] 263 | / fn parse_optional<'a>(data: &'a [u8]) [INFO] [stderr] 264 | | -> Result<(Cow<'a, OsStr>, &'a [u8]), ParseRowError> [INFO] [stderr] 265 | | { [INFO] [stderr] 266 | | let (field, tail) = try!(parse_field(data, b"- ")); [INFO] [stderr] 267 | | let field = rstrip_whitespaces(field); [INFO] [stderr] 268 | | Ok((unescape_octals(OsStr::from_bytes(field)), tail)) [INFO] [stderr] 269 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/mountinfo.rs:283:23 [INFO] [stderr] | [INFO] [stderr] 283 | return &v[..i + 1]; [INFO] [stderr] | ^^^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `libmount`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ffa5b05062c6b0dfc2af8d29b06cafdf814cffd8ca4fb81a4485f6c1c434b8bd"` [INFO] running `"docker" "rm" "-f" "ffa5b05062c6b0dfc2af8d29b06cafdf814cffd8ca4fb81a4485f6c1c434b8bd"` [INFO] [stdout] ffa5b05062c6b0dfc2af8d29b06cafdf814cffd8ca4fb81a4485f6c1c434b8bd