[INFO] crate libloadorder-ffi 11.4.1 is already in cache
[INFO] extracting crate libloadorder-ffi 11.4.1 into work/ex/clippy-test-run/sources/stable/reg/libloadorder-ffi/11.4.1
[INFO] extracting crate libloadorder-ffi 11.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libloadorder-ffi/11.4.1
[INFO] validating manifest of libloadorder-ffi-11.4.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of libloadorder-ffi-11.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing libloadorder-ffi-11.4.1
[INFO] finished frobbing libloadorder-ffi-11.4.1
[INFO] frobbed toml for libloadorder-ffi-11.4.1 written to work/ex/clippy-test-run/sources/stable/reg/libloadorder-ffi/11.4.1/Cargo.toml
[INFO] started frobbing libloadorder-ffi-11.4.1
[INFO] finished frobbing libloadorder-ffi-11.4.1
[INFO] frobbed toml for libloadorder-ffi-11.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libloadorder-ffi/11.4.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting libloadorder-ffi-11.4.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libloadorder-ffi/11.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 66e97458db62213a88ead0eea4817c198882835401857d3cea2ad64451a6d0da
[INFO] running `"docker" "start" "-a" "66e97458db62213a88ead0eea4817c198882835401857d3cea2ad64451a6d0da"`
[INFO] [stderr]    Compiling libloadorder-ffi v11.4.1 (/opt/crater/workdir)
[INFO] [stderr]     Checking esplugin v2.1.1
[INFO] [stderr]     Checking libloadorder v11.4.1
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/helpers.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 | /     match err {
[INFO] [stderr] 55 | |         &InvalidPath(_) => LIBLO_ERROR_FILE_NOT_FOUND,
[INFO] [stderr] 56 | |         &IoError(ref x) => map_io_error(x),
[INFO] [stderr] 57 | |         &NoFilename => LIBLO_ERROR_FILE_PARSE_FAIL,
[INFO] [stderr] ...  |
[INFO] [stderr] 71 | |         &NoLocalAppData => LIBLO_ERROR_INVALID_ARGS,
[INFO] [stderr] 72 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 54 |     match *err {
[INFO] [stderr] 55 |         InvalidPath(_) => LIBLO_ERROR_FILE_NOT_FOUND,
[INFO] [stderr] 56 |         IoError(ref x) => map_io_error(x),
[INFO] [stderr] 57 |         NoFilename => LIBLO_ERROR_FILE_PARSE_FAIL,
[INFO] [stderr] 58 |         SystemTimeError(_) => LIBLO_ERROR_TIMESTAMP_WRITE_FAIL,
[INFO] [stderr] 59 |         NotUtf8(_) => LIBLO_ERROR_FILE_NOT_UTF8,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/helpers.rs:94:14
[INFO] [stderr]    |
[INFO] [stderr] 94 |         .map(|s| to_c_string(s))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `to_c_string`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/helpers.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 | /     match err {
[INFO] [stderr] 55 | |         &InvalidPath(_) => LIBLO_ERROR_FILE_NOT_FOUND,
[INFO] [stderr] 56 | |         &IoError(ref x) => map_io_error(x),
[INFO] [stderr] 57 | |         &NoFilename => LIBLO_ERROR_FILE_PARSE_FAIL,
[INFO] [stderr] ...  |
[INFO] [stderr] 71 | |         &NoLocalAppData => LIBLO_ERROR_INVALID_ARGS,
[INFO] [stderr] 72 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 54 |     match *err {
[INFO] [stderr] 55 |         InvalidPath(_) => LIBLO_ERROR_FILE_NOT_FOUND,
[INFO] [stderr] 56 |         IoError(ref x) => map_io_error(x),
[INFO] [stderr] 57 |         NoFilename => LIBLO_ERROR_FILE_PARSE_FAIL,
[INFO] [stderr] 58 |         SystemTimeError(_) => LIBLO_ERROR_TIMESTAMP_WRITE_FAIL,
[INFO] [stderr] 59 |         NotUtf8(_) => LIBLO_ERROR_FILE_NOT_UTF8,
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/helpers.rs:94:14
[INFO] [stderr]    |
[INFO] [stderr] 94 |         .map(|s| to_c_string(s))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `to_c_string`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.12s
[INFO] running `"docker" "inspect" "66e97458db62213a88ead0eea4817c198882835401857d3cea2ad64451a6d0da"`
[INFO] running `"docker" "rm" "-f" "66e97458db62213a88ead0eea4817c198882835401857d3cea2ad64451a6d0da"`
[INFO] [stdout] 66e97458db62213a88ead0eea4817c198882835401857d3cea2ad64451a6d0da