[INFO] crate libloadorder 11.4.1 is already in cache [INFO] extracting crate libloadorder 11.4.1 into work/ex/clippy-test-run/sources/stable/reg/libloadorder/11.4.1 [INFO] extracting crate libloadorder 11.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libloadorder/11.4.1 [INFO] validating manifest of libloadorder-11.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libloadorder-11.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libloadorder-11.4.1 [INFO] finished frobbing libloadorder-11.4.1 [INFO] frobbed toml for libloadorder-11.4.1 written to work/ex/clippy-test-run/sources/stable/reg/libloadorder/11.4.1/Cargo.toml [INFO] started frobbing libloadorder-11.4.1 [INFO] finished frobbing libloadorder-11.4.1 [INFO] frobbed toml for libloadorder-11.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libloadorder/11.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libloadorder-11.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libloadorder/11.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7379cbc2ecbd99b39bf4a84d180179a06367b5a3652412258177051d70f671cf [INFO] running `"docker" "start" "-a" "7379cbc2ecbd99b39bf4a84d180179a06367b5a3652412258177051d70f671cf"` [INFO] [stderr] Checking esplugin v2.1.1 [INFO] [stderr] Checking criterion v0.2.9 [INFO] [stderr] Checking libloadorder v11.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `writeln!(file, "")` [INFO] [stderr] --> src/load_order/textfile_based.rs:308:9 [INFO] [stderr] | [INFO] [stderr] 308 | writeln!(file, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(file)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(file, "")` [INFO] [stderr] --> src/load_order/textfile_based.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | writeln!(file, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(file)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(file, "")` [INFO] [stderr] --> src/load_order/timestamp_based.rs:285:9 [INFO] [stderr] | [INFO] [stderr] 285 | writeln!(file, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(file)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: function is never used: `appdata_folder_name` [INFO] [stderr] --> src/game_settings.rs:171:1 [INFO] [stderr] | [INFO] [stderr] 171 | fn appdata_folder_name(game_id: &GameId) -> Option<&str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enums.rs:57:27 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn to_esplugin_id(&self) -> EspmId { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enums.rs:71:35 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn supports_light_masters(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_settings.rs:171:33 [INFO] [stderr] | [INFO] [stderr] 171 | fn appdata_folder_name(game_id: &GameId) -> Option<&str> { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `GameId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_settings.rs:186:29 [INFO] [stderr] | [INFO] [stderr] 186 | fn load_order_path(game_id: &GameId, local_path: &Path) -> Option { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `GameId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_settings.rs:193:31 [INFO] [stderr] | [INFO] [stderr] 193 | fn plugins_file_path(game_id: &GameId, game_path: &Path, local_path: &Path) -> PathBuf { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `GameId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/load_order/readable.rs:240:10 [INFO] [stderr] | [INFO] [stderr] 240 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/plugin.rs:180:14 [INFO] [stderr] | [INFO] [stderr] 180 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/plugin.rs:182:36 [INFO] [stderr] | [INFO] [stderr] 182 | .zip(suffix.as_bytes().into_iter().rev()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(file, "")` [INFO] [stderr] --> src/load_order/tests.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | writeln!(file, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(file)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(file, "")` [INFO] [stderr] --> src/load_order/textfile_based.rs:308:9 [INFO] [stderr] | [INFO] [stderr] 308 | writeln!(file, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(file)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(file, "")` [INFO] [stderr] --> src/load_order/textfile_based.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | writeln!(file, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(file)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(file, "")` [INFO] [stderr] --> src/load_order/timestamp_based.rs:285:9 [INFO] [stderr] | [INFO] [stderr] 285 | writeln!(file, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(file)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(file, "")` [INFO] [stderr] --> benches/load_order.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | writeln!(file, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(file)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enums.rs:57:27 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn to_esplugin_id(&self) -> EspmId { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enums.rs:71:35 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn supports_light_masters(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_settings.rs:171:33 [INFO] [stderr] | [INFO] [stderr] 171 | fn appdata_folder_name(game_id: &GameId) -> Option<&str> { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `GameId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_settings.rs:186:29 [INFO] [stderr] | [INFO] [stderr] 186 | fn load_order_path(game_id: &GameId, local_path: &Path) -> Option { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `GameId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_settings.rs:193:31 [INFO] [stderr] | [INFO] [stderr] 193 | fn plugins_file_path(game_id: &GameId, game_path: &Path, local_path: &Path) -> PathBuf { [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `GameId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/load_order/readable.rs:240:10 [INFO] [stderr] | [INFO] [stderr] 240 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/load_order/textfile_based.rs:461:29 [INFO] [stderr] | [INFO] [stderr] 461 | .encode(filename.as_ref(), EncoderTrap::Strict) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/plugin.rs:180:14 [INFO] [stderr] | [INFO] [stderr] 180 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/plugin.rs:182:36 [INFO] [stderr] | [INFO] [stderr] 182 | .zip(suffix.as_bytes().into_iter().rev()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.23s [INFO] running `"docker" "inspect" "7379cbc2ecbd99b39bf4a84d180179a06367b5a3652412258177051d70f671cf"` [INFO] running `"docker" "rm" "-f" "7379cbc2ecbd99b39bf4a84d180179a06367b5a3652412258177051d70f671cf"` [INFO] [stdout] 7379cbc2ecbd99b39bf4a84d180179a06367b5a3652412258177051d70f671cf