[INFO] crate libloading 0.5.0 is already in cache [INFO] extracting crate libloading 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/libloading/0.5.0 [INFO] extracting crate libloading 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libloading/0.5.0 [INFO] validating manifest of libloading-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libloading-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libloading-0.5.0 [INFO] finished frobbing libloading-0.5.0 [INFO] frobbed toml for libloading-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/libloading/0.5.0/Cargo.toml [INFO] started frobbing libloading-0.5.0 [INFO] finished frobbing libloading-0.5.0 [INFO] frobbed toml for libloading-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libloading/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libloading-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libloading/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bf57507847e435bee9e2cf9d9f8e4d099498f18066c0cd30a0a260ba184ad151 [INFO] running `"docker" "start" "-a" "bf57507847e435bee9e2cf9d9f8e4d099498f18066c0cd30a0a260ba184ad151"` [INFO] [stderr] Compiling libloading v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/os/unix/mod.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | mem::transmute(&self.pointer) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.pointer as *const *mut std::ffi::c_void as *const T)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/util.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn cstr_cow_from_bytes<'a>(slice: &'a [u8]) -> Result, NullError> { [INFO] [stderr] 40 | | static ZERO: raw::c_char = 0; [INFO] [stderr] 41 | | Ok(match slice.last() { [INFO] [stderr] 42 | | // Slice out of 0 elements [INFO] [stderr] ... | [INFO] [stderr] 48 | | }) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/os/unix/mod.rs:252:13 [INFO] [stderr] | [INFO] [stderr] 252 | mem::transmute(&self.pointer) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.pointer as *const *mut std::ffi::c_void as *const T)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/util.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn cstr_cow_from_bytes<'a>(slice: &'a [u8]) -> Result, NullError> { [INFO] [stderr] 40 | | static ZERO: raw::c_char = 0; [INFO] [stderr] 41 | | Ok(match slice.last() { [INFO] [stderr] 42 | | // Slice out of 0 elements [INFO] [stderr] ... | [INFO] [stderr] 48 | | }) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/functions.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | const LIBPATH: &'static str = concat!(env!("OUT_DIR"), "/libtest_helpers.dll"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/functions.rs:10:62 [INFO] [stderr] | [INFO] [stderr] 10 | let rustc = option_env!("RUSTC").unwrap_or_else(|| { "rustc".into() }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider removing `.into()`: `"rustc"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.67s [INFO] running `"docker" "inspect" "bf57507847e435bee9e2cf9d9f8e4d099498f18066c0cd30a0a260ba184ad151"` [INFO] running `"docker" "rm" "-f" "bf57507847e435bee9e2cf9d9f8e4d099498f18066c0cd30a0a260ba184ad151"` [INFO] [stdout] bf57507847e435bee9e2cf9d9f8e4d099498f18066c0cd30a0a260ba184ad151