[INFO] crate liblightning 0.0.2 is already in cache [INFO] extracting crate liblightning 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/liblightning/0.0.2 [INFO] extracting crate liblightning 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/liblightning/0.0.2 [INFO] validating manifest of liblightning-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of liblightning-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing liblightning-0.0.2 [INFO] finished frobbing liblightning-0.0.2 [INFO] frobbed toml for liblightning-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/liblightning/0.0.2/Cargo.toml [INFO] started frobbing liblightning-0.0.2 [INFO] finished frobbing liblightning-0.0.2 [INFO] frobbed toml for liblightning-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/liblightning/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting liblightning-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/liblightning/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a0c2c05fa9d2e9c310f4457c9f00015bffb49a34716b1ab17ec776317658d85c [INFO] running `"docker" "start" "-a" "a0c2c05fa9d2e9c310f4457c9f00015bffb49a34716b1ab17ec776317658d85c"` [INFO] [stderr] Compiling liblightning v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/co.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | inner: inner [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/co.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | rsp: rsp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rsp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stack.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | mem: mem [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stack_pool.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | config: config [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/promise.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | co: co [INFO] [stderr] | ^^^^^^ help: replace it with: `co` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/co.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | inner: inner [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/co.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | rsp: rsp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rsp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stack.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | mem: mem [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stack_pool.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | config: config [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/promise.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | co: co [INFO] [stderr] | ^^^^^^ help: replace it with: `co` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `resume_unwind` [INFO] [stderr] --> src/scheduler.rs:3:50 [INFO] [stderr] | [INFO] [stderr] 3 | use std::panic::{catch_unwind, AssertUnwindSafe, resume_unwind}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `invoke_box::OnceInvokeBox` [INFO] [stderr] --> src/scheduler.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use invoke_box::OnceInvokeBox; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/co.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | (&mut mem[0] as *mut u8).offset(mem.len() as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(&mut mem[0] as *mut u8).add(mem.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/scheduler.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | let value: Rc>>>> = Rc::new(Cell::new(None)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/scheduler.rs:161:20 [INFO] [stderr] | [INFO] [stderr] 161 | if let Err(_) = catch_unwind(AssertUnwindSafe(|| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 161 | if catch_unwind(AssertUnwindSafe(|| { [INFO] [stderr] 162 | let ps = { [INFO] [stderr] 163 | let ret = co.resume(); [INFO] [stderr] 164 | [INFO] [stderr] 165 | // Promise. [INFO] [stderr] 166 | if let Some(p) = ret { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/scheduler.rs:270:20 [INFO] [stderr] | [INFO] [stderr] 270 | if let Err(_) = catch_unwind(AssertUnwindSafe(|| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 270 | if catch_unwind(AssertUnwindSafe(|| { [INFO] [stderr] 271 | let ps = { [INFO] [stderr] 272 | let ret = co.resume(); [INFO] [stderr] 273 | [INFO] [stderr] 274 | // Promise. [INFO] [stderr] 275 | if let Some(p) = ret { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `resume_unwind` [INFO] [stderr] --> src/scheduler.rs:3:50 [INFO] [stderr] | [INFO] [stderr] 3 | use std::panic::{catch_unwind, AssertUnwindSafe, resume_unwind}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `invoke_box::OnceInvokeBox` [INFO] [stderr] --> src/scheduler.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use invoke_box::OnceInvokeBox; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/co.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | (&mut mem[0] as *mut u8).offset(mem.len() as isize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(&mut mem[0] as *mut u8).add(mem.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/co.rs:259:16 [INFO] [stderr] | [INFO] [stderr] 259 | if let Ok(_) = catch_unwind(AssertUnwindSafe(|| { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 259 | if catch_unwind(AssertUnwindSafe(|| { [INFO] [stderr] 260 | co.take_stack(); [INFO] [stderr] 261 | })).is_ok() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/scheduler.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | let value: Rc>>>> = Rc::new(Cell::new(None)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/scheduler.rs:161:20 [INFO] [stderr] | [INFO] [stderr] 161 | if let Err(_) = catch_unwind(AssertUnwindSafe(|| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 161 | if catch_unwind(AssertUnwindSafe(|| { [INFO] [stderr] 162 | let ps = { [INFO] [stderr] 163 | let ret = co.resume(); [INFO] [stderr] 164 | [INFO] [stderr] 165 | // Promise. [INFO] [stderr] 166 | if let Some(p) = ret { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/scheduler.rs:270:20 [INFO] [stderr] | [INFO] [stderr] 270 | if let Err(_) = catch_unwind(AssertUnwindSafe(|| { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 270 | if catch_unwind(AssertUnwindSafe(|| { [INFO] [stderr] 271 | let ps = { [INFO] [stderr] 272 | let ret = co.resume(); [INFO] [stderr] 273 | [INFO] [stderr] 274 | // Promise. [INFO] [stderr] 275 | if let Some(p) = ret { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::mpsc` [INFO] [stderr] --> examples/sleep.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::sync::mpsc; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/simple.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `liblightning`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a0c2c05fa9d2e9c310f4457c9f00015bffb49a34716b1ab17ec776317658d85c"` [INFO] running `"docker" "rm" "-f" "a0c2c05fa9d2e9c310f4457c9f00015bffb49a34716b1ab17ec776317658d85c"` [INFO] [stdout] a0c2c05fa9d2e9c310f4457c9f00015bffb49a34716b1ab17ec776317658d85c