[INFO] crate libimagtodo 0.9.0 is already in cache [INFO] extracting crate libimagtodo 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/libimagtodo/0.9.0 [INFO] extracting crate libimagtodo 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagtodo/0.9.0 [INFO] validating manifest of libimagtodo-0.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libimagtodo-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libimagtodo-0.9.0 [INFO] finished frobbing libimagtodo-0.9.0 [INFO] frobbed toml for libimagtodo-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/libimagtodo/0.9.0/Cargo.toml [INFO] started frobbing libimagtodo-0.9.0 [INFO] finished frobbing libimagtodo-0.9.0 [INFO] frobbed toml for libimagtodo-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagtodo/0.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libimagtodo-0.9.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libimagtodo/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f0d5b0f81ae1fc1632d9ec8ba2e497d824882ac68e73aa2e7d8b7139e56ed3ca [INFO] running `"docker" "start" "-a" "f0d5b0f81ae1fc1632d9ec8ba2e497d824882ac68e73aa2e7d8b7139e56ed3ca"` [INFO] [stderr] Checking is-match v0.1.0 [INFO] [stderr] Checking uuid v0.7.2 [INFO] [stderr] Checking libimagutil v0.9.0 [INFO] [stderr] Checking libimagerror v0.9.0 [INFO] [stderr] Checking toml-query v0.8.0 [INFO] [stderr] Checking task-hookrs v0.6.0 [INFO] [stderr] Checking libimagstore v0.9.0 [INFO] [stderr] Checking libimagtodo v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/taskstore.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | let val = serde_to_string(&ttask).context(err_msg("Import error"))?; [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/taskstore.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | let val = serde_to_string(&ttask).context(err_msg("Import error"))?; [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/taskstore.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | let uuid = t.uuid().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*t.uuid()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/taskstore.rs:92:22 [INFO] [stderr] | [INFO] [stderr] 92 | .map(|t| t.uuid().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*t.uuid()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/taskstore.rs:150:21 [INFO] [stderr] | [INFO] [stderr] 150 | let _ = self.delete_task_by_uuid(*ttask.uuid())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/taskstore.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | let uuid = t.uuid().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*t.uuid()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/taskstore.rs:92:22 [INFO] [stderr] | [INFO] [stderr] 92 | .map(|t| t.uuid().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*t.uuid()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/taskstore.rs:150:21 [INFO] [stderr] | [INFO] [stderr] 150 | let _ = self.delete_task_by_uuid(*ttask.uuid())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.77s [INFO] running `"docker" "inspect" "f0d5b0f81ae1fc1632d9ec8ba2e497d824882ac68e73aa2e7d8b7139e56ed3ca"` [INFO] running `"docker" "rm" "-f" "f0d5b0f81ae1fc1632d9ec8ba2e497d824882ac68e73aa2e7d8b7139e56ed3ca"` [INFO] [stdout] f0d5b0f81ae1fc1632d9ec8ba2e497d824882ac68e73aa2e7d8b7139e56ed3ca