[INFO] crate libimagtimetrack 0.9.0 is already in cache [INFO] extracting crate libimagtimetrack 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/libimagtimetrack/0.9.0 [INFO] extracting crate libimagtimetrack 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagtimetrack/0.9.0 [INFO] validating manifest of libimagtimetrack-0.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libimagtimetrack-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libimagtimetrack-0.9.0 [INFO] finished frobbing libimagtimetrack-0.9.0 [INFO] frobbed toml for libimagtimetrack-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/libimagtimetrack/0.9.0/Cargo.toml [INFO] started frobbing libimagtimetrack-0.9.0 [INFO] finished frobbing libimagtimetrack-0.9.0 [INFO] frobbed toml for libimagtimetrack-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagtimetrack/0.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libimagtimetrack-0.9.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libimagtimetrack/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9fd5c8a17efceb705c077f1c0947c8a86a0ed74b798ee4b2b0b9c6025a8cc73e [INFO] running `"docker" "start" "-a" "9fd5c8a17efceb705c077f1c0947c8a86a0ed74b798ee4b2b0b9c6025a8cc73e"` [INFO] [stderr] Checking boolinator v2.4.0 [INFO] [stderr] Checking filters v0.3.0 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking libimagerror v0.9.0 [INFO] [stderr] Checking toml-query v0.8.0 [INFO] [stderr] Checking libimagutil v0.9.0 [INFO] [stderr] Checking libimagstore v0.9.0 [INFO] [stderr] Checking libimagentrydatetime v0.9.0 [INFO] [stderr] Checking libimagentrytag v0.9.0 [INFO] [stderr] Checking libimagtimetrack v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/create.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/create.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | store: store, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `store` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/create.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter/create.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | store: store, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `store` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | pub const CRATE_NAME : &'static str = "timetrack"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:21:31 [INFO] [stderr] | [INFO] [stderr] 21 | pub const DATE_TIME_FORMAT : &'static str = "%Y-%m-%dT%H:%M:%S"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:22:42 [INFO] [stderr] | [INFO] [stderr] 22 | pub const DATE_TIME_START_HEADER_PATH : &'static str = "timetrack.start"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:23:40 [INFO] [stderr] | [INFO] [stderr] 23 | pub const DATE_TIME_END_HEADER_PATH : &'static str = "timetrack.end"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:24:40 [INFO] [stderr] | [INFO] [stderr] 24 | pub const DATE_TIME_TAG_HEADER_PATH : &'static str = "timetrack.tag"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | pub const CRATE_NAME : &'static str = "timetrack"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:21:31 [INFO] [stderr] | [INFO] [stderr] 21 | pub const DATE_TIME_FORMAT : &'static str = "%Y-%m-%dT%H:%M:%S"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:22:42 [INFO] [stderr] | [INFO] [stderr] 22 | pub const DATE_TIME_START_HEADER_PATH : &'static str = "timetrack.start"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:23:40 [INFO] [stderr] | [INFO] [stderr] 23 | pub const DATE_TIME_END_HEADER_PATH : &'static str = "timetrack.end"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/constants.rs:24:40 [INFO] [stderr] | [INFO] [stderr] 24 | pub const DATE_TIME_TAG_HEADER_PATH : &'static str = "timetrack.tag"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/iter/filter.rs:52:34 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn has_one_of_tags<'a>(tags: &'a Vec) -> HasOneOfTags<'a> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[TTT]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/iter/filter.rs:106:26 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn new(tags: &'a Vec) -> HasOneOfTags<'a> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[TTT]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/iter/storeid.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn create_entries<'a>(self, store: &'a Store) -> CreateTimeTrackIter<'a> { [INFO] [stderr] 43 | | CreateTimeTrackIter::new(self, store) [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/iter/storeid.rs:63:36 [INFO] [stderr] | [INFO] [stderr] 63 | .map(|id| (id, self.datetime.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.datetime` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/iter/tag.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | Err(Error::from(err_msg("Error in Tag format"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `err_msg("Error in Tag format")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/iter/filter.rs:52:34 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn has_one_of_tags<'a>(tags: &'a Vec) -> HasOneOfTags<'a> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[TTT]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/iter/filter.rs:106:26 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn new(tags: &'a Vec) -> HasOneOfTags<'a> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[TTT]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/iter/storeid.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn create_entries<'a>(self, store: &'a Store) -> CreateTimeTrackIter<'a> { [INFO] [stderr] 43 | | CreateTimeTrackIter::new(self, store) [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/iter/storeid.rs:63:36 [INFO] [stderr] | [INFO] [stderr] 63 | .map(|id| (id, self.datetime.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.datetime` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/iter/tag.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | Err(Error::from(err_msg("Error in Tag format"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `err_msg("Error in Tag format")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.89s [INFO] running `"docker" "inspect" "9fd5c8a17efceb705c077f1c0947c8a86a0ed74b798ee4b2b0b9c6025a8cc73e"` [INFO] running `"docker" "rm" "-f" "9fd5c8a17efceb705c077f1c0947c8a86a0ed74b798ee4b2b0b9c6025a8cc73e"` [INFO] [stdout] 9fd5c8a17efceb705c077f1c0947c8a86a0ed74b798ee4b2b0b9c6025a8cc73e