[INFO] crate libimagstore 0.9.0 is already in cache
[INFO] extracting crate libimagstore 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/libimagstore/0.9.0
[INFO] extracting crate libimagstore 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagstore/0.9.0
[INFO] validating manifest of libimagstore-0.9.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of libimagstore-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing libimagstore-0.9.0
[INFO] finished frobbing libimagstore-0.9.0
[INFO] frobbed toml for libimagstore-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/libimagstore/0.9.0/Cargo.toml
[INFO] started frobbing libimagstore-0.9.0
[INFO] finished frobbing libimagstore-0.9.0
[INFO] frobbed toml for libimagstore-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagstore/0.9.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting libimagstore-0.9.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libimagstore/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] be58e8095dae762c3bc294dc6483a2a995e248ddfcda03c3575db5d4f761cf3e
[INFO] running `"docker" "start" "-a" "be58e8095dae762c3bc294dc6483a2a995e248ddfcda03c3575db5d4f761cf3e"`
[INFO] [stderr]     Checking boolinator v2.4.0
[INFO] [stderr]     Checking toml-query v0.8.0
[INFO] [stderr]     Checking libimagerror v0.9.0
[INFO] [stderr]     Checking libimagutil v0.9.0
[INFO] [stderr]     Checking libimagstore v0.9.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/store.rs:203:13
[INFO] [stderr]     |
[INFO] [stderr] 203 |             backend: backend,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `backend`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/store.rs:203:13
[INFO] [stderr]     |
[INFO] [stderr] 203 |             backend: backend,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `backend`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/file_abstraction/fs.rs:192:47
[INFO] [stderr]     |
[INFO] [stderr] 192 |             ::std::io::ErrorKind::NotFound => return Ok(None),
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/file_abstraction/fs.rs:193:18
[INFO] [stderr]     |
[INFO] [stderr] 193 |             _ => return Err(e),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/file_abstraction/inmemory.rs:87:17
[INFO] [stderr]    |
[INFO] [stderr] 87 |                 return Ok(());
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/util.rs:58:13
[INFO] [stderr]    |
[INFO] [stderr] 58 |             let _ = writeln!(header, "{}", line).context(EM::FormatError)?;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/util.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 |             let _ = writeln!(content, "{}", line).context(EM::FormatError)?;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/util.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 |             let _ = write!(content, "{}", line).context(EM::FormatError)?;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly
[INFO] [stderr]   --> src/storeid.rs:46:24
[INFO] [stderr]    |
[INFO] [stderr] 46 | #[derive(Debug, Clone, Hash, Eq, PartialOrd, Ord)]
[INFO] [stderr]    |                        ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::derive_hash_xor_eq)] on by default
[INFO] [stderr] note: `PartialEq` implemented here
[INFO] [stderr]   --> src/storeid.rs:52:1
[INFO] [stderr]    |
[INFO] [stderr] 52 | / impl PartialEq for StoreId {
[INFO] [stderr] 53 | |     fn eq(&self, other: &StoreId) -> bool {
[INFO] [stderr] 54 | |         self.id == other.id
[INFO] [stderr] 55 | |     }
[INFO] [stderr] 56 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/storeid.rs:286:5
[INFO] [stderr]     |
[INFO] [stderr] 286 | /     pub fn with_store<'a>(self, store: &'a Store) -> StoreIdIteratorWithStore<'a> {
[INFO] [stderr] 287 | |         StoreIdIteratorWithStore(self, store)
[INFO] [stderr] 288 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/store.rs:497:9
[INFO] [stderr]     |
[INFO] [stderr] 497 | /         let _ = self
[INFO] [stderr] 498 | |             .backend
[INFO] [stderr] 499 | |             .remove_file(&pb)
[INFO] [stderr] 500 | |             .context(EM::FileError)
[INFO] [stderr] 501 | |             .context(format_err!("DeleteCallError: {}", id))?;
[INFO] [stderr]     | |______________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/store.rs:618:13
[INFO] [stderr]     |
[INFO] [stderr] 618 | /             let _ = self
[INFO] [stderr] 619 | |                 .backend
[INFO] [stderr] 620 | |                 .rename(&old_id_pb, &new_id_pb)
[INFO] [stderr] 621 | |                 .context({
[INFO] [stderr] ...   |
[INFO] [stderr] 624 | |                     format_err!("Rename error: {} -> {}", old, new)
[INFO] [stderr] 625 | |                 })?;
[INFO] [stderr]     | |____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]    --> src/store.rs:633:43
[INFO] [stderr]     |
[INFO] [stderr] 633 |                       .and_then(|mut entry| {
[INFO] [stderr]     |  ___________________________________________^
[INFO] [stderr] 634 | |                         entry.id = new_id.clone();
[INFO] [stderr] 635 | |                         hsmap.insert(new_id.clone(), entry)
[INFO] [stderr] 636 | |                     }).is_none())
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/file_abstraction/fs.rs:111:17
[INFO] [stderr]     |
[INFO] [stderr] 111 |                 let _ = create_dir_all(&p).context(EM::DirNotCreated)?;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/file_abstraction/fs.rs:204:13
[INFO] [stderr]     |
[INFO] [stderr] 204 |             let _ = create_dir_all(parent)?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/file_abstraction/inmemory.rs:104:5
[INFO] [stderr]     |
[INFO] [stderr] 104 | /     fn backend_cloned<'a>(&'a self) -> Result<HashMap<PathBuf, Entry>> {
[INFO] [stderr] 105 | |         self.virtual_filesystem
[INFO] [stderr] 106 | |             .lock()
[INFO] [stderr] 107 | |             .map_err(|_| Error::from(EM::LockError))
[INFO] [stderr] 108 | |             .map(|mtx| mtx.deref().borrow().clone())
[INFO] [stderr] 109 | |             .into()
[INFO] [stderr] 110 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/file_abstraction/inmemory.rs:105:9
[INFO] [stderr]     |
[INFO] [stderr] 105 | /         self.virtual_filesystem
[INFO] [stderr] 106 | |             .lock()
[INFO] [stderr] 107 | |             .map_err(|_| Error::from(EM::LockError))
[INFO] [stderr] 108 | |             .map(|mtx| mtx.deref().borrow().clone())
[INFO] [stderr] 109 | |             .into()
[INFO] [stderr]     | |___________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into()`
[INFO] [stderr]     |
[INFO] [stderr] 105 |         self.virtual_filesystem
[INFO] [stderr] 106 |             .lock()
[INFO] [stderr] 107 |             .map_err(|_| Error::from(EM::LockError))
[INFO] [stderr] 108 |             .map(|mtx| mtx.deref().borrow().clone())
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/file_abstraction/inmemory.rs:175:5
[INFO] [stderr]     |
[INFO] [stderr] 175 | /     fn fill<'a>(&'a mut self, mut d: Drain) -> Result<()> {
[INFO] [stderr] 176 | |         debug!("Draining into : {:?}", self);
[INFO] [stderr] 177 | |         let mut mtx = self.backend()
[INFO] [stderr] 178 | |             .lock()
[INFO] [stderr] ...   |
[INFO] [stderr] 187 | |         Ok(())
[INFO] [stderr] 188 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/file_abstraction/mod.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     fn fill<'a>(&'a mut self, d: Drain) -> Result<()>;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/file_abstraction/mod.rs:81:5
[INFO] [stderr]    |
[INFO] [stderr] 81 | /     pub fn iter<'a>(&'a mut self) -> DrainIter<'a> {
[INFO] [stderr] 82 | |         DrainIter(self.0.drain())
[INFO] [stderr] 83 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `libimagstore`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/file_abstraction/fs.rs:192:47
[INFO] [stderr]     |
[INFO] [stderr] 192 |             ::std::io::ErrorKind::NotFound => return Ok(None),
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/file_abstraction/fs.rs:193:18
[INFO] [stderr]     |
[INFO] [stderr] 193 |             _ => return Err(e),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/file_abstraction/inmemory.rs:87:17
[INFO] [stderr]    |
[INFO] [stderr] 87 |                 return Ok(());
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/util.rs:58:13
[INFO] [stderr]    |
[INFO] [stderr] 58 |             let _ = writeln!(header, "{}", line).context(EM::FormatError)?;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/util.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 |             let _ = writeln!(content, "{}", line).context(EM::FormatError)?;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/util.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 |             let _ = write!(content, "{}", line).context(EM::FormatError)?;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly
[INFO] [stderr]   --> src/storeid.rs:46:24
[INFO] [stderr]    |
[INFO] [stderr] 46 | #[derive(Debug, Clone, Hash, Eq, PartialOrd, Ord)]
[INFO] [stderr]    |                        ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::derive_hash_xor_eq)] on by default
[INFO] [stderr] note: `PartialEq` implemented here
[INFO] [stderr]   --> src/storeid.rs:52:1
[INFO] [stderr]    |
[INFO] [stderr] 52 | / impl PartialEq for StoreId {
[INFO] [stderr] 53 | |     fn eq(&self, other: &StoreId) -> bool {
[INFO] [stderr] 54 | |         self.id == other.id
[INFO] [stderr] 55 | |     }
[INFO] [stderr] 56 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/storeid.rs:286:5
[INFO] [stderr]     |
[INFO] [stderr] 286 | /     pub fn with_store<'a>(self, store: &'a Store) -> StoreIdIteratorWithStore<'a> {
[INFO] [stderr] 287 | |         StoreIdIteratorWithStore(self, store)
[INFO] [stderr] 288 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/store.rs:497:9
[INFO] [stderr]     |
[INFO] [stderr] 497 | /         let _ = self
[INFO] [stderr] 498 | |             .backend
[INFO] [stderr] 499 | |             .remove_file(&pb)
[INFO] [stderr] 500 | |             .context(EM::FileError)
[INFO] [stderr] 501 | |             .context(format_err!("DeleteCallError: {}", id))?;
[INFO] [stderr]     | |______________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/store.rs:618:13
[INFO] [stderr]     |
[INFO] [stderr] 618 | /             let _ = self
[INFO] [stderr] 619 | |                 .backend
[INFO] [stderr] 620 | |                 .rename(&old_id_pb, &new_id_pb)
[INFO] [stderr] 621 | |                 .context({
[INFO] [stderr] ...   |
[INFO] [stderr] 624 | |                     format_err!("Rename error: {} -> {}", old, new)
[INFO] [stderr] 625 | |                 })?;
[INFO] [stderr]     | |____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]    --> src/store.rs:633:43
[INFO] [stderr]     |
[INFO] [stderr] 633 |                       .and_then(|mut entry| {
[INFO] [stderr]     |  ___________________________________________^
[INFO] [stderr] 634 | |                         entry.id = new_id.clone();
[INFO] [stderr] 635 | |                         hsmap.insert(new_id.clone(), entry)
[INFO] [stderr] 636 | |                     }).is_none())
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]     --> src/store.rs:1122:13
[INFO] [stderr]      |
[INFO] [stderr] 1122 | /             store.create(PathBuf::from(s.clone()))
[INFO] [stderr] 1123 | |                 .ok()
[INFO] [stderr] 1124 | |                 .map(|entry| {
[INFO] [stderr] 1125 | |                     assert!(entry.verify().is_ok());
[INFO] [stderr] ...    |
[INFO] [stderr] 1128 | |                     assert!(loc.ends_with(s));
[INFO] [stderr] 1129 | |                 });
[INFO] [stderr]      | |__________________^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] help: try this
[INFO] [stderr]      |
[INFO] [stderr] 1122 |             if let Some(entry) = store.create(PathBuf::from(s.clone()))
[INFO] [stderr] 1123 |                 .ok() { ... }
[INFO] [stderr]      |
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]     --> src/store.rs:1217:39
[INFO] [stderr]      |
[INFO] [stderr] 1217 |                 assert!(r.map_err(|e| debug!("ERROR: {:?}", e)).is_ok());
[INFO] [stderr]      |                                       ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr]      = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/file_abstraction/fs.rs:111:17
[INFO] [stderr]     |
[INFO] [stderr] 111 |                 let _ = create_dir_all(&p).context(EM::DirNotCreated)?;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/file_abstraction/fs.rs:204:13
[INFO] [stderr]     |
[INFO] [stderr] 204 |             let _ = create_dir_all(parent)?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/file_abstraction/inmemory.rs:104:5
[INFO] [stderr]     |
[INFO] [stderr] 104 | /     fn backend_cloned<'a>(&'a self) -> Result<HashMap<PathBuf, Entry>> {
[INFO] [stderr] 105 | |         self.virtual_filesystem
[INFO] [stderr] 106 | |             .lock()
[INFO] [stderr] 107 | |             .map_err(|_| Error::from(EM::LockError))
[INFO] [stderr] 108 | |             .map(|mtx| mtx.deref().borrow().clone())
[INFO] [stderr] 109 | |             .into()
[INFO] [stderr] 110 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/file_abstraction/inmemory.rs:105:9
[INFO] [stderr]     |
[INFO] [stderr] 105 | /         self.virtual_filesystem
[INFO] [stderr] 106 | |             .lock()
[INFO] [stderr] 107 | |             .map_err(|_| Error::from(EM::LockError))
[INFO] [stderr] 108 | |             .map(|mtx| mtx.deref().borrow().clone())
[INFO] [stderr] 109 | |             .into()
[INFO] [stderr]     | |___________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into()`
[INFO] [stderr]     |
[INFO] [stderr] 105 |         self.virtual_filesystem
[INFO] [stderr] 106 |             .lock()
[INFO] [stderr] 107 |             .map_err(|_| Error::from(EM::LockError))
[INFO] [stderr] 108 |             .map(|mtx| mtx.deref().borrow().clone())
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/file_abstraction/inmemory.rs:175:5
[INFO] [stderr]     |
[INFO] [stderr] 175 | /     fn fill<'a>(&'a mut self, mut d: Drain) -> Result<()> {
[INFO] [stderr] 176 | |         debug!("Draining into : {:?}", self);
[INFO] [stderr] 177 | |         let mut mtx = self.backend()
[INFO] [stderr] 178 | |             .lock()
[INFO] [stderr] ...   |
[INFO] [stderr] 187 | |         Ok(())
[INFO] [stderr] 188 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/file_abstraction/mod.rs:53:5
[INFO] [stderr]    |
[INFO] [stderr] 53 |     fn fill<'a>(&'a mut self, d: Drain) -> Result<()>;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/file_abstraction/mod.rs:81:5
[INFO] [stderr]    |
[INFO] [stderr] 81 | /     pub fn iter<'a>(&'a mut self) -> DrainIter<'a> {
[INFO] [stderr] 82 | |         DrainIter(self.0.drain())
[INFO] [stderr] 83 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `libimagstore`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "be58e8095dae762c3bc294dc6483a2a995e248ddfcda03c3575db5d4f761cf3e"`
[INFO] running `"docker" "rm" "-f" "be58e8095dae762c3bc294dc6483a2a995e248ddfcda03c3575db5d4f761cf3e"`
[INFO] [stdout] be58e8095dae762c3bc294dc6483a2a995e248ddfcda03c3575db5d4f761cf3e