[INFO] crate libimaginteraction 0.9.0 is already in cache [INFO] extracting crate libimaginteraction 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/libimaginteraction/0.9.0 [INFO] extracting crate libimaginteraction 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimaginteraction/0.9.0 [INFO] validating manifest of libimaginteraction-0.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libimaginteraction-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libimaginteraction-0.9.0 [INFO] finished frobbing libimaginteraction-0.9.0 [INFO] frobbed toml for libimaginteraction-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/libimaginteraction/0.9.0/Cargo.toml [INFO] started frobbing libimaginteraction-0.9.0 [INFO] finished frobbing libimaginteraction-0.9.0 [INFO] frobbed toml for libimaginteraction-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimaginteraction/0.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libimaginteraction-0.9.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libimaginteraction/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1c919fd79771c05521cca2bd87e292c35545c78003b4a381717505cc6ffdf648 [INFO] running `"docker" "start" "-a" "1c919fd79771c05521cca2bd87e292c35545c78003b4a381717505cc6ffdf648"` [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking interactor v0.1.1 [INFO] [stderr] Compiling pest_generator v2.1.0 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking handlebars v1.1.0 [INFO] [stderr] Checking libimaginteraction v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/ask.rs:108:1 [INFO] [stderr] | [INFO] [stderr] 108 | / pub fn ask_string(s: &str, [INFO] [stderr] 109 | | default: Option, [INFO] [stderr] 110 | | permit_empty: bool, [INFO] [stderr] 111 | | permit_multiline: bool, [INFO] [stderr] ... | [INFO] [stderr] 125 | | output) [INFO] [stderr] 126 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/ask.rs:128:1 [INFO] [stderr] | [INFO] [stderr] 128 | / fn ask_string_(s: &str, [INFO] [stderr] 129 | | default: Option, [INFO] [stderr] 130 | | permit_empty: bool, [INFO] [stderr] 131 | | permit_multiline: bool, [INFO] [stderr] ... | [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/ask.rs:182:12 [INFO] [stderr] | [INFO] [stderr] 182 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 183 | | writeln!(output, "[imag]: {}?", Yellow.paint(question)).map_err(Error::from) [INFO] [stderr] 184 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/ask.rs:180:11 [INFO] [stderr] | [INFO] [stderr] 180 | if nl { [INFO] [stderr] | ___________^ [INFO] [stderr] 181 | | writeln!(output, "[imag]: {}?", Yellow.paint(question)).map_err(Error::from) [INFO] [stderr] 182 | | } else { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/ask.rs:221:17 [INFO] [stderr] | [INFO] [stderr] 221 | assert!(false == ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/ask.rs:231:17 [INFO] [stderr] | [INFO] [stderr] 231 | assert!(false == ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/ask.rs:241:17 [INFO] [stderr] | [INFO] [stderr] 241 | assert!(false == ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/ask.rs:251:17 [INFO] [stderr] | [INFO] [stderr] 251 | assert!(false == ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/ask.rs:261:17 [INFO] [stderr] | [INFO] [stderr] 261 | assert!(true == ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/ask.rs:271:17 [INFO] [stderr] | [INFO] [stderr] 271 | assert!(true == ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/ask.rs:281:17 [INFO] [stderr] | [INFO] [stderr] 281 | assert!(false == ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/ask.rs:291:17 [INFO] [stderr] | [INFO] [stderr] 291 | assert!(true == ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/ask.rs:301:17 [INFO] [stderr] | [INFO] [stderr] 301 | assert!(false == ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/ask.rs:311:17 [INFO] [stderr] | [INFO] [stderr] 311 | assert!(true == ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `ask_bool_(question, default, &mut BufReader::new(answers.as_bytes()), &mut sink).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format.rs:100:24 [INFO] [stderr] | [INFO] [stderr] 100 | let p = h.param(0).ok_or(RenderError::new("Too few arguments"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Too few arguments"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format.rs:111:32 [INFO] [stderr] | [INFO] [stderr] 111 | let p = h.param(0).ok_or(RenderError::new("Too few arguments"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Too few arguments"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format.rs:123:32 [INFO] [stderr] | [INFO] [stderr] 123 | let p = h.param(0).ok_or(RenderError::new("Too few arguments"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Too few arguments"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format.rs:135:32 [INFO] [stderr] | [INFO] [stderr] 135 | let p = h.param(0).ok_or(RenderError::new("Too few arguments"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Too few arguments"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format.rs:147:32 [INFO] [stderr] | [INFO] [stderr] 147 | let p = h.param(0).ok_or(RenderError::new("Too few arguments"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Too few arguments"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/format.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | / match h.param(idx).ok_or(RenderError::new("Too few arguments"))?.value() { [INFO] [stderr] 156 | | &Value::Number(ref num) => num.as_u64().ok_or_else(|| RenderError::new("Number cannot be parsed")), [INFO] [stderr] 157 | | _ => Err(RenderError::new("Type error: First argument should be a number")), [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 155 | match *h.param(idx).ok_or(RenderError::new("Too few arguments"))?.value() { [INFO] [stderr] 156 | Value::Number(ref num) => num.as_u64().ok_or_else(|| RenderError::new("Number cannot be parsed")), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format.rs:155:24 [INFO] [stderr] | [INFO] [stderr] 155 | match h.param(idx).ok_or(RenderError::new("Too few arguments"))?.value() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Too few arguments"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format.rs:167:31 [INFO] [stderr] | [INFO] [stderr] 167 | let text = h.param(1).ok_or(RenderError::new("Too few arguments"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Too few arguments"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format.rs:180:31 [INFO] [stderr] | [INFO] [stderr] 180 | let text = h.param(1).ok_or(RenderError::new("Too few arguments"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Too few arguments"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format.rs:193:31 [INFO] [stderr] | [INFO] [stderr] 193 | let text = h.param(1).ok_or(RenderError::new("Too few arguments"))?.value().render(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Too few arguments"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ui.rs:53:10 [INFO] [stderr] | [INFO] [stderr] 53 | .ok_or(err_msg("CLI error")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("CLI error"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ui.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | vals.into_iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `vals` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `libimaginteraction`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/ask.rs:108:1 [INFO] [stderr] | [INFO] [stderr] 108 | / pub fn ask_string(s: &str, [INFO] [stderr] 109 | | default: Option, [INFO] [stderr] 110 | | permit_empty: bool, [INFO] [stderr] 111 | | permit_multiline: bool, [INFO] [stderr] ... | [INFO] [stderr] 125 | | output) [INFO] [stderr] 126 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/ask.rs:128:1 [INFO] [stderr] | [INFO] [stderr] 128 | / fn ask_string_(s: &str, [INFO] [stderr] 129 | | default: Option, [INFO] [stderr] 130 | | permit_empty: bool, [INFO] [stderr] 131 | | permit_multiline: bool, [INFO] [stderr] ... | [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/ask.rs:182:12 [INFO] [stderr] | [INFO] [stderr] 182 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 183 | | writeln!(output, "[imag]: {}?", Yellow.paint(question)).map_err(Error::from) [INFO] [stderr] 184 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/ask.rs:180:11 [INFO] [stderr] | [INFO] [stderr] 180 | if nl { [INFO] [stderr] | ___________^ [INFO] [stderr] 181 | | writeln!(output, "[imag]: {}?", Yellow.paint(question)).map_err(Error::from) [INFO] [stderr] 182 | | } else { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format.rs:100:24 [INFO] [stderr] | [INFO] [stderr] 100 | let p = h.param(0).ok_or(RenderError::new("Too few arguments"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Too few arguments"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format.rs:111:32 [INFO] [stderr] | [INFO] [stderr] 111 | let p = h.param(0).ok_or(RenderError::new("Too few arguments"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Too few arguments"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format.rs:123:32 [INFO] [stderr] | [INFO] [stderr] 123 | let p = h.param(0).ok_or(RenderError::new("Too few arguments"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Too few arguments"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format.rs:135:32 [INFO] [stderr] | [INFO] [stderr] 135 | let p = h.param(0).ok_or(RenderError::new("Too few arguments"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Too few arguments"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format.rs:147:32 [INFO] [stderr] | [INFO] [stderr] 147 | let p = h.param(0).ok_or(RenderError::new("Too few arguments"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Too few arguments"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/format.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | / match h.param(idx).ok_or(RenderError::new("Too few arguments"))?.value() { [INFO] [stderr] 156 | | &Value::Number(ref num) => num.as_u64().ok_or_else(|| RenderError::new("Number cannot be parsed")), [INFO] [stderr] 157 | | _ => Err(RenderError::new("Type error: First argument should be a number")), [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 155 | match *h.param(idx).ok_or(RenderError::new("Too few arguments"))?.value() { [INFO] [stderr] 156 | Value::Number(ref num) => num.as_u64().ok_or_else(|| RenderError::new("Number cannot be parsed")), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format.rs:155:24 [INFO] [stderr] | [INFO] [stderr] 155 | match h.param(idx).ok_or(RenderError::new("Too few arguments"))?.value() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Too few arguments"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format.rs:167:31 [INFO] [stderr] | [INFO] [stderr] 167 | let text = h.param(1).ok_or(RenderError::new("Too few arguments"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Too few arguments"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format.rs:180:31 [INFO] [stderr] | [INFO] [stderr] 180 | let text = h.param(1).ok_or(RenderError::new("Too few arguments"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Too few arguments"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/format.rs:193:31 [INFO] [stderr] | [INFO] [stderr] 193 | let text = h.param(1).ok_or(RenderError::new("Too few arguments"))?.value().render(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| RenderError::new("Too few arguments"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ui.rs:53:10 [INFO] [stderr] | [INFO] [stderr] 53 | .ok_or(err_msg("CLI error")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("CLI error"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ui.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | vals.into_iter() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `vals` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `libimaginteraction`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1c919fd79771c05521cca2bd87e292c35545c78003b4a381717505cc6ffdf648"` [INFO] running `"docker" "rm" "-f" "1c919fd79771c05521cca2bd87e292c35545c78003b4a381717505cc6ffdf648"` [INFO] [stdout] 1c919fd79771c05521cca2bd87e292c35545c78003b4a381717505cc6ffdf648