[INFO] crate libimagentrytag 0.9.0 is already in cache [INFO] extracting crate libimagentrytag 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/libimagentrytag/0.9.0 [INFO] extracting crate libimagentrytag 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagentrytag/0.9.0 [INFO] validating manifest of libimagentrytag-0.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libimagentrytag-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libimagentrytag-0.9.0 [INFO] finished frobbing libimagentrytag-0.9.0 [INFO] frobbed toml for libimagentrytag-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/libimagentrytag/0.9.0/Cargo.toml [INFO] started frobbing libimagentrytag-0.9.0 [INFO] finished frobbing libimagentrytag-0.9.0 [INFO] frobbed toml for libimagentrytag-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagentrytag/0.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libimagentrytag-0.9.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libimagentrytag/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1b41e6636f96ce4a40deb8704f4f4fcfaf7339cdddaba087ee3ed1c6b62fa1d3 [INFO] running `"docker" "start" "-a" "1b41e6636f96ce4a40deb8704f4f4fcfaf7339cdddaba087ee3ed1c6b62fa1d3"` [INFO] [stderr] Checking filters v0.3.0 [INFO] [stderr] Checking toml-query v0.8.0 [INFO] [stderr] Checking libimagerror v0.9.0 [INFO] [stderr] Checking libimagutil v0.9.0 [INFO] [stderr] Checking libimagstore v0.9.0 [INFO] [stderr] Checking libimagentrytag v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tag.rs:32:22 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn is_tag_str(s: &String) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tagable.rs:84:14 [INFO] [stderr] | [INFO] [stderr] 84 | .unwrap_or(Ok(vec![])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok(vec![]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tagable.rs:82:22 [INFO] [stderr] | [INFO] [stderr] 82 | .unwrap_or(Ok(vec![])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok(vec![]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tagable.rs:66:53 [INFO] [stderr] | [INFO] [stderr] 66 | Value::String(ref s) => !is_tag_str(s).is_ok(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `is_tag_str(s).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tagable.rs:88:32 [INFO] [stderr] | [INFO] [stderr] 88 | if ts.iter().any(|tag| !is_tag_str(tag).is_ok()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `is_tag_str(tag).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/tagable.rs:89:27 [INFO] [stderr] | [INFO] [stderr] 89 | let not_tag = ts.iter().filter(|t| !is_tag_str(t).is_ok()).next().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|t| !is_tag_str(t).is_ok()).next()` with `find(|t| !is_tag_str(t).is_ok())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tagable.rs:89:48 [INFO] [stderr] | [INFO] [stderr] 89 | let not_tag = ts.iter().filter(|t| !is_tag_str(t).is_ok()).next().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `is_tag_str(t).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tagable.rs:144:16 [INFO] [stderr] | [INFO] [stderr] 144 | / match *tag { [INFO] [stderr] 145 | | &Value::String(ref s) => { s == t }, [INFO] [stderr] 146 | | _ => unreachable!() [INFO] [stderr] 147 | | } [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 144 | match *(*tag) { [INFO] [stderr] 145 | Value::String(ref s) => { s == t }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tag.rs:32:22 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn is_tag_str(s: &String) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tagable.rs:84:14 [INFO] [stderr] | [INFO] [stderr] 84 | .unwrap_or(Ok(vec![])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok(vec![]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tagable.rs:82:22 [INFO] [stderr] | [INFO] [stderr] 82 | .unwrap_or(Ok(vec![])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok(vec![]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tagable.rs:66:53 [INFO] [stderr] | [INFO] [stderr] 66 | Value::String(ref s) => !is_tag_str(s).is_ok(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `is_tag_str(s).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tagable.rs:88:32 [INFO] [stderr] | [INFO] [stderr] 88 | if ts.iter().any(|tag| !is_tag_str(tag).is_ok()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `is_tag_str(tag).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/tagable.rs:89:27 [INFO] [stderr] | [INFO] [stderr] 89 | let not_tag = ts.iter().filter(|t| !is_tag_str(t).is_ok()).next().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|t| !is_tag_str(t).is_ok()).next()` with `find(|t| !is_tag_str(t).is_ok())` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tagable.rs:89:48 [INFO] [stderr] | [INFO] [stderr] 89 | let not_tag = ts.iter().filter(|t| !is_tag_str(t).is_ok()).next().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `is_tag_str(t).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/tagable.rs:144:16 [INFO] [stderr] | [INFO] [stderr] 144 | / match *tag { [INFO] [stderr] 145 | | &Value::String(ref s) => { s == t }, [INFO] [stderr] 146 | | _ => unreachable!() [INFO] [stderr] 147 | | } [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 144 | match *(*tag) { [INFO] [stderr] 145 | Value::String(ref s) => { s == t }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.16s [INFO] running `"docker" "inspect" "1b41e6636f96ce4a40deb8704f4f4fcfaf7339cdddaba087ee3ed1c6b62fa1d3"` [INFO] running `"docker" "rm" "-f" "1b41e6636f96ce4a40deb8704f4f4fcfaf7339cdddaba087ee3ed1c6b62fa1d3"` [INFO] [stdout] 1b41e6636f96ce4a40deb8704f4f4fcfaf7339cdddaba087ee3ed1c6b62fa1d3