[INFO] crate libimagentryref 0.9.0 is already in cache [INFO] extracting crate libimagentryref 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/libimagentryref/0.9.0 [INFO] extracting crate libimagentryref 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagentryref/0.9.0 [INFO] validating manifest of libimagentryref-0.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libimagentryref-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libimagentryref-0.9.0 [INFO] finished frobbing libimagentryref-0.9.0 [INFO] frobbed toml for libimagentryref-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/libimagentryref/0.9.0/Cargo.toml [INFO] started frobbing libimagentryref-0.9.0 [INFO] finished frobbing libimagentryref-0.9.0 [INFO] frobbed toml for libimagentryref-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagentryref/0.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libimagentryref-0.9.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libimagentryref/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a6ff2a37918e094e3f825bf73ea6306903b85c0a8af4de8822b67288b7d03b50 [INFO] running `"docker" "start" "-a" "a6ff2a37918e094e3f825bf73ea6306903b85c0a8af4de8822b67288b7d03b50"` [INFO] [stderr] Checking filters v0.3.0 [INFO] [stderr] Checking libimagerror v0.9.0 [INFO] [stderr] Checking libimagutil v0.9.0 [INFO] [stderr] Checking libimagstore v0.9.0 [INFO] [stderr] Checking libimagentryutil v0.9.0 [INFO] [stderr] Checking libimagentryref v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/reference.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | let _ = self.set_isflag::()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reference.rs:108:46 [INFO] [stderr] | [INFO] [stderr] 108 | hdr.insert("ref.path", Value::String(String::from(path_str)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `path_str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/reference.rs:131:23 [INFO] [stderr] | [INFO] [stderr] 131 | .and_then(|pb| RPG::unique_hash(pb)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RPG::unique_hash` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/reference.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | let _ = self.set_isflag::()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reference.rs:108:46 [INFO] [stderr] | [INFO] [stderr] 108 | hdr.insert("ref.path", Value::String(String::from(path_str)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `path_str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/reference.rs:131:23 [INFO] [stderr] | [INFO] [stderr] 131 | .and_then(|pb| RPG::unique_hash(pb)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RPG::unique_hash` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.43s [INFO] running `"docker" "inspect" "a6ff2a37918e094e3f825bf73ea6306903b85c0a8af4de8822b67288b7d03b50"` [INFO] running `"docker" "rm" "-f" "a6ff2a37918e094e3f825bf73ea6306903b85c0a8af4de8822b67288b7d03b50"` [INFO] [stdout] a6ff2a37918e094e3f825bf73ea6306903b85c0a8af4de8822b67288b7d03b50