[INFO] crate libimagentrymarkdown 0.9.0 is already in cache [INFO] extracting crate libimagentrymarkdown 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/libimagentrymarkdown/0.9.0 [INFO] extracting crate libimagentrymarkdown 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagentrymarkdown/0.9.0 [INFO] validating manifest of libimagentrymarkdown-0.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libimagentrymarkdown-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libimagentrymarkdown-0.9.0 [INFO] finished frobbing libimagentrymarkdown-0.9.0 [INFO] frobbed toml for libimagentrymarkdown-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/libimagentrymarkdown/0.9.0/Cargo.toml [INFO] started frobbing libimagentrymarkdown-0.9.0 [INFO] finished frobbing libimagentrymarkdown-0.9.0 [INFO] frobbed toml for libimagentrymarkdown-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagentrymarkdown/0.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libimagentrymarkdown-0.9.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libimagentrymarkdown/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b8696bd75678b2155057351e7068e23db121393e2e34ab814928fb79350d2fb1 [INFO] running `"docker" "start" "-a" "b8696bd75678b2155057351e7068e23db121393e2e34ab814928fb79350d2fb1"` [INFO] [stderr] Compiling hoedown v6.0.0 [INFO] [stderr] Checking libimagutil v0.9.0 [INFO] [stderr] Checking libimagerror v0.9.0 [INFO] [stderr] Checking libimagstore v0.9.0 [INFO] [stderr] Checking libimagentryutil v0.9.0 [INFO] [stderr] Checking libimagentrylink v0.9.0 [INFO] [stderr] Checking libimagentryref v0.9.0 [INFO] [stderr] Checking libimagentrymarkdown v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/html.rs:55:30 [INFO] [stderr] | [INFO] [stderr] 55 | ToHtmlIterator { i: i } [INFO] [stderr] | ^^^^ help: replace it with: `i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/html.rs:86:32 [INFO] [stderr] | [INFO] [stderr] 86 | WithHtmlIterator { i: i } [INFO] [stderr] | ^^^^ help: replace it with: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/link.rs:41:59 [INFO] [stderr] | [INFO] [stderr] 41 | .map(move |link| UrlLink { title: self.title, link: link, }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/link.rs:88:40 [INFO] [stderr] | [INFO] [stderr] 88 | self.links.push(Link { link: link, title: content }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/html.rs:55:30 [INFO] [stderr] | [INFO] [stderr] 55 | ToHtmlIterator { i: i } [INFO] [stderr] | ^^^^ help: replace it with: `i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/html.rs:86:32 [INFO] [stderr] | [INFO] [stderr] 86 | WithHtmlIterator { i: i } [INFO] [stderr] | ^^^^ help: replace it with: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/link.rs:41:59 [INFO] [stderr] | [INFO] [stderr] 41 | .map(move |link| UrlLink { title: self.title, link: link, }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/link.rs:88:40 [INFO] [stderr] | [INFO] [stderr] 88 | self.links.push(Link { link: link, title: content }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/processor.rs:202:21 [INFO] [stderr] | [INFO] [stderr] 202 | return LinkQualification::ExternalLink(url); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `LinkQualification::ExternalLink(url)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/processor.rs:202:21 [INFO] [stderr] | [INFO] [stderr] 202 | return LinkQualification::ExternalLink(url); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `LinkQualification::ExternalLink(url)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/processor.rs:142:44 [INFO] [stderr] | [INFO] [stderr] 142 | .ok_or_else(|| Error::from(format_err!("Store get error: {}", id)))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `format_err!("Store get error: {}", id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/processor.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | let _ = entry.add_internal_link(&mut target)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/processor.rs:142:44 [INFO] [stderr] | [INFO] [stderr] 142 | .ok_or_else(|| Error::from(format_err!("Store get error: {}", id)))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `format_err!("Store get error: {}", id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/processor.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | let _ = entry.add_internal_link(&mut target)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/processor.rs:256:35 [INFO] [stderr] | [INFO] [stderr] 256 | *base.get_content_mut() = format!("This is an example entry with no links"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"This is an example entry with no links".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/processor.rs:273:35 [INFO] [stderr] | [INFO] [stderr] 273 | *base.get_content_mut() = format!("This is an example entry with one [link](test-2.2)"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"This is an example entry with one [link](test-2.2)".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/processor.rs:316:35 [INFO] [stderr] | [INFO] [stderr] 316 | *base.get_content_mut() = format!("This is an example entry with one [link](/test-2.2)"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"This is an example entry with one [link](/test-2.2)".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/processor.rs:337:35 [INFO] [stderr] | [INFO] [stderr] 337 | *base.get_content_mut() = format!("This is an example entry with one [link](test-2.2)"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"This is an example entry with one [link](test-2.2)".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/processor.rs:377:35 [INFO] [stderr] | [INFO] [stderr] 377 | *base.get_content_mut() = format!("An [example](http://example.com) is here."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"An [example](http://example.com) is here.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/processor.rs:427:35 [INFO] [stderr] | [INFO] [stderr] 427 | *base.get_content_mut() = format!("An [example ref](file:///etc/hosts) is here."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"An [example ref](file:///etc/hosts) is here.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/processor.rs:457:35 [INFO] [stderr] | [INFO] [stderr] 457 | *base.get_content_mut() = format!( [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 458 | | r#"An [example ref](file:///etc/hosts) [INFO] [stderr] 459 | | is [here](file:///etc/group)."# [INFO] [stderr] 460 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 457 | *base.get_content_mut() = r#"An [example ref](file:///etc/hosts) [INFO] [stderr] 458 | is [here](file:///etc/group)."#.to_string(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/processor.rs:490:35 [INFO] [stderr] | [INFO] [stderr] 490 | *base.get_content_mut() = format!( [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 491 | | r#"An [example ref](file:///etc/hosts) [INFO] [stderr] 492 | | is [here](file:///etc/group)."# [INFO] [stderr] 493 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 490 | *base.get_content_mut() = r#"An [example ref](file:///etc/hosts) [INFO] [stderr] 491 | is [here](file:///etc/group)."#.to_string(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/processor.rs:521:35 [INFO] [stderr] | [INFO] [stderr] 521 | *base.get_content_mut() = format!("An [example](http://example.com) is here."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"An [example](http://example.com) is here.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/processor.rs:548:35 [INFO] [stderr] | [INFO] [stderr] 548 | *base.get_content_mut() = format!("This is an example entry with one [link](test-2.2)"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"This is an example entry with one [link](test-2.2)".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/processor.rs:565:47 [INFO] [stderr] | [INFO] [stderr] 565 | assert_eq!(2, store.entries().unwrap().collect::>().len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.95s [INFO] running `"docker" "inspect" "b8696bd75678b2155057351e7068e23db121393e2e34ab814928fb79350d2fb1"` [INFO] running `"docker" "rm" "-f" "b8696bd75678b2155057351e7068e23db121393e2e34ab814928fb79350d2fb1"` [INFO] [stdout] b8696bd75678b2155057351e7068e23db121393e2e34ab814928fb79350d2fb1