[INFO] crate libimagentrylist 0.6.4 is already in cache [INFO] extracting crate libimagentrylist 0.6.4 into work/ex/clippy-test-run/sources/stable/reg/libimagentrylist/0.6.4 [INFO] extracting crate libimagentrylist 0.6.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagentrylist/0.6.4 [INFO] validating manifest of libimagentrylist-0.6.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libimagentrylist-0.6.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libimagentrylist-0.6.4 [INFO] finished frobbing libimagentrylist-0.6.4 [INFO] frobbed toml for libimagentrylist-0.6.4 written to work/ex/clippy-test-run/sources/stable/reg/libimagentrylist/0.6.4/Cargo.toml [INFO] started frobbing libimagentrylist-0.6.4 [INFO] finished frobbing libimagentrylist-0.6.4 [INFO] frobbed toml for libimagentrylist-0.6.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagentrylist/0.6.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libimagentrylist-0.6.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libimagentrylist/0.6.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 29bd264d3588b7edceefd5f53e2ace1aab99c16c1452dd35a1e7c39c43e8b4b5 [INFO] running `"docker" "start" "-a" "29bd264d3588b7edceefd5f53e2ace1aab99c16c1452dd35a1e7c39c43e8b4b5"` [INFO] [stderr] Checking libimagerror v0.6.4 [INFO] [stderr] Checking toml-query v0.6.0 [INFO] [stderr] Checking libimagutil v0.6.4 [INFO] [stderr] Checking libimagstore v0.6.4 [INFO] [stderr] Checking libimagentrylist v0.6.4 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/listers/core.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | write!(stdout(), "{:?}\n", (self.lister)(&entry)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/listers/line.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | unknown_output: unknown_output, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unknown_output` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/listers/line.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | write!(stdout(), "{:?}\n", s).chain_err(|| LEK::FormatError)? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/listers/path.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | absolute: absolute, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `absolute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/listers/path.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | write!(stdout(), "{:?}\n", pb).chain_err(|| LEK::FormatError)? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/listers/core.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | write!(stdout(), "{:?}\n", (self.lister)(&entry)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/listers/line.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | unknown_output: unknown_output, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unknown_output` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/listers/line.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | write!(stdout(), "{:?}\n", s).chain_err(|| LEK::FormatError)? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/listers/path.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | absolute: absolute, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `absolute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/listers/path.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | write!(stdout(), "{:?}\n", pb).chain_err(|| LEK::FormatError)? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/listers/line.rs:49:51 [INFO] [stderr] | [INFO] [stderr] 49 | let s = entry.get_location().to_str().unwrap_or(String::from(self.unknown_output)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from(self.unknown_output))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/listers/path.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | pb.into() [INFO] [stderr] | ^^^^^^^^^ help: consider removing `.into()`: `pb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/listers/line.rs:49:51 [INFO] [stderr] | [INFO] [stderr] 49 | let s = entry.get_location().to_str().unwrap_or(String::from(self.unknown_output)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from(self.unknown_output))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/listers/path.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | pb.into() [INFO] [stderr] | ^^^^^^^^^ help: consider removing `.into()`: `pb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.09s [INFO] running `"docker" "inspect" "29bd264d3588b7edceefd5f53e2ace1aab99c16c1452dd35a1e7c39c43e8b4b5"` [INFO] running `"docker" "rm" "-f" "29bd264d3588b7edceefd5f53e2ace1aab99c16c1452dd35a1e7c39c43e8b4b5"` [INFO] [stdout] 29bd264d3588b7edceefd5f53e2ace1aab99c16c1452dd35a1e7c39c43e8b4b5