[INFO] crate libimagentryfilter 0.9.0 is already in cache [INFO] extracting crate libimagentryfilter 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/libimagentryfilter/0.9.0 [INFO] extracting crate libimagentryfilter 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagentryfilter/0.9.0 [INFO] validating manifest of libimagentryfilter-0.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libimagentryfilter-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libimagentryfilter-0.9.0 [INFO] finished frobbing libimagentryfilter-0.9.0 [INFO] frobbed toml for libimagentryfilter-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/libimagentryfilter/0.9.0/Cargo.toml [INFO] started frobbing libimagentryfilter-0.9.0 [INFO] finished frobbing libimagentryfilter-0.9.0 [INFO] frobbed toml for libimagentryfilter-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagentryfilter/0.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libimagentryfilter-0.9.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libimagentryfilter/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dcb902709875d092eb0364a07cb85870fe813d1f16ab48713384a2ed1e982824 [INFO] running `"docker" "start" "-a" "dcb902709875d092eb0364a07cb85870fe813d1f16ab48713384a2ed1e982824"` [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking libimagentrytag v0.9.0 [INFO] [stderr] Checking libimagentryfilter v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builtin/header/field_predicate.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | predicate: predicate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `predicate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builtin/header/version/eq.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | VersionEq { version: version } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builtin/header/version/gt.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | VersionGt { version: version } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builtin/header/version/lt.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | VersionLt { version: version } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tags/mod.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tags/mod.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tags/mod.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builtin/header/field_predicate.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | predicate: predicate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `predicate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builtin/header/version/eq.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | VersionEq { version: version } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builtin/header/version/gt.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | VersionGt { version: version } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builtin/header/version/lt.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | VersionLt { version: version } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tags/mod.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tags/mod.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tags/mod.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/builtin/header/field_isempty.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | / match v { [INFO] [stderr] 54 | | &Value::Array(ref a) => a.is_empty(), [INFO] [stderr] 55 | | &Value::String(ref s) => s.is_empty(), [INFO] [stderr] 56 | | &Value::Table(ref t) => t.is_empty(), [INFO] [stderr] ... | [INFO] [stderr] 60 | | &Value::Integer(_) => false, [INFO] [stderr] 61 | | } [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | match *v { [INFO] [stderr] 54 | Value::Array(ref a) => a.is_empty(), [INFO] [stderr] 55 | Value::String(ref s) => s.is_empty(), [INFO] [stderr] 56 | Value::Table(ref t) => t.is_empty(), [INFO] [stderr] 57 | Value::Boolean(_) | [INFO] [stderr] 58 | Value::Float(_) | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/builtin/header/field_isempty.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | / match v { [INFO] [stderr] 54 | | &Value::Array(ref a) => a.is_empty(), [INFO] [stderr] 55 | | &Value::String(ref s) => s.is_empty(), [INFO] [stderr] 56 | | &Value::Table(ref t) => t.is_empty(), [INFO] [stderr] ... | [INFO] [stderr] 60 | | &Value::Integer(_) => false, [INFO] [stderr] 61 | | } [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | match *v { [INFO] [stderr] 54 | Value::Array(ref a) => a.is_empty(), [INFO] [stderr] 55 | Value::String(ref s) => s.is_empty(), [INFO] [stderr] 56 | Value::Table(ref t) => t.is_empty(), [INFO] [stderr] 57 | Value::Boolean(_) | [INFO] [stderr] 58 | Value::Float(_) | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.74s [INFO] running `"docker" "inspect" "dcb902709875d092eb0364a07cb85870fe813d1f16ab48713384a2ed1e982824"` [INFO] running `"docker" "rm" "-f" "dcb902709875d092eb0364a07cb85870fe813d1f16ab48713384a2ed1e982824"` [INFO] [stdout] dcb902709875d092eb0364a07cb85870fe813d1f16ab48713384a2ed1e982824