[INFO] crate libimagentrycategory 0.9.0 is already in cache
[INFO] extracting crate libimagentrycategory 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/libimagentrycategory/0.9.0
[INFO] extracting crate libimagentrycategory 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagentrycategory/0.9.0
[INFO] validating manifest of libimagentrycategory-0.9.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of libimagentrycategory-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing libimagentrycategory-0.9.0
[INFO] finished frobbing libimagentrycategory-0.9.0
[INFO] frobbed toml for libimagentrycategory-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/libimagentrycategory/0.9.0/Cargo.toml
[INFO] started frobbing libimagentrycategory-0.9.0
[INFO] finished frobbing libimagentrycategory-0.9.0
[INFO] frobbed toml for libimagentrycategory-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagentrycategory/0.9.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting libimagentrycategory-0.9.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libimagentrycategory/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6299a91ac506f173b1a4f5325441c0f4e44bccd5b82e79954de749ff1f22d78b
[INFO] running `"docker" "start" "-a" "6299a91ac506f173b1a4f5325441c0f4e44bccd5b82e79954de749ff1f22d78b"`
[INFO] [stderr]     Checking libimagstore v0.9.0
[INFO] [stderr]     Checking libimagentryutil v0.9.0
[INFO] [stderr]     Checking libimagentrylink v0.9.0
[INFO] [stderr]     Checking libimagentrycategory v0.9.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/store.rs:39:48
[INFO] [stderr]    |
[INFO] [stderr] 39 | pub const CATEGORY_REGISTER_NAME_FIELD_PATH : &'static str = "category.register.name";
[INFO] [stderr]    |                                               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/category.rs:53:28
[INFO] [stderr]    |
[INFO] [stderr] 53 |             .ok_or_else(|| Error::from(err_msg("Category name missing")))
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `err_msg("Category name missing")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/entry.rs:68:28
[INFO] [stderr]    |
[INFO] [stderr] 68 |             .ok_or_else(|| Error::from(err_msg("Category does not exist")))?;
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `err_msg("Category does not exist")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/entry.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 |         let _ = self.set_category(s)?;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/entry.rs:71:9
[INFO] [stderr]    |
[INFO] [stderr] 71 |         let _ = self.add_internal_link(&mut category)?;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/entry.rs:80:28
[INFO] [stderr]    |
[INFO] [stderr] 80 |             .ok_or_else(|| Error::from(err_msg("Category name missing")))
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `err_msg("Category name missing")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/store.rs:97:32
[INFO] [stderr]    |
[INFO] [stderr] 97 |                 .ok_or_else(|| Error::from(err_msg("Category does not exist")))
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `err_msg("Category does not exist")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/store.rs:102:17
[INFO] [stderr]     |
[INFO] [stderr] 102 |                 let _         = category.remove_internal_link(&mut entry)?;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/iter.rs:71:48
[INFO] [stderr]    |
[INFO] [stderr] 71 |                                 .ok_or_else(|| Error::from(err_msg("Store read error")))?
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `err_msg("Store read error")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/iter.rs:76:48
[INFO] [stderr]    |
[INFO] [stderr] 76 |                                 .ok_or_else(|| Error::from(err_msg("Store read error")))
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `err_msg("Store read error")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/iter.rs:108:44
[INFO] [stderr]     |
[INFO] [stderr] 108 |                             .ok_or_else(|| Error::from(err_msg("Store read error")))?;
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `err_msg("Store read error")`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/store.rs:39:48
[INFO] [stderr]    |
[INFO] [stderr] 39 | pub const CATEGORY_REGISTER_NAME_FIELD_PATH : &'static str = "category.register.name";
[INFO] [stderr]    |                                               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/category.rs:53:28
[INFO] [stderr]    |
[INFO] [stderr] 53 |             .ok_or_else(|| Error::from(err_msg("Category name missing")))
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `err_msg("Category name missing")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/entry.rs:68:28
[INFO] [stderr]    |
[INFO] [stderr] 68 |             .ok_or_else(|| Error::from(err_msg("Category does not exist")))?;
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `err_msg("Category does not exist")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/entry.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 |         let _ = self.set_category(s)?;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]   --> src/entry.rs:71:9
[INFO] [stderr]    |
[INFO] [stderr] 71 |         let _ = self.add_internal_link(&mut category)?;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/entry.rs:80:28
[INFO] [stderr]    |
[INFO] [stderr] 80 |             .ok_or_else(|| Error::from(err_msg("Category name missing")))
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `err_msg("Category name missing")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/store.rs:97:32
[INFO] [stderr]    |
[INFO] [stderr] 97 |                 .ok_or_else(|| Error::from(err_msg("Category does not exist")))
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `err_msg("Category does not exist")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/store.rs:102:17
[INFO] [stderr]     |
[INFO] [stderr] 102 |                 let _         = category.remove_internal_link(&mut entry)?;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/iter.rs:71:48
[INFO] [stderr]    |
[INFO] [stderr] 71 |                                 .ok_or_else(|| Error::from(err_msg("Store read error")))?
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `err_msg("Store read error")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/iter.rs:76:48
[INFO] [stderr]    |
[INFO] [stderr] 76 |                                 .ok_or_else(|| Error::from(err_msg("Store read error")))
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `err_msg("Store read error")`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/iter.rs:108:44
[INFO] [stderr]     |
[INFO] [stderr] 108 |                             .ok_or_else(|| Error::from(err_msg("Store read error")))?;
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `err_msg("Store read error")`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 16.51s
[INFO] running `"docker" "inspect" "6299a91ac506f173b1a4f5325441c0f4e44bccd5b82e79954de749ff1f22d78b"`
[INFO] running `"docker" "rm" "-f" "6299a91ac506f173b1a4f5325441c0f4e44bccd5b82e79954de749ff1f22d78b"`
[INFO] [stdout] 6299a91ac506f173b1a4f5325441c0f4e44bccd5b82e79954de749ff1f22d78b