[INFO] crate libimagbookmark 0.9.0 is already in cache [INFO] extracting crate libimagbookmark 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/libimagbookmark/0.9.0 [INFO] extracting crate libimagbookmark 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagbookmark/0.9.0 [INFO] validating manifest of libimagbookmark-0.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libimagbookmark-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libimagbookmark-0.9.0 [INFO] finished frobbing libimagbookmark-0.9.0 [INFO] frobbed toml for libimagbookmark-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/libimagbookmark/0.9.0/Cargo.toml [INFO] started frobbing libimagbookmark-0.9.0 [INFO] finished frobbing libimagbookmark-0.9.0 [INFO] frobbed toml for libimagbookmark-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libimagbookmark/0.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libimagbookmark-0.9.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libimagbookmark/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8fe579f76451d9b38e518d46b07e8e794bd68cf30f447109df44ba619789fe0a [INFO] running `"docker" "start" "-a" "8fe579f76451d9b38e518d46b07e8e794bd68cf30f447109df44ba619789fe0a"` [INFO] [stderr] Checking libimagentrylink v0.9.0 [INFO] [stderr] Checking libimagbookmark v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/collection.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / fn new(&'a self, name: &str) -> Result> { [INFO] [stderr] 56 | | ModuleEntryPath::new(name) [INFO] [stderr] 57 | | .into_storeid() [INFO] [stderr] 58 | | .and_then(|id| self.create(id).map_err(Error::from)) [INFO] [stderr] 59 | | .map_err(Error::from) [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/collection.rs:94:52 [INFO] [stderr] | [INFO] [stderr] 94 | self.get_internal_links().map(|v| v.filter(|id| is_external_link_storeid(id)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `is_external_link_storeid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/collection.rs:160:53 [INFO] [stderr] | [INFO] [stderr] 160 | Some(Err(e)) => return Some(Err(Error::from(e))), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/collection.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / fn new(&'a self, name: &str) -> Result> { [INFO] [stderr] 56 | | ModuleEntryPath::new(name) [INFO] [stderr] 57 | | .into_storeid() [INFO] [stderr] 58 | | .and_then(|id| self.create(id).map_err(Error::from)) [INFO] [stderr] 59 | | .map_err(Error::from) [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/collection.rs:94:52 [INFO] [stderr] | [INFO] [stderr] 94 | self.get_internal_links().map(|v| v.filter(|id| is_external_link_storeid(id)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `is_external_link_storeid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/collection.rs:160:53 [INFO] [stderr] | [INFO] [stderr] 160 | Some(Err(e)) => return Some(Err(Error::from(e))), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider removing `Error::from()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.56s [INFO] running `"docker" "inspect" "8fe579f76451d9b38e518d46b07e8e794bd68cf30f447109df44ba619789fe0a"` [INFO] running `"docker" "rm" "-f" "8fe579f76451d9b38e518d46b07e8e794bd68cf30f447109df44ba619789fe0a"` [INFO] [stdout] 8fe579f76451d9b38e518d46b07e8e794bd68cf30f447109df44ba619789fe0a