[INFO] crate libicmp 0.1.2 is already in cache [INFO] extracting crate libicmp 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/libicmp/0.1.2 [INFO] extracting crate libicmp 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libicmp/0.1.2 [INFO] validating manifest of libicmp-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libicmp-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libicmp-0.1.2 [INFO] finished frobbing libicmp-0.1.2 [INFO] frobbed toml for libicmp-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/libicmp/0.1.2/Cargo.toml [INFO] started frobbing libicmp-0.1.2 [INFO] finished frobbing libicmp-0.1.2 [INFO] frobbed toml for libicmp-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libicmp/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libicmp-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libicmp/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 75b4cc66060a072f8877e038457c5d883f0e834fba8a523f4b94e8c82e28ef8b [INFO] running `"docker" "start" "-a" "75b4cc66060a072f8877e038457c5d883f0e834fba8a523f4b94e8c82e28ef8b"` [INFO] [stderr] Checking libicmp v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/header.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | ttype: ttype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ttype` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/header.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/header.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/icmp.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/icmp.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | host: host, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ping.rs:33:23 [INFO] [stderr] | [INFO] [stderr] 33 | PingBuilder { host: host, .. self } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ping.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | PingBuilder { num_pings: num_pings, .. self } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_pings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ping.rs:43:23 [INFO] [stderr] | [INFO] [stderr] 43 | PingBuilder { interval_secs: interval_secs, .. self } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interval_secs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ping.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | PingBuilder { timeout_secs: timeout_secs, .. self } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timeout_secs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ping.rs:53:23 [INFO] [stderr] | [INFO] [stderr] 53 | PingBuilder { debug: debug, .. self } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `debug` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/header.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | ttype: ttype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ttype` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/header.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packet/header.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/icmp.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/icmp.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | host: host, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ping.rs:33:23 [INFO] [stderr] | [INFO] [stderr] 33 | PingBuilder { host: host, .. self } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ping.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | PingBuilder { num_pings: num_pings, .. self } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_pings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ping.rs:43:23 [INFO] [stderr] | [INFO] [stderr] 43 | PingBuilder { interval_secs: interval_secs, .. self } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interval_secs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ping.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | PingBuilder { timeout_secs: timeout_secs, .. self } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timeout_secs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ping.rs:53:23 [INFO] [stderr] | [INFO] [stderr] 53 | PingBuilder { debug: debug, .. self } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `debug` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/packet/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod packet; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/packet/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod packet; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: item `packet::packet::EchoRequest` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/packet/packet.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / impl EchoRequest { [INFO] [stderr] 13 | | [INFO] [stderr] 14 | | fn create_u32_data(id: u16, seq: u16) -> u32 { [INFO] [stderr] 15 | | let mut w = vec![]; [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet/checksum.rs:18:16 [INFO] [stderr] | [INFO] [stderr] 18 | sum += *d as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*d)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/packet/header.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | for i in 0..header.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try replacing the loop by: `header.clone_from_slice(&w[..header.len()])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/icmp.rs:69:59 [INFO] [stderr] | [INFO] [stderr] 69 | let time = Instant::now().duration_since(*self.echoes.get(&echo.seq()).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.echoes[&echo.seq()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ping::PingBuilder<'a>` [INFO] [stderr] --> src/ping.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> PingBuilder<'a> { [INFO] [stderr] 22 | | PingBuilder { [INFO] [stderr] 23 | | host: "127.0.0.1", [INFO] [stderr] 24 | | num_pings: DEFAULT_NUM_PINGS, [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ping.rs:106:60 [INFO] [stderr] | [INFO] [stderr] 106 | let time = (dur.as_secs() * 1000) as f64 + dur.subsec_nanos() as f64 / 1e6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dur.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `packet::packet::EchoRequest` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/packet/packet.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / impl EchoRequest { [INFO] [stderr] 13 | | [INFO] [stderr] 14 | | fn create_u32_data(id: u16, seq: u16) -> u32 { [INFO] [stderr] 15 | | let mut w = vec![]; [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packet/checksum.rs:18:16 [INFO] [stderr] | [INFO] [stderr] 18 | sum += *d as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*d)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/packet/header.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | for i in 0..header.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try replacing the loop by: `header.clone_from_slice(&w[..header.len()])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/icmp.rs:69:59 [INFO] [stderr] | [INFO] [stderr] 69 | let time = Instant::now().duration_since(*self.echoes.get(&echo.seq()).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.echoes[&echo.seq()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ping::PingBuilder<'a>` [INFO] [stderr] --> src/ping.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> PingBuilder<'a> { [INFO] [stderr] 22 | | PingBuilder { [INFO] [stderr] 23 | | host: "127.0.0.1", [INFO] [stderr] 24 | | num_pings: DEFAULT_NUM_PINGS, [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ping.rs:106:60 [INFO] [stderr] | [INFO] [stderr] 106 | let time = (dur.as_secs() * 1000) as f64 + dur.subsec_nanos() as f64 / 1e6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dur.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.61s [INFO] running `"docker" "inspect" "75b4cc66060a072f8877e038457c5d883f0e834fba8a523f4b94e8c82e28ef8b"` [INFO] running `"docker" "rm" "-f" "75b4cc66060a072f8877e038457c5d883f0e834fba8a523f4b94e8c82e28ef8b"` [INFO] [stdout] 75b4cc66060a072f8877e038457c5d883f0e834fba8a523f4b94e8c82e28ef8b