[INFO] crate libhoney 0.0.5 is already in cache [INFO] extracting crate libhoney 0.0.5 into work/ex/clippy-test-run/sources/stable/reg/libhoney/0.0.5 [INFO] extracting crate libhoney 0.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libhoney/0.0.5 [INFO] validating manifest of libhoney-0.0.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libhoney-0.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libhoney-0.0.5 [INFO] finished frobbing libhoney-0.0.5 [INFO] frobbed toml for libhoney-0.0.5 written to work/ex/clippy-test-run/sources/stable/reg/libhoney/0.0.5/Cargo.toml [INFO] started frobbing libhoney-0.0.5 [INFO] finished frobbing libhoney-0.0.5 [INFO] frobbed toml for libhoney-0.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libhoney/0.0.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libhoney-0.0.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libhoney/0.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 150745b8696614c01df00a09162c6712bd327a0d686b9d18045bdcfeb0e15c20 [INFO] running `"docker" "start" "-a" "150745b8696614c01df00a09162c6712bd327a0d686b9d18045bdcfeb0e15c20"` [INFO] [stderr] Checking libhoney v0.0.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | transmission: transmission, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transmission` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | transmission: transmission, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transmission` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | transmission: transmission, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transmission` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | transmission: transmission, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transmission` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] extern crate serde_json; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/transmission.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/event.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return event; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `event` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/builder.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / return Builder{ [INFO] [stderr] 24 | | transmission: transmission, [INFO] [stderr] 25 | | fields: HashMap::new(), [INFO] [stderr] 26 | | dynamic_fields: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 29 | | dataset: "".to_string(), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 23 | Builder{ [INFO] [stderr] 24 | transmission: transmission, [INFO] [stderr] 25 | fields: HashMap::new(), [INFO] [stderr] 26 | dynamic_fields: HashMap::new(), [INFO] [stderr] 27 | api_host: "".to_string(), [INFO] [stderr] 28 | write_key: "".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/builder.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return builder; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] extern crate serde_json; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/transmission.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/event.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return event; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `event` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/builder.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / return Builder{ [INFO] [stderr] 24 | | transmission: transmission, [INFO] [stderr] 25 | | fields: HashMap::new(), [INFO] [stderr] 26 | | dynamic_fields: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 29 | | dataset: "".to_string(), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 23 | Builder{ [INFO] [stderr] 24 | transmission: transmission, [INFO] [stderr] 25 | fields: HashMap::new(), [INFO] [stderr] 26 | dynamic_fields: HashMap::new(), [INFO] [stderr] 27 | api_host: "".to_string(), [INFO] [stderr] 28 | write_key: "".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/builder.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return builder; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `transmission::Transmission` [INFO] [stderr] --> src/transmission.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> Transmission { [INFO] [stderr] 36 | | let core = Core::new().unwrap(); [INFO] [stderr] 37 | | let handle = core.handle(); [INFO] [stderr] 38 | | let client = Client::configure() [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | impl Default for transmission::Transmission { [INFO] [stderr] 35 | fn default() -> Self { [INFO] [stderr] 36 | Self::new() [INFO] [stderr] 37 | } [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `libhoney::Libhoney` [INFO] [stderr] --> src/libhoney.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Libhoney { [INFO] [stderr] 19 | | Config::default().build() [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | impl Default for libhoney::Libhoney { [INFO] [stderr] 18 | fn default() -> Self { [INFO] [stderr] 19 | Self::new() [INFO] [stderr] 20 | } [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/builder.rs:48:52 [INFO] [stderr] | [INFO] [stderr] 48 | builder.add_dynamic_field(key.clone(), value.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `transmission::Transmission` [INFO] [stderr] --> src/transmission.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> Transmission { [INFO] [stderr] 36 | | let core = Core::new().unwrap(); [INFO] [stderr] 37 | | let handle = core.handle(); [INFO] [stderr] 38 | | let client = Client::configure() [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | impl Default for transmission::Transmission { [INFO] [stderr] 35 | fn default() -> Self { [INFO] [stderr] 36 | Self::new() [INFO] [stderr] 37 | } [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `libhoney::Libhoney` [INFO] [stderr] --> src/libhoney.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Libhoney { [INFO] [stderr] 19 | | Config::default().build() [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | impl Default for libhoney::Libhoney { [INFO] [stderr] 18 | fn default() -> Self { [INFO] [stderr] 19 | Self::new() [INFO] [stderr] 20 | } [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/builder.rs:48:52 [INFO] [stderr] | [INFO] [stderr] 48 | builder.add_dynamic_field(key.clone(), value.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.68s [INFO] running `"docker" "inspect" "150745b8696614c01df00a09162c6712bd327a0d686b9d18045bdcfeb0e15c20"` [INFO] running `"docker" "rm" "-f" "150745b8696614c01df00a09162c6712bd327a0d686b9d18045bdcfeb0e15c20"` [INFO] [stdout] 150745b8696614c01df00a09162c6712bd327a0d686b9d18045bdcfeb0e15c20