[INFO] crate libgitdit 0.4.0 is already in cache
[INFO] extracting crate libgitdit 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/libgitdit/0.4.0
[INFO] extracting crate libgitdit 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libgitdit/0.4.0
[INFO] validating manifest of libgitdit-0.4.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of libgitdit-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing libgitdit-0.4.0
[INFO] finished frobbing libgitdit-0.4.0
[INFO] frobbed toml for libgitdit-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/libgitdit/0.4.0/Cargo.toml
[INFO] started frobbing libgitdit-0.4.0
[INFO] finished frobbing libgitdit-0.4.0
[INFO] frobbed toml for libgitdit-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libgitdit/0.4.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting libgitdit-0.4.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libgitdit/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] bf214ec804c3d8bcde484662388c86423e58d0ef783ac1d17446700c661e1a11
[INFO] running `"docker" "start" "-a" "bf214ec804c3d8bcde484662388c86423e58d0ef783ac1d17446700c661e1a11"`
[INFO] [stderr]     Checking libgitdit v0.4.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/gc.rs:73:13
[INFO] [stderr]    |
[INFO] [stderr] 73 |             repo: repo,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `repo`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/issue.rs:123:32
[INFO] [stderr]     |
[INFO] [stderr] 123 |             .map(|obj| Issue { repo: repo, obj: obj })
[INFO] [stderr]     |                                ^^^^^^^^^^ help: replace it with: `repo`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/issue.rs:123:44
[INFO] [stderr]     |
[INFO] [stderr] 123 |             .map(|obj| Issue { repo: repo, obj: obj })
[INFO] [stderr]     |                                            ^^^^^^^^ help: replace it with: `obj`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/iter.rs:41:32
[INFO] [stderr]    |
[INFO] [stderr] 41 |         HeadRefsToIssuesIter { inner: inner, repo: repo }
[INFO] [stderr]    |                                ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/iter.rs:41:46
[INFO] [stderr]    |
[INFO] [stderr] 41 |         HeadRefsToIssuesIter { inner: inner, repo: repo }
[INFO] [stderr]    |                                              ^^^^^^^^^^ help: replace it with: `repo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/iter.rs:75:20
[INFO] [stderr]    |
[INFO] [stderr] 75 |         Messages { revwalk: revwalk, repo: repo }
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^ help: replace it with: `revwalk`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/iter.rs:75:38
[INFO] [stderr]    |
[INFO] [stderr] 75 |         Messages { revwalk: revwalk, repo: repo }
[INFO] [stderr]    |                                      ^^^^^^^^^^ help: replace it with: `repo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/message/block.rs:154:13
[INFO] [stderr]     |
[INFO] [stderr] 154 |             blocks: blocks,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `blocks`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/trailer/accumulation.rs:173:29
[INFO] [stderr]     |
[INFO] [stderr] 173 |         SingleAccumulator { key: key, acc: ValueAccumulator::from(policy) }
[INFO] [stderr]     |                             ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/trailer/accumulation.rs:216:44
[INFO] [stderr]     |
[INFO] [stderr] 216 |         SingleKeyTrailerAssemblyIterator { key: key, inner: inner }
[INFO] [stderr]     |                                            ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/trailer/accumulation.rs:216:54
[INFO] [stderr]     |
[INFO] [stderr] 216 |         SingleKeyTrailerAssemblyIterator { key: key, inner: inner }
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/trailer/filter.rs:70:16
[INFO] [stderr]    |
[INFO] [stderr] 70 |         Self { trailer: trailer, matcher: matcher }
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^ help: replace it with: `trailer`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/trailer/filter.rs:70:34
[INFO] [stderr]    |
[INFO] [stderr] 70 |         Self { trailer: trailer, matcher: matcher }
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^ help: replace it with: `matcher`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/test_utils.rs:47:23
[INFO] [stderr]    |
[INFO] [stderr] 47 |         TestingRepo { repo: repo }
[INFO] [stderr]    |                       ^^^^^^^^^^ help: replace it with: `repo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/gc.rs:73:13
[INFO] [stderr]    |
[INFO] [stderr] 73 |             repo: repo,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `repo`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/issue.rs:123:32
[INFO] [stderr]     |
[INFO] [stderr] 123 |             .map(|obj| Issue { repo: repo, obj: obj })
[INFO] [stderr]     |                                ^^^^^^^^^^ help: replace it with: `repo`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/issue.rs:123:44
[INFO] [stderr]     |
[INFO] [stderr] 123 |             .map(|obj| Issue { repo: repo, obj: obj })
[INFO] [stderr]     |                                            ^^^^^^^^ help: replace it with: `obj`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/iter.rs:41:32
[INFO] [stderr]    |
[INFO] [stderr] 41 |         HeadRefsToIssuesIter { inner: inner, repo: repo }
[INFO] [stderr]    |                                ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/iter.rs:41:46
[INFO] [stderr]    |
[INFO] [stderr] 41 |         HeadRefsToIssuesIter { inner: inner, repo: repo }
[INFO] [stderr]    |                                              ^^^^^^^^^^ help: replace it with: `repo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/iter.rs:75:20
[INFO] [stderr]    |
[INFO] [stderr] 75 |         Messages { revwalk: revwalk, repo: repo }
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^ help: replace it with: `revwalk`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/iter.rs:75:38
[INFO] [stderr]    |
[INFO] [stderr] 75 |         Messages { revwalk: revwalk, repo: repo }
[INFO] [stderr]    |                                      ^^^^^^^^^^ help: replace it with: `repo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/message/block.rs:154:13
[INFO] [stderr]     |
[INFO] [stderr] 154 |             blocks: blocks,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `blocks`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/trailer/accumulation.rs:173:29
[INFO] [stderr]     |
[INFO] [stderr] 173 |         SingleAccumulator { key: key, acc: ValueAccumulator::from(policy) }
[INFO] [stderr]     |                             ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/trailer/accumulation.rs:216:44
[INFO] [stderr]     |
[INFO] [stderr] 216 |         SingleKeyTrailerAssemblyIterator { key: key, inner: inner }
[INFO] [stderr]     |                                            ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/trailer/accumulation.rs:216:54
[INFO] [stderr]     |
[INFO] [stderr] 216 |         SingleKeyTrailerAssemblyIterator { key: key, inner: inner }
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/trailer/filter.rs:70:16
[INFO] [stderr]    |
[INFO] [stderr] 70 |         Self { trailer: trailer, matcher: matcher }
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^ help: replace it with: `trailer`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/trailer/filter.rs:70:34
[INFO] [stderr]    |
[INFO] [stderr] 70 |         Self { trailer: trailer, matcher: matcher }
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^ help: replace it with: `matcher`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant
[INFO] [stderr]    --> src/gc.rs:124:13
[INFO] [stderr]     |
[INFO] [stderr] 124 | /             if let Some(local_head) = issue.local_head().ok() {
[INFO] [stderr] 125 | |                 // Its ok to ignore failures to retrieve the local head. It will
[INFO] [stderr] 126 | |                 // not be present in user's repositories anyway.
[INFO] [stderr] 127 | |                 messages.push(
[INFO] [stderr] ...   |
[INFO] [stderr] 158 | |                 referring_refs.collect_result_into(&mut retval)?;
[INFO] [stderr] 159 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::if_let_some_result)] on by default
[INFO] [stderr]     = help: Consider matching on `Ok(local_head)` and removing the call to `ok` instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/issue.rs:98:21
[INFO] [stderr]     |
[INFO] [stderr] 98  |           f.write_str(match self {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 99  | |             &IssueRefType::Any   => "Any ref",
[INFO] [stderr] 100 | |             &IssueRefType::Head  => "Head ref",
[INFO] [stderr] 101 | |             &IssueRefType::Leaf  => "Leaf ref",
[INFO] [stderr] 102 | |         })
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 98  |         f.write_str(match *self {
[INFO] [stderr] 99  |             IssueRefType::Any   => "Any ref",
[INFO] [stderr] 100 |             IssueRefType::Head  => "Head ref",
[INFO] [stderr] 101 |             IssueRefType::Leaf  => "Leaf ref",
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unused label `'refill`
[INFO] [stderr]    --> src/iter.rs:261:13
[INFO] [stderr]     |
[INFO] [stderr] 261 | /             'refill: for item in &mut self.inner {
[INFO] [stderr] 262 | |                 match item.chain_err(|| EK::CannotGetCommit) {
[INFO] [stderr] 263 | |                     Ok(id) => if let Some(new_refs) = self.refs.remove(&id) {
[INFO] [stderr] 264 | |                         // NOTE: should new_refs be empty, we just loop once
[INFO] [stderr] ...   |
[INFO] [stderr] 270 | |                 }
[INFO] [stderr] 271 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_label)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/message/block.rs:90:36
[INFO] [stderr]    |
[INFO] [stderr] 90 |             if trimmed.starts_with(" ") {
[INFO] [stderr]    |                                    ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/message/line_processor.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 | /             match line.is_empty() {
[INFO] [stderr] 44 | |                 true  => String::from(">"),
[INFO] [stderr] 45 | |                 false => format!("> {}", line),
[INFO] [stderr] 46 | |             }
[INFO] [stderr]    | |_____________^ help: consider using an if/else expression: `if line.is_empty() { String::from(">") } else { format!("> {}", line) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/message/line_processor.rs:139:43
[INFO] [stderr]     |
[INFO] [stderr] 139 |             if !next.as_ref().starts_with("#") {
[INFO] [stderr]     |                                           ^^^ help: try using a char instead: `'#'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/message/line_processor.rs:181:13
[INFO] [stderr]     |
[INFO] [stderr] 181 |             self.blanks = self.blanks - 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.blanks -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/message/line_processor.rs:198:13
[INFO] [stderr]     |
[INFO] [stderr] 198 |             self.blanks = self.blanks + 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.blanks += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/message/line_processor.rs:204:13
[INFO] [stderr]     |
[INFO] [stderr] 204 |             self.blanks = self.blanks - 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.blanks -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/message/mod.rs:97:29
[INFO] [stderr]    |
[INFO] [stderr] 97 |         if try!(self.next().ok_or(Error::from_kind(EK::EmptyMessage))).as_ref().is_empty() {
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from_kind(EK::EmptyMessage))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/repository.rs:134:46
[INFO] [stderr]     |
[INFO] [stderr] 134 |             .and_then(|name| name.rsplitn(3, "/").nth(1))
[INFO] [stderr]     |                                              ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/trailer/accumulation.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 | /         match self {
[INFO] [stderr] 50 | |             &mut ValueAccumulator::Latest(ref mut value) => if value.is_none() {
[INFO] [stderr] 51 | |                 *value = Some(new_value);
[INFO] [stderr] 52 | |             },
[INFO] [stderr] 53 | |             &mut ValueAccumulator::List(ref mut values)  => values.push(new_value),
[INFO] [stderr] 54 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 49 |         match *self {
[INFO] [stderr] 50 |             ValueAccumulator::Latest(ref mut value) => if value.is_none() {
[INFO] [stderr] 51 |                 *value = Some(new_value);
[INFO] [stderr] 52 |             },
[INFO] [stderr] 53 |             ValueAccumulator::List(ref mut values)  => values.push(new_value),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/trailer/accumulation.rs:131:9
[INFO] [stderr]     |
[INFO] [stderr] 131 |            self.get_mut(key.as_ref())
[INFO] [stderr]     |   _________^
[INFO] [stderr]     |  |_________|
[INFO] [stderr]     | ||
[INFO] [stderr] 132 | ||             .map(|ref mut acc| acc.process(value));
[INFO] [stderr]     | ||__________________________________________________^- help: try this: `if let Some(ref mut acc) = self.get_mut(key.as_ref()) { acc.process(value) }`
[INFO] [stderr]     | |___________________________________________________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/trailer/filter.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 | /         match self {
[INFO] [stderr] 42 | |             &ValueMatcher::Any             => true,
[INFO] [stderr] 43 | |             &ValueMatcher::Equals(ref v)   => value == v,
[INFO] [stderr] 44 | |             &ValueMatcher::Contains(ref s) => value.to_string().contains(s),
[INFO] [stderr] 45 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 41 |         match *self {
[INFO] [stderr] 42 |             ValueMatcher::Any             => true,
[INFO] [stderr] 43 |             ValueMatcher::Equals(ref v)   => value == v,
[INFO] [stderr] 44 |             ValueMatcher::Contains(ref s) => value.to_string().contains(s),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/trailer/filter.rs:80:20
[INFO] [stderr]    |
[INFO] [stderr] 80 |     pub fn matches<'b>(&self, accumulator: &::std::collections::HashMap<String, ValueAccumulator>) -> bool {
[INFO] [stderr]    |                    ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/trailer/mod.rs:95:9
[INFO] [stderr]    |
[INFO] [stderr] 95 | /         match self {
[INFO] [stderr] 96 | |             &mut TrailerValue::Int(i)    => *self = TrailerValue::String(i.to_string() + slice),
[INFO] [stderr] 97 | |             &mut TrailerValue::String(ref mut s) => s.push_str(slice),
[INFO] [stderr] 98 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 95 |         match *self {
[INFO] [stderr] 96 |             TrailerValue::Int(i)    => *self = TrailerValue::String(i.to_string() + slice),
[INFO] [stderr] 97 |             TrailerValue::String(ref mut s) => s.push_str(slice),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant
[INFO] [stderr]    --> src/gc.rs:124:13
[INFO] [stderr]     |
[INFO] [stderr] 124 | /             if let Some(local_head) = issue.local_head().ok() {
[INFO] [stderr] 125 | |                 // Its ok to ignore failures to retrieve the local head. It will
[INFO] [stderr] 126 | |                 // not be present in user's repositories anyway.
[INFO] [stderr] 127 | |                 messages.push(
[INFO] [stderr] ...   |
[INFO] [stderr] 158 | |                 referring_refs.collect_result_into(&mut retval)?;
[INFO] [stderr] 159 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::if_let_some_result)] on by default
[INFO] [stderr]     = help: Consider matching on `Ok(local_head)` and removing the call to `ok` instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/issue.rs:98:21
[INFO] [stderr]     |
[INFO] [stderr] 98  |           f.write_str(match self {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 99  | |             &IssueRefType::Any   => "Any ref",
[INFO] [stderr] 100 | |             &IssueRefType::Head  => "Head ref",
[INFO] [stderr] 101 | |             &IssueRefType::Leaf  => "Leaf ref",
[INFO] [stderr] 102 | |         })
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 98  |         f.write_str(match *self {
[INFO] [stderr] 99  |             IssueRefType::Any   => "Any ref",
[INFO] [stderr] 100 |             IssueRefType::Head  => "Head ref",
[INFO] [stderr] 101 |             IssueRefType::Leaf  => "Leaf ref",
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unused label `'refill`
[INFO] [stderr]    --> src/iter.rs:261:13
[INFO] [stderr]     |
[INFO] [stderr] 261 | /             'refill: for item in &mut self.inner {
[INFO] [stderr] 262 | |                 match item.chain_err(|| EK::CannotGetCommit) {
[INFO] [stderr] 263 | |                     Ok(id) => if let Some(new_refs) = self.refs.remove(&id) {
[INFO] [stderr] 264 | |                         // NOTE: should new_refs be empty, we just loop once
[INFO] [stderr] ...   |
[INFO] [stderr] 270 | |                 }
[INFO] [stderr] 271 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_label)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/message/block.rs:90:36
[INFO] [stderr]    |
[INFO] [stderr] 90 |             if trimmed.starts_with(" ") {
[INFO] [stderr]    |                                    ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/message/line_processor.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 | /             match line.is_empty() {
[INFO] [stderr] 44 | |                 true  => String::from(">"),
[INFO] [stderr] 45 | |                 false => format!("> {}", line),
[INFO] [stderr] 46 | |             }
[INFO] [stderr]    | |_____________^ help: consider using an if/else expression: `if line.is_empty() { String::from(">") } else { format!("> {}", line) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/message/line_processor.rs:139:43
[INFO] [stderr]     |
[INFO] [stderr] 139 |             if !next.as_ref().starts_with("#") {
[INFO] [stderr]     |                                           ^^^ help: try using a char instead: `'#'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/message/line_processor.rs:181:13
[INFO] [stderr]     |
[INFO] [stderr] 181 |             self.blanks = self.blanks - 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.blanks -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/message/line_processor.rs:198:13
[INFO] [stderr]     |
[INFO] [stderr] 198 |             self.blanks = self.blanks + 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.blanks += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/message/line_processor.rs:204:13
[INFO] [stderr]     |
[INFO] [stderr] 204 |             self.blanks = self.blanks - 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.blanks -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/message/mod.rs:97:29
[INFO] [stderr]    |
[INFO] [stderr] 97 |         if try!(self.next().ok_or(Error::from_kind(EK::EmptyMessage))).as_ref().is_empty() {
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from_kind(EK::EmptyMessage))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/repository.rs:134:46
[INFO] [stderr]     |
[INFO] [stderr] 134 |             .and_then(|name| name.rsplitn(3, "/").nth(1))
[INFO] [stderr]     |                                              ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/trailer/accumulation.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 | /         match self {
[INFO] [stderr] 50 | |             &mut ValueAccumulator::Latest(ref mut value) => if value.is_none() {
[INFO] [stderr] 51 | |                 *value = Some(new_value);
[INFO] [stderr] 52 | |             },
[INFO] [stderr] 53 | |             &mut ValueAccumulator::List(ref mut values)  => values.push(new_value),
[INFO] [stderr] 54 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 49 |         match *self {
[INFO] [stderr] 50 |             ValueAccumulator::Latest(ref mut value) => if value.is_none() {
[INFO] [stderr] 51 |                 *value = Some(new_value);
[INFO] [stderr] 52 |             },
[INFO] [stderr] 53 |             ValueAccumulator::List(ref mut values)  => values.push(new_value),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/trailer/accumulation.rs:131:9
[INFO] [stderr]     |
[INFO] [stderr] 131 |            self.get_mut(key.as_ref())
[INFO] [stderr]     |   _________^
[INFO] [stderr]     |  |_________|
[INFO] [stderr]     | ||
[INFO] [stderr] 132 | ||             .map(|ref mut acc| acc.process(value));
[INFO] [stderr]     | ||__________________________________________________^- help: try this: `if let Some(ref mut acc) = self.get_mut(key.as_ref()) { acc.process(value) }`
[INFO] [stderr]     | |___________________________________________________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/trailer/filter.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 | /         match self {
[INFO] [stderr] 42 | |             &ValueMatcher::Any             => true,
[INFO] [stderr] 43 | |             &ValueMatcher::Equals(ref v)   => value == v,
[INFO] [stderr] 44 | |             &ValueMatcher::Contains(ref s) => value.to_string().contains(s),
[INFO] [stderr] 45 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 41 |         match *self {
[INFO] [stderr] 42 |             ValueMatcher::Any             => true,
[INFO] [stderr] 43 |             ValueMatcher::Equals(ref v)   => value == v,
[INFO] [stderr] 44 |             ValueMatcher::Contains(ref s) => value.to_string().contains(s),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/trailer/filter.rs:80:20
[INFO] [stderr]    |
[INFO] [stderr] 80 |     pub fn matches<'b>(&self, accumulator: &::std::collections::HashMap<String, ValueAccumulator>) -> bool {
[INFO] [stderr]    |                    ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/trailer/mod.rs:95:9
[INFO] [stderr]    |
[INFO] [stderr] 95 | /         match self {
[INFO] [stderr] 96 | |             &mut TrailerValue::Int(i)    => *self = TrailerValue::String(i.to_string() + slice),
[INFO] [stderr] 97 | |             &mut TrailerValue::String(ref mut s) => s.push_str(slice),
[INFO] [stderr] 98 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 95 |         match *self {
[INFO] [stderr] 96 |             TrailerValue::Int(i)    => *self = TrailerValue::String(i.to_string() + slice),
[INFO] [stderr] 97 |             TrailerValue::String(ref mut s) => s.push_str(slice),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.38s
[INFO] running `"docker" "inspect" "bf214ec804c3d8bcde484662388c86423e58d0ef783ac1d17446700c661e1a11"`
[INFO] running `"docker" "rm" "-f" "bf214ec804c3d8bcde484662388c86423e58d0ef783ac1d17446700c661e1a11"`
[INFO] [stdout] bf214ec804c3d8bcde484662388c86423e58d0ef783ac1d17446700c661e1a11