[INFO] crate libflo_dynamic_event 0.1.2 is already in cache [INFO] extracting crate libflo_dynamic_event 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/libflo_dynamic_event/0.1.2 [INFO] extracting crate libflo_dynamic_event 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libflo_dynamic_event/0.1.2 [INFO] validating manifest of libflo_dynamic_event-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libflo_dynamic_event-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libflo_dynamic_event-0.1.2 [INFO] removed path dependency libflo_module from libflo_dynamic_event-0.1.2 [INFO] finished frobbing libflo_dynamic_event-0.1.2 [INFO] frobbed toml for libflo_dynamic_event-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/libflo_dynamic_event/0.1.2/Cargo.toml [INFO] started frobbing libflo_dynamic_event-0.1.2 [INFO] removed path dependency libflo_module from libflo_dynamic_event-0.1.2 [INFO] finished frobbing libflo_dynamic_event-0.1.2 [INFO] frobbed toml for libflo_dynamic_event-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libflo_dynamic_event/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libflo_dynamic_event-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libflo_dynamic_event/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f2bc6a3a01f7b60b83635aeccc0ee3348b4bc354922ede05d4437ab94d015be8 [INFO] running `"docker" "start" "-a" "f2bc6a3a01f7b60b83635aeccc0ee3348b4bc354922ede05d4437ab94d015be8"` [INFO] [stderr] Compiling syntex_pos v0.44.0 [INFO] [stderr] Checking error-chain v0.7.2 [INFO] [stderr] Compiling syntex_errors v0.44.0 [INFO] [stderr] Compiling syntex_syntax v0.44.1 [INFO] [stderr] Compiling syntex v0.44.0 [INFO] [stderr] Compiling aster v0.27.0 [INFO] [stderr] Compiling quasi v0.20.1 [INFO] [stderr] Compiling serde_codegen_internals v0.8.9 [INFO] [stderr] Compiling quasi_codegen v0.20.0 [INFO] [stderr] Compiling serde_codegen v0.8.9 [INFO] [stderr] Compiling libflo_module v0.1.2 [INFO] [stderr] Compiling libflo_dynamic_event v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dynamic_event_mapper.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | dynamic_event_map: dynamic_event_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dynamic_event_map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/payload.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | dynamic_event_mapper: dynamic_event_mapper, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dynamic_event_mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dynamic_event_mapper.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | dynamic_event_map: dynamic_event_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dynamic_event_map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/payload.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | dynamic_event_mapper: dynamic_event_mapper, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dynamic_event_mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/libflo_dynamic_event-4bb17382e1e72b0c/out/serde_types.rs:213:40 [INFO] [stderr] | [INFO] [stderr] 213 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/libflo_dynamic_event-4bb17382e1e72b0c/out/serde_types.rs:213:50 [INFO] [stderr] | [INFO] [stderr] 213 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/libflo_dynamic_event-4bb17382e1e72b0c/out/serde_types.rs:26:56 [INFO] [stderr] | [INFO] [stderr] 26 | "DynamicEventSerde" , 0 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/libflo_dynamic_event-4bb17382e1e72b0c/out/serde_types.rs:67:62 [INFO] [stderr] | [INFO] [stderr] 67 | "DynamicEventMapperSerde" , 0 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> /opt/crater/target/debug/build/libflo_dynamic_event-4bb17382e1e72b0c/out/serde_types.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | &'a Vec>>) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/dynamic_event_mapper.rs:24:38 [INFO] [stderr] | [INFO] [stderr] 24 | Some(some) => Ok(some.clone()), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/load.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | module_name: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/load.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | *current_id = *current_id + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*current_id += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/load.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | if let Some(_) = inner_dynamic_event_map.insert(dynamic_event.clone(), dynamic_event_id) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 34 | | return Err(ErrorKind::DynamicEventLoadNameCollision(dynamic_event, module_name.clone()).into()); [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________- help: try this: `if inner_dynamic_event_map.insert(dynamic_event.clone(), dynamic_event_id).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the HashMap [INFO] [stderr] --> src/load.rs:49:65 [INFO] [stderr] | [INFO] [stderr] 49 | let mut pre_dynamic_event_map = module_mapper.get_raw_map().into_iter().map(|_| None).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/libflo_dynamic_event-4bb17382e1e72b0c/out/serde_types.rs:213:40 [INFO] [stderr] | [INFO] [stderr] 213 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/libflo_dynamic_event-4bb17382e1e72b0c/out/serde_types.rs:213:50 [INFO] [stderr] | [INFO] [stderr] 213 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/libflo_dynamic_event-4bb17382e1e72b0c/out/serde_types.rs:26:56 [INFO] [stderr] | [INFO] [stderr] 26 | "DynamicEventSerde" , 0 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/libflo_dynamic_event-4bb17382e1e72b0c/out/serde_types.rs:67:62 [INFO] [stderr] | [INFO] [stderr] 67 | "DynamicEventMapperSerde" , 0 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> /opt/crater/target/debug/build/libflo_dynamic_event-4bb17382e1e72b0c/out/serde_types.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | &'a Vec>>) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/dynamic_event_mapper.rs:24:38 [INFO] [stderr] | [INFO] [stderr] 24 | Some(some) => Ok(some.clone()), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/load.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | module_name: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/load.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | *current_id = *current_id + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*current_id += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/load.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | if let Some(_) = inner_dynamic_event_map.insert(dynamic_event.clone(), dynamic_event_id) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 34 | | return Err(ErrorKind::DynamicEventLoadNameCollision(dynamic_event, module_name.clone()).into()); [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________- help: try this: `if inner_dynamic_event_map.insert(dynamic_event.clone(), dynamic_event_id).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the HashMap [INFO] [stderr] --> src/load.rs:49:65 [INFO] [stderr] | [INFO] [stderr] 49 | let mut pre_dynamic_event_map = module_mapper.get_raw_map().into_iter().map(|_| None).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 11s [INFO] running `"docker" "inspect" "f2bc6a3a01f7b60b83635aeccc0ee3348b4bc354922ede05d4437ab94d015be8"` [INFO] running `"docker" "rm" "-f" "f2bc6a3a01f7b60b83635aeccc0ee3348b4bc354922ede05d4437ab94d015be8"` [INFO] [stdout] f2bc6a3a01f7b60b83635aeccc0ee3348b4bc354922ede05d4437ab94d015be8