[INFO] crate libflo_cmdline_host 0.1.2 is already in cache [INFO] extracting crate libflo_cmdline_host 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/libflo_cmdline_host/0.1.2 [INFO] extracting crate libflo_cmdline_host 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libflo_cmdline_host/0.1.2 [INFO] validating manifest of libflo_cmdline_host-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libflo_cmdline_host-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libflo_cmdline_host-0.1.2 [INFO] removed path dependency libflo from libflo_cmdline_host-0.1.2 [INFO] removed path dependency libflo_dynamic_event from libflo_cmdline_host-0.1.2 [INFO] removed path dependency libflo_event from libflo_cmdline_host-0.1.2 [INFO] removed path dependency libflo_func from libflo_cmdline_host-0.1.2 [INFO] removed path dependency libflo_module from libflo_cmdline_host-0.1.2 [INFO] finished frobbing libflo_cmdline_host-0.1.2 [INFO] frobbed toml for libflo_cmdline_host-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/libflo_cmdline_host/0.1.2/Cargo.toml [INFO] started frobbing libflo_cmdline_host-0.1.2 [INFO] removed path dependency libflo from libflo_cmdline_host-0.1.2 [INFO] removed path dependency libflo_dynamic_event from libflo_cmdline_host-0.1.2 [INFO] removed path dependency libflo_event from libflo_cmdline_host-0.1.2 [INFO] removed path dependency libflo_func from libflo_cmdline_host-0.1.2 [INFO] removed path dependency libflo_module from libflo_cmdline_host-0.1.2 [INFO] finished frobbing libflo_cmdline_host-0.1.2 [INFO] frobbed toml for libflo_cmdline_host-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libflo_cmdline_host/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libflo_cmdline_host-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libflo_cmdline_host/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 35dad8b32ece9ed8445ba097bf047b0172147a8cddc1b8c26b63d5d39dcf5e2d [INFO] running `"docker" "start" "-a" "35dad8b32ece9ed8445ba097bf047b0172147a8cddc1b8c26b63d5d39dcf5e2d"` [INFO] [stderr] Compiling sharedlib v6.0.0 [INFO] [stderr] Checking libflo_error v0.1.2 [INFO] [stderr] Compiling libflo_module v0.1.2 [INFO] [stderr] Compiling libflo_func v0.1.2 [INFO] [stderr] Compiling libflo_event v0.1.2 [INFO] [stderr] Compiling libflo_dynamic_event v0.1.2 [INFO] [stderr] Checking libflo v0.1.2 [INFO] [stderr] Checking libflo_cmdline_host v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/program.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | libflo: libflo, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `libflo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/program.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | error_stream: error_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/startup.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | payload: payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/startup.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | in_stream: in_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `in_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] --> src/backend/program.rs:26:13 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] 26 | libflo: libflo, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `libflo` [INFO] [stderr] --> src/backend/startup.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | out_stream: out_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/startup.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | error_stream: error_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/program.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | error_stream: error_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_stream` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/payload.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | dynamic_event_mapper: dynamic_event_mapper, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dynamic_event_mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/startup.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | payload: payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/startup.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | in_stream: in_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `in_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/startup.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | out_stream: out_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/startup.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | error_stream: error_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/payload.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | dynamic_event_mapper: dynamic_event_mapper, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dynamic_event_mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/payload.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | event_mapper: event_mapper, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/payload.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | func_mapper: func_mapper, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `func_mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/payload.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | module_mapper: module_mapper, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/payload.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | path_resolver: path_resolver, [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/payload.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | event_mapper: event_mapper, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/payload.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | func_mapper: func_mapper, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `func_mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/payload.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | module_mapper: module_mapper, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/payload.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | path_resolver: path_resolver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `path_resolver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test/util/clone_reader.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | CloneReader{ reader: reader } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test/util/clone_writer.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | CloneWriter{ writer: writer } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test/util/reading_end.rs:16:21 [INFO] [stderr] | [INFO] [stderr] 16 | ReadingEnd{ locking_stream: locking_stream, position: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `locking_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test/util/stream_pair_startup.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | startup: startup, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `startup` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test/util/stream_pair_startup.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | input_into_program: input_into_program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_into_program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test/util/stream_pair_startup.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | output_from_program: output_from_program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_from_program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test/util/writing_end.rs:17:21 [INFO] [stderr] | [INFO] [stderr] 17 | WritingEnd{ locking_stream: locking_stream, position: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `locking_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `path_resolver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/backend/program.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/backend/program.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/execute.rs:28:44 [INFO] [stderr] | [INFO] [stderr] 28 | func.call(Input::None).map_err(|err| Error::from(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/execute.rs:32:50 [INFO] [stderr] | [INFO] [stderr] 32 | match func.call(Input::None).map_err(|err| Error::from(err))? { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/execute.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | func.call(Input::String(arg)).map_err(|err| Error::from(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/execute.rs:43:57 [INFO] [stderr] | [INFO] [stderr] 43 | match func.call(Input::String(arg)).map_err(|err| Error::from(err))? { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/backend/execute.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | let mut words = words.into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `words` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/backend/execute.rs:66:70 [INFO] [stderr] | [INFO] [stderr] 66 | let arg = String::from_utf8(line.as_bytes()[1..].into_iter().cloned().collect())?; [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/program.rs:87:28 [INFO] [stderr] | [INFO] [stderr] 87 | result.map_err(|err| Error::from(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/backend/startup.rs:51:33 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn destructure(self) -> (Payload, Box, Box, Box) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/test/util/clone_reader.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn new(reader: T) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/execute.rs:28:44 [INFO] [stderr] | [INFO] [stderr] 28 | func.call(Input::None).map_err(|err| Error::from(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/execute.rs:32:50 [INFO] [stderr] | [INFO] [stderr] 32 | match func.call(Input::None).map_err(|err| Error::from(err))? { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/execute.rs:38:51 [INFO] [stderr] | [INFO] [stderr] 38 | func.call(Input::String(arg)).map_err(|err| Error::from(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/execute.rs:43:57 [INFO] [stderr] | [INFO] [stderr] 43 | match func.call(Input::String(arg)).map_err(|err| Error::from(err))? { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/backend/execute.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | let mut words = words.into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `words` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/backend/execute.rs:66:70 [INFO] [stderr] | [INFO] [stderr] 66 | let arg = String::from_utf8(line.as_bytes()[1..].into_iter().cloned().collect())?; [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/program.rs:87:28 [INFO] [stderr] | [INFO] [stderr] 87 | result.map_err(|err| Error::from(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/backend/startup.rs:51:33 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn destructure(self) -> (Payload, Box, Box, Box) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/test/util/stream_pair.rs:20:20 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn to_pair(self) -> (ReadingEnd, WritingEnd) { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.68s [INFO] running `"docker" "inspect" "35dad8b32ece9ed8445ba097bf047b0172147a8cddc1b8c26b63d5d39dcf5e2d"` [INFO] running `"docker" "rm" "-f" "35dad8b32ece9ed8445ba097bf047b0172147a8cddc1b8c26b63d5d39dcf5e2d"` [INFO] [stdout] 35dad8b32ece9ed8445ba097bf047b0172147a8cddc1b8c26b63d5d39dcf5e2d