[INFO] crate libflo_action_util 0.1.0 is already in cache [INFO] extracting crate libflo_action_util 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/libflo_action_util/0.1.0 [INFO] extracting crate libflo_action_util 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libflo_action_util/0.1.0 [INFO] validating manifest of libflo_action_util-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libflo_action_util-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libflo_action_util-0.1.0 [INFO] removed path dependency libflo from libflo_action_util-0.1.0 [INFO] removed path dependency libflo_module from libflo_action_util-0.1.0 [INFO] removed path dependency number_or_string from libflo_action_util-0.1.0 [INFO] finished frobbing libflo_action_util-0.1.0 [INFO] frobbed toml for libflo_action_util-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/libflo_action_util/0.1.0/Cargo.toml [INFO] started frobbing libflo_action_util-0.1.0 [INFO] removed path dependency libflo from libflo_action_util-0.1.0 [INFO] removed path dependency libflo_module from libflo_action_util-0.1.0 [INFO] removed path dependency number_or_string from libflo_action_util-0.1.0 [INFO] finished frobbing libflo_action_util-0.1.0 [INFO] frobbed toml for libflo_action_util-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libflo_action_util/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libflo_action_util-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libflo_action_util/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e3e70e3c6a99c14909ee0e97171e4ea99330145e54e47623e787b5671fb8006f [INFO] running `"docker" "start" "-a" "e3e70e3c6a99c14909ee0e97171e4ea99330145e54e47623e787b5671fb8006f"` [INFO] [stderr] Compiling sharedlib v6.0.0 [INFO] [stderr] Compiling syntex_syntax v0.44.1 [INFO] [stderr] Checking libflo_error v0.1.2 [INFO] [stderr] Checking number_or_string v0.1.1 [INFO] [stderr] Compiling aster v0.27.0 [INFO] [stderr] Compiling syntex v0.44.0 [INFO] [stderr] Compiling serde_codegen_internals v0.8.9 [INFO] [stderr] Compiling quasi v0.20.1 [INFO] [stderr] Compiling quasi_codegen v0.20.0 [INFO] [stderr] Compiling serde_codegen v0.8.9 [INFO] [stderr] Compiling libflo_module v0.1.2 [INFO] [stderr] Compiling libflo_func v0.1.2 [INFO] [stderr] Compiling libflo_event v0.1.2 [INFO] [stderr] Compiling libflo_dynamic_event v0.1.2 [INFO] [stderr] Compiling libflo_action_util v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking libflo v0.1.2 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/action_mapper.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | action_map: action_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `action_map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ext_action_mapper.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | action_mapper: action_mapper, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `action_mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ext_action_mapper.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | module_mapper: module_mapper [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/action_mapper.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | action_map: action_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `action_map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ext_action_mapper.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | action_mapper: action_mapper, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `action_mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ext_action_mapper.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | module_mapper: module_mapper [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_mapper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/libflo_action_util-3e3f6deaa62beb85/out/serde_types.rs:18:56 [INFO] [stderr] | [INFO] [stderr] 18 | "ActionMapperSerde" , 0 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> /opt/crater/target/debug/build/libflo_action_util-3e3f6deaa62beb85/out/serde_types.rs:30:36 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn new(action_map: &'a Vec>>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/action_mapper.rs:25:38 [INFO] [stderr] | [INFO] [stderr] 25 | Some(some) => Ok(some.clone()), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ext_action_mapper.rs:24:70 [INFO] [stderr] | [INFO] [stderr] 24 | self.action_mapper.get(module_id, action_name).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/libflo_action_util-3e3f6deaa62beb85/out/serde_types.rs:18:56 [INFO] [stderr] | [INFO] [stderr] 18 | "ActionMapperSerde" , 0 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> /opt/crater/target/debug/build/libflo_action_util-3e3f6deaa62beb85/out/serde_types.rs:30:36 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn new(action_map: &'a Vec>>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/action_mapper.rs:25:38 [INFO] [stderr] | [INFO] [stderr] 25 | Some(some) => Ok(some.clone()), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/ext_action_mapper.rs:24:70 [INFO] [stderr] | [INFO] [stderr] 24 | self.action_mapper.get(module_id, action_name).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 05s [INFO] running `"docker" "inspect" "e3e70e3c6a99c14909ee0e97171e4ea99330145e54e47623e787b5671fb8006f"` [INFO] running `"docker" "rm" "-f" "e3e70e3c6a99c14909ee0e97171e4ea99330145e54e47623e787b5671fb8006f"` [INFO] [stdout] e3e70e3c6a99c14909ee0e97171e4ea99330145e54e47623e787b5671fb8006f