[INFO] crate libflate 0.1.19 is already in cache [INFO] extracting crate libflate 0.1.19 into work/ex/clippy-test-run/sources/stable/reg/libflate/0.1.19 [INFO] extracting crate libflate 0.1.19 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libflate/0.1.19 [INFO] validating manifest of libflate-0.1.19 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libflate-0.1.19 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libflate-0.1.19 [INFO] finished frobbing libflate-0.1.19 [INFO] frobbed toml for libflate-0.1.19 written to work/ex/clippy-test-run/sources/stable/reg/libflate/0.1.19/Cargo.toml [INFO] started frobbing libflate-0.1.19 [INFO] finished frobbing libflate-0.1.19 [INFO] frobbed toml for libflate-0.1.19 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libflate/0.1.19/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libflate-0.1.19 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libflate/0.1.19:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8066994d7154720130ab6eca6f60fa2108233f794c88dd1ae552332eea9020be [INFO] running `"docker" "start" "-a" "8066994d7154720130ab6eca6f60fa2108233f794c88dd1ae552332eea9020be"` [INFO] [stderr] Checking libflate v0.1.19 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:3:45 [INFO] [stderr] | [INFO] [stderr] 3 | #![cfg_attr(feature = "cargo-clippy", allow(inline_always))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:3:45 [INFO] [stderr] | [INFO] [stderr] 3 | #![cfg_attr(feature = "cargo-clippy", allow(inline_always))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:3:45 [INFO] [stderr] | [INFO] [stderr] 3 | #![cfg_attr(feature = "cargo-clippy", allow(inline_always))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:3:45 [INFO] [stderr] | [INFO] [stderr] 3 | #![cfg_attr(feature = "cargo-clippy", allow(inline_always))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/huffman.rs:327:56 [INFO] [stderr] | [INFO] [stderr] 327 | #[cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit.rs:186:31 [INFO] [stderr] | [INFO] [stderr] 186 | writer.write_bits(11, 0b10101011010).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b101_0101_1010` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit.rs:192:26 [INFO] [stderr] | [INFO] [stderr] 192 | assert_eq!(buf, [0b10100101, 0b01010101, 0b00000001]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit.rs:192:38 [INFO] [stderr] | [INFO] [stderr] 192 | assert_eq!(buf, [0b10100101, 0b01010101, 0b00000001]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0101_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit.rs:192:50 [INFO] [stderr] | [INFO] [stderr] 192 | assert_eq!(buf, [0b10100101, 0b01010101, 0b00000001]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit.rs:197:20 [INFO] [stderr] | [INFO] [stderr] 197 | let buf = [0b10100101, 0b11010101]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit.rs:197:32 [INFO] [stderr] | [INFO] [stderr] 197 | let buf = [0b10100101, 0b11010101]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1101_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit.rs:201:50 [INFO] [stderr] | [INFO] [stderr] 201 | assert_eq!(reader.read_bits(8).unwrap(), 0b01101001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0110_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/checksum.rs:49:35 [INFO] [stderr] | [INFO] [stderr] 49 | assert_eq!(crc32.value(), 0x8587D865); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8587_D865` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/checksum.rs:56:37 [INFO] [stderr] | [INFO] [stderr] 56 | assert_eq!(adler32.value(), 0x05C801F0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x05C8_01F0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/huffman.rs:327:56 [INFO] [stderr] | [INFO] [stderr] 327 | #[cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/deflate/mod.rs:47:25 [INFO] [stderr] | [INFO] [stderr] 47 | let plain = (0..lz77::MAX_DISTANCE as u32 * 32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(lz77::MAX_DISTANCE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/non_blocking/deflate/decode.rs:319:28 [INFO] [stderr] | [INFO] [stderr] 319 | let text: String = (0..10000) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 320 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..10000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/flate.rs:53:44 [INFO] [stderr] | [INFO] [stderr] 53 | fs::File::open(input_filename).expect(&format!("Can't open file: {}", input_filename)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can't open file: {}", input_filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> examples/flate.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | .expect(&format!("Can't create file: {}", output_filename)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can't create file: {}", output_filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.75s [INFO] running `"docker" "inspect" "8066994d7154720130ab6eca6f60fa2108233f794c88dd1ae552332eea9020be"` [INFO] running `"docker" "rm" "-f" "8066994d7154720130ab6eca6f60fa2108233f794c88dd1ae552332eea9020be"` [INFO] [stdout] 8066994d7154720130ab6eca6f60fa2108233f794c88dd1ae552332eea9020be