[INFO] crate libfastdl 0.1.0 is already in cache [INFO] extracting crate libfastdl 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/libfastdl/0.1.0 [INFO] extracting crate libfastdl 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libfastdl/0.1.0 [INFO] validating manifest of libfastdl-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libfastdl-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libfastdl-0.1.0 [INFO] finished frobbing libfastdl-0.1.0 [INFO] frobbed toml for libfastdl-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/libfastdl/0.1.0/Cargo.toml [INFO] started frobbing libfastdl-0.1.0 [INFO] finished frobbing libfastdl-0.1.0 [INFO] frobbed toml for libfastdl-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libfastdl/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libfastdl-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libfastdl/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e83c814dc067f5193595818154185a9e11b3fa3112358c5f6ae1069bca5bb295 [INFO] running `"docker" "start" "-a" "e83c814dc067f5193595818154185a9e11b3fa3112358c5f6ae1069bca5bb295"` [INFO] [stderr] Checking libfastdl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return Ok(func); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(func)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self.fn_map.get::(symbol) { [INFO] [stderr] 22 | | Some(func) => { [INFO] [stderr] 23 | | let func = transmute::<&libloading::Symbol<*const()>, &libloading::Symbol>(func); [INFO] [stderr] 24 | | return Ok(func); [INFO] [stderr] 25 | | }, [INFO] [stderr] 26 | | None => {} [INFO] [stderr] 27 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | if let Some(func) = self.fn_map.get::(symbol) { [INFO] [stderr] 22 | let func = transmute::<&libloading::Symbol<*const()>, &libloading::Symbol>(func); [INFO] [stderr] 23 | return Ok(func); [INFO] [stderr] 24 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:23:28 [INFO] [stderr] | [INFO] [stderr] 23 | let func = transmute::<&libloading::Symbol<*const()>, &libloading::Symbol>(func); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(func as *const libloading::Symbol<'_, *const ()> as *const libloading::Symbol<'a, T>)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:30:20 [INFO] [stderr] | [INFO] [stderr] 30 | let func = self.fn_map.get::(symbol).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.fn_map[symbol]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | let func = transmute::<&libloading::Symbol<*const()>, &libloading::Symbol>(func); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(func as *const libloading::Symbol<'_, *const ()> as *const libloading::Symbol<'a, T>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return Ok(func); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(func)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self.fn_map.get::(symbol) { [INFO] [stderr] 22 | | Some(func) => { [INFO] [stderr] 23 | | let func = transmute::<&libloading::Symbol<*const()>, &libloading::Symbol>(func); [INFO] [stderr] 24 | | return Ok(func); [INFO] [stderr] 25 | | }, [INFO] [stderr] 26 | | None => {} [INFO] [stderr] 27 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | if let Some(func) = self.fn_map.get::(symbol) { [INFO] [stderr] 22 | let func = transmute::<&libloading::Symbol<*const()>, &libloading::Symbol>(func); [INFO] [stderr] 23 | return Ok(func); [INFO] [stderr] 24 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:23:28 [INFO] [stderr] | [INFO] [stderr] 23 | let func = transmute::<&libloading::Symbol<*const()>, &libloading::Symbol>(func); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(func as *const libloading::Symbol<'_, *const ()> as *const libloading::Symbol<'a, T>)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:30:20 [INFO] [stderr] | [INFO] [stderr] 30 | let func = self.fn_map.get::(symbol).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.fn_map[symbol]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | let func = transmute::<&libloading::Symbol<*const()>, &libloading::Symbol>(func); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(func as *const libloading::Symbol<'_, *const ()> as *const libloading::Symbol<'a, T>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.95s [INFO] running `"docker" "inspect" "e83c814dc067f5193595818154185a9e11b3fa3112358c5f6ae1069bca5bb295"` [INFO] running `"docker" "rm" "-f" "e83c814dc067f5193595818154185a9e11b3fa3112358c5f6ae1069bca5bb295"` [INFO] [stdout] e83c814dc067f5193595818154185a9e11b3fa3112358c5f6ae1069bca5bb295