[INFO] crate libchisel 0.1.0 is already in cache
[INFO] extracting crate libchisel 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/libchisel/0.1.0
[INFO] extracting crate libchisel 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libchisel/0.1.0
[INFO] validating manifest of libchisel-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of libchisel-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing libchisel-0.1.0
[INFO] finished frobbing libchisel-0.1.0
[INFO] frobbed toml for libchisel-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/libchisel/0.1.0/Cargo.toml
[INFO] started frobbing libchisel-0.1.0
[INFO] finished frobbing libchisel-0.1.0
[INFO] frobbed toml for libchisel-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libchisel/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting libchisel-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libchisel/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2b5e7ce59519180e69756760d52a7961a418572044e9e138a3975bc3903fc77b
[INFO] running `"docker" "start" "-a" "2b5e7ce59519180e69756760d52a7961a418572044e9e138a3975bc3903fc77b"`
[INFO] [stderr]     Checking parity-wasm v0.21.1
[INFO] [stderr]     Checking libchisel v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `parity_wasm::builder::*`
[INFO] [stderr]  --> src/trimexports.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 | use parity_wasm::builder::*;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `thing`
[INFO] [stderr]   --> src/trimexports.rs:60:21
[INFO] [stderr]    |
[INFO] [stderr] 60 |         if let Some(thing) = self.entries.iter().find(|matched_export| {
[INFO] [stderr]    |                     ^^^^^ help: consider using `_thing` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `insert`
[INFO] [stderr]    --> src/remapimports.rs:127:5
[INFO] [stderr]     |
[INFO] [stderr] 127 |     fn insert(&mut self, from_module: &str, from_field: &str, to_module: &str, to_field: &str) {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `remapimports::RemapImports`
[INFO] [stderr]    --> src/remapimports.rs:152:5
[INFO] [stderr]     |
[INFO] [stderr] 152 | /     pub fn new() -> Self {
[INFO] [stderr] 153 | |         RemapImports {
[INFO] [stderr] 154 | |             translations: Translations::ewasm(),
[INFO] [stderr] 155 | |         }
[INFO] [stderr] 156 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 147 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/remapimports.rs:168:9
[INFO] [stderr]     |
[INFO] [stderr] 168 | /         if let &mut Section::Import(ref mut import_section) = section {
[INFO] [stderr] 169 | |             return Some(import_section);
[INFO] [stderr] 170 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 168 |         if let Section::Import(ref mut import_section) = *section {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/trimexports.rs:18:28
[INFO] [stderr]    |
[INFO] [stderr] 18 | fn cmp_internal_variant(a: &Internal, b: &Internal) -> bool {
[INFO] [stderr]    |                            ^^^^^^^^^ help: consider passing by value instead: `Internal`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/trimexports.rs:18:42
[INFO] [stderr]    |
[INFO] [stderr] 18 | fn cmp_internal_variant(a: &Internal, b: &Internal) -> bool {
[INFO] [stderr]    |                                          ^^^^^^^^^ help: consider passing by value instead: `Internal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/trimexports.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 | /         if let &mut Section::Export(ref mut export_section) = section {
[INFO] [stderr] 26 | |             return Some(export_section);
[INFO] [stderr] 27 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 25 |         if let Section::Export(ref mut export_section) = *section {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `ImportPair`
[INFO] [stderr]    --> src/remapimports.rs:196:33
[INFO] [stderr]     |
[INFO] [stderr] 196 |     use super::{rename_imports, ImportPair, Translations};
[INFO] [stderr]     |                                 ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::collections::HashMap`
[INFO] [stderr]    --> src/remapimports.rs:199:9
[INFO] [stderr]     |
[INFO] [stderr] 199 |     use std::collections::HashMap;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `parity_wasm::builder::*`
[INFO] [stderr]  --> src/trimexports.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 | use parity_wasm::builder::*;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/lib.rs:37:16
[INFO] [stderr]    |
[INFO] [stderr] 37 |             Ok((true))
[INFO] [stderr]    |                ^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/lib.rs:37:16
[INFO] [stderr]    |
[INFO] [stderr] 37 |             Ok((true))
[INFO] [stderr]    |                ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `thing`
[INFO] [stderr]   --> src/trimexports.rs:60:21
[INFO] [stderr]    |
[INFO] [stderr] 60 |         if let Some(thing) = self.entries.iter().find(|matched_export| {
[INFO] [stderr]    |                     ^^^^^ help: consider using `_thing` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `module`
[INFO] [stderr]   --> src/lib.rs:36:28
[INFO] [stderr]    |
[INFO] [stderr] 36 |         fn translate(self, module: &mut Module) -> Result<bool, String> {
[INFO] [stderr]    |                            ^^^^^^ help: consider using `_module` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `module`
[INFO] [stderr]   --> src/lib.rs:42:27
[INFO] [stderr]    |
[INFO] [stderr] 42 |         fn validate(self, module: &Module) -> Result<bool, String> {
[INFO] [stderr]    |                           ^^^^^^ help: consider using `_module` instead
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `insert`
[INFO] [stderr]    --> src/remapimports.rs:127:5
[INFO] [stderr]     |
[INFO] [stderr] 127 |     fn insert(&mut self, from_module: &str, from_field: &str, to_module: &str, to_field: &str) {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `remapimports::RemapImports`
[INFO] [stderr]    --> src/remapimports.rs:152:5
[INFO] [stderr]     |
[INFO] [stderr] 152 | /     pub fn new() -> Self {
[INFO] [stderr] 153 | |         RemapImports {
[INFO] [stderr] 154 | |             translations: Translations::ewasm(),
[INFO] [stderr] 155 | |         }
[INFO] [stderr] 156 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 147 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/remapimports.rs:168:9
[INFO] [stderr]     |
[INFO] [stderr] 168 | /         if let &mut Section::Import(ref mut import_section) = section {
[INFO] [stderr] 169 | |             return Some(import_section);
[INFO] [stderr] 170 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 168 |         if let Section::Import(ref mut import_section) = *section {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/trimexports.rs:18:28
[INFO] [stderr]    |
[INFO] [stderr] 18 | fn cmp_internal_variant(a: &Internal, b: &Internal) -> bool {
[INFO] [stderr]    |                            ^^^^^^^^^ help: consider passing by value instead: `Internal`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/trimexports.rs:18:42
[INFO] [stderr]    |
[INFO] [stderr] 18 | fn cmp_internal_variant(a: &Internal, b: &Internal) -> bool {
[INFO] [stderr]    |                                          ^^^^^^^^^ help: consider passing by value instead: `Internal`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/trimexports.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 | /         if let &mut Section::Export(ref mut export_section) = section {
[INFO] [stderr] 26 | |             return Some(export_section);
[INFO] [stderr] 27 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 25 |         if let Section::Export(ref mut export_section) = *section {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.09s
[INFO] running `"docker" "inspect" "2b5e7ce59519180e69756760d52a7961a418572044e9e138a3975bc3903fc77b"`
[INFO] running `"docker" "rm" "-f" "2b5e7ce59519180e69756760d52a7961a418572044e9e138a3975bc3903fc77b"`
[INFO] [stdout] 2b5e7ce59519180e69756760d52a7961a418572044e9e138a3975bc3903fc77b