[INFO] crate libcantal 0.3.2 is already in cache [INFO] extracting crate libcantal 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/libcantal/0.3.2 [INFO] extracting crate libcantal 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libcantal/0.3.2 [INFO] validating manifest of libcantal-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libcantal-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libcantal-0.3.2 [INFO] finished frobbing libcantal-0.3.2 [INFO] frobbed toml for libcantal-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/libcantal/0.3.2/Cargo.toml [INFO] started frobbing libcantal-0.3.2 [INFO] finished frobbing libcantal-0.3.2 [INFO] frobbed toml for libcantal-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libcantal/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libcantal-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libcantal/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] df62a60a123c684e3899b4c41fcf4dcfe88a7f1d423d8b9f4c4f2d2fa25f0585 [INFO] running `"docker" "start" "-a" "df62a60a123c684e3899b4c41fcf4dcfe88a7f1d423d8b9f4c4f2d2fa25f0585"` [INFO] [stderr] Checking libcantal v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collection.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | meta_path: meta_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `meta_path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collection.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | values_path: values_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `values_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/collection.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | / write!(metadata_buf, "{main_type} {size}{space}{type_suffix}: {key}\n", [INFO] [stderr] 170 | | main_type=metric.raw_type.main_type(), [INFO] [stderr] 171 | | size=metric.size, [INFO] [stderr] 172 | | space=if metric.raw_type.type_suffix().is_some() { " " } else {""}, [INFO] [stderr] 173 | | type_suffix=metric.raw_type.type_suffix().unwrap_or(""), [INFO] [stderr] 174 | | key=metric.name) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | values_path: values_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `values_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collection.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | meta_path: meta_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `meta_path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/collection.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | values_path: values_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `values_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/collection.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | / write!(metadata_buf, "{main_type} {size}{space}{type_suffix}: {key}\n", [INFO] [stderr] 170 | | main_type=metric.raw_type.main_type(), [INFO] [stderr] 171 | | size=metric.size, [INFO] [stderr] 172 | | space=if metric.raw_type.type_suffix().is_some() { " " } else {""}, [INFO] [stderr] 173 | | type_suffix=metric.raw_type.type_suffix().unwrap_or(""), [INFO] [stderr] 174 | | key=metric.name) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | values_path: values_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `values_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/collection.rs:86:1 [INFO] [stderr] | [INFO] [stderr] 86 | / pub fn start<'x, T: Collection + ?Sized>(coll: &'x T) [INFO] [stderr] 87 | | -> Result, Error> [INFO] [stderr] 88 | | { [INFO] [stderr] 89 | | use std::os::unix::io::AsRawFd; [INFO] [stderr] ... | [INFO] [stderr] 190 | | Ok(result) [INFO] [stderr] 191 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/collection.rs:86:1 [INFO] [stderr] | [INFO] [stderr] 86 | / pub fn start<'x, T: Collection + ?Sized>(coll: &'x T) [INFO] [stderr] 87 | | -> Result, Error> [INFO] [stderr] 88 | | { [INFO] [stderr] 89 | | use std::os::unix::io::AsRawFd; [INFO] [stderr] ... | [INFO] [stderr] 190 | | Ok(result) [INFO] [stderr] 191 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/collection.rs:176:45 [INFO] [stderr] | [INFO] [stderr] 176 | metric.pointer.copy_assign(unsafe { ptr.offset(offset as isize) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/collection.rs:176:45 [INFO] [stderr] | [INFO] [stderr] 176 | metric.pointer.copy_assign(unsafe { ptr.offset(offset as isize) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/read.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn start_with_reading<'x, T: Collection + ?Sized>(coll: &'x T) [INFO] [stderr] 49 | | -> Result, Error> [INFO] [stderr] 50 | | { [INFO] [stderr] 51 | | match read_and_map(coll) { [INFO] [stderr] ... | [INFO] [stderr] 59 | | } [INFO] [stderr] 60 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/read.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | / fn read_and_map<'x, T: Collection + ?Sized>(coll: &'x T) [INFO] [stderr] 64 | | -> Result>, Error> [INFO] [stderr] 65 | | { [INFO] [stderr] 66 | | use std::os::unix::io::AsRawFd; [INFO] [stderr] ... | [INFO] [stderr] 186 | | Ok(Some(result)) [INFO] [stderr] 187 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/read.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn start_with_reading<'x, T: Collection + ?Sized>(coll: &'x T) [INFO] [stderr] 49 | | -> Result, Error> [INFO] [stderr] 50 | | { [INFO] [stderr] 51 | | match read_and_map(coll) { [INFO] [stderr] ... | [INFO] [stderr] 59 | | } [INFO] [stderr] 60 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/read.rs:63:1 [INFO] [stderr] | [INFO] [stderr] 63 | / fn read_and_map<'x, T: Collection + ?Sized>(coll: &'x T) [INFO] [stderr] 64 | | -> Result>, Error> [INFO] [stderr] 65 | | { [INFO] [stderr] 66 | | use std::os::unix::io::AsRawFd; [INFO] [stderr] ... | [INFO] [stderr] 186 | | Ok(Some(result)) [INFO] [stderr] 187 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/read.rs:140:39 [INFO] [stderr] | [INFO] [stderr] 140 | let mut pair = line.splitn(2, ":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/read.rs:176:21 [INFO] [stderr] | [INFO] [stderr] 176 | if extra > 0 || map.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!map.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `counter::Counter` [INFO] [stderr] --> src/counter.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> Counter { [INFO] [stderr] 25 | | let tmp = Box::new(Atomic::new(0)); [INFO] [stderr] 26 | | Counter { [INFO] [stderr] 27 | | pointer: unsafe { transmute(&*tmp) }, [INFO] [stderr] 28 | | value: tmp, [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/counter.rs:75:46 [INFO] [stderr] | [INFO] [stderr] 75 | let ptr: *mut Atomic = unsafe { transmute(ptr) }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `ptr as *mut atomic::Atomic` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/counter.rs:80:38 [INFO] [stderr] | [INFO] [stderr] 80 | self.pointer.store( unsafe { transmute(ptr) }, Ordering::SeqCst); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `ptr as *mut atomic::Atomic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/read.rs:140:39 [INFO] [stderr] | [INFO] [stderr] 140 | let mut pair = line.splitn(2, ":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/counter.rs:87:37 [INFO] [stderr] | [INFO] [stderr] 87 | self.pointer.store(unsafe { transmute(&*self.value) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*self.value as *const atomic::Atomic as *mut atomic::Atomic` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `integer::Integer` [INFO] [stderr] --> src/integer.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> Integer { [INFO] [stderr] 25 | | let tmp = Box::new(Atomic::new(0)); [INFO] [stderr] 26 | | Integer { [INFO] [stderr] 27 | | pointer: unsafe { transmute(&*tmp) }, [INFO] [stderr] 28 | | value: tmp, [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/read.rs:176:21 [INFO] [stderr] | [INFO] [stderr] 176 | if extra > 0 || map.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!map.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/integer.rs:87:46 [INFO] [stderr] | [INFO] [stderr] 87 | let ptr: *mut Atomic = unsafe { transmute(ptr) }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `ptr as *mut atomic::Atomic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/integer.rs:92:37 [INFO] [stderr] | [INFO] [stderr] 92 | self.pointer.store(unsafe { transmute(ptr) }, Ordering::SeqCst); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `ptr as *mut atomic::Atomic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/integer.rs:99:37 [INFO] [stderr] | [INFO] [stderr] 99 | self.pointer.store(unsafe { transmute(&*self.value) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*self.value as *const atomic::Atomic as *mut atomic::Atomic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `counter::Counter` [INFO] [stderr] --> src/counter.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> Counter { [INFO] [stderr] 25 | | let tmp = Box::new(Atomic::new(0)); [INFO] [stderr] 26 | | Counter { [INFO] [stderr] 27 | | pointer: unsafe { transmute(&*tmp) }, [INFO] [stderr] 28 | | value: tmp, [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/counter.rs:75:46 [INFO] [stderr] | [INFO] [stderr] 75 | let ptr: *mut Atomic = unsafe { transmute(ptr) }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `ptr as *mut atomic::Atomic` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/counter.rs:80:38 [INFO] [stderr] | [INFO] [stderr] 80 | self.pointer.store( unsafe { transmute(ptr) }, Ordering::SeqCst); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `ptr as *mut atomic::Atomic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/counter.rs:87:37 [INFO] [stderr] | [INFO] [stderr] 87 | self.pointer.store(unsafe { transmute(&*self.value) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*self.value as *const atomic::Atomic as *mut atomic::Atomic` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `integer::Integer` [INFO] [stderr] --> src/integer.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> Integer { [INFO] [stderr] 25 | | let tmp = Box::new(Atomic::new(0)); [INFO] [stderr] 26 | | Integer { [INFO] [stderr] 27 | | pointer: unsafe { transmute(&*tmp) }, [INFO] [stderr] 28 | | value: tmp, [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/integer.rs:87:46 [INFO] [stderr] | [INFO] [stderr] 87 | let ptr: *mut Atomic = unsafe { transmute(ptr) }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `ptr as *mut atomic::Atomic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/integer.rs:92:37 [INFO] [stderr] | [INFO] [stderr] 92 | self.pointer.store(unsafe { transmute(ptr) }, Ordering::SeqCst); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `ptr as *mut atomic::Atomic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/integer.rs:99:37 [INFO] [stderr] | [INFO] [stderr] 99 | self.pointer.store(unsafe { transmute(&*self.value) }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*self.value as *const atomic::Atomic as *mut atomic::Atomic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/custom_type.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | return Some(self.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/custom_type.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.90s [INFO] running `"docker" "inspect" "df62a60a123c684e3899b4c41fcf4dcfe88a7f1d423d8b9f4c4f2d2fa25f0585"` [INFO] running `"docker" "rm" "-f" "df62a60a123c684e3899b4c41fcf4dcfe88a7f1d423d8b9f4c4f2d2fa25f0585"` [INFO] [stdout] df62a60a123c684e3899b4c41fcf4dcfe88a7f1d423d8b9f4c4f2d2fa25f0585