[INFO] crate libasm 0.1.2 is already in cache [INFO] extracting crate libasm 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/libasm/0.1.2 [INFO] extracting crate libasm 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libasm/0.1.2 [INFO] validating manifest of libasm-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libasm-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libasm-0.1.2 [INFO] finished frobbing libasm-0.1.2 [INFO] frobbed toml for libasm-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/libasm/0.1.2/Cargo.toml [INFO] started frobbing libasm-0.1.2 [INFO] finished frobbing libasm-0.1.2 [INFO] frobbed toml for libasm-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libasm/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libasm-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libasm/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 506aec281f951e2e816b3a198cffe938ce45dcdf4bd2564cc22b14f3c3c5732e [INFO] running `"docker" "start" "-a" "506aec281f951e2e816b3a198cffe938ce45dcdf4bd2564cc22b14f3c3c5732e"` [INFO] [stderr] Checking cc v1.0.28 [INFO] [stderr] Checking syn v0.12.15 [INFO] [stderr] Checking libasm v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/extract.rs:17:44 [INFO] [stderr] | [INFO] [stderr] 17 | let start = node_to_string(iter.next().expect(&format!("expected more")).kind); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("expected more"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/extract.rs:17:52 [INFO] [stderr] | [INFO] [stderr] 17 | let start = node_to_string(iter.next().expect(&format!("expected more")).kind); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"expected more".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / match item { [INFO] [stderr] 35 | | Item::Macro(macro_item) => { [INFO] [stderr] 36 | | let mac = macro_item.mac; [INFO] [stderr] 37 | | if mac.path == "lasm".into() { [INFO] [stderr] ... | [INFO] [stderr] 41 | | _ => {} [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | if let Item::Macro(macro_item) = item { [INFO] [stderr] 35 | let mac = macro_item.mac; [INFO] [stderr] 36 | if mac.path == "lasm".into() { [INFO] [stderr] 37 | extract_asm(mac.tts); [INFO] [stderr] 38 | } [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/extract.rs:17:44 [INFO] [stderr] | [INFO] [stderr] 17 | let start = node_to_string(iter.next().expect(&format!("expected more")).kind); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("expected more"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/extract.rs:17:52 [INFO] [stderr] | [INFO] [stderr] 17 | let start = node_to_string(iter.next().expect(&format!("expected more")).kind); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"expected more".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / match item { [INFO] [stderr] 35 | | Item::Macro(macro_item) => { [INFO] [stderr] 36 | | let mac = macro_item.mac; [INFO] [stderr] 37 | | if mac.path == "lasm".into() { [INFO] [stderr] ... | [INFO] [stderr] 41 | | _ => {} [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | if let Item::Macro(macro_item) = item { [INFO] [stderr] 35 | let mac = macro_item.mac; [INFO] [stderr] 36 | if mac.path == "lasm".into() { [INFO] [stderr] 37 | extract_asm(mac.tts); [INFO] [stderr] 38 | } [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.95s [INFO] running `"docker" "inspect" "506aec281f951e2e816b3a198cffe938ce45dcdf4bd2564cc22b14f3c3c5732e"` [INFO] running `"docker" "rm" "-f" "506aec281f951e2e816b3a198cffe938ce45dcdf4bd2564cc22b14f3c3c5732e"` [INFO] [stdout] 506aec281f951e2e816b3a198cffe938ce45dcdf4bd2564cc22b14f3c3c5732e