[INFO] crate lib-resp 0.1.1 is already in cache [INFO] extracting crate lib-resp 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/lib-resp/0.1.1 [INFO] extracting crate lib-resp 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lib-resp/0.1.1 [INFO] validating manifest of lib-resp-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lib-resp-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lib-resp-0.1.1 [INFO] finished frobbing lib-resp-0.1.1 [INFO] frobbed toml for lib-resp-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/lib-resp/0.1.1/Cargo.toml [INFO] started frobbing lib-resp-0.1.1 [INFO] finished frobbing lib-resp-0.1.1 [INFO] frobbed toml for lib-resp-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lib-resp/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lib-resp-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lib-resp/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1fb376b15df5968bb4c66c4cb176e936788f8554c4d63ec479e5c770383a084d [INFO] running `"docker" "start" "-a" "1fb376b15df5968bb4c66c4cb176e936788f8554c4d63ec479e5c770383a084d"` [INFO] [stderr] Checking lib-resp v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/value.rs:396:29 [INFO] [stderr] | [INFO] [stderr] 396 | write!(f, "\r\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/value.rs:396:29 [INFO] [stderr] | [INFO] [stderr] 396 | write!(f, "\r\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / match self { [INFO] [stderr] 41 | | &Value::Int(ref datum) => { [INFO] [stderr] 42 | | let datum_str = &datum.to_string(); [INFO] [stderr] 43 | | [INFO] [stderr] ... | [INFO] [stderr] 141 | | }, [INFO] [stderr] 142 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | match *self { [INFO] [stderr] 41 | Value::Int(ref datum) => { [INFO] [stderr] 42 | let datum_str = &datum.to_string(); [INFO] [stderr] 43 | [INFO] [stderr] 44 | let mut encoded = String::with_capacity(datum_str.len() + 3); [INFO] [stderr] 45 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:79:40 [INFO] [stderr] | [INFO] [stderr] 79 | &Value::BStr(ref inner) => match inner { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 80 | | &None => Value::ENCODED_NULL_BSTR.to_owned(), [INFO] [stderr] 81 | | [INFO] [stderr] 82 | | &Some(ref datum) => match datum.len() { [INFO] [stderr] ... | [INFO] [stderr] 102 | | }, [INFO] [stderr] 103 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 79 | &Value::BStr(ref inner) => match *inner { [INFO] [stderr] 80 | None => Value::ENCODED_NULL_BSTR.to_owned(), [INFO] [stderr] 81 | [INFO] [stderr] 82 | Some(ref datum) => match datum.len() { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:105:41 [INFO] [stderr] | [INFO] [stderr] 105 | &Value::Array(ref inner) => match inner { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 106 | | &None => Value::ENCODED_NULL_ARRAY.to_owned(), [INFO] [stderr] 107 | | [INFO] [stderr] 108 | | &Some(ref data) => match data.len() { [INFO] [stderr] ... | [INFO] [stderr] 140 | | }, [INFO] [stderr] 141 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 105 | &Value::Array(ref inner) => match *inner { [INFO] [stderr] 106 | None => Value::ENCODED_NULL_ARRAY.to_owned(), [INFO] [stderr] 107 | [INFO] [stderr] 108 | Some(ref data) => match data.len() { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | / match self { [INFO] [stderr] 182 | | &Value::Array(None) | &Value::BStr(None) => true, [INFO] [stderr] 183 | | [INFO] [stderr] 184 | | // No other types can represent null values [INFO] [stderr] 185 | | _ => false, [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 181 | match *self { [INFO] [stderr] 182 | Value::Array(None) | Value::BStr(None) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:217:9 [INFO] [stderr] | [INFO] [stderr] 217 | / match self { [INFO] [stderr] 218 | | &Value::Int(_) => false, [INFO] [stderr] 219 | | [INFO] [stderr] 220 | | &Value::Str(ref value) | &Value::Err(ref value) => value.is_empty(), [INFO] [stderr] ... | [INFO] [stderr] 232 | | }, [INFO] [stderr] 233 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 217 | match *self { [INFO] [stderr] 218 | Value::Int(_) => false, [INFO] [stderr] 219 | [INFO] [stderr] 220 | Value::Str(ref value) | Value::Err(ref value) => value.is_empty(), [INFO] [stderr] 221 | [INFO] [stderr] 222 | Value::BStr(ref inner) => match inner { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:222:40 [INFO] [stderr] | [INFO] [stderr] 222 | &Value::BStr(ref inner) => match inner { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 223 | | &None => true, [INFO] [stderr] 224 | | [INFO] [stderr] 225 | | &Some(ref value) => value.is_empty(), [INFO] [stderr] 226 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 222 | &Value::BStr(ref inner) => match *inner { [INFO] [stderr] 223 | None => true, [INFO] [stderr] 224 | [INFO] [stderr] 225 | Some(ref value) => value.is_empty(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:228:41 [INFO] [stderr] | [INFO] [stderr] 228 | &Value::Array(ref inner) => match inner { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 229 | | &None => true, [INFO] [stderr] 230 | | [INFO] [stderr] 231 | | &Some(ref items) => items.is_empty(), [INFO] [stderr] 232 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 228 | &Value::Array(ref inner) => match *inner { [INFO] [stderr] 229 | None => true, [INFO] [stderr] 230 | [INFO] [stderr] 231 | Some(ref items) => items.is_empty(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:331:9 [INFO] [stderr] | [INFO] [stderr] 331 | / match self { [INFO] [stderr] 332 | | &Value::Int(ref datum) => write!(f, "Int({})", datum), [INFO] [stderr] 333 | | [INFO] [stderr] 334 | | &Value::Str(ref datum) => write!(f, r#"Str("{}")"#, datum), [INFO] [stderr] ... | [INFO] [stderr] 368 | | } [INFO] [stderr] 369 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 331 | match *self { [INFO] [stderr] 332 | Value::Int(ref datum) => write!(f, "Int({})", datum), [INFO] [stderr] 333 | [INFO] [stderr] 334 | Value::Str(ref datum) => write!(f, r#"Str("{}")"#, datum), [INFO] [stderr] 335 | [INFO] [stderr] 336 | Value::Err(ref datum) => write!(f, r#"Err("{}")"#, datum), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:338:40 [INFO] [stderr] | [INFO] [stderr] 338 | &Value::BStr(ref value) => match value { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 339 | | &None => write!(f, "BStr(None)"), [INFO] [stderr] 340 | | [INFO] [stderr] 341 | | &Some(ref datum) => match datum.len() { [INFO] [stderr] ... | [INFO] [stderr] 345 | | }, [INFO] [stderr] 346 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 338 | &Value::BStr(ref value) => match *value { [INFO] [stderr] 339 | None => write!(f, "BStr(None)"), [INFO] [stderr] 340 | [INFO] [stderr] 341 | Some(ref datum) => match datum.len() { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:351:17 [INFO] [stderr] | [INFO] [stderr] 351 | / match value { [INFO] [stderr] 352 | | &Some(ref data) => { [INFO] [stderr] 353 | | write!(f, "{}](", data.len())?; [INFO] [stderr] 354 | | [INFO] [stderr] ... | [INFO] [stderr] 366 | | &None => write!(f, "-1]"), [INFO] [stderr] 367 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 351 | match *value { [INFO] [stderr] 352 | Some(ref data) => { [INFO] [stderr] 353 | write!(f, "{}](", data.len())?; [INFO] [stderr] 354 | [INFO] [stderr] 355 | for (i, datum) in data.iter().enumerate() { [INFO] [stderr] 356 | write!(f, "{:?}", datum)?; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / match self { [INFO] [stderr] 41 | | &Value::Int(ref datum) => { [INFO] [stderr] 42 | | let datum_str = &datum.to_string(); [INFO] [stderr] 43 | | [INFO] [stderr] ... | [INFO] [stderr] 141 | | }, [INFO] [stderr] 142 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | match *self { [INFO] [stderr] 41 | Value::Int(ref datum) => { [INFO] [stderr] 42 | let datum_str = &datum.to_string(); [INFO] [stderr] 43 | [INFO] [stderr] 44 | let mut encoded = String::with_capacity(datum_str.len() + 3); [INFO] [stderr] 45 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:375:9 [INFO] [stderr] | [INFO] [stderr] 375 | / match self { [INFO] [stderr] 376 | | &Value::Int(ref datum) => write!(f, "(integer) {}", datum), [INFO] [stderr] 377 | | [INFO] [stderr] 378 | | &Value::Str(ref datum) => write!(f, "{}", datum), [INFO] [stderr] ... | [INFO] [stderr] 404 | | }, [INFO] [stderr] 405 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 375 | match *self { [INFO] [stderr] 376 | Value::Int(ref datum) => write!(f, "(integer) {}", datum), [INFO] [stderr] 377 | [INFO] [stderr] 378 | Value::Str(ref datum) => write!(f, "{}", datum), [INFO] [stderr] 379 | [INFO] [stderr] 380 | Value::Err(ref datum) => write!(f, "(error) {}", datum), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:382:40 [INFO] [stderr] | [INFO] [stderr] 382 | &Value::BStr(ref value) => match value { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 383 | | &Some(ref datum) => write!(f, r#""{}""#, datum), [INFO] [stderr] 384 | | [INFO] [stderr] 385 | | &None => write!(f, r#""""#), [INFO] [stderr] 386 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:79:40 [INFO] [stderr] | [INFO] [stderr] 79 | &Value::BStr(ref inner) => match inner { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 80 | | &None => Value::ENCODED_NULL_BSTR.to_owned(), [INFO] [stderr] 81 | | [INFO] [stderr] 82 | | &Some(ref datum) => match datum.len() { [INFO] [stderr] ... | [INFO] [stderr] 102 | | }, [INFO] [stderr] 103 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 79 | &Value::BStr(ref inner) => match *inner { [INFO] [stderr] 80 | None => Value::ENCODED_NULL_BSTR.to_owned(), [INFO] [stderr] 81 | [INFO] [stderr] 82 | Some(ref datum) => match datum.len() { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 382 | &Value::BStr(ref value) => match *value { [INFO] [stderr] 383 | Some(ref datum) => write!(f, r#""{}""#, datum), [INFO] [stderr] 384 | [INFO] [stderr] 385 | None => write!(f, r#""""#), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:105:41 [INFO] [stderr] | [INFO] [stderr] 105 | &Value::Array(ref inner) => match inner { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 106 | | &None => Value::ENCODED_NULL_ARRAY.to_owned(), [INFO] [stderr] 107 | | [INFO] [stderr] 108 | | &Some(ref data) => match data.len() { [INFO] [stderr] ... | [INFO] [stderr] 140 | | }, [INFO] [stderr] 141 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 105 | &Value::Array(ref inner) => match *inner { [INFO] [stderr] 106 | None => Value::ENCODED_NULL_ARRAY.to_owned(), [INFO] [stderr] 107 | [INFO] [stderr] 108 | Some(ref data) => match data.len() { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:388:41 [INFO] [stderr] | [INFO] [stderr] 388 | &Value::Array(ref value) => match value { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 389 | | &Some(ref data) => { [INFO] [stderr] 390 | | for (i, datum) in data.iter().enumerate() { [INFO] [stderr] 391 | | let n = i + 1; [INFO] [stderr] ... | [INFO] [stderr] 403 | | &None => write!(f, "(empty list or set)"), [INFO] [stderr] 404 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 388 | &Value::Array(ref value) => match *value { [INFO] [stderr] 389 | Some(ref data) => { [INFO] [stderr] 390 | for (i, datum) in data.iter().enumerate() { [INFO] [stderr] 391 | let n = i + 1; [INFO] [stderr] 392 | [INFO] [stderr] 393 | write!(f, "{}) {}", n, datum)?; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | / match self { [INFO] [stderr] 182 | | &Value::Array(None) | &Value::BStr(None) => true, [INFO] [stderr] 183 | | [INFO] [stderr] 184 | | // No other types can represent null values [INFO] [stderr] 185 | | _ => false, [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 181 | match *self { [INFO] [stderr] 182 | Value::Array(None) | Value::BStr(None) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:217:9 [INFO] [stderr] | [INFO] [stderr] 217 | / match self { [INFO] [stderr] 218 | | &Value::Int(_) => false, [INFO] [stderr] 219 | | [INFO] [stderr] 220 | | &Value::Str(ref value) | &Value::Err(ref value) => value.is_empty(), [INFO] [stderr] ... | [INFO] [stderr] 232 | | }, [INFO] [stderr] 233 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 217 | match *self { [INFO] [stderr] 218 | Value::Int(_) => false, [INFO] [stderr] 219 | [INFO] [stderr] 220 | Value::Str(ref value) | Value::Err(ref value) => value.is_empty(), [INFO] [stderr] 221 | [INFO] [stderr] 222 | Value::BStr(ref inner) => match inner { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:222:40 [INFO] [stderr] | [INFO] [stderr] 222 | &Value::BStr(ref inner) => match inner { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 223 | | &None => true, [INFO] [stderr] 224 | | [INFO] [stderr] 225 | | &Some(ref value) => value.is_empty(), [INFO] [stderr] 226 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 222 | &Value::BStr(ref inner) => match *inner { [INFO] [stderr] 223 | None => true, [INFO] [stderr] 224 | [INFO] [stderr] 225 | Some(ref value) => value.is_empty(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:228:41 [INFO] [stderr] | [INFO] [stderr] 228 | &Value::Array(ref inner) => match inner { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 229 | | &None => true, [INFO] [stderr] 230 | | [INFO] [stderr] 231 | | &Some(ref items) => items.is_empty(), [INFO] [stderr] 232 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 228 | &Value::Array(ref inner) => match *inner { [INFO] [stderr] 229 | None => true, [INFO] [stderr] 230 | [INFO] [stderr] 231 | Some(ref items) => items.is_empty(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:331:9 [INFO] [stderr] | [INFO] [stderr] 331 | / match self { [INFO] [stderr] 332 | | &Value::Int(ref datum) => write!(f, "Int({})", datum), [INFO] [stderr] 333 | | [INFO] [stderr] 334 | | &Value::Str(ref datum) => write!(f, r#"Str("{}")"#, datum), [INFO] [stderr] ... | [INFO] [stderr] 368 | | } [INFO] [stderr] 369 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 331 | match *self { [INFO] [stderr] 332 | Value::Int(ref datum) => write!(f, "Int({})", datum), [INFO] [stderr] 333 | [INFO] [stderr] 334 | Value::Str(ref datum) => write!(f, r#"Str("{}")"#, datum), [INFO] [stderr] 335 | [INFO] [stderr] 336 | Value::Err(ref datum) => write!(f, r#"Err("{}")"#, datum), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:338:40 [INFO] [stderr] | [INFO] [stderr] 338 | &Value::BStr(ref value) => match value { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 339 | | &None => write!(f, "BStr(None)"), [INFO] [stderr] 340 | | [INFO] [stderr] 341 | | &Some(ref datum) => match datum.len() { [INFO] [stderr] ... | [INFO] [stderr] 345 | | }, [INFO] [stderr] 346 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 338 | &Value::BStr(ref value) => match *value { [INFO] [stderr] 339 | None => write!(f, "BStr(None)"), [INFO] [stderr] 340 | [INFO] [stderr] 341 | Some(ref datum) => match datum.len() { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:351:17 [INFO] [stderr] | [INFO] [stderr] 351 | / match value { [INFO] [stderr] 352 | | &Some(ref data) => { [INFO] [stderr] 353 | | write!(f, "{}](", data.len())?; [INFO] [stderr] 354 | | [INFO] [stderr] ... | [INFO] [stderr] 366 | | &None => write!(f, "-1]"), [INFO] [stderr] 367 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 351 | match *value { [INFO] [stderr] 352 | Some(ref data) => { [INFO] [stderr] 353 | write!(f, "{}](", data.len())?; [INFO] [stderr] 354 | [INFO] [stderr] 355 | for (i, datum) in data.iter().enumerate() { [INFO] [stderr] 356 | write!(f, "{:?}", datum)?; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:375:9 [INFO] [stderr] | [INFO] [stderr] 375 | / match self { [INFO] [stderr] 376 | | &Value::Int(ref datum) => write!(f, "(integer) {}", datum), [INFO] [stderr] 377 | | [INFO] [stderr] 378 | | &Value::Str(ref datum) => write!(f, "{}", datum), [INFO] [stderr] ... | [INFO] [stderr] 404 | | }, [INFO] [stderr] 405 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 375 | match *self { [INFO] [stderr] 376 | Value::Int(ref datum) => write!(f, "(integer) {}", datum), [INFO] [stderr] 377 | [INFO] [stderr] 378 | Value::Str(ref datum) => write!(f, "{}", datum), [INFO] [stderr] 379 | [INFO] [stderr] 380 | Value::Err(ref datum) => write!(f, "(error) {}", datum), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:382:40 [INFO] [stderr] | [INFO] [stderr] 382 | &Value::BStr(ref value) => match value { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 383 | | &Some(ref datum) => write!(f, r#""{}""#, datum), [INFO] [stderr] 384 | | [INFO] [stderr] 385 | | &None => write!(f, r#""""#), [INFO] [stderr] 386 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 382 | &Value::BStr(ref value) => match *value { [INFO] [stderr] 383 | Some(ref datum) => write!(f, r#""{}""#, datum), [INFO] [stderr] 384 | [INFO] [stderr] 385 | None => write!(f, r#""""#), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:388:41 [INFO] [stderr] | [INFO] [stderr] 388 | &Value::Array(ref value) => match value { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 389 | | &Some(ref data) => { [INFO] [stderr] 390 | | for (i, datum) in data.iter().enumerate() { [INFO] [stderr] 391 | | let n = i + 1; [INFO] [stderr] ... | [INFO] [stderr] 403 | | &None => write!(f, "(empty list or set)"), [INFO] [stderr] 404 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 388 | &Value::Array(ref value) => match *value { [INFO] [stderr] 389 | Some(ref data) => { [INFO] [stderr] 390 | for (i, datum) in data.iter().enumerate() { [INFO] [stderr] 391 | let n = i + 1; [INFO] [stderr] 392 | [INFO] [stderr] 393 | write!(f, "{}) {}", n, datum)?; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoder.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | if self.src.fill_buf()?.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.src.fill_buf()?.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoder.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | if self.src.fill_buf()?.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.src.fill_buf()?.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/value-bench.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `lib-resp`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/decoder-bench.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `lib-resp`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/parser-bench.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `lib-resp`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "1fb376b15df5968bb4c66c4cb176e936788f8554c4d63ec479e5c770383a084d"` [INFO] running `"docker" "rm" "-f" "1fb376b15df5968bb4c66c4cb176e936788f8554c4d63ec479e5c770383a084d"` [INFO] [stdout] 1fb376b15df5968bb4c66c4cb176e936788f8554c4d63ec479e5c770383a084d