[INFO] crate liar 0.5.0 is already in cache
[INFO] extracting crate liar 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/liar/0.5.0
[INFO] extracting crate liar 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/liar/0.5.0
[INFO] validating manifest of liar-0.5.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of liar-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing liar-0.5.0
[INFO] finished frobbing liar-0.5.0
[INFO] frobbed toml for liar-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/liar/0.5.0/Cargo.toml
[INFO] started frobbing liar-0.5.0
[INFO] finished frobbing liar-0.5.0
[INFO] frobbed toml for liar-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/liar/0.5.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting liar-0.5.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/liar/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 59a907ded884317e3b55a83683fe5c86f5bd520a3cb8c452228a24a6a9c655e4
[INFO] running `"docker" "start" "-a" "59a907ded884317e3b55a83683fe5c86f5bd520a3cb8c452228a24a6a9c655e4"`
[INFO] [stderr]    Compiling liar v0.5.0 (/opt/crater/workdir)
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `timer::portable::PortableTimer`
[INFO] [stderr]   --> src/timer/portable.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     pub fn new() -> Self {
[INFO] [stderr] 16 | |         let instant = Instant::now();
[INFO] [stderr] 17 | |
[INFO] [stderr] 18 | |         PortableTimer { instant }
[INFO] [stderr] 19 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 13 | impl Default for timer::portable::PortableTimer {
[INFO] [stderr] 14 |     fn default() -> Self {
[INFO] [stderr] 15 |         Self::new()
[INFO] [stderr] 16 |     }
[INFO] [stderr] 17 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/timer/portable.rs:34:38
[INFO] [stderr]    |
[INFO] [stderr] 34 |         (d.as_secs() as f64) * 1e9 + (d.subsec_nanos() as f64)
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(d.subsec_nanos())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `timer::posix::CPUTimer`
[INFO] [stderr]   --> src/timer/posix.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     pub fn new() -> Self {
[INFO] [stderr] 16 | |         let ts = libc::timespec {
[INFO] [stderr] 17 | |             tv_sec: 0,
[INFO] [stderr] 18 | |             tv_nsec: 0,
[INFO] [stderr] ...  |
[INFO] [stderr] 21 | |         CPUTimer { ts }
[INFO] [stderr] 22 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 13 | impl Default for timer::posix::CPUTimer {
[INFO] [stderr] 14 |     fn default() -> Self {
[INFO] [stderr] 15 |         Self::new()
[INFO] [stderr] 16 |     }
[INFO] [stderr] 17 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `data`
[INFO] [stderr]   --> src/no_std/bencher.rs:39:18
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for i in 0..self.data.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for (i, <item>) in data.iter_mut().enumerate().take(self.data.len()) {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/no_std/bencher.rs:39:18
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for i in 0..self.data.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `data[..self.data.len()].clone_from_slice(&self.data[..])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `samples`.
[INFO] [stderr]   --> src/no_std/runner.rs:29:18
[INFO] [stderr]    |
[INFO] [stderr] 29 |         for i in 0..samples.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 29 |         for <item> in &mut samples {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `timer::portable::PortableTimer`
[INFO] [stderr]   --> src/timer/portable.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     pub fn new() -> Self {
[INFO] [stderr] 16 | |         let instant = Instant::now();
[INFO] [stderr] 17 | |
[INFO] [stderr] 18 | |         PortableTimer { instant }
[INFO] [stderr] 19 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 13 | impl Default for timer::portable::PortableTimer {
[INFO] [stderr] 14 |     fn default() -> Self {
[INFO] [stderr] 15 |         Self::new()
[INFO] [stderr] 16 |     }
[INFO] [stderr] 17 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/timer/portable.rs:34:38
[INFO] [stderr]    |
[INFO] [stderr] 34 |         (d.as_secs() as f64) * 1e9 + (d.subsec_nanos() as f64)
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(d.subsec_nanos())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `timer::posix::CPUTimer`
[INFO] [stderr]   --> src/timer/posix.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     pub fn new() -> Self {
[INFO] [stderr] 16 | |         let ts = libc::timespec {
[INFO] [stderr] 17 | |             tv_sec: 0,
[INFO] [stderr] 18 | |             tv_nsec: 0,
[INFO] [stderr] ...  |
[INFO] [stderr] 21 | |         CPUTimer { ts }
[INFO] [stderr] 22 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 13 | impl Default for timer::posix::CPUTimer {
[INFO] [stderr] 14 |     fn default() -> Self {
[INFO] [stderr] 15 |         Self::new()
[INFO] [stderr] 16 |     }
[INFO] [stderr] 17 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `data`
[INFO] [stderr]   --> src/no_std/bencher.rs:39:18
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for i in 0..self.data.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for (i, <item>) in data.iter_mut().enumerate().take(self.data.len()) {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/no_std/bencher.rs:39:18
[INFO] [stderr]    |
[INFO] [stderr] 39 |         for i in 0..self.data.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `data[..self.data.len()].clone_from_slice(&self.data[..])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `samples`.
[INFO] [stderr]   --> src/no_std/runner.rs:29:18
[INFO] [stderr]    |
[INFO] [stderr] 29 |         for i in 0..samples.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 29 |         for <item> in &mut samples {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.62s
[INFO] running `"docker" "inspect" "59a907ded884317e3b55a83683fe5c86f5bd520a3cb8c452228a24a6a9c655e4"`
[INFO] running `"docker" "rm" "-f" "59a907ded884317e3b55a83683fe5c86f5bd520a3cb8c452228a24a6a9c655e4"`
[INFO] [stdout] 59a907ded884317e3b55a83683fe5c86f5bd520a3cb8c452228a24a6a9c655e4