[INFO] crate lhef 0.2.1 is already in cache [INFO] extracting crate lhef 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/lhef/0.2.1 [INFO] extracting crate lhef 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lhef/0.2.1 [INFO] validating manifest of lhef-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lhef-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lhef-0.2.1 [INFO] finished frobbing lhef-0.2.1 [INFO] frobbed toml for lhef-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/lhef/0.2.1/Cargo.toml [INFO] started frobbing lhef-0.2.1 [INFO] finished frobbing lhef-0.2.1 [INFO] frobbed toml for lhef-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lhef/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lhef-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lhef/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f503a38c144b576bf21997e273cab19e834ddc258136d89e7d5e38a98467a28a [INFO] running `"docker" "start" "-a" "f503a38c144b576bf21997e273cab19e834ddc258136d89e7d5e38a98467a28a"` [INFO] [stderr] Checking xmltree v0.7.0 [INFO] [stderr] Checking lhef v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:852:9 [INFO] [stderr] | [INFO] [stderr] 852 | write!(&mut output, "{}\n", runinfo.NPRUP)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:857:13 [INFO] [stderr] | [INFO] [stderr] 857 | write!(&mut output, "{} {} {} {}\n", xs, xserr, xsmax, id)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:852:9 [INFO] [stderr] | [INFO] [stderr] 852 | write!(&mut output, "{}\n", runinfo.NPRUP)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:953:13 [INFO] [stderr] | [INFO] [stderr] 953 | write!(&mut output, "{} {}\n", lifetime, spin)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:857:13 [INFO] [stderr] | [INFO] [stderr] 857 | write!(&mut output, "{} {} {} {}\n", xs, xserr, xsmax, id)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:953:13 [INFO] [stderr] | [INFO] [stderr] 953 | write!(&mut output, "{} {}\n", lifetime, spin)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | const LHEF_TAG_OPEN: &'static str = " src/lib.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | const COMMENT_END: &'static str = "-->"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | const HEADER_START: &'static str = " src/lib.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | const HEADER_END: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | const INIT_START: &'static str = " src/lib.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | const INIT_END: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:26:21 [INFO] [stderr] | [INFO] [stderr] 26 | const EVENT_START: &'static str = " src/lib.rs:27:19 [INFO] [stderr] | [INFO] [stderr] 27 | const EVENT_END: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | const LHEF_LAST_LINE: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | const LHEF_TAG_OPEN: &'static str = " src/lib.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | const COMMENT_END: &'static str = "-->"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | const HEADER_START: &'static str = " src/lib.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | const HEADER_END: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | const INIT_START: &'static str = " src/lib.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | const INIT_END: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:26:21 [INFO] [stderr] | [INFO] [stderr] 26 | const EVENT_START: &'static str = " src/lib.rs:27:19 [INFO] [stderr] | [INFO] [stderr] 27 | const EVENT_END: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | const LHEF_LAST_LINE: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str` [INFO] [stderr] --> src/lib.rs:1061:9 [INFO] [stderr] | [INFO] [stderr] 1061 | use std::str; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1069:22 [INFO] [stderr] | [INFO] [stderr] 1069 | PDFSUP: [230000, 230000], [INFO] [stderr] | ^^^^^^ help: consider: `230_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1069:30 [INFO] [stderr] | [INFO] [stderr] 1069 | PDFSUP: [230000, 230000], [INFO] [stderr] | ^^^^^^ help: consider: `230_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1072:26 [INFO] [stderr] | [INFO] [stderr] 1072 | XSECUP: vec!(120588124.02), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `120_588_124.02` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1073:26 [INFO] [stderr] | [INFO] [stderr] 1073 | XERRUP: vec!(702517.48228), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `702_517.482_28` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1084:21 [INFO] [stderr] | [INFO] [stderr] 1084 | AQEDUP: 0.007546771, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.007_546_771` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1085:21 [INFO] [stderr] | [INFO] [stderr] 1085 | AQCDUP: 0.1190024, [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.119_002_4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1091:28 [INFO] [stderr] | [INFO] [stderr] 1091 | [0.0, 0.0, 4.7789443449, 4.7789443449, 0.0], [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `4.778_944_344_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1091:42 [INFO] [stderr] | [INFO] [stderr] 1091 | [0.0, 0.0, 4.7789443449, 4.7789443449, 0.0], [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `4.778_944_344_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1092:29 [INFO] [stderr] | [INFO] [stderr] 1092 | [0.0, 0.0, -1240.3761329, 1240.3761329, 0.0], [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_240.376_132_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1092:43 [INFO] [stderr] | [INFO] [stderr] 1092 | [0.0, 0.0, -1240.3761329, 1240.3761329, 0.0], [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_240.376_132_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1093:18 [INFO] [stderr] | [INFO] [stderr] 1093 | [37.283715118, 21.98166528, -1132.689358, 1133.5159684, 0.0], [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `37.283_715_118` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1093:32 [INFO] [stderr] | [INFO] [stderr] 1093 | [37.283715118, 21.98166528, -1132.689358, 1133.5159684, 0.0], [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `21.981_665_28` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1093:46 [INFO] [stderr] | [INFO] [stderr] 1093 | [37.283715118, 21.98166528, -1132.689358, 1133.5159684, 0.0], [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `1_132.689_358` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1093:59 [INFO] [stderr] | [INFO] [stderr] 1093 | [37.283715118, 21.98166528, -1132.689358, 1133.5159684, 0.0], [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_133.515_968_4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1094:19 [INFO] [stderr] | [INFO] [stderr] 1094 | [-37.283715118, -21.98166528, -102.90783056, 111.63910879, 0.0] [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `37.283_715_118` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1094:34 [INFO] [stderr] | [INFO] [stderr] 1094 | [-37.283715118, -21.98166528, -102.90783056, 111.63910879, 0.0] [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `21.981_665_28` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1094:48 [INFO] [stderr] | [INFO] [stderr] 1094 | [-37.283715118, -21.98166528, -102.90783056, 111.63910879, 0.0] [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `102.907_830_56` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1094:62 [INFO] [stderr] | [INFO] [stderr] 1094 | [-37.283715118, -21.98166528, -102.90783056, 111.63910879, 0.0] [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `111.639_108_79` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/lib.rs:251:28 [INFO] [stderr] | [INFO] [stderr] 251 | while !s.is_empty() && s.chars().last().unwrap() != '\n' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] help: like this [INFO] [stderr] | [INFO] [stderr] 251 | while !s.is_empty() && !s.ends_with(' [INFO] [stderr] 252 | ') { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:272:27 [INFO] [stderr] | [INFO] [stderr] 272 | let text: &str = text.ok_or(Box::new(MissingEntry(String::from(name))))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Box::new(MissingEntry(String::from(name))))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/lib.rs:282:8 [INFO] [stderr] | [INFO] [stderr] 282 | if tag.chars().last() != Some('>') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!tag.ends_with('>')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/lib.rs:309:8 [INFO] [stderr] | [INFO] [stderr] 309 | if rem.chars().next() != Some('=') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!rem.starts_with('=')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:775:72 [INFO] [stderr] | [INFO] [stderr] 775 | if header.children.is_empty() && !text.starts_with("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:779:40 [INFO] [stderr] | [INFO] [stderr] 779 | if !text.ends_with("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/lib.rs:861:16 [INFO] [stderr] | [INFO] [stderr] 861 | if runinfo.info.chars().last() != Some('\n') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!runinfo.info.ends_with('\n')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/lib.rs:957:16 [INFO] [stderr] | [INFO] [stderr] 957 | if event.info.chars().last() != Some('\n') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!event.info.ends_with('\n')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/lib.rs:251:28 [INFO] [stderr] | [INFO] [stderr] 251 | while !s.is_empty() && s.chars().last().unwrap() != '\n' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] help: like this [INFO] [stderr] | [INFO] [stderr] 251 | while !s.is_empty() && !s.ends_with(' [INFO] [stderr] 252 | ') { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:272:27 [INFO] [stderr] | [INFO] [stderr] 272 | let text: &str = text.ok_or(Box::new(MissingEntry(String::from(name))))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Box::new(MissingEntry(String::from(name))))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/lib.rs:282:8 [INFO] [stderr] | [INFO] [stderr] 282 | if tag.chars().last() != Some('>') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!tag.ends_with('>')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/lib.rs:309:8 [INFO] [stderr] | [INFO] [stderr] 309 | if rem.chars().next() != Some('=') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!rem.starts_with('=')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:775:72 [INFO] [stderr] | [INFO] [stderr] 775 | if header.children.is_empty() && !text.starts_with("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:779:40 [INFO] [stderr] | [INFO] [stderr] 779 | if !text.ends_with("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/lib.rs:861:16 [INFO] [stderr] | [INFO] [stderr] 861 | if runinfo.info.chars().last() != Some('\n') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!runinfo.info.ends_with('\n')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/lib.rs:957:16 [INFO] [stderr] | [INFO] [stderr] 957 | if event.info.chars().last() != Some('\n') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!event.info.ends_with('\n')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.74s [INFO] running `"docker" "inspect" "f503a38c144b576bf21997e273cab19e834ddc258136d89e7d5e38a98467a28a"` [INFO] running `"docker" "rm" "-f" "f503a38c144b576bf21997e273cab19e834ddc258136d89e7d5e38a98467a28a"` [INFO] [stdout] f503a38c144b576bf21997e273cab19e834ddc258136d89e7d5e38a98467a28a