[INFO] crate lexx 0.1.0 is already in cache [INFO] extracting crate lexx 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/lexx/0.1.0 [INFO] extracting crate lexx 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lexx/0.1.0 [INFO] validating manifest of lexx-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lexx-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lexx-0.1.0 [INFO] finished frobbing lexx-0.1.0 [INFO] frobbed toml for lexx-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/lexx/0.1.0/Cargo.toml [INFO] started frobbing lexx-0.1.0 [INFO] finished frobbing lexx-0.1.0 [INFO] frobbed toml for lexx-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lexx/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lexx-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lexx/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 28f1483fdf4601eb6fb64e985919d9fdc1523f5ecacea29c14f70947d1ce6af8 [INFO] running `"docker" "start" "-a" "28f1483fdf4601eb6fb64e985919d9fdc1523f5ecacea29c14f70947d1ce6af8"` [INFO] [stderr] Checking syntex_pos v0.46.0 [INFO] [stderr] Checking syntex_errors v0.46.0 [INFO] [stderr] Checking syntex_syntax v0.46.0 [INFO] [stderr] Checking lexx v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:76:29 [INFO] [stderr] | [INFO] [stderr] 76 | v.push(Token::OpenDelim(d.delim.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `d.delim` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:80:30 [INFO] [stderr] | [INFO] [stderr] 80 | v.push(Token::CloseDelim(d.delim.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `d.delim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / match t { [INFO] [stderr] 86 | | &TokenTree::Token(_,ref t) => vec![t.clone()].into_iter(), [INFO] [stderr] 87 | | &TokenTree::Delimited(_,ref x) => dr(x), [INFO] [stderr] 88 | | &TokenTree::Sequence(_,ref x) => sr(x) [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | match *t { [INFO] [stderr] 86 | TokenTree::Token(_,ref t) => vec![t.clone()].into_iter(), [INFO] [stderr] 87 | TokenTree::Delimited(_,ref x) => dr(x), [INFO] [stderr] 88 | TokenTree::Sequence(_,ref x) => sr(x) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:97:30 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn flatten_token_tree(v: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[TokenTree]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Parser` [INFO] [stderr] --> src/lib.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / pub fn new() -> Parser { [INFO] [stderr] 116 | | Parser { [INFO] [stderr] 117 | | p: ParseSess::new() [INFO] [stderr] 118 | | } [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 113 | impl Default for Parser { [INFO] [stderr] 114 | fn default() -> Self { [INFO] [stderr] 115 | Self::new() [INFO] [stderr] 116 | } [INFO] [stderr] 117 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:76:29 [INFO] [stderr] | [INFO] [stderr] 76 | v.push(Token::OpenDelim(d.delim.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `d.delim` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:80:30 [INFO] [stderr] | [INFO] [stderr] 80 | v.push(Token::CloseDelim(d.delim.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `d.delim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / match t { [INFO] [stderr] 86 | | &TokenTree::Token(_,ref t) => vec![t.clone()].into_iter(), [INFO] [stderr] 87 | | &TokenTree::Delimited(_,ref x) => dr(x), [INFO] [stderr] 88 | | &TokenTree::Sequence(_,ref x) => sr(x) [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | match *t { [INFO] [stderr] 86 | TokenTree::Token(_,ref t) => vec![t.clone()].into_iter(), [INFO] [stderr] 87 | TokenTree::Delimited(_,ref x) => dr(x), [INFO] [stderr] 88 | TokenTree::Sequence(_,ref x) => sr(x) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:97:30 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn flatten_token_tree(v: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[TokenTree]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Parser` [INFO] [stderr] --> src/lib.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / pub fn new() -> Parser { [INFO] [stderr] 116 | | Parser { [INFO] [stderr] 117 | | p: ParseSess::new() [INFO] [stderr] 118 | | } [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 113 | impl Default for Parser { [INFO] [stderr] 114 | fn default() -> Self { [INFO] [stderr] 115 | Self::new() [INFO] [stderr] 116 | } [INFO] [stderr] 117 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.22s [INFO] running `"docker" "inspect" "28f1483fdf4601eb6fb64e985919d9fdc1523f5ecacea29c14f70947d1ce6af8"` [INFO] running `"docker" "rm" "-f" "28f1483fdf4601eb6fb64e985919d9fdc1523f5ecacea29c14f70947d1ce6af8"` [INFO] [stdout] 28f1483fdf4601eb6fb64e985919d9fdc1523f5ecacea29c14f70947d1ce6af8