[INFO] crate leveled-hash-map 1.1.1 is already in cache [INFO] extracting crate leveled-hash-map 1.1.1 into work/ex/clippy-test-run/sources/stable/reg/leveled-hash-map/1.1.1 [INFO] extracting crate leveled-hash-map 1.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/leveled-hash-map/1.1.1 [INFO] validating manifest of leveled-hash-map-1.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of leveled-hash-map-1.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing leveled-hash-map-1.1.1 [INFO] finished frobbing leveled-hash-map-1.1.1 [INFO] frobbed toml for leveled-hash-map-1.1.1 written to work/ex/clippy-test-run/sources/stable/reg/leveled-hash-map/1.1.1/Cargo.toml [INFO] started frobbing leveled-hash-map-1.1.1 [INFO] finished frobbing leveled-hash-map-1.1.1 [INFO] frobbed toml for leveled-hash-map-1.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/leveled-hash-map/1.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting leveled-hash-map-1.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/leveled-hash-map/1.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ee192c765894eaff2e5d89e118056167591586ab667f1ea2b866a7594b351371 [INFO] running `"docker" "start" "-a" "ee192c765894eaff2e5d89e118056167591586ab667f1ea2b866a7594b351371"` [INFO] [stderr] Checking leveled-hash-map v1.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:9:11 [INFO] [stderr] | [INFO] [stderr] 9 | pool: Vec, (Option>, V)>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `LeveledHashMap` [INFO] [stderr] --> src/lib.rs:184:5 [INFO] [stderr] | [INFO] [stderr] 184 | / pub fn new() -> LeveledHashMap { [INFO] [stderr] 185 | | LeveledHashMap { [INFO] [stderr] 186 | | pool: Vec::new(), [INFO] [stderr] 187 | | sub: Vec::new(), [INFO] [stderr] 188 | | } [INFO] [stderr] 189 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:449:55 [INFO] [stderr] | [INFO] [stderr] 449 | pub fn remove(&mut self, key_chain: &[Arc]) -> Option<(V, Vec, (Option>, V)>>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:480:84 [INFO] [stderr] | [INFO] [stderr] 480 | pub fn remove_advanced(&mut self, key_chain: &[Arc], start_level: usize) -> Option<(V, Vec, (Option>, V)>>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:513:88 [INFO] [stderr] | [INFO] [stderr] 513 | pub fn remove_professional(&mut self, key_chain: &[Arc], start_level: usize) -> Result<(Option>, V, Vec, (Option>, V)>>), LeveledHashMapError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:536:29 [INFO] [stderr] | [INFO] [stderr] 536 | let mut sub_values: Vec, (Option>, V)>> = Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:9:11 [INFO] [stderr] | [INFO] [stderr] 9 | pool: Vec, (Option>, V)>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `LeveledHashMap` [INFO] [stderr] --> src/lib.rs:184:5 [INFO] [stderr] | [INFO] [stderr] 184 | / pub fn new() -> LeveledHashMap { [INFO] [stderr] 185 | | LeveledHashMap { [INFO] [stderr] 186 | | pool: Vec::new(), [INFO] [stderr] 187 | | sub: Vec::new(), [INFO] [stderr] 188 | | } [INFO] [stderr] 189 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:449:55 [INFO] [stderr] | [INFO] [stderr] 449 | pub fn remove(&mut self, key_chain: &[Arc]) -> Option<(V, Vec, (Option>, V)>>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:480:84 [INFO] [stderr] | [INFO] [stderr] 480 | pub fn remove_advanced(&mut self, key_chain: &[Arc], start_level: usize) -> Option<(V, Vec, (Option>, V)>>)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:513:88 [INFO] [stderr] | [INFO] [stderr] 513 | pub fn remove_professional(&mut self, key_chain: &[Arc], start_level: usize) -> Result<(Option>, V, Vec, (Option>, V)>>), LeveledHashMapError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:536:29 [INFO] [stderr] | [INFO] [stderr] 536 | let mut sub_values: Vec, (Option>, V)>> = Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> tests/leveled_hash_map.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / fn advanced() { [INFO] [stderr] 10 | | let mut map: LeveledHashMap<&'static str, u8> = LeveledHashMap::new(); [INFO] [stderr] 11 | | [INFO] [stderr] 12 | | map.insert(&[Arc::new("food")], 10).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 93 | | assert_eq!(0, remove_result.len()); [INFO] [stderr] 94 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/leveled_hash_map.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | assert_eq!(&10, remove_result.get(&Arc::new("food")).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&remove_result[&Arc::new("food")]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.22s [INFO] running `"docker" "inspect" "ee192c765894eaff2e5d89e118056167591586ab667f1ea2b866a7594b351371"` [INFO] running `"docker" "rm" "-f" "ee192c765894eaff2e5d89e118056167591586ab667f1ea2b866a7594b351371"` [INFO] [stdout] ee192c765894eaff2e5d89e118056167591586ab667f1ea2b866a7594b351371