[INFO] crate letterboxd 0.1.1 is already in cache [INFO] extracting crate letterboxd 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/letterboxd/0.1.1 [INFO] extracting crate letterboxd 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/letterboxd/0.1.1 [INFO] validating manifest of letterboxd-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of letterboxd-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing letterboxd-0.1.1 [INFO] finished frobbing letterboxd-0.1.1 [INFO] frobbed toml for letterboxd-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/letterboxd/0.1.1/Cargo.toml [INFO] started frobbing letterboxd-0.1.1 [INFO] finished frobbing letterboxd-0.1.1 [INFO] frobbed toml for letterboxd-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/letterboxd/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting letterboxd-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/letterboxd/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e15b785368e03834000200a518f89378d4f3150ebd27a67657756d60634f6e0d [INFO] running `"docker" "start" "-a" "e15b785368e03834000200a518f89378d4f3150ebd27a67657756d60634f6e0d"` [INFO] [stderr] Checking uuid v0.4.0 [INFO] [stderr] Checking serde_url_params v0.1.1 [INFO] [stderr] Checking letterboxd v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | hyper_client: hyper_client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hyper_client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/defs.rs:1259:13 [INFO] [stderr] | [INFO] [stderr] 1259 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/defs.rs:1513:13 [INFO] [stderr] | [INFO] [stderr] 1513 | film: film, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `film` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/defs.rs:1584:13 [INFO] [stderr] | [INFO] [stderr] 1584 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/defs.rs:2929:13 [INFO] [stderr] | [INFO] [stderr] 2929 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | hyper_client: hyper_client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hyper_client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/defs.rs:1259:13 [INFO] [stderr] | [INFO] [stderr] 1259 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/defs.rs:1513:13 [INFO] [stderr] | [INFO] [stderr] 1513 | film: film, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `film` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/defs.rs:1584:13 [INFO] [stderr] | [INFO] [stderr] 1584 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/defs.rs:2929:13 [INFO] [stderr] | [INFO] [stderr] 2929 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Activity` [INFO] [stderr] --> src/defs.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / enum AbstractActivity { [INFO] [stderr] 18 | | /// Common fields: [INFO] [stderr] 19 | | /// member The member associated with the activity. [INFO] [stderr] 20 | | /// when_created The timestamp of the activity, in ISO 8601 format with UTC [INFO] [stderr] ... | [INFO] [stderr] 115 | | }, [INFO] [stderr] 116 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Activity` [INFO] [stderr] --> src/defs.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / enum AbstractActivity { [INFO] [stderr] 18 | | /// Common fields: [INFO] [stderr] 19 | | /// member The member associated with the activity. [INFO] [stderr] 20 | | /// when_created The timestamp of the activity, in ISO 8601 format with UTC [INFO] [stderr] ... | [INFO] [stderr] 115 | | }, [INFO] [stderr] 116 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Activity` [INFO] [stderr] --> src/defs.rs:236:1 [INFO] [stderr] | [INFO] [stderr] 236 | / enum ActivityClass { [INFO] [stderr] 237 | | OwnActivity, [INFO] [stderr] 238 | | NotOwnActivity, [INFO] [stderr] 239 | | IncomingActivity, [INFO] [stderr] 240 | | NotIncomingActivity, [INFO] [stderr] 241 | | NetworkActivity, [INFO] [stderr] 242 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Activity` [INFO] [stderr] --> src/defs.rs:280:1 [INFO] [stderr] | [INFO] [stderr] 280 | / enum ActivityType { [INFO] [stderr] 281 | | ReviewActivity, [INFO] [stderr] 282 | | ReviewCommentActivity, [INFO] [stderr] 283 | | ReviewLikeActivity, [INFO] [stderr] ... | [INFO] [stderr] 294 | | InvitationAcceptedActivity, [INFO] [stderr] 295 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Activity` [INFO] [stderr] --> src/defs.rs:236:1 [INFO] [stderr] | [INFO] [stderr] 236 | / enum ActivityClass { [INFO] [stderr] 237 | | OwnActivity, [INFO] [stderr] 238 | | NotOwnActivity, [INFO] [stderr] 239 | | IncomingActivity, [INFO] [stderr] 240 | | NotIncomingActivity, [INFO] [stderr] 241 | | NetworkActivity, [INFO] [stderr] 242 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Activity` [INFO] [stderr] --> src/defs.rs:280:1 [INFO] [stderr] | [INFO] [stderr] 280 | / enum ActivityType { [INFO] [stderr] 281 | | ReviewActivity, [INFO] [stderr] 282 | | ReviewCommentActivity, [INFO] [stderr] 283 | | ReviewLikeActivity, [INFO] [stderr] ... | [INFO] [stderr] 294 | | InvitationAcceptedActivity, [INFO] [stderr] 295 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/defs.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / ReviewCommentActivity { [INFO] [stderr] 96 | | member: MemberSummary, [INFO] [stderr] 97 | | when_created: String, [INFO] [stderr] 98 | | /// The review associated with the activity. [INFO] [stderr] ... | [INFO] [stderr] 101 | | comment: ReviewComment, [INFO] [stderr] 102 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/defs.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / ReviewCommentActivity { [INFO] [stderr] 96 | | member: MemberSummary, [INFO] [stderr] 97 | | when_created: String, [INFO] [stderr] 98 | | /// The review associated with the activity. [INFO] [stderr] ... | [INFO] [stderr] 101 | | comment: ReviewComment, [INFO] [stderr] 102 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/defs.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / ReviewSearchItem { [INFO] [stderr] 211 | | score: f32, [INFO] [stderr] 212 | | /// Details of the review. [INFO] [stderr] 213 | | review: LogEntry, [INFO] [stderr] 214 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/defs.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / ReviewSearchItem { [INFO] [stderr] 211 | | score: f32, [INFO] [stderr] 212 | | /// Details of the review. [INFO] [stderr] 213 | | review: LogEntry, [INFO] [stderr] 214 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/defs.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / ReviewCommentActivity { [INFO] [stderr] 96 | | member: MemberSummary, [INFO] [stderr] 97 | | when_created: String, [INFO] [stderr] 98 | | /// The review associated with the activity. [INFO] [stderr] ... | [INFO] [stderr] 101 | | comment: ReviewComment, [INFO] [stderr] 102 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/defs.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / ReviewCommentActivity { [INFO] [stderr] 96 | | member: MemberSummary, [INFO] [stderr] 97 | | when_created: String, [INFO] [stderr] 98 | | /// The review associated with the activity. [INFO] [stderr] ... | [INFO] [stderr] 101 | | comment: ReviewComment, [INFO] [stderr] 102 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/defs.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / ReviewSearchItem { [INFO] [stderr] 211 | | score: f32, [INFO] [stderr] 212 | | /// Details of the review. [INFO] [stderr] 213 | | review: LogEntry, [INFO] [stderr] 214 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/defs.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / ReviewSearchItem { [INFO] [stderr] 211 | | score: f32, [INFO] [stderr] 212 | | /// Details of the review. [INFO] [stderr] 213 | | review: LogEntry, [INFO] [stderr] 214 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/integration-auth.rs:83:23 [INFO] [stderr] | [INFO] [stderr] 83 | const LIST_NAME: &'static str = "some_new_list"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 33.57s [INFO] running `"docker" "inspect" "e15b785368e03834000200a518f89378d4f3150ebd27a67657756d60634f6e0d"` [INFO] running `"docker" "rm" "-f" "e15b785368e03834000200a518f89378d4f3150ebd27a67657756d60634f6e0d"` [INFO] [stdout] e15b785368e03834000200a518f89378d4f3150ebd27a67657756d60634f6e0d