[INFO] crate ledger-parser 2.1.0 is already in cache [INFO] extracting crate ledger-parser 2.1.0 into work/ex/clippy-test-run/sources/stable/reg/ledger-parser/2.1.0 [INFO] extracting crate ledger-parser 2.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ledger-parser/2.1.0 [INFO] validating manifest of ledger-parser-2.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ledger-parser-2.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ledger-parser-2.1.0 [INFO] finished frobbing ledger-parser-2.1.0 [INFO] frobbed toml for ledger-parser-2.1.0 written to work/ex/clippy-test-run/sources/stable/reg/ledger-parser/2.1.0/Cargo.toml [INFO] started frobbing ledger-parser-2.1.0 [INFO] finished frobbing ledger-parser-2.1.0 [INFO] frobbed toml for ledger-parser-2.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ledger-parser/2.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ledger-parser-2.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ledger-parser/2.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 67ad464f2a9b2be200f5ee4744fd4cfe931d754075faa1857e247b31415812df [INFO] running `"docker" "start" "-a" "67ad464f2a9b2be200f5ee4744fd4cfe931d754075faa1857e247b31415812df"` [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking rust_decimal v0.10.2 [INFO] [stderr] Checking ledger-parser v2.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model_internal.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | transactions: transactions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transactions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model_internal.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | commodity_prices: commodity_prices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `commodity_prices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model_internal.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | transactions: transactions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transactions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model_internal.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | commodity_prices: commodity_prices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `commodity_prices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser.rs:331:60 [INFO] [stderr] | [INFO] [stderr] 331 | Ok((CompleteStr(""), NaiveDate::from_ymd(2017, 03, 24))) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 331 | Ok((CompleteStr(""), NaiveDate::from_ymd(2017, 3, 24))) [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 331 | Ok((CompleteStr(""), NaiveDate::from_ymd(2017, 0o3, 24))) [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser.rs:335:60 [INFO] [stderr] | [INFO] [stderr] 335 | Ok((CompleteStr(""), NaiveDate::from_ymd(2017, 03, 24))) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 335 | Ok((CompleteStr(""), NaiveDate::from_ymd(2017, 3, 24))) [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 335 | Ok((CompleteStr(""), NaiveDate::from_ymd(2017, 0o3, 24))) [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser.rs:339:60 [INFO] [stderr] | [INFO] [stderr] 339 | Ok((CompleteStr(""), NaiveDate::from_ymd(2017, 03, 24))) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 339 | Ok((CompleteStr(""), NaiveDate::from_ymd(2017, 3, 24))) [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 339 | Ok((CompleteStr(""), NaiveDate::from_ymd(2017, 0o3, 24))) [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser.rs:356:43 [INFO] [stderr] | [INFO] [stderr] 356 | NaiveDate::from_ymd(2017, 03, 24).and_hms(17, 15, 23) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 356 | NaiveDate::from_ymd(2017, 3, 24).and_hms(17, 15, 23) [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 356 | NaiveDate::from_ymd(2017, 0o3, 24).and_hms(17, 15, 23) [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser.rs:594:57 [INFO] [stderr] | [INFO] [stderr] 594 | date: NaiveDate::from_ymd(2018, 10, 01), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 594 | date: NaiveDate::from_ymd(2018, 10, 1), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 594 | date: NaiveDate::from_ymd(2018, 10, 0o1), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/lib.rs:91:61 [INFO] [stderr] | [INFO] [stderr] 91 | date: NaiveDate::from_ymd(2018, 10, 01), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 91 | date: NaiveDate::from_ymd(2018, 10, 1), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 91 | date: NaiveDate::from_ymd(2018, 10, 0o1), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/lib.rs:125:61 [INFO] [stderr] | [INFO] [stderr] 125 | date: NaiveDate::from_ymd(2018, 10, 01), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 125 | date: NaiveDate::from_ymd(2018, 10, 1), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 125 | date: NaiveDate::from_ymd(2018, 10, 0o1), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/parser.rs:42:1 [INFO] [stderr] | [INFO] [stderr] 42 | / named_args!(numberN(n: usize), [INFO] [stderr] 43 | | map_res!(take_while_m_n!(n, n, is_digit), |s: CompleteStr| { i32::from_str(s.0) }) [INFO] [stderr] 44 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_comparisons)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/parser.rs:135:1 [INFO] [stderr] | [INFO] [stderr] 135 | / named!(commodity_without_quotes, [INFO] [stderr] 136 | | map!( [INFO] [stderr] 137 | | recognize!( [INFO] [stderr] 138 | | tuple!( [INFO] [stderr] ... | [INFO] [stderr] 144 | | ) [INFO] [stderr] 145 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/parser.rs:160:34 [INFO] [stderr] | [INFO] [stderr] 160 | quantity: if let Some(_) = neg_opt { [INFO] [stderr] | ___________________________- ^^^^^^^ [INFO] [stderr] 161 | | quantity * Decimal::new(-1, 0) [INFO] [stderr] 162 | | } else { quantity }, [INFO] [stderr] | |___________________________________- help: try this: `if neg_opt.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/parser.rs:42:1 [INFO] [stderr] | [INFO] [stderr] 42 | / named_args!(numberN(n: usize), [INFO] [stderr] 43 | | map_res!(take_while_m_n!(n, n, is_digit), |s: CompleteStr| { i32::from_str(s.0) }) [INFO] [stderr] 44 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_comparisons)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/parser.rs:135:1 [INFO] [stderr] | [INFO] [stderr] 135 | / named!(commodity_without_quotes, [INFO] [stderr] 136 | | map!( [INFO] [stderr] 137 | | recognize!( [INFO] [stderr] 138 | | tuple!( [INFO] [stderr] ... | [INFO] [stderr] 144 | | ) [INFO] [stderr] 145 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/parser.rs:160:34 [INFO] [stderr] | [INFO] [stderr] 160 | quantity: if let Some(_) = neg_opt { [INFO] [stderr] | ___________________________- ^^^^^^^ [INFO] [stderr] 161 | | quantity * Decimal::new(-1, 0) [INFO] [stderr] 162 | | } else { quantity }, [INFO] [stderr] | |___________________________________- help: try this: `if neg_opt.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.17s [INFO] running `"docker" "inspect" "67ad464f2a9b2be200f5ee4744fd4cfe931d754075faa1857e247b31415812df"` [INFO] running `"docker" "rm" "-f" "67ad464f2a9b2be200f5ee4744fd4cfe931d754075faa1857e247b31415812df"` [INFO] [stdout] 67ad464f2a9b2be200f5ee4744fd4cfe931d754075faa1857e247b31415812df