[INFO] crate ledger 0.0.8 is already in cache [INFO] extracting crate ledger 0.0.8 into work/ex/clippy-test-run/sources/stable/reg/ledger/0.0.8 [INFO] extracting crate ledger 0.0.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ledger/0.0.8 [INFO] validating manifest of ledger-0.0.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ledger-0.0.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ledger-0.0.8 [INFO] finished frobbing ledger-0.0.8 [INFO] frobbed toml for ledger-0.0.8 written to work/ex/clippy-test-run/sources/stable/reg/ledger/0.0.8/Cargo.toml [INFO] started frobbing ledger-0.0.8 [INFO] finished frobbing ledger-0.0.8 [INFO] frobbed toml for ledger-0.0.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ledger/0.0.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ledger-0.0.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ledger/0.0.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e1499087b57d5969722d4cf31a21f2d14e1e1485e0291fa1b758e1a334386af1 [INFO] running `"docker" "start" "-a" "e1499087b57d5969722d4cf31a21f2d14e1e1485e0291fa1b758e1a334386af1"` [INFO] [stderr] Compiling hidapi v0.5.0 [INFO] [stderr] Checking ledger v0.0.8 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:447:13 [INFO] [stderr] | [INFO] [stderr] 447 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:447:13 [INFO] [stderr] | [INFO] [stderr] 447 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:59:29 [INFO] [stderr] | [INFO] [stderr] 59 | const LEDGER_TIMEOUT: i32 = 10000000; [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | / return HidApiWrapper{ [INFO] [stderr] 133 | | _api: RefCell::new(Weak::new()) [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 132 | HidApiWrapper{ [INFO] [stderr] 133 | _api: RefCell::new(Weak::new()) [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:59:29 [INFO] [stderr] | [INFO] [stderr] 59 | const LEDGER_TIMEOUT: i32 = 10000000; [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | / return HidApiWrapper{ [INFO] [stderr] 133 | | _api: RefCell::new(Weak::new()) [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 132 | HidApiWrapper{ [INFO] [stderr] 133 | _api: RefCell::new(Weak::new()) [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: field is never used: `api_mutex` [INFO] [stderr] --> src/lib.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | api_mutex: Arc>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `command_length` [INFO] [stderr] --> src/lib.rs:209:23 [INFO] [stderr] | [INFO] [stderr] 209 | in_data.push(((command_length >> 0) & 0xFF) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `channel` [INFO] [stderr] --> src/lib.rs:214:22 [INFO] [stderr] | [INFO] [stderr] 214 | buffer[1] = ((channel >> 0) & 0xFF) as u8; // channel big endian [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the variable `sequence_idx` is used as a loop counter. Consider using `for (sequence_idx, item) in in_data.chunks((LEDGER_PACKET_SIZE - 5) as usize).enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:219:22 [INFO] [stderr] | [INFO] [stderr] 219 | for chunk in in_data.chunks((LEDGER_PACKET_SIZE - 5) as usize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `sequence_idx` [INFO] [stderr] --> src/lib.rs:222:30 [INFO] [stderr] | [INFO] [stderr] 222 | buffer[4] = ((sequence_idx >> 0) & 0xFF) as u8; // sequence_idx big endian [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:307:29 [INFO] [stderr] | [INFO] [stderr] 307 | let apdu_retcode = ((answer[answer.len() - 2] as u16) << 8) + answer[answer.len() - 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(answer[answer.len() - 2])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:307:71 [INFO] [stderr] | [INFO] [stderr] 307 | let apdu_retcode = ((answer[answer.len() - 2] as u16) << 8) + answer[answer.len() - 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(answer[answer.len() - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:385:30 [INFO] [stderr] | [INFO] [stderr] 385 | 1 => data[i + 1] as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[i + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:386:31 [INFO] [stderr] | [INFO] [stderr] 386 | 2 => (data[i + 2] as u16 * 256 + data[i + 1] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[i + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:386:58 [INFO] [stderr] | [INFO] [stderr] 386 | 2 => (data[i + 2] as u16 * 256 + data[i + 1] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[i + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: field is never used: `api_mutex` [INFO] [stderr] --> src/lib.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | api_mutex: Arc>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `command_length` [INFO] [stderr] --> src/lib.rs:209:23 [INFO] [stderr] | [INFO] [stderr] 209 | in_data.push(((command_length >> 0) & 0xFF) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `channel` [INFO] [stderr] --> src/lib.rs:214:22 [INFO] [stderr] | [INFO] [stderr] 214 | buffer[1] = ((channel >> 0) & 0xFF) as u8; // channel big endian [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the variable `sequence_idx` is used as a loop counter. Consider using `for (sequence_idx, item) in in_data.chunks((LEDGER_PACKET_SIZE - 5) as usize).enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:219:22 [INFO] [stderr] | [INFO] [stderr] 219 | for chunk in in_data.chunks((LEDGER_PACKET_SIZE - 5) as usize) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `sequence_idx` [INFO] [stderr] --> src/lib.rs:222:30 [INFO] [stderr] | [INFO] [stderr] 222 | buffer[4] = ((sequence_idx >> 0) & 0xFF) as u8; // sequence_idx big endian [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:307:29 [INFO] [stderr] | [INFO] [stderr] 307 | let apdu_retcode = ((answer[answer.len() - 2] as u16) << 8) + answer[answer.len() - 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(answer[answer.len() - 2])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:307:71 [INFO] [stderr] | [INFO] [stderr] 307 | let apdu_retcode = ((answer[answer.len() - 2] as u16) << 8) + answer[answer.len() - 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(answer[answer.len() - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:385:30 [INFO] [stderr] | [INFO] [stderr] 385 | 1 => data[i + 1] as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[i + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:386:31 [INFO] [stderr] | [INFO] [stderr] 386 | 2 => (data[i + 2] as u16 * 256 + data[i + 1] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[i + 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:386:58 [INFO] [stderr] | [INFO] [stderr] 386 | 2 => (data[i + 2] as u16 * 256 + data[i + 1] as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(data[i + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.25s [INFO] running `"docker" "inspect" "e1499087b57d5969722d4cf31a21f2d14e1e1485e0291fa1b758e1a334386af1"` [INFO] running `"docker" "rm" "-f" "e1499087b57d5969722d4cf31a21f2d14e1e1485e0291fa1b758e1a334386af1"` [INFO] [stdout] e1499087b57d5969722d4cf31a21f2d14e1e1485e0291fa1b758e1a334386af1