[INFO] crate ledb-derive 0.2.1 is already in cache [INFO] extracting crate ledb-derive 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/ledb-derive/0.2.1 [INFO] extracting crate ledb-derive 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ledb-derive/0.2.1 [INFO] validating manifest of ledb-derive-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ledb-derive-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ledb-derive-0.2.1 [INFO] finished frobbing ledb-derive-0.2.1 [INFO] frobbed toml for ledb-derive-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/ledb-derive/0.2.1/Cargo.toml [INFO] started frobbing ledb-derive-0.2.1 [INFO] finished frobbing ledb-derive-0.2.1 [INFO] frobbed toml for ledb-derive-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ledb-derive/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ledb-derive-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ledb-derive/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8d2d17b1247e0a68b41f0db10d8eb38a5d084420ec527fc679e5466f0ca2a1db [INFO] running `"docker" "start" "-a" "8d2d17b1247e0a68b41f0db10d8eb38a5d084420ec527fc679e5466f0ca2a1db"` [INFO] [stderr] Checking ledb-derive v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/document.rs:17:70 [INFO] [stderr] | [INFO] [stderr] 17 | primary_field = get_serde_rename(&field).or(Some(primary_field_name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(primary_field_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/document.rs:19:40 [INFO] [stderr] | [INFO] [stderr] 19 | return Err(format!("Only one primary key field per document allowed")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Only one primary key field per document allowed".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/document.rs:124:58 [INFO] [stderr] | [INFO] [stderr] 124 | && attr.tts.clone().into_iter().any(|tt| { [INFO] [stderr] | __________________________________________________________^ [INFO] [stderr] 125 | | if let TokenTree::Group(group) = tt { [INFO] [stderr] 126 | | group.stream().into_iter().any(|tt| { [INFO] [stderr] 127 | | if let TokenTree::Ident(ident) = tt { [INFO] [stderr] ... | [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | }) { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/document.rs:17:70 [INFO] [stderr] | [INFO] [stderr] 17 | primary_field = get_serde_rename(&field).or(Some(primary_field_name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(primary_field_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/document.rs:19:40 [INFO] [stderr] | [INFO] [stderr] 19 | return Err(format!("Only one primary key field per document allowed")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Only one primary key field per document allowed".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/document.rs:124:58 [INFO] [stderr] | [INFO] [stderr] 124 | && attr.tts.clone().into_iter().any(|tt| { [INFO] [stderr] | __________________________________________________________^ [INFO] [stderr] 125 | | if let TokenTree::Group(group) = tt { [INFO] [stderr] 126 | | group.stream().into_iter().any(|tt| { [INFO] [stderr] 127 | | if let TokenTree::Ident(ident) = tt { [INFO] [stderr] ... | [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | }) { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.64s [INFO] running `"docker" "inspect" "8d2d17b1247e0a68b41f0db10d8eb38a5d084420ec527fc679e5466f0ca2a1db"` [INFO] running `"docker" "rm" "-f" "8d2d17b1247e0a68b41f0db10d8eb38a5d084420ec527fc679e5466f0ca2a1db"` [INFO] [stdout] 8d2d17b1247e0a68b41f0db10d8eb38a5d084420ec527fc679e5466f0ca2a1db