[INFO] crate led_bargraph 0.1.1 is already in cache
[INFO] extracting crate led_bargraph 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/led_bargraph/0.1.1
[INFO] extracting crate led_bargraph 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/led_bargraph/0.1.1
[INFO] validating manifest of led_bargraph-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of led_bargraph-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing led_bargraph-0.1.1
[INFO] finished frobbing led_bargraph-0.1.1
[INFO] frobbed toml for led_bargraph-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/led_bargraph/0.1.1/Cargo.toml
[INFO] started frobbing led_bargraph-0.1.1
[INFO] finished frobbing led_bargraph-0.1.1
[INFO] frobbed toml for led_bargraph-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/led_bargraph/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting led_bargraph-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/led_bargraph/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6c15470fa3551c7cf50ef7287c6ddc113ef4c9841347f138d2955986e23b4cfc
[INFO] running `"docker" "start" "-a" "6c15470fa3551c7cf50ef7287c6ddc113ef4c9841347f138d2955986e23b4cfc"`
[INFO] [stderr]     Checking chrono v0.4.6
[INFO] [stderr]     Checking slog-scope v4.1.1
[INFO] [stderr]     Checking slog-stdlog v3.0.4-pre
[INFO] [stderr]     Checking slog-term v2.4.0
[INFO] [stderr]     Checking ht16k33 v0.1.0
[INFO] [stderr]     Checking led_bargraph v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:148:13
[INFO] [stderr]     |
[INFO] [stderr] 148 |             device: device,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `device`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:150:13
[INFO] [stderr]     |
[INFO] [stderr] 150 |             logger: logger,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `logger`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:151:13
[INFO] [stderr]     |
[INFO] [stderr] 151 |             show: show,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `show`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:148:13
[INFO] [stderr]     |
[INFO] [stderr] 148 |             device: device,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `device`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:150:13
[INFO] [stderr]     |
[INFO] [stderr] 150 |             logger: logger,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `logger`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:151:13
[INFO] [stderr]     |
[INFO] [stderr] 151 |             show: show,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `show`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:143:36
[INFO] [stderr]     |
[INFO] [stderr] 143 |         let logger = logger.into().unwrap_or(Logger::root(StdLog.fuse(), o!()));
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Logger::root(StdLog.fuse(), o!()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:236:21
[INFO] [stderr]     |
[INFO] [stderr] 236 |     pub fn is_ready(&mut self) -> bool {
[INFO] [stderr]     |                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]    --> src/lib.rs:322:30
[INFO] [stderr]     |
[INFO] [stderr] 322 |     pub fn update(&mut self, bar: u8, range: u8) -> Result<(), BargraphError<D>> {
[INFO] [stderr]     |                              ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::blacklisted_name)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:340:28
[INFO] [stderr]     |
[INFO] [stderr] 340 |         for current_bar in 1..(range + 1) {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^ help: use: `1..=range`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:341:13
[INFO] [stderr]     |
[INFO] [stderr] 341 | /             let mut fill = false;
[INFO] [stderr] 342 | |             if current_bar <= value {
[INFO] [stderr] 343 | |                 fill = true;
[INFO] [stderr] 344 | |             }
[INFO] [stderr]     | |_____________^ help: it is more idiomatic to write: `let <mut> fill = if current_bar <= value { true } else { false };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:450:42
[INFO] [stderr]     |
[INFO] [stderr] 450 |     pub fn set_blink(&mut self, enabled: &bool) -> Result<(), BargraphError<D>> {
[INFO] [stderr]     |                                          ^^^^^ help: consider passing by value instead: `bool`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:477:37
[INFO] [stderr]     |
[INFO] [stderr] 477 |     fn set_bar_fill(&mut self, bar: &u8, range: &u8, fill: &bool) {
[INFO] [stderr]     |                                     ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:477:49
[INFO] [stderr]     |
[INFO] [stderr] 477 |     fn set_bar_fill(&mut self, bar: &u8, range: &u8, fill: &bool) {
[INFO] [stderr]     |                                                 ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:477:60
[INFO] [stderr]     |
[INFO] [stderr] 477 |     fn set_bar_fill(&mut self, bar: &u8, range: &u8, fill: &bool) {
[INFO] [stderr]     |                                                            ^^^^^ help: consider passing by value instead: `bool`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]    --> src/lib.rs:477:32
[INFO] [stderr]     |
[INFO] [stderr] 477 |     fn set_bar_fill(&mut self, bar: &u8, range: &u8, fill: &bool) {
[INFO] [stderr]     |                                ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]    --> src/lib.rs:485:13
[INFO] [stderr]     |
[INFO] [stderr] 485 |         for bar in start_bar..end_bar {
[INFO] [stderr]     |             ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:143:36
[INFO] [stderr]     |
[INFO] [stderr] 143 |         let logger = logger.into().unwrap_or(Logger::root(StdLog.fuse(), o!()));
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Logger::root(StdLog.fuse(), o!()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:236:21
[INFO] [stderr]     |
[INFO] [stderr] 236 |     pub fn is_ready(&mut self) -> bool {
[INFO] [stderr]     |                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]    --> src/lib.rs:322:30
[INFO] [stderr]     |
[INFO] [stderr] 322 |     pub fn update(&mut self, bar: u8, range: u8) -> Result<(), BargraphError<D>> {
[INFO] [stderr]     |                              ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::blacklisted_name)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:340:28
[INFO] [stderr]     |
[INFO] [stderr] 340 |         for current_bar in 1..(range + 1) {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^ help: use: `1..=range`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:341:13
[INFO] [stderr]     |
[INFO] [stderr] 341 | /             let mut fill = false;
[INFO] [stderr] 342 | |             if current_bar <= value {
[INFO] [stderr] 343 | |                 fill = true;
[INFO] [stderr] 344 | |             }
[INFO] [stderr]     | |_____________^ help: it is more idiomatic to write: `let <mut> fill = if current_bar <= value { true } else { false };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:450:42
[INFO] [stderr]     |
[INFO] [stderr] 450 |     pub fn set_blink(&mut self, enabled: &bool) -> Result<(), BargraphError<D>> {
[INFO] [stderr]     |                                          ^^^^^ help: consider passing by value instead: `bool`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:477:37
[INFO] [stderr]     |
[INFO] [stderr] 477 |     fn set_bar_fill(&mut self, bar: &u8, range: &u8, fill: &bool) {
[INFO] [stderr]     |                                     ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:477:49
[INFO] [stderr]     |
[INFO] [stderr] 477 |     fn set_bar_fill(&mut self, bar: &u8, range: &u8, fill: &bool) {
[INFO] [stderr]     |                                                 ^^^ help: consider passing by value instead: `u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:477:60
[INFO] [stderr]     |
[INFO] [stderr] 477 |     fn set_bar_fill(&mut self, bar: &u8, range: &u8, fill: &bool) {
[INFO] [stderr]     |                                                            ^^^^^ help: consider passing by value instead: `bool`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]    --> src/lib.rs:477:32
[INFO] [stderr]     |
[INFO] [stderr] 477 |     fn set_bar_fill(&mut self, bar: &u8, range: &u8, fill: &bool) {
[INFO] [stderr]     |                                ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: use of a blacklisted/placeholder name `bar`
[INFO] [stderr]    --> src/lib.rs:485:13
[INFO] [stderr]     |
[INFO] [stderr] 485 |         for bar in start_bar..end_bar {
[INFO] [stderr]     |             ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/led-bargraph.rs:37:15
[INFO] [stderr]    |
[INFO] [stderr] 37 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/bin/led-bargraph.rs:37:15
[INFO] [stderr]    |
[INFO] [stderr] 37 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 19.23s
[INFO] running `"docker" "inspect" "6c15470fa3551c7cf50ef7287c6ddc113ef4c9841347f138d2955986e23b4cfc"`
[INFO] running `"docker" "rm" "-f" "6c15470fa3551c7cf50ef7287c6ddc113ef4c9841347f138d2955986e23b4cfc"`
[INFO] [stdout] 6c15470fa3551c7cf50ef7287c6ddc113ef4c9841347f138d2955986e23b4cfc