[INFO] crate leanpub 0.1.4 is already in cache
[INFO] extracting crate leanpub 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/leanpub/0.1.4
[INFO] extracting crate leanpub 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/leanpub/0.1.4
[INFO] validating manifest of leanpub-0.1.4 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of leanpub-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing leanpub-0.1.4
[INFO] finished frobbing leanpub-0.1.4
[INFO] frobbed toml for leanpub-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/leanpub/0.1.4/Cargo.toml
[INFO] started frobbing leanpub-0.1.4
[INFO] finished frobbing leanpub-0.1.4
[INFO] frobbed toml for leanpub-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/leanpub/0.1.4/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting leanpub-0.1.4 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/leanpub/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cff792c6067c42caefe9a9b71b0c98caa82f13439696c968100a4ed1743b1386
[INFO] running `"docker" "start" "-a" "cff792c6067c42caefe9a9b71b0c98caa82f13439696c968100a4ed1743b1386"`
[INFO] [stderr]     Checking leanpub v0.1.4 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/responses.rs:70:5
[INFO] [stderr]    |
[INFO] [stderr] 70 |     return s.parse::<f32>().map_err(de::Error::custom);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `s.parse::<f32>().map_err(de::Error::custom)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/responses.rs:77:5
[INFO] [stderr]    |
[INFO] [stderr] 77 | /     return match &s[..] {
[INFO] [stderr] 78 | |         "" => Ok(Option::None),
[INFO] [stderr] 79 | |         _ => Ok(Option::Some(s)) 
[INFO] [stderr] 80 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 77 |     match &s[..] {
[INFO] [stderr] 78 |         "" => Ok(Option::None),
[INFO] [stderr] 79 |         _ => Ok(Option::Some(s)) 
[INFO] [stderr] 80 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/utils/http.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 |         return Ok(content);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(content)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/utils/http.rs:59:9
[INFO] [stderr]    |
[INFO] [stderr] 59 |         return Ok(());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/utils/http.rs:45:13
[INFO] [stderr]    |
[INFO] [stderr] 45 |             return Ok(file.write(data).unwrap());
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(file.write(data).unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:40:9
[INFO] [stderr]    |
[INFO] [stderr] 40 | /         return Client {
[INFO] [stderr] 41 | |             client: Box::new(DefaultHttpClient {}),
[INFO] [stderr] 42 | |             api_key: match api_key {
[INFO] [stderr] 43 | |                 Some(key) => Option::Some(key.to_string()),
[INFO] [stderr] 44 | |                 None => None,
[INFO] [stderr] 45 | |             },
[INFO] [stderr] 46 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 40 |         Client {
[INFO] [stderr] 41 |             client: Box::new(DefaultHttpClient {}),
[INFO] [stderr] 42 |             api_key: match api_key {
[INFO] [stderr] 43 |                 Some(key) => Option::Some(key.to_string()),
[INFO] [stderr] 44 |                 None => None,
[INFO] [stderr] 45 |             },
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:61:9
[INFO] [stderr]    |
[INFO] [stderr] 61 |         return Ok(serde_json::from_str::<Summary>(&response)?);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(serde_json::from_str::<Summary>(&response)?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:83:17
[INFO] [stderr]    |
[INFO] [stderr] 83 |                 return Ok(());
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:85:21
[INFO] [stderr]    |
[INFO] [stderr] 85 |             None => return Err(format_err!("No preview available.")),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("No preview available."))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:90:9
[INFO] [stderr]    |
[INFO] [stderr] 90 | /         return match &self.api_key {
[INFO] [stderr] 91 | |             Some(key) => format!("{}?api_key={}", url, key),
[INFO] [stderr] 92 | |             None => url,
[INFO] [stderr] 93 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 90 |         match &self.api_key {
[INFO] [stderr] 91 |             Some(key) => format!("{}?api_key={}", url, key),
[INFO] [stderr] 92 |             None => url,
[INFO] [stderr] 93 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/responses.rs:70:5
[INFO] [stderr]    |
[INFO] [stderr] 70 |     return s.parse::<f32>().map_err(de::Error::custom);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `s.parse::<f32>().map_err(de::Error::custom)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/responses.rs:77:5
[INFO] [stderr]    |
[INFO] [stderr] 77 | /     return match &s[..] {
[INFO] [stderr] 78 | |         "" => Ok(Option::None),
[INFO] [stderr] 79 | |         _ => Ok(Option::Some(s)) 
[INFO] [stderr] 80 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 77 |     match &s[..] {
[INFO] [stderr] 78 |         "" => Ok(Option::None),
[INFO] [stderr] 79 |         _ => Ok(Option::Some(s)) 
[INFO] [stderr] 80 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/utils/http.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 |         return Ok(content);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(content)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/utils/http.rs:59:9
[INFO] [stderr]    |
[INFO] [stderr] 59 |         return Ok(());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/utils/http.rs:45:13
[INFO] [stderr]    |
[INFO] [stderr] 45 |             return Ok(file.write(data).unwrap());
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(file.write(data).unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/utils/http.rs:87:9
[INFO] [stderr]    |
[INFO] [stderr] 87 | /         return FakeHttpClient {
[INFO] [stderr] 88 | |             content: content.to_string(),
[INFO] [stderr] 89 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 87 |         FakeHttpClient {
[INFO] [stderr] 88 |             content: content.to_string(),
[INFO] [stderr] 89 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/utils/http.rs:96:9
[INFO] [stderr]    |
[INFO] [stderr] 96 |         return Ok(self.content.clone());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self.content.clone())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/utils/http.rs:99:9
[INFO] [stderr]    |
[INFO] [stderr] 99 |         return Ok(());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:40:9
[INFO] [stderr]    |
[INFO] [stderr] 40 | /         return Client {
[INFO] [stderr] 41 | |             client: Box::new(DefaultHttpClient {}),
[INFO] [stderr] 42 | |             api_key: match api_key {
[INFO] [stderr] 43 | |                 Some(key) => Option::Some(key.to_string()),
[INFO] [stderr] 44 | |                 None => None,
[INFO] [stderr] 45 | |             },
[INFO] [stderr] 46 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 40 |         Client {
[INFO] [stderr] 41 |             client: Box::new(DefaultHttpClient {}),
[INFO] [stderr] 42 |             api_key: match api_key {
[INFO] [stderr] 43 |                 Some(key) => Option::Some(key.to_string()),
[INFO] [stderr] 44 |                 None => None,
[INFO] [stderr] 45 |             },
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:61:9
[INFO] [stderr]    |
[INFO] [stderr] 61 |         return Ok(serde_json::from_str::<Summary>(&response)?);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(serde_json::from_str::<Summary>(&response)?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:83:17
[INFO] [stderr]    |
[INFO] [stderr] 83 |                 return Ok(());
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:85:21
[INFO] [stderr]    |
[INFO] [stderr] 85 |             None => return Err(format_err!("No preview available.")),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format_err!("No preview available."))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:90:9
[INFO] [stderr]    |
[INFO] [stderr] 90 | /         return match &self.api_key {
[INFO] [stderr] 91 | |             Some(key) => format!("{}?api_key={}", url, key),
[INFO] [stderr] 92 | |             None => url,
[INFO] [stderr] 93 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 90 |         match &self.api_key {
[INFO] [stderr] 91 |             Some(key) => format!("{}?api_key={}", url, key),
[INFO] [stderr] 92 |             None => url,
[INFO] [stderr] 93 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/lib.rs:117:9
[INFO] [stderr]     |
[INFO] [stderr] 117 |         assert_eq!(0.0, result.total_revenue);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/lib.rs:117:9
[INFO] [stderr]     |
[INFO] [stderr] 117 |         assert_eq!(0.0, result.total_revenue);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/lib.rs:128:9
[INFO] [stderr]     |
[INFO] [stderr] 128 |         assert_eq!(4.99, result.minimum_price);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/lib.rs:128:9
[INFO] [stderr]     |
[INFO] [stderr] 128 |         assert_eq!(4.99, result.minimum_price);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/lib.rs:129:9
[INFO] [stderr]     |
[INFO] [stderr] 129 |         assert_eq!(9.99, result.suggested_price);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/lib.rs:129:9
[INFO] [stderr]     |
[INFO] [stderr] 129 |         assert_eq!(9.99, result.suggested_price);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `leanpub`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "cff792c6067c42caefe9a9b71b0c98caa82f13439696c968100a4ed1743b1386"`
[INFO] running `"docker" "rm" "-f" "cff792c6067c42caefe9a9b71b0c98caa82f13439696c968100a4ed1743b1386"`
[INFO] [stdout] cff792c6067c42caefe9a9b71b0c98caa82f13439696c968100a4ed1743b1386