[INFO] crate lde 0.3.0 is already in cache [INFO] extracting crate lde 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/lde/0.3.0 [INFO] extracting crate lde 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lde/0.3.0 [INFO] validating manifest of lde-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lde-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lde-0.3.0 [INFO] finished frobbing lde-0.3.0 [INFO] frobbed toml for lde-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/lde/0.3.0/Cargo.toml [INFO] started frobbing lde-0.3.0 [INFO] finished frobbing lde-0.3.0 [INFO] frobbed toml for lde-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lde/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lde-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lde/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f9ca88b812f93cc08919ef245917af539a2374b9d953e6e1f364a52089755e39 [INFO] running `"docker" "start" "-a" "f9ca88b812f93cc08919ef245917af539a2374b9d953e6e1f364a52089755e39"` [INFO] [stderr] Checking lde v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lde/x64.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | if mode == 0x00 { [INFO] [stderr] | _________________^ [INFO] [stderr] 193 | | if (op & 0b111) == 0b101 { [INFO] [stderr] 194 | | msize += 4; [INFO] [stderr] 195 | | } [INFO] [stderr] 196 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 192 | if mode == 0x00 && (op & 0b111) == 0b101 { [INFO] [stderr] 193 | msize += 4; [INFO] [stderr] 194 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lde/x86.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | if mode == 0x00 { [INFO] [stderr] | _________________^ [INFO] [stderr] 180 | | if (op & 0b111) == 0b101 { [INFO] [stderr] 181 | | msize += 4; [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 179 | if mode == 0x00 && (op & 0b111) == 0b101 { [INFO] [stderr] 180 | msize += 4; [INFO] [stderr] 181 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lde/mod.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | (self[((val >> 5) & 7) as usize] & (0x80000000 >> (val & 0x1F))) != 0 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lde/mod.rs:32:40 [INFO] [stderr] | [INFO] [stderr] 32 | (self[((val >> 5) & 7) as usize] & (0x80000000 >> (val & 0x1F))) != 0 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/lde/x64.rs:99:1 [INFO] [stderr] | [INFO] [stderr] 99 | / pub fn lde_int(opcode: &[u8]) -> u32 { [INFO] [stderr] 100 | | let modrm; [INFO] [stderr] 101 | | let mut op: u8; [INFO] [stderr] 102 | | let (mut ddef, mut mdef) = (4u32, 8u32); [INFO] [stderr] ... | [INFO] [stderr] 215 | | if total as usize <= opcode.len() { total } else { 0 } [INFO] [stderr] 216 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/lde/x86.rs:90:1 [INFO] [stderr] | [INFO] [stderr] 90 | / pub fn lde_int(opcode: &[u8]) -> u32 { [INFO] [stderr] 91 | | let modrm; [INFO] [stderr] 92 | | let mut op: u8; [INFO] [stderr] 93 | | let (mut ddef, mut mdef) = (4u32, 4u32); [INFO] [stderr] ... | [INFO] [stderr] 202 | | if total as usize <= opcode.len() { total } else { 0 } [INFO] [stderr] 203 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/opcode.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | unsafe { mem::transmute(bytes.as_ref()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(bytes.as_ref() as *const [u8] as *const opcode::OpCode)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/opcode.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | unsafe { mem::transmute(bytes.as_mut()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(bytes.as_mut() as *mut [u8] as *mut opcode::OpCode)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/iter_mut.rs:16:2 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn as_iter<'s>(&'s self) -> Iter<'s, X> { [INFO] [stderr] | _____^ [INFO] [stderr] 17 | | Iter { [INFO] [stderr] 18 | | bytes: self.bytes, [INFO] [stderr] 19 | | va: self.va, [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/iter_mut.rs:23:2 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn into_iter(self) -> Iter<'a, X> { [INFO] [stderr] | _____^ [INFO] [stderr] 24 | | Iter { [INFO] [stderr] 25 | | bytes: self.bytes, [INFO] [stderr] 26 | | va: self.va, [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: The function/method `ptr::read` doesn't need a mutable reference [INFO] [stderr] --> src/iter_mut.rs:35:41 [INFO] [stderr] | [INFO] [stderr] 35 | let (head, tail) = unsafe { ptr::read(&mut self.bytes) }.split_at_mut(n); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:147:2 [INFO] [stderr] | [INFO] [stderr] 147 | fn iter<'a>(bytes: &'a [u8], va: Self::Va) -> Iter<'a, Self> { [INFO] [stderr] | _____^ [INFO] [stderr] 148 | | Iter { bytes, va } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:153:2 [INFO] [stderr] | [INFO] [stderr] 153 | fn iter_mut<'a>(bytes: &'a mut [u8], va: Self::Va) -> IterMut<'a, Self> { [INFO] [stderr] | _____^ [INFO] [stderr] 154 | | IterMut { bytes, va } [INFO] [stderr] 155 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:192:2 [INFO] [stderr] | [INFO] [stderr] 192 | pub fn iter<'a>(self, bytes: &'a [u8], va: u32) -> Iter<'a, X86> { [INFO] [stderr] | _____^ [INFO] [stderr] 193 | | ::iter(bytes, va) [INFO] [stderr] 194 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:198:2 [INFO] [stderr] | [INFO] [stderr] 198 | pub fn iter_mut<'a>(self, bytes: &'a mut [u8], va: u32) -> IterMut<'a, X86> { [INFO] [stderr] | _____^ [INFO] [stderr] 199 | | ::iter_mut(bytes, va) [INFO] [stderr] 200 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:273:2 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn iter<'a>(self, bytes: &'a [u8], va: u64) -> Iter<'a, X64> { [INFO] [stderr] | _____^ [INFO] [stderr] 274 | | ::iter(bytes, va) [INFO] [stderr] 275 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:291:2 [INFO] [stderr] | [INFO] [stderr] 291 | pub fn iter_mut<'a>(self, bytes: &'a mut [u8], va: u64) -> IterMut<'a, X64> { [INFO] [stderr] | _____^ [INFO] [stderr] 292 | | ::iter_mut(bytes, va) [INFO] [stderr] 293 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lde/x64.rs:192:5 [INFO] [stderr] | [INFO] [stderr] 192 | if mode == 0x00 { [INFO] [stderr] | _________________^ [INFO] [stderr] 193 | | if (op & 0b111) == 0b101 { [INFO] [stderr] 194 | | msize += 4; [INFO] [stderr] 195 | | } [INFO] [stderr] 196 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 192 | if mode == 0x00 && (op & 0b111) == 0b101 { [INFO] [stderr] 193 | msize += 4; [INFO] [stderr] 194 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lde/x86.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | if mode == 0x00 { [INFO] [stderr] | _________________^ [INFO] [stderr] 180 | | if (op & 0b111) == 0b101 { [INFO] [stderr] 181 | | msize += 4; [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 179 | if mode == 0x00 && (op & 0b111) == 0b101 { [INFO] [stderr] 180 | msize += 4; [INFO] [stderr] 181 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lde/mod.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | (self[((val >> 5) & 7) as usize] & (0x80000000 >> (val & 0x1F))) != 0 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lde/mod.rs:32:40 [INFO] [stderr] | [INFO] [stderr] 32 | (self[((val >> 5) & 7) as usize] & (0x80000000 >> (val & 0x1F))) != 0 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/lde/x64.rs:99:1 [INFO] [stderr] | [INFO] [stderr] 99 | / pub fn lde_int(opcode: &[u8]) -> u32 { [INFO] [stderr] 100 | | let modrm; [INFO] [stderr] 101 | | let mut op: u8; [INFO] [stderr] 102 | | let (mut ddef, mut mdef) = (4u32, 8u32); [INFO] [stderr] ... | [INFO] [stderr] 215 | | if total as usize <= opcode.len() { total } else { 0 } [INFO] [stderr] 216 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/lde/x86.rs:90:1 [INFO] [stderr] | [INFO] [stderr] 90 | / pub fn lde_int(opcode: &[u8]) -> u32 { [INFO] [stderr] 91 | | let modrm; [INFO] [stderr] 92 | | let mut op: u8; [INFO] [stderr] 93 | | let (mut ddef, mut mdef) = (4u32, 4u32); [INFO] [stderr] ... | [INFO] [stderr] 202 | | if total as usize <= opcode.len() { total } else { 0 } [INFO] [stderr] 203 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/opcode.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | unsafe { mem::transmute(bytes.as_ref()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(bytes.as_ref() as *const [u8] as *const opcode::OpCode)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/opcode.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | unsafe { mem::transmute(bytes.as_mut()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(bytes.as_mut() as *mut [u8] as *mut opcode::OpCode)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/iter_mut.rs:16:2 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn as_iter<'s>(&'s self) -> Iter<'s, X> { [INFO] [stderr] | _____^ [INFO] [stderr] 17 | | Iter { [INFO] [stderr] 18 | | bytes: self.bytes, [INFO] [stderr] 19 | | va: self.va, [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/iter_mut.rs:23:2 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn into_iter(self) -> Iter<'a, X> { [INFO] [stderr] | _____^ [INFO] [stderr] 24 | | Iter { [INFO] [stderr] 25 | | bytes: self.bytes, [INFO] [stderr] 26 | | va: self.va, [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: The function/method `ptr::read` doesn't need a mutable reference [INFO] [stderr] --> src/iter_mut.rs:35:41 [INFO] [stderr] | [INFO] [stderr] 35 | let (head, tail) = unsafe { ptr::read(&mut self.bytes) }.split_at_mut(n); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:147:2 [INFO] [stderr] | [INFO] [stderr] 147 | fn iter<'a>(bytes: &'a [u8], va: Self::Va) -> Iter<'a, Self> { [INFO] [stderr] | _____^ [INFO] [stderr] 148 | | Iter { bytes, va } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:153:2 [INFO] [stderr] | [INFO] [stderr] 153 | fn iter_mut<'a>(bytes: &'a mut [u8], va: Self::Va) -> IterMut<'a, Self> { [INFO] [stderr] | _____^ [INFO] [stderr] 154 | | IterMut { bytes, va } [INFO] [stderr] 155 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:192:2 [INFO] [stderr] | [INFO] [stderr] 192 | pub fn iter<'a>(self, bytes: &'a [u8], va: u32) -> Iter<'a, X86> { [INFO] [stderr] | _____^ [INFO] [stderr] 193 | | ::iter(bytes, va) [INFO] [stderr] 194 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:198:2 [INFO] [stderr] | [INFO] [stderr] 198 | pub fn iter_mut<'a>(self, bytes: &'a mut [u8], va: u32) -> IterMut<'a, X86> { [INFO] [stderr] | _____^ [INFO] [stderr] 199 | | ::iter_mut(bytes, va) [INFO] [stderr] 200 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:273:2 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn iter<'a>(self, bytes: &'a [u8], va: u64) -> Iter<'a, X64> { [INFO] [stderr] | _____^ [INFO] [stderr] 274 | | ::iter(bytes, va) [INFO] [stderr] 275 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:291:2 [INFO] [stderr] | [INFO] [stderr] 291 | pub fn iter_mut<'a>(self, bytes: &'a mut [u8], va: u64) -> IterMut<'a, X64> { [INFO] [stderr] | _____^ [INFO] [stderr] 292 | | ::iter_mut(bytes, va) [INFO] [stderr] 293 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.36s [INFO] running `"docker" "inspect" "f9ca88b812f93cc08919ef245917af539a2374b9d953e6e1f364a52089755e39"` [INFO] running `"docker" "rm" "-f" "f9ca88b812f93cc08919ef245917af539a2374b9d953e6e1f364a52089755e39"` [INFO] [stdout] f9ca88b812f93cc08919ef245917af539a2374b9d953e6e1f364a52089755e39