[INFO] crate ldap3 0.6.1 is already in cache [INFO] extracting crate ldap3 0.6.1 into work/ex/clippy-test-run/sources/stable/reg/ldap3/0.6.1 [INFO] extracting crate ldap3 0.6.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ldap3/0.6.1 [INFO] validating manifest of ldap3-0.6.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ldap3-0.6.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ldap3-0.6.1 [INFO] finished frobbing ldap3-0.6.1 [INFO] frobbed toml for ldap3-0.6.1 written to work/ex/clippy-test-run/sources/stable/reg/ldap3/0.6.1/Cargo.toml [INFO] started frobbing ldap3-0.6.1 [INFO] finished frobbing ldap3-0.6.1 [INFO] frobbed toml for ldap3-0.6.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ldap3/0.6.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ldap3-0.6.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ldap3/0.6.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fb2107c4f58ae386d582ee05f29a1b9640d481bb5a08a026327bd0a46c84adac [INFO] running `"docker" "start" "-a" "fb2107c4f58ae386d582ee05f29a1b9640d481bb5a08a026327bd0a46c84adac"` [INFO] [stderr] Checking lber v0.1.6 [INFO] [stderr] Checking tokio-tls v0.2.1 [INFO] [stderr] Checking tokio-uds v0.1.7 [INFO] [stderr] Checking tokio-uds-proto v0.1.1 [INFO] [stderr] Checking ldap3 v0.6.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controls_impl/assertion.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | Assertion { filter: filter }.into() [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `filter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controls_impl/paged_results.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | PagedResults { size: size, cookie: cookie } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controls_impl/paged_results.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | PagedResults { size: size, cookie: cookie } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cookie` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controls_impl/read_entry.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | attrs: attrs, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `attrs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controls_impl/read_entry.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | attrs: attrs, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `attrs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controls_impl/mod.rs:204:53 [INFO] [stderr] | [INFO] [stderr] 204 | ctrls.push(Control(known_type, RawControl { ctype: ctype, crit: crit, val: val })); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ctype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controls_impl/mod.rs:204:67 [INFO] [stderr] | [INFO] [stderr] 204 | ctrls.push(Control(known_type, RawControl { ctype: ctype, crit: crit, val: val })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `crit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controls_impl/mod.rs:204:79 [INFO] [stderr] | [INFO] [stderr] 204 | ctrls.push(Control(known_type, RawControl { ctype: ctype, crit: crit, val: val })); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filter.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | inner: inner [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ldap.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | bundle: bundle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bundle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ldap.rs:170:21 [INFO] [stderr] | [INFO] [stderr] 170 | bundle: bundle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bundle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ldap.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | bundle: bundle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bundle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:123:17 [INFO] [stderr] | [INFO] [stderr] 123 | rc: rc, [INFO] [stderr] | ^^^^^^ help: replace it with: `rc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | matched: matched, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matched` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | refs: refs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `refs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:299:17 [INFO] [stderr] | [INFO] [stderr] 299 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/search.rs:386:13 [INFO] [stderr] | [INFO] [stderr] 386 | dn: dn, [INFO] [stderr] | ^^^^^^ help: replace it with: `dn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/search.rs:568:17 [INFO] [stderr] | [INFO] [stderr] 568 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/search.rs:569:17 [INFO] [stderr] | [INFO] [stderr] 569 | initial_timeout: initial_timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `initial_timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/search.rs:570:17 [INFO] [stderr] | [INFO] [stderr] 570 | ldap: ldap, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ldap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/search.rs:571:17 [INFO] [stderr] | [INFO] [stderr] 571 | bundle: bundle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bundle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/search.rs:572:17 [INFO] [stderr] | [INFO] [stderr] 572 | tx_i: tx_i, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tx_i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/search.rs:573:17 [INFO] [stderr] | [INFO] [stderr] 573 | rx_i: rx_i, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rx_i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/search.rs:577:17 [INFO] [stderr] | [INFO] [stderr] 577 | timeout: timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tls_client.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | connector: connector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tls_client.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | do_handshake: do_handshake, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `do_handshake` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controls_impl/assertion.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | Assertion { filter: filter }.into() [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `filter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controls_impl/paged_results.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | PagedResults { size: size, cookie: cookie } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controls_impl/paged_results.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | PagedResults { size: size, cookie: cookie } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cookie` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controls_impl/read_entry.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | attrs: attrs, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `attrs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controls_impl/read_entry.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | attrs: attrs, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `attrs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controls_impl/mod.rs:204:53 [INFO] [stderr] | [INFO] [stderr] 204 | ctrls.push(Control(known_type, RawControl { ctype: ctype, crit: crit, val: val })); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ctype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controls_impl/mod.rs:204:67 [INFO] [stderr] | [INFO] [stderr] 204 | ctrls.push(Control(known_type, RawControl { ctype: ctype, crit: crit, val: val })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `crit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/controls_impl/mod.rs:204:79 [INFO] [stderr] | [INFO] [stderr] 204 | ctrls.push(Control(known_type, RawControl { ctype: ctype, crit: crit, val: val })); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filter.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | inner: inner [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ldap.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | bundle: bundle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bundle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ldap.rs:170:21 [INFO] [stderr] | [INFO] [stderr] 170 | bundle: bundle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bundle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ldap.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | bundle: bundle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bundle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | tx: tx, [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:123:17 [INFO] [stderr] | [INFO] [stderr] 123 | rc: rc, [INFO] [stderr] | ^^^^^^ help: replace it with: `rc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | matched: matched, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matched` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | refs: refs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `refs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/protocol.rs:299:17 [INFO] [stderr] | [INFO] [stderr] 299 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/search.rs:386:13 [INFO] [stderr] | [INFO] [stderr] 386 | dn: dn, [INFO] [stderr] | ^^^^^^ help: replace it with: `dn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/search.rs:568:17 [INFO] [stderr] | [INFO] [stderr] 568 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/search.rs:569:17 [INFO] [stderr] | [INFO] [stderr] 569 | initial_timeout: initial_timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `initial_timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/search.rs:570:17 [INFO] [stderr] | [INFO] [stderr] 570 | ldap: ldap, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ldap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/search.rs:571:17 [INFO] [stderr] | [INFO] [stderr] 571 | bundle: bundle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bundle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/search.rs:572:17 [INFO] [stderr] | [INFO] [stderr] 572 | tx_i: tx_i, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tx_i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/search.rs:573:17 [INFO] [stderr] | [INFO] [stderr] 573 | rx_i: rx_i, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rx_i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/search.rs:577:17 [INFO] [stderr] | [INFO] [stderr] 577 | timeout: timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tls_client.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | connector: connector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tls_client.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | do_handshake: do_handshake, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `do_handshake` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `should_implement_trait` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/conn.rs:109:46 [INFO] [stderr] | [INFO] [stderr] 109 | #[cfg_attr(feature="cargo-clippy", allow(should_implement_trait))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::should_implement_trait` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/controls_impl/assertion.rs:8:27 [INFO] [stderr] | [INFO] [stderr] 8 | pub const ASSERTION_OID: &'static str = "1.3.6.1.1.12"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `new_ret_no_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/controls_impl/assertion.rs:20:46 [INFO] [stderr] | [INFO] [stderr] 20 | #[cfg_attr(feature="cargo-clippy", allow(new_ret_no_self))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::new_ret_no_self` [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/controls_impl/paged_results.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | pub const PAGED_RESULTS_OID: &'static str = "1.2.840.113556.1.4.319"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/controls_impl/proxy_auth.rs:13:28 [INFO] [stderr] | [INFO] [stderr] 13 | pub const PROXY_AUTH_OID: &'static str = "2.16.840.1.113730.3.4.18"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/controls_impl/read_entry.rs:11:26 [INFO] [stderr] | [INFO] [stderr] 11 | pub const PRE_READ_OID: &'static str = "1.3.6.1.1.13.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/controls_impl/read_entry.rs:12:27 [INFO] [stderr] | [INFO] [stderr] 12 | pub const POST_READ_OID: &'static str = "1.3.6.1.1.13.2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `new_ret_no_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/controls_impl/read_entry.rs:44:46 [INFO] [stderr] | [INFO] [stderr] 44 | #[cfg_attr(feature="cargo-clippy", allow(new_ret_no_self))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::new_ret_no_self` [INFO] [stderr] [INFO] [stderr] warning: lint name `new_ret_no_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/controls_impl/read_entry.rs:69:46 [INFO] [stderr] | [INFO] [stderr] 69 | #[cfg_attr(feature="cargo-clippy", allow(new_ret_no_self))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::new_ret_no_self` [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/controls_impl/relax_rules.rs:9:29 [INFO] [stderr] | [INFO] [stderr] 9 | pub const RELAX_RULES_OID: &'static str = "1.3.6.1.4.1.4203.666.5.12"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/exop_impl/whoami.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | pub const WHOAMI_OID: &'static str = "1.3.6.1.4.1.4203.1.11.3"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/exop_impl/starttls.rs:3:26 [INFO] [stderr] | [INFO] [stderr] 3 | pub const STARTTLS_OID: &'static str = "1.3.6.1.4.1.1466.20037"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/exop_impl/starttls.rs:11:42 [INFO] [stderr] | [INFO] [stderr] 11 | #[cfg_attr(feature="cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: lint name `new_without_default` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/search.rs:406:46 [INFO] [stderr] | [INFO] [stderr] 406 | #[cfg_attr(feature="cargo-clippy", allow(new_without_default))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default` [INFO] [stderr] [INFO] [stderr] warning: lint name `should_implement_trait` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/conn.rs:109:46 [INFO] [stderr] | [INFO] [stderr] 109 | #[cfg_attr(feature="cargo-clippy", allow(should_implement_trait))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::should_implement_trait` [INFO] [stderr] [INFO] [stderr] warning: lint name `should_implement_trait` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/conn.rs:109:46 [INFO] [stderr] | [INFO] [stderr] 109 | #[cfg_attr(feature="cargo-clippy", allow(should_implement_trait))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::should_implement_trait` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/controls_impl/assertion.rs:8:27 [INFO] [stderr] | [INFO] [stderr] 8 | pub const ASSERTION_OID: &'static str = "1.3.6.1.1.12"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `new_ret_no_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/controls_impl/assertion.rs:20:46 [INFO] [stderr] | [INFO] [stderr] 20 | #[cfg_attr(feature="cargo-clippy", allow(new_ret_no_self))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::new_ret_no_self` [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/controls_impl/paged_results.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | pub const PAGED_RESULTS_OID: &'static str = "1.2.840.113556.1.4.319"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/controls_impl/proxy_auth.rs:13:28 [INFO] [stderr] | [INFO] [stderr] 13 | pub const PROXY_AUTH_OID: &'static str = "2.16.840.1.113730.3.4.18"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/controls_impl/read_entry.rs:11:26 [INFO] [stderr] | [INFO] [stderr] 11 | pub const PRE_READ_OID: &'static str = "1.3.6.1.1.13.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/controls_impl/read_entry.rs:12:27 [INFO] [stderr] | [INFO] [stderr] 12 | pub const POST_READ_OID: &'static str = "1.3.6.1.1.13.2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `new_ret_no_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/controls_impl/read_entry.rs:44:46 [INFO] [stderr] | [INFO] [stderr] 44 | #[cfg_attr(feature="cargo-clippy", allow(new_ret_no_self))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::new_ret_no_self` [INFO] [stderr] [INFO] [stderr] warning: lint name `new_ret_no_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/controls_impl/read_entry.rs:69:46 [INFO] [stderr] | [INFO] [stderr] 69 | #[cfg_attr(feature="cargo-clippy", allow(new_ret_no_self))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::new_ret_no_self` [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/controls_impl/relax_rules.rs:9:29 [INFO] [stderr] | [INFO] [stderr] 9 | pub const RELAX_RULES_OID: &'static str = "1.3.6.1.4.1.4203.666.5.12"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/exop_impl/whoami.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | pub const WHOAMI_OID: &'static str = "1.3.6.1.4.1.4203.1.11.3"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/exop_impl/starttls.rs:3:26 [INFO] [stderr] | [INFO] [stderr] 3 | pub const STARTTLS_OID: &'static str = "1.3.6.1.4.1.1466.20037"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `doc_markdown` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/exop_impl/starttls.rs:11:42 [INFO] [stderr] | [INFO] [stderr] 11 | #[cfg_attr(feature="cargo-clippy", allow(doc_markdown))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::doc_markdown` [INFO] [stderr] [INFO] [stderr] warning: lint name `new_without_default` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/search.rs:406:46 [INFO] [stderr] | [INFO] [stderr] 406 | #[cfg_attr(feature="cargo-clippy", allow(new_without_default))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default` [INFO] [stderr] [INFO] [stderr] warning: lint name `should_implement_trait` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/conn.rs:109:46 [INFO] [stderr] | [INFO] [stderr] 109 | #[cfg_attr(feature="cargo-clippy", allow(should_implement_trait))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::should_implement_trait` [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/abandon.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | inner: msgid as i64 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(msgid)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/conn.rs:146:16 [INFO] [stderr] | [INFO] [stderr] 146 | Ok(channel.unbounded_send(()).map_err(|_e| io::Error::new(io::ErrorKind::Other, "send on abandon channel"))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 146 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/conn.rs:333:12 [INFO] [stderr] | [INFO] [stderr] 333 | Ok(self.core.borrow_mut().run(self.inner.clone().unbind())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 333 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/controls_impl/paged_results.rs:35:28 [INFO] [stderr] | [INFO] [stderr] 35 | inner: pr.size as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(pr.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/controls_impl/mod.rs:198:29 [INFO] [stderr] | [INFO] [stderr] 198 | Some(v) => Some(Vec::from(v.expect_primitive().expect("octet string"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Vec::from()`: `v.expect_primitive().expect("octet string")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/exop_impl/whoami.rs:33:37 [INFO] [stderr] | [INFO] [stderr] 33 | authzid: str::from_utf8(val.as_ref()).expect("authzid").to_owned() [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/ldap.rs:304:15 [INFO] [stderr] | [INFO] [stderr] 304 | resolver: Option Box>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/protocol.rs:230:17 [INFO] [stderr] | [INFO] [stderr] 230 | type Item = (RequestId, (LdapOp, Box)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/protocol.rs:264:28 [INFO] [stderr] | [INFO] [stderr] 264 | inner: next_ldap_id as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(next_ldap_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/protocol.rs:340:21 [INFO] [stderr] | [INFO] [stderr] 340 | type SinkItem = (RequestId, (LdapOp, Box)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/search.rs:241:29 [INFO] [stderr] | [INFO] [stderr] 241 | / if let &Control(Some(types::PagedResults), ref raw) = ctrl { [INFO] [stderr] 242 | | pr_index = Some(cno); [INFO] [stderr] 243 | | let pr: PagedResults = raw.parse(); [INFO] [stderr] 244 | | if pr.cookie.is_empty() { [INFO] [stderr] ... | [INFO] [stderr] 276 | | continue 'poll_loop; [INFO] [stderr] 277 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 241 | if let Control(Some(types::PagedResults), ref raw) = *ctrl { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `search::SearchOptions` [INFO] [stderr] --> src/search.rs:407:5 [INFO] [stderr] | [INFO] [stderr] 407 | / pub fn new() -> Self { [INFO] [stderr] 408 | | SearchOptions { [INFO] [stderr] 409 | | deref: DerefAliases::Never, [INFO] [stderr] 410 | | typesonly: false, [INFO] [stderr] ... | [INFO] [stderr] 414 | | } [INFO] [stderr] 415 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 403 | impl Default for search::SearchOptions { [INFO] [stderr] 404 | fn default() -> Self { [INFO] [stderr] 405 | Self::new() [INFO] [stderr] 406 | } [INFO] [stderr] 407 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/search.rs:514:31 [INFO] [stderr] | [INFO] [stderr] 514 | inner: opts.sizelimit as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(opts.sizelimit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/search.rs:518:31 [INFO] [stderr] | [INFO] [stderr] 518 | inner: opts.timelimit as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(opts.timelimit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/util.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | lit.into() [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `lit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/util.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | val.into() [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/abandon.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | inner: msgid as i64 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(msgid)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/conn.rs:146:16 [INFO] [stderr] | [INFO] [stderr] 146 | Ok(channel.unbounded_send(()).map_err(|_e| io::Error::new(io::ErrorKind::Other, "send on abandon channel"))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 146 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/conn.rs:333:12 [INFO] [stderr] | [INFO] [stderr] 333 | Ok(self.core.borrow_mut().run(self.inner.clone().unbind())?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 333 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/controls_impl/paged_results.rs:35:28 [INFO] [stderr] | [INFO] [stderr] 35 | inner: pr.size as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(pr.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/controls_impl/mod.rs:198:29 [INFO] [stderr] | [INFO] [stderr] 198 | Some(v) => Some(Vec::from(v.expect_primitive().expect("octet string"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Vec::from()`: `v.expect_primitive().expect("octet string")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/exop_impl/whoami.rs:33:37 [INFO] [stderr] | [INFO] [stderr] 33 | authzid: str::from_utf8(val.as_ref()).expect("authzid").to_owned() [INFO] [stderr] | ^^^^^^^^^^^^ help: try this: `val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/ldap.rs:304:15 [INFO] [stderr] | [INFO] [stderr] 304 | resolver: Option Box>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/protocol.rs:230:17 [INFO] [stderr] | [INFO] [stderr] 230 | type Item = (RequestId, (LdapOp, Box)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/protocol.rs:264:28 [INFO] [stderr] | [INFO] [stderr] 264 | inner: next_ldap_id as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(next_ldap_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/protocol.rs:340:21 [INFO] [stderr] | [INFO] [stderr] 340 | type SinkItem = (RequestId, (LdapOp, Box)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/search.rs:241:29 [INFO] [stderr] | [INFO] [stderr] 241 | / if let &Control(Some(types::PagedResults), ref raw) = ctrl { [INFO] [stderr] 242 | | pr_index = Some(cno); [INFO] [stderr] 243 | | let pr: PagedResults = raw.parse(); [INFO] [stderr] 244 | | if pr.cookie.is_empty() { [INFO] [stderr] ... | [INFO] [stderr] 276 | | continue 'poll_loop; [INFO] [stderr] 277 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 241 | if let Control(Some(types::PagedResults), ref raw) = *ctrl { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `search::SearchOptions` [INFO] [stderr] --> src/search.rs:407:5 [INFO] [stderr] | [INFO] [stderr] 407 | / pub fn new() -> Self { [INFO] [stderr] 408 | | SearchOptions { [INFO] [stderr] 409 | | deref: DerefAliases::Never, [INFO] [stderr] 410 | | typesonly: false, [INFO] [stderr] ... | [INFO] [stderr] 414 | | } [INFO] [stderr] 415 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 403 | impl Default for search::SearchOptions { [INFO] [stderr] 404 | fn default() -> Self { [INFO] [stderr] 405 | Self::new() [INFO] [stderr] 406 | } [INFO] [stderr] 407 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/search.rs:514:31 [INFO] [stderr] | [INFO] [stderr] 514 | inner: opts.sizelimit as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(opts.sizelimit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/search.rs:518:31 [INFO] [stderr] | [INFO] [stderr] 518 | inner: opts.timelimit as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(opts.timelimit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/util.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | lit.into() [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `lit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/util.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | val.into() [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: lint name `single_match` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> examples/search_streaming_paged.rs:37:54 [INFO] [stderr] | [INFO] [stderr] 37 | #[cfg_attr(feature="cargo-clippy", allow(single_match))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::single_match` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `single_match` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> examples/search_streaming_paged.rs:37:54 [INFO] [stderr] | [INFO] [stderr] 37 | #[cfg_attr(feature="cargo-clippy", allow(single_match))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::single_match` [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> examples/connect_tls_ipaddr.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | drop(env_logger::init()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type () [INFO] [stderr] --> examples/connect_tls_ipaddr.rs:11:10 [INFO] [stderr] | [INFO] [stderr] 11 | drop(env_logger::init()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> examples/connect_tls_ipaddr.rs:11:10 [INFO] [stderr] | [INFO] [stderr] 11 | drop(env_logger::init()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 11 | drop(()); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ldap3`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "fb2107c4f58ae386d582ee05f29a1b9640d481bb5a08a026327bd0a46c84adac"` [INFO] running `"docker" "rm" "-f" "fb2107c4f58ae386d582ee05f29a1b9640d481bb5a08a026327bd0a46c84adac"` [INFO] [stdout] fb2107c4f58ae386d582ee05f29a1b9640d481bb5a08a026327bd0a46c84adac